From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.13519.1676032649804729961 for ; Fri, 10 Feb 2023 04:37:29 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YTTtTHPK; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676032649; x=1707568649; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=inyCG977Cff5pChditDddGqOLbVsoGVogfHsat2pMXU=; b=YTTtTHPKyUAIaIGpdpYStEgGzrMRBabA3+gRMIPWyNvqLgkUGKUSKAqE TER9DRCnN8ZOA2sM3l3ModiaIHW1F/m6P4MhusuMiG847cPR4bEXrNQ69 ufN8TIGN44xpB8rxYVxC41CKV9t7u6mfkDSXZ2S+ewDbWb9NhJYATDx4E CvkepKypxKpkIkqoIU0mg2eEETQs2ZFACHsP3AVjaMft7wA1D+JP4hD1w 3gKTtWa6tK1M3NENaQUrcU307loAoOCk8GIg3zhMUnGjNzk4VFHnFRSq9 gGtKAKeiv76f22JXMLc1mWTgWqOMOl6n6gjZuYufVihTdPvRLCitmk962 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10616"; a="331713867" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="331713867" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 04:37:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10616"; a="698413375" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="698413375" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 10 Feb 2023 04:37:28 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 10 Feb 2023 04:37:27 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 10 Feb 2023 04:37:27 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 10 Feb 2023 04:37:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lwy90hDBchtBdYsR2RZE5NR6E5XXUWD8dynI3zzjZhwOKQBW3LYOLixlH/jIlE0qaJTUT5u98qF24V4J10PdSA9Eg+xXPE8SJdA5RShCHoJumHh/XdnIjYTiMWPY2r1PlOolDE/VXclfcpNQwADRhJwey6t5rfbBFJBwM6Pad1glPX2Ko0Vp7NMkOJL4SJcsWwfvvuig6/JEpjL0xLq4n1uKcfaiXL8t2wLtU4eqRDAxVRf8cfX09iW8+1rakHAPqdGtc9cilqEkSFiiXzH9KvkyeS0rOR2vNDIq2wqhebMFMd2Iv5nvEj5zU3EQ3IFUe2BDyMVb1g9Rxyv1iJaPMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VIL/cHbKYMxE1PcQWS0ukq4qkVRMZ+Hc/bfLshol6yw=; b=YsP5+mF/b/f+/4+nVLFPS9OOJVKuzP1j/h58KrwLXG4f9CozSGnL2G3aTHU0jYCcWHVJfS2/gR/CeK9Kmkrp6Wl+UE/Zsnd69OzuueZ7mytVwamdvhLfL2SwgYhadWY+gITMh+lCWwvglLkQnxBCoxBQN1Bso2Kce3WbcRsfXb9FnymrOgWcr1KlXRoUf5rAOe9G47BMlOYmlGyI7SSsVLgGVa3OMdLAj7VMU3NC39nAEevDe6ouRRJ7yL/x56TLhyGh/HlOXIQB5u6UkFq6wggEL42iuSiu+L09UeMAoaMLL0zs3+nBbQ7CHKHt9A951ByvGDD6F9lf1kdjc7/TjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by IA1PR11MB8247.namprd11.prod.outlook.com (2603:10b6:208:449::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Fri, 10 Feb 2023 12:37:24 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%3]) with mapi id 15.20.6086.017; Fri, 10 Feb 2023 12:37:24 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , "Wu, Jiaxin" CC: "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Thread-Topic: [edk2-devel] [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Thread-Index: AQHZPRXvUunGC8Xwak2WQ/WGAugRZK7ICvIAgAATB5A= Date: Fri, 10 Feb 2023 12:37:23 +0000 Message-ID: References: <20230210060519.11100-1-jiaxin.wu@intel.com> <20230210060519.11100-4-jiaxin.wu@intel.com> <20230210112646.g6yz6put3mtarqtd@sirius.home.kraxel.org> In-Reply-To: <20230210112646.g6yz6put3mtarqtd@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|IA1PR11MB8247:EE_ x-ms-office365-filtering-correlation-id: 7f6ddb22-7a7b-470b-5d5c-08db0b638f74 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CjdRpwwLta497wqpG13zCWmB4F9m/PmAbzrUdMtuUHBqZc4/KA7sutY85Bk3YmeCb85w7wuaaYpeEDJ068NyipQ5RCIPCnb5SPi0znEG9HeP+Q59XgYFPO4unLso7Dm3TLIgSFoEwc75Ii+8JoBHgK/S1vuW311vA91SskI5mnWw1czuPm9liltxLYCM3jX1ym5VNOYmbA6WDU51RHYfu2f8KukoRspIpxjLV3lcVcsyJP4B0o9Ba5jt6z/1tpdcUCryTqeUQoizp4MBWXzNaZSdULCdsDD2IbSZv6ViCgeG2zHjexSJ6VT9Ajxwe4KEstt6RAwdldLZsIe/bOGkz61DqSSmHiopzrdu+Qr7KgXSS1hAYO8zBRxJmqMuX+V/Y3f9DKVYMLRkqYa0LPpv6WPOF+GAXENQ1516CIiiMf7bcg/LfwyJjeq5km8b5mIFmqHCq/BRtk4q0HDPD3IwPW1nFcXMEE2aMe3M9cE/reHppdtmIC11LN3zlo97B4qRNv1qnyXF4sZXw0So30LIC7HQxgYkcKW/y8rjaaRPlA16BmmPQ1VjDO3a9jieQNtn3B8n3RhBpMcsYhO6wBdd0k884OGDpfzJmOXSGsnzLPxGht9x58CeYm1TbQ08L58LgW3K4ZZRP688QAs5czBNdpXBOpC679U2qsv/MHwxSKSm6TP7u18TZuUQEIySW78Z5BZJUOBk0rwi7XzVa1z4XGvMIPgaRZUddSJYCAviaKkLCcoOHqHS+ZgnuqR/MU1YlWpH9kvoVOQrcu6oQjWJCQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199018)(66476007)(4326008)(66946007)(76116006)(8676002)(316002)(38100700002)(66556008)(122000001)(6636002)(110136005)(54906003)(86362001)(52536014)(33656002)(478600001)(966005)(6506007)(53546011)(186003)(83380400001)(9686003)(26005)(2906002)(107886003)(38070700005)(82960400001)(71200400001)(66899018)(5660300002)(66446008)(64756008)(41300700001)(8936002)(55016003)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PLtl1ajDKl9d99fpu8VnDyZ7zdx2ULJ7iYffbJXpzqjpqbvD4i8aFDItR98l?= =?us-ascii?Q?SgFqLsTNKQ4QOxbYuZT+VaHYZad8VXKPu7gz5rTscXNy6ebaC4qCKRCI5mTm?= =?us-ascii?Q?22A1BD8d4GPliqpZVzk1Z4uuGdGfgXKCrhbYTfad82IAaW8/FJL7kISPXn2x?= =?us-ascii?Q?Xj/r8z0MYpObgyN5LTrhKYL6vnDE0I/NZ216HBUczQYK5TBpyrea4kHI+fEE?= =?us-ascii?Q?L43u4Jsu9IXWC0H7lNoFS6oYpxuQ0yo2beRhQN+VdIRCTi2ovoOKDNajFmCl?= =?us-ascii?Q?driquttykH4dZvE6chcv6tEnW0GWybMqOtUDAcZ9KVUcdvzYlO4c9rKXR6mI?= =?us-ascii?Q?nfsQdKD20JEOt5q4vw5pooAi8PFQtvL2xvH+AzIGton0jK/qf8XJeVLIJktQ?= =?us-ascii?Q?SR1LQHWVqzuVrURtY8aM0MgbRk2IRWb2D02yArfAmde13PCxPCH9/41vsuMC?= =?us-ascii?Q?NRZDrZzzwvmeLiZl04O/06tSD8qT030u+u4vzg8+3Pd1Iugeg666G6kKAmi+?= =?us-ascii?Q?oqx8T8e5xqo5hGG8et2F2b9/oe3sLYAR3y7nUqTh7pXQDhow/oLB8iL65cv4?= =?us-ascii?Q?dgX0s239QhEP1NSQBhHHXjlkFG54ekC98/RBR8Gsl7eIW8GseCQt92t2tIDd?= =?us-ascii?Q?0R8Li9ZPWi/VJE8EmYI1t9urfPLMPGWsGPbxfAAAyk6JLoaYH7cdco8JMeCB?= =?us-ascii?Q?oJrf19iBbpJiWzGFQMYUej30Obhdpi/9+/sjM8WRVoDOy6JGRVYfkhWKW9Bp?= =?us-ascii?Q?9Tc2PjBcz6ONvE1geBIheWHW+MFy4f1iu7q7S+oijSy2723EaSFK9axpKsgb?= =?us-ascii?Q?/FKX1MzGLJtRkSkt0ziMvI8p/0sEGjgVeexA90/U8JGzH1P6VBbwQCRULTI8?= =?us-ascii?Q?tyMZdCAgHXMPF0vw/Rh94Z59cV7wTgwhTjPOPr6l/5Vti7QFkJGjtJRBTj+l?= =?us-ascii?Q?Okvl8aHsYAnkka8XObEOJeWDyGJFbLQh9DDa+FNiyFI/qLyqx1XOXOlc5KSC?= =?us-ascii?Q?7Wn4iCVGKqYR2SOOtFF8E3vvgy8A25twZEJvp/NB63ewtIo+ga8T35ePTIzv?= =?us-ascii?Q?RaK6OchRqeyzPiASC3uk11SYHdTfxO+UBG0Q0IbNduhjoSDHzD+ZyUCYNVz2?= =?us-ascii?Q?Bmc0DwSiuFWtGk3OvgjWZ7tsUNapXqMxJCuyYBBVVcd7YkoeBCFm5lHVLswU?= =?us-ascii?Q?YEpSyv/b2IP5M7RJ4xa7Qb44xbIX3DvHs/hpqjlN63TRwSVeuzjMFjaktlZP?= =?us-ascii?Q?x/XJjtdYXdp3aNCSXETUgtCQ+KKRBVGOurrMlOtZBAyRvIrcCohhGlXTdyiY?= =?us-ascii?Q?YZbBfRIdWsexbTTUPxtNbRZerTh+ZVZCKLT+SyLOh9/vlSVM/+NDO1hl1S88?= =?us-ascii?Q?0Ri1DtZj+2WM58d8sZGBpUd3lS4LLBapnx5fRWvk3VBHwTdoI9pIpybhlUGT?= =?us-ascii?Q?6MtZIKibQmEGIJzUWP7eDHA5O4uqNKl8ss6QRl9krLVP5WVSE3McG74WN4HM?= =?us-ascii?Q?U0YyIh6bPyPKmj72qLraxthXuFlfmQN1C/7nKSB3Y6xmCSZrtqnbRoEvgMNC?= =?us-ascii?Q?q6dGnL6otegCwtXPLXbCInKZOVSpIwBfYuMUMRaE?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f6ddb22-7a7b-470b-5d5c-08db0b638f74 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2023 12:37:23.8868 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qnjTZKwUWC1/qEMeK1iUGV60WcCRrz3GRBpNmyIOZxkR/2MzOTOB/ESxsnJpidg5rcr0viTRi1Y3odfHmVOYyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8247 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gerd, All the 4 are needed to make sure SMM still works. Only having one will cause system hang. I think Jiaxin's commit message is to describe what has been done to enable the single feature: Early SMM rebase. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Friday, February 10, 2023 7:27 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [edk2-devel] [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: > Consume SMM Base Hob for SmBase info >=20 > > Mainly changes as below: > > * Assume the biggest possibility of tile size is 8k. > > * Combine 2 SMIs (gcSmmInitTemplate & gcSmiHandlerTemplate) into one > > (gcSmiHandlerTemplate), the new SMI handler needs to run to 2 paths: > > one to SmmCpuFeaturesInitializeProcessor(), the other to SMM Core > > Entry Point. > > * Issue SMI IPI (All Excluding Self SMM IPI + BSP SMM IPI) for first > > SMI init before normal SMI sources happen. > > * Call SmmCpuFeaturesInitializeProcessor() in parallel. >=20 > Four changes in a single patch. Please split them up. >=20 > thanks, > Gerd >=20 >=20 >=20 >=20 >=20