public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"kraxel@redhat.com" <kraxel@redhat.com>
Cc: Pawel Polawski <ppolawsk@redhat.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
	Oliver Steffen <osteffen@redhat.com>,
	"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug
Date: Tue, 21 Mar 2023 07:28:44 +0000	[thread overview]
Message-ID: <MN6PR11MB82445F9CB170B40A73FFED2C8C819@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230307122037.3100651-1-kraxel@redhat.com>

> +  } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) &&
> +             (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255))
> +  {
> +    X2Apic = TRUE;

Gerd,
I agree with your needs that want X2 APIC even the actual processor number in BIOS phase <= 255.

Question: Is it possible that BIOS stays at XAPIC, and later OS switches to X2 APIC when the maximum CPU count > 255?

I am thinking about adding a new PCD to tell MP code switch to x2 apic in the first time AP wakes up. Possible timeline for the code change is
about within 1 month. Do you think it can meet your needs?

Thanks,
Ray

  parent reply	other threads:[~2023-03-21  7:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 12:20 [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug Gerd Hoffmann
2023-03-20  9:56 ` Gerd Hoffmann
2023-03-21  7:28 ` Ni, Ray [this message]
2023-03-21 11:53   ` [edk2-devel] " Gerd Hoffmann
2023-03-23  2:45     ` Ni, Ray
2023-05-03  7:24   ` Gerd Hoffmann
2023-05-24 12:32     ` Ni, Ray
2023-07-04  9:43       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN6PR11MB82445F9CB170B40A73FFED2C8C819@MN6PR11MB8244.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox