From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DB00D9412BF for ; Fri, 2 Feb 2024 06:20:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0zejfRLjLSLc96edOAD/UQL52K5EQt8Ax2wkip0R4js=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706854854; v=1; b=fAyobMX1tJa3paWJisHPl4aJ4AZTwMPSOtIKSEF+XbeZiHvHSJMY24njb754C2oqFq/LHJ2f DPiNiO+jRREidpsl51H7TX2Sq6YG7UoVDSTTxGBuwiWUm3CQsohcSpvqPqsgSJ65TfncDf5w3FF 75J0SY4Vu/pkeN+iJRM+KuU0= X-Received: by 127.0.0.2 with SMTP id cYd6YY7687511xEm11Wv1227; Thu, 01 Feb 2024 22:20:54 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web10.17544.1706854853696070470 for ; Thu, 01 Feb 2024 22:20:53 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="22584553" X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="22584553" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2024 22:20:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="789147959" X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="789147959" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Feb 2024 22:20:52 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 22:20:52 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 22:20:51 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 1 Feb 2024 22:20:51 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 1 Feb 2024 22:20:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJt6wTaxjCBlmjBXSbPn/SvQNTVc+/px4gFcKipuPmYkDhmXks82jUpYOvLbUIgOITfGKn4dxd9yS1bijY1Rwev6dqj81XwlSo8GW6ZyCtSaPz1ocGuRI9mIeRT57JUT4bDbQKvCQZtGHMWwSS8yxB1eKKAhd4329gbJFnXDQ9C6TRuPhYGq95v6PIODmJWXVZFe0+P+Q7FlWlVTDoQ3oeBE+cJi8hwrEcC7M39B7P/4s5cjDxR4C6pSU7m2z1olIFGcuCyURnvGEQXHNQSzlFEC3VycrC2lPHMI0Cw8SY8VIikXUMHnKbfwuFl/C5zPS8jRmdDcDy14o02DKUVoHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6irSqETnxB1BuHxq5OlI9qqGgAePHyxZuhe+apYP7pI=; b=FrKfJ3EcuSFR14EywbZ1AzgkG8CdcSs6SBk+xU0+i2Q7VqXINtAwpsQtGxp+ku/Git2SMW8tAKbLegGR6hRSTekHOCrIgg2u0pNvczrYbTW7bKBn2Ysy7/bd2bBcTmy3bIvo8afqOWk6Qf2esrl94HLKLfFWM57+LBU7V0yswH2DpwWAwT4t6EMrs0cMOpFAnR4N1vtEcoQXgq9rt7p6UIfBIDQHMvdDxgxOsbpSt2lclu2PHSUqe1lLRDXsJupxe/kwDl5kkkdFS9gMNBewqnHM6dXJ8pP3P4OPLlj6ertHD4DCge6Gpr6C4hYxScWxstZvorBppNb92erzBTbxJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH3PR11MB7348.namprd11.prod.outlook.com (2603:10b6:610:14d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.24; Fri, 2 Feb 2024 06:20:42 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::fdd3:11d7:1c15:6c2d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::fdd3:11d7:1c15:6c2d%7]) with mapi id 15.20.7228.029; Fri, 2 Feb 2024 06:20:41 +0000 From: "Ni, Ray" To: Tom Lendacky , "devel@edk2.groups.io" CC: Ard Biesheuvel , "Aktas, Erdem" , Gerd Hoffmann , "Yao, Jiewen" , Laszlo Ersek , Liming Gao , "Kinney, Michael D" , "Xu, Min M" , "Liu, Zhiguang" , "Kumar, Rahul R" , Michael Roth Subject: Re: [edk2-devel] [PATCH 13/16] UefiCpuPkg/MpInitLib: Always use AP Create if PcdSevSnpApicIds is set Thread-Topic: [PATCH 13/16] UefiCpuPkg/MpInitLib: Always use AP Create if PcdSevSnpApicIds is set Thread-Index: AQHaUKUpRRt1xKWpEESsJ8HRaQZkU7D2nLgQ Date: Fri, 2 Feb 2024 06:20:41 +0000 Message-ID: References: <1948e02ed8167f9b9f8a71dd2d3216896720aa30.1706307195.git.thomas.lendacky@amd.com> In-Reply-To: <1948e02ed8167f9b9f8a71dd2d3216896720aa30.1706307195.git.thomas.lendacky@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH3PR11MB7348:EE_ x-ms-office365-filtering-correlation-id: cf2348dd-add5-4927-9b46-08dc23b714a5 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: n7J/lWdq6shVoSDIIlcq/td//tcltpqMvsd8x9nw0mZKEiQ1O3f2HrRHrXZUR6jl6TXsNwqRsttHa/Uu6xw8RJy91MGKSxchKD3bWi5U9SiugpN9hBbFidWPl6FtdP5p5HUzFrUlwzzC+fef4SdSPkP6AcOQaqqavlYj979EoCDi5jkt4V57Rp/K36Y8oXWgWgXFnwsa22ZVmKRcgfvklggEBzqFXs6CjHWkY0OGD2Hj+1v5lCB0yVRVIO1NGEZpIla/WzzqcizRdaECeReOeUGgkySdtvgjAGwt70UBqnL/xgD/+Uk+QT85FDwpjgbhT8L85sVlEooFnME0n4BBuA9iiusIQx14C/59SqISEzjM4bX/7UKrBT7m4Xbs8PKAIG399N7ZZZrcnqmPHHl40YMLiJlyYJ/NaZCDfDgLaSx/MjV17VxxTA2/itQVcoAAKeVKjUEXXaoBbskvXA7xouIZj0jHtiJqmVopq9bwRb/hFTYPE1NuIpwSaUfPsl/PmIxnCBqIKp69K8jq98Dt8MUyGzuVYqXqUBkrlWr/BNyoWqQMJYX0/1SdtobcelcDNoPka8UxK7i83DluNeCe0YGmpUKSsMHWfCdR7uF1351FVQGi6zFuPZyuexalK8lYsMf8dhSHxDaRcaUDbH97Xg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v5dUMVDmKraXqTq05oXb+uSZa0ZA84gNzEoXUj8XAe+wkwDqssa82wD95FLC?= =?us-ascii?Q?5KmtXVDaswzO0srDz0P+3BYBDtIVo4ZMMF7a6Yc5bIqzw0b9HkUzNoZB2eEo?= =?us-ascii?Q?Q2H4MGFYlg2jLVHenCQF2NGHyvE2qqPyI24Ktk0A5dGGNTAnciIVeyAwmRdL?= =?us-ascii?Q?IYV+VPcQlHouYY2lApZHUE3DGl8fJS8EyC/pdrCsuuG9cEixd5le8Jw54lCH?= =?us-ascii?Q?bKR0ebuu/4CQwXh/IZv2Hqn8P8PRjeGDXnbF0RVOxIqJBe10ArjcSdsSLSYm?= =?us-ascii?Q?Bmmo1xcznenRF61igBgOLCrbTqeLFNsTTxkswZJdQyZXgVTHLUMh2+Okc4fP?= =?us-ascii?Q?YaETMDEhuy7iit614ccr43DROTjIqbjnJcgRlCVTM+Aht4QgseZ3HwmNvPEz?= =?us-ascii?Q?M7r3dtnN3BeIWMWOnXPM48tmvKOI+D63x4PINSRg/fXuWNIHRN4fKXhhiySj?= =?us-ascii?Q?SvLEeDlw2Ry2+757CLmSfaRLpPX89BAkMno/05YuRloGD7pH5amP7Dz3shdT?= =?us-ascii?Q?tKM+CpYHIfPw5MVmh0pHWCoXv8pQDcmntmY39Q/jZZ7t7z5VUUlSD1cmtAfC?= =?us-ascii?Q?SK/bYmKfNvrKWVSn398CWcQPggKDWPFkd6M9eSpBB6uaY6u2qnqCYSuOJRJY?= =?us-ascii?Q?OjP2SaPZkrvrrtgrZlkAqzUQmp0nFViedoyLOdwrehfdo/q9Zq6hjJ0BO5pJ?= =?us-ascii?Q?EFdsDHvWBTmNpeIK18U4YMcSpPTVSjOMrh1DAUQr9mZeR4fpzsOI7LXtU0DU?= =?us-ascii?Q?T62+1y1tvRM0oQBHdZp6URdkG8JcrkMIUFA4nFeEwWI2UYWpGH4+i9TaJt8D?= =?us-ascii?Q?jthHRhVOW7N2tyQO9bqaSUGTIEALm96puSzfpWRLaHN6XU8LeZo25Tc/qCtm?= =?us-ascii?Q?F6+xcrKp8CtAWJzQaCZByeP++dJZmrC9Xf/1WFmJ08SL62H+nieyLLFYzVVf?= =?us-ascii?Q?HZ0IZeJUeT+MtMvpv7sLF19q/HfZfc6FB0ibz0/2uFoAtIAnKKfAkZ/HShGe?= =?us-ascii?Q?XJsiEfaNz+rWXuZ3fNFYEsdSeXhkNUwns7zgRQzAXVz3LaQoiJg4c2nUl8ZG?= =?us-ascii?Q?7L6Um/p4uTVWmGQJkfdhkGsjq2sikKEX8NVU+PMOWdcTrIa4nqDOjRKl3nkq?= =?us-ascii?Q?pKLM/ZB9qN96Ua2t3V8zBbQymOT1ssmGX3AEzWg4/IVjsTCcQ8lfvCjzrRTE?= =?us-ascii?Q?MhdNK6ol157hyoU453h6hOV59+X0RF3izlFtByqgu6sAy/Q0HPGDOEXQteRB?= =?us-ascii?Q?1yIRquxhy+Qn0llAywqH7PGUpYTGeMUPT2+rPl/VFOtdap/BGbDaXSlwLZH9?= =?us-ascii?Q?0AmqiglUHW4oZyUW7K6SNuDe/MWHMEtKmCkJlAq/SsWFhafsWvjZSICIN0Z5?= =?us-ascii?Q?c353qdb3j2LRkHLU/3VHcvkT/kLRy8NTX6WXeMrhKZC5RwWYxbCHF2BNGR6S?= =?us-ascii?Q?OFh8AgkhOSRa+GGQ6ugoN0jCkQUjzoAUd8fxugZrUIvKJfRQKvf8UYqQopt9?= =?us-ascii?Q?B9ElkjfSfXegNt4mLX76+ARXVBP6r0uTiFb4FLM+JV+t45TvtELedPhbap1T?= =?us-ascii?Q?NSW12IljRTivXRoM9gg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf2348dd-add5-4927-9b46-08dc23b714a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2024 06:20:41.1748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S7Sj4eKH2dOaVaaeznVTEX43b0MwQFFNi+nHg/VqAoACv7GhQz8oW/4BVgCf7xgAa4OUTFHxtBq+/vRC/MNHUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7348 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: S1fagVJ5i2AxXVhMo3Wov4h5x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fAyobMX1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > + if (SevSnpUseCreateAP (CpuMpData)) { 1. Is it possible to rename "SevSnpUseCreateAP" to some name starting with "IsXXX"? I originally mixed it with SevSnpCreateAP() and thought you created a bug. > + GhcbApicIds =3D (GHCB_APIC_IDS *)(UINTN)PcdGet64 (PcdSevSnpApicIds); 2. Can you define a GUIDed HOB to hold the contents instead of dynamic PCDs= ? Dynamic PCDs cannot tell whether the value is updated in earlier code or st= ill holds the default value. Also, I prefer to minimize the dynamic PCD usage in CPU code. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115022): https://edk2.groups.io/g/devel/message/115022 Mute This Topic: https://groups.io/mt/103986469/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-