From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.3539.1685426395994150887 for ; Mon, 29 May 2023 22:59:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=MBkIs6l7; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685426396; x=1716962396; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vzU0uj2DNImidkYh3W6qz8BgjVjeWHDYkbBwSGmWLDE=; b=MBkIs6l7cP9KB65H1TugsTP0cUCSeqBSTrApLNAjDsqeWHR8CJ41iUGD u/XeIC+qKiVOb3uN9VE3sxPPCue2L6CNEgGkly5KOe+LVHXarjXi0ireQ 1KJRFrj4qkiROx9RwTP+fk5yz4Hk54EDDDpfzIWojMY0PQsUibrvbs7y+ kllPgpZXEo+tFv6+0rXyTFe/aTDKR7D8ZlmyJyfVM6RjS9qGg+pgGBRms p3Ns1maLsIX3x/hkqVPerW0LQlDMTseDR7Mu5Kh0fCQL3nSLTR99Hrs+a xmUX4e4oubKe5LeSwzfur41rDq1fcmEahSx2xOqM8W3qYuQmljWlqE9eP Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10725"; a="357198508" X-IronPort-AV: E=Sophos;i="6.00,203,1681196400"; d="scan'208";a="357198508" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2023 22:59:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10725"; a="739379583" X-IronPort-AV: E=Sophos;i="6.00,203,1681196400"; d="scan'208";a="739379583" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 29 May 2023 22:59:54 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 29 May 2023 22:59:54 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 29 May 2023 22:59:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 29 May 2023 22:59:54 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 29 May 2023 22:59:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7SibeXveNilrS8jvJ/d7Wyi7infKR579GPRimP964AFN+W6BUm1mQww3U2RF7FsFUaTfDqXsMtFPBom14Y4/w3rsPRBXLncuEdBkpyHgTJtI5bDREnbUsYQeacYjtf6+hoNfnCZAIt9Qa230NjOxc/QHfrn0mT0lB/9eMgcenjdlZIvQuBoFJXcPs7K54NIjR7wjYJlLW9zeF3bBgTrsG6zIin9j+fvkKy+mql38B0nm3TXWQkEvJP4MwEtNEHBgj+bA9bhw4X/zxpoDW9rDSV7+jg2217O3qF0vfG5jN93Cks+8rhDyuxqm+7jne/ojwuiTLc0YcK3JGWMSaaI1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=faQZKYliSaDDV7EgCvPKg/r5n7pAJ+RkmEbNYP+TMHY=; b=liUy+PP9RU+t7++ZiWRsxq05r0ZADoujanCY6clxtKenMyjO9FuciYfVsMVoKk4QmpeHmq+XJQTHcJSJCrl17Fk+uEmCgvS6lTi3fNaoOd/mR/yI5c9qlXv8DN79I8VY1zyAU/BgrcPaRiyV1Kz9P4SfIGYm2IIO8DcINLwQrQ3kINd6y4kH0/llZovGdv1D6r+g3pg3W6jlFNQKIvn2edvxfYzu2x8kzRVd4Z4UpJ4M06I4d389otK9hROdcLWedrz9dL1JMmI7SksnpvdNLcO+B67lX0LVIUKl6GNZyYA+PdWGitOr3ZvYdpEBQg834Y5rXw5O6vdWE69yy1iR7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ0PR11MB5769.namprd11.prod.outlook.com (2603:10b6:a03:420::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Tue, 30 May 2023 05:59:51 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6433.018; Tue, 30 May 2023 05:59:51 +0000 From: "Ni, Ray" To: Ard Biesheuvel , "devel@edk2.groups.io" CC: "Yao, Jiewen" , Gerd Hoffmann , Taylor Beebe , Oliver Smith-Denny , "Bi, Dandan" , "Gao, Liming" , "Kinney, Michael D" , Leif Lindholm , Michael Kubacki Subject: Re: [RFC PATCH 03/11] MdeModulePkg/DxeCore: Remove FreePage argument from CoreUnloadImage Thread-Topic: [RFC PATCH 03/11] MdeModulePkg/DxeCore: Remove FreePage argument from CoreUnloadImage Thread-Index: AQHZkhbNYsWfzDWL1kuL4cnzbFwl3q9yU68A Date: Tue, 30 May 2023 05:59:50 +0000 Message-ID: References: <20230529101705.2476949-1-ardb@kernel.org> <20230529101705.2476949-4-ardb@kernel.org> In-Reply-To: <20230529101705.2476949-4-ardb@kernel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ0PR11MB5769:EE_ x-ms-office365-filtering-correlation-id: b6bd5627-45d5-452c-dfb7-08db60d314ee x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2a3KIKWpWUYNDnS8WmxOTj0FtQPy5A9+3d7zovIZAHimWh8lI1586kg9gQbwNRdRAxIG1o8xy5aX4z3BYixr7+PD0U0t+O7AX7bO6NudtdpeZuWc/JJbTr5pa+mRXxeRz8V/RJKbyWLIev1ysdetjWbZafmJ1WKhQcRmfWLbEFqezIk/FxcrIAiPercEqVuNWIl6JwBOpIes+cSAzRLKNulrpXA3Pg7zRRy24nHuoT3H48vqam82tbqzoopXJwV3QzETueqWDym7cNH/cLQq2NBSiyZIupUeqtKiGOUwt62b2M5Ez1MupQ1LrAFSevnYEaei5AX6upKE5VsZBdcs2rcp+OmIEFdk7vzNQOj49TSh6mCnKErU3yGpcB1MhNN5o2d5AgciVHfQD+IFG7p/+DIotPnRPc/PAj+ZdoRtfWTl6aaQvIa8oncUu+jMg3phIw2S39LiRlXDVQkjMrdxoETSd1saxkdgRSjDCd+Km8FTC6C99YpSxgIQ8JIanjb1cceivPasLSBurjtipgPoPN6zgyDtMmDbgi3rTA0c3c+5OcyF0er785sAj1QzcELIUUaxv2o8ulCGyaa1a2T+Y3PfskulHSUo3zgbhuZbyVgETQeu4+U7nsOtJeMtWxl7 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(396003)(346002)(39860400002)(366004)(451199021)(6506007)(9686003)(186003)(2906002)(53546011)(54906003)(110136005)(478600001)(26005)(83380400001)(8936002)(7696005)(86362001)(8676002)(82960400001)(41300700001)(38100700002)(122000001)(55016003)(66556008)(66946007)(64756008)(66446008)(66476007)(76116006)(5660300002)(316002)(33656002)(71200400001)(38070700005)(52536014)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Oyv403A2y0MQXxP6nALxuGtffeY4QExSPryZk9ciHTZmSUMNzl+tdJoDxjvS?= =?us-ascii?Q?g80RFbftjnONfp7OZMzoXyBPPOpK73AjxREJYiyvo/omeM4h8awVz6HqsxxY?= =?us-ascii?Q?ztIfnHHrhnJTd9Aw6ThcKcagBq39wTlGfWOu7E/f9ADc1CipRyXbF3B/ZfEv?= =?us-ascii?Q?OGkavjTHMBimjzq7wHmFWgEvIADjHjsGAWY8a8ILhFhgZhB0gBu1w4hSd/tK?= =?us-ascii?Q?6UczsorhREi+pyWF8Ww/IiEdbkE8GNKOGXmpR0FhPs2TUTeobky0uudSG1JD?= =?us-ascii?Q?4OOxgzzpo1RgPiIWhC8Cvixc9u7ykfwbUsSDBjRKtDvBMqay8NZjLiwAbt++?= =?us-ascii?Q?MLubrf6pX9BQNralA7k+XdqUGm7nNf3zilwn0eKeGpGuBG/XGVLLlrq5PTYn?= =?us-ascii?Q?5hJt6oHbmm97SlvljJRW4hn9iOhKrqGUKNiEmLfK13S0Mw3OCSRYDaJxsdX6?= =?us-ascii?Q?g3GFGErtcgYvIp01FZcfYp4EA24usls+vT95g88bVjAutXSavkwMxvUTYtGm?= =?us-ascii?Q?XKTn6GtDovRvEEXNMPXAQaYsVGeWQXGBxqM6WwS+vq9zo8VIBQAW1rn6aYdM?= =?us-ascii?Q?JidIaltYnPm7q9GYEmyCehATiWyK39K+i/2e1hSJmrsHQM8x4bDzH3w9pm1i?= =?us-ascii?Q?l70SUgRWFLBFq17gEg+DEblEdFp9WNr7U85yUb2gQgk8itFPEcGh3gn8Wu/1?= =?us-ascii?Q?uMjCjxzBbG5m7BHQXB88y4fPZyPcXIeAfHR7rhObAQG3k13TUHNwgRPOVv0U?= =?us-ascii?Q?eaQ9GBBRWEuRWjq9OMAfQEb4iXXdIilpGavxkrE7rJLDqTIdY3gNDSLch8NP?= =?us-ascii?Q?HvR2T6JN9smbW0F0uVxU+VgStF7+2fXYJ7KTz+GocE7ae8nk+X0z5OKxHzx7?= =?us-ascii?Q?nXHEU+4/QnNrbkgWjHkgF+9bh+8LzfGuPbhrX2dZZwe2Pvmtp+WQU9NLjHpF?= =?us-ascii?Q?Y93IRWSNC5nRtHcpmahESK1T7g1VLuvAq5nAHv7TMmR6GvgasDlisaLmh7AI?= =?us-ascii?Q?AWjxFHNLvH29aBDsRmdYENSb3k4AwyX7BrO8XabGiaLjWTnz4dsQVaJ2uuIV?= =?us-ascii?Q?c6MQzkwE50Vh3Qv6DxZjMCJt5656alMjDumIwlO/5bSZj6+fGsM/WCsCRVe8?= =?us-ascii?Q?rfycJteym5kSyHEJzVVYNKPrt/AZUiYtE90JkDS2RgXBlkv0MlIplZ7e8M60?= =?us-ascii?Q?hTDVWqG7kfVk01QwY3YMWCAyG/DJPxgdWtiBY5eoto7nj/zS3rQEZfmKQYQd?= =?us-ascii?Q?PnFOTQvK1Ov3j4vgMm2v6wbYouYjZcny4ZF5NVS0pHRmpARUNcxYXEPUHslY?= =?us-ascii?Q?31zlkKt/zof9+EXU97lenMjqmo2jz8HTgm42hNcaeiBw7aneJAntu1ReFdYm?= =?us-ascii?Q?GOjSp18JgxvjXNL6VcUED3QoubwQZ8MKYNx60W3OGdbqi+T/pNvjskxpn46n?= =?us-ascii?Q?aD1UZMKCVSFjzE7ryawzcYogHfLhUMFMrOtymi/av7NVOslgPF8jAaI7oWRS?= =?us-ascii?Q?BAetM5Cinbzxxy7fE7w7SBpbX7ISQP2NMnZ+TKncx+EvaSchI6ZEuLu4PzKw?= =?us-ascii?Q?ponU6bck7Yx7Co8HufQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6bd5627-45d5-452c-dfb7-08db60d314ee X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2023 05:59:50.8215 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 718AOsJNac0M1f/KfbPH2m75R7hLmSfXswee06/8MQtePB09kFW8OCT1Jo/N7euu+qv5F0hl5tPFNvZ8xxriOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5769 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Ard Biesheuvel > Sent: Monday, May 29, 2023 6:17 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Ni, Ray ; Yao, Ji= ewen > ; Gerd Hoffmann ; Taylor Beebe > ; Oliver Smith-Denny ; Bi, Dandan > ; Gao, Liming ; Kinney, > Michael D ; Leif Lindholm > ; Michael Kubacki > Subject: [RFC PATCH 03/11] MdeModulePkg/DxeCore: Remove FreePage > argument from CoreUnloadImage >=20 > The FreePage argument to CoreUnloadAndCloseImage () is now always TRUE > so drop it from the prototype. While at it, make the function static as > it is never called from another translation unit. >=20 > Signed-off-by: Ard Biesheuvel > --- > MdeModulePkg/Core/Dxe/Image/Image.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) >=20 > diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c > b/MdeModulePkg/Core/Dxe/Image/Image.c > index 6625d0cd0ff82107..f30e369370a09609 100644 > --- a/MdeModulePkg/Core/Dxe/Image/Image.c > +++ b/MdeModulePkg/Core/Dxe/Image/Image.c > @@ -888,13 +888,12 @@ CoreLoadedImageInfo ( > Unloads EFI image from memory. >=20 >=20 >=20 > @param Image EFI image >=20 > - @param FreePage Free allocated pages >=20 >=20 >=20 > **/ >=20 > +STATIC >=20 > VOID >=20 > CoreUnloadAndCloseImage ( >=20 > - IN LOADED_IMAGE_PRIVATE_DATA *Image, >=20 > - IN BOOLEAN FreePage >=20 > + IN LOADED_IMAGE_PRIVATE_DATA *Image >=20 > ) >=20 > { >=20 > EFI_STATUS Status; >=20 > @@ -1022,7 +1021,7 @@ CoreUnloadAndCloseImage ( > // >=20 > // Free the Image from memory >=20 > // >=20 > - if ((Image->ImageBasePage !=3D 0) && FreePage) { >=20 > + if (Image->ImageBasePage !=3D 0) { >=20 > CoreFreePages (Image->ImageBasePage, Image->NumberOfPages); >=20 > } >=20 >=20 >=20 > @@ -1413,7 +1412,7 @@ CoreLoadImageCommon ( > // >=20 > if (EFI_ERROR (Status)) { >=20 > if (Image !=3D NULL) { >=20 > - CoreUnloadAndCloseImage (Image, TRUE); >=20 > + CoreUnloadAndCloseImage (Image); >=20 > Image =3D NULL; >=20 > } >=20 > } else if (EFI_ERROR (SecurityStatus)) { >=20 > @@ -1711,7 +1710,7 @@ CoreStartImage ( > // unload it >=20 > // >=20 > if (EFI_ERROR (Image->Status) || (Image->Type =3D=3D > EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION)) { >=20 > - CoreUnloadAndCloseImage (Image, TRUE); >=20 > + CoreUnloadAndCloseImage (Image); >=20 > // >=20 > // ImageHandle may be invalid after the image is unloaded, so use NU= LL > handle to record perf log. >=20 > // >=20 > @@ -1776,7 +1775,7 @@ CoreExit ( > // >=20 > // The image has not been started so just free its resources >=20 > // >=20 > - CoreUnloadAndCloseImage (Image, TRUE); >=20 > + CoreUnloadAndCloseImage (Image); >=20 > Status =3D EFI_SUCCESS; >=20 > goto Done; >=20 > } >=20 > @@ -1874,7 +1873,7 @@ CoreUnloadImage ( > // >=20 > // if the Image was not started or Unloaded O.K. then clean up >=20 > // >=20 > - CoreUnloadAndCloseImage (Image, TRUE); >=20 > + CoreUnloadAndCloseImage (Image); >=20 > } >=20 >=20 >=20 > Done: >=20 > -- > 2.39.2