From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.10725.1676280336053912225 for ; Mon, 13 Feb 2023 01:25:36 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=PHAyk8we; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676280336; x=1707816336; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VMR2V4owNIXcg8NHv0sSpQn4nN+Ti8BTEFxG30hmAAI=; b=PHAyk8weTKFdI0/+I9IAR9QgXcpa1pc8hnM1Iua6+cGwi2D1Fj3+m0vm /Twa46nu/1uby94LoGTa/pEM/3Pfqu7UuldKf07xn39w0FIGUTnb3ODC0 FN3RUJ/iR7RdFJMzj+AEVWRsTwVJEoQHAIgD0B6KgACDesNKEd99zUsVt V63pWXcAIE2kaQRdabfPPzx0SpUm6GC6dqTNu8RPDaBa8UrsW1SzZxsgy 20wNU0pSWAoBUrdPIynW/2oIZcJHBdvglVzktZOVxH80Y9j2y1f+eV3Ge 3dYVPr7qeJq0l9zrbHuJNncKwvxzfh8Nri2+R4fiYfVPcdPIim9Zwi/eK g==; X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="311211282" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="311211282" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 01:25:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="670757343" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="670757343" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 13 Feb 2023 01:25:34 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 13 Feb 2023 01:25:33 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 13 Feb 2023 01:25:33 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 13 Feb 2023 01:25:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ghn6e8TSt+MPO/xIS4NcccaUp/yNDf2ngf3nfrpe4HOx4T8/HtsIBWmS/xRxBFTH3iNuhvsxB0q0JC+8A+OEtOj7TvXJ+TedXqturdra2qLHNklJjqrHgI3X/eEzvBb1RnUGM6EaD7QupiueMWYQy5LW/fwBzMFsFjVctcTC7ZXP5ZWHtd+S2fDAPr8dqCW0orzkVBXVT8mZZEXMygo78ji7BtscRh/aF9/npK6VxHhxYkf6MPg4PBla3YmGK5/EjPLyU2Q9tDCl5ZnV1xhrlpczj6FsehqPMbIwF+qln+8DexO24E3rSHzb2VkMMbeVV70YfF6l3sfU/6w5ykiV+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N5Ad0v/jPdev+43yWarF5lTg5ekEq1ny1ECUH5Pi2S4=; b=cTtfaC6VWtb4wYxfb5mQzrzoK9SoWgsDuUYSCjoPWdaaV4oH/FsCnAtGle+IGywBwBcZ6j46NASKmE2t77YdDVABRaYTJoCJHY4Lu3xOistF7IVys40LuJ1vOH0MtD37Ir/BxFJXkHaMeA7Em3+PjoEGR7TvGILKsv+wrkUT4rmFX2ZpopRAPzksHghBGmKIf0SHGSbAiAZuJncWbrJFJEI39/X6WxOOhU8J6RcHx9WsL6nTnI9SUYuWKDaxPaqNCFdf+GqU41pKC3toBCaNiXajMgztXHsb5xyr3w5H6snv0GnXeHe/4YcjHQMyFa0rferUcfFIr8rwGTmMwMaV6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW4PR11MB8265.namprd11.prod.outlook.com (2603:10b6:303:1e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 09:25:31 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%4]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 09:25:31 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [PATCH v6 1/6] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call Thread-Topic: [PATCH v6 1/6] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call Thread-Index: AQHZP4dk+h0PyL9OT0mufG+HD3/lfK7Mmzgg Date: Mon, 13 Feb 2023 09:25:30 +0000 Message-ID: References: <20230213084417.9232-1-jiaxin.wu@intel.com> <20230213084417.9232-2-jiaxin.wu@intel.com> In-Reply-To: <20230213084417.9232-2-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW4PR11MB8265:EE_ x-ms-office365-filtering-correlation-id: f67027bb-b8c4-446f-69ca-08db0da44050 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XerBxLMwx5vWiBRT6UbRfPj2bS4A6sTjCHP1JCxrSWSF7PEJUUfbl+WYyZ+Zp1ZUNRYvzoHj/J3Ho3qA6GHgN5iqPNo+JyPT27aMC6K7fzgMgPeBBC46ln0SdtYu+hcA1XluLHlBnHrVwoObN0FK7KsRxi1gSUY45Iv2OpviO5dD+cceMg3QxOJToLKG22w2haTTgy9eRoflwvHp3btGC4w8MmlAEMpBqGXfI3e7Il/nMJLgoI6tOTLBXy/JQ51EGaJDd7T6tx728Ee9qS7fLQtTX66NwGC+d7/OQ7Varf7C3WrG17fmeEQEDQ0BYfpo1w8sXMImB149QL2fRbT7k2XucHy2jRSH0SoJ0vkYJPhHgDJeRPkCV2RO1jXeR0Qiqk1pAwuGXOaueraRl01hamMT8d2U+5FquMEXt0vsqMpXer+kUMlV0qtS3ckP+m9rAgYZ4GZACLrc4bjj9WaobSVcsmUmloILeNZmT0jGkUZhDB+Ms5Uy4DdPFqQn9nYS8nRjx7nMuL1+kzqaGfd/9tdquu0roxAxGZ1CmA8ztzdaDqV+9mt1EG8zNTtg3EFf6K1c67ndkGs9bPbfKYhwho84Ndz//G5SZq5IQiZeZ+NiolWS9GD9bFCVtPlw7Eb6G1JXVKoqBRfAoWwm8xd/qQPY6MNuLtxVlcxkh3377yj+lqCdhwWHUa8rBm8m1c8zVLa+OgKR4W2mycSmee2VGIdENOkN5jc3/0fY/9kxZCA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(346002)(136003)(376002)(39860400002)(396003)(366004)(451199018)(52536014)(5660300002)(86362001)(38070700005)(33656002)(2906002)(8936002)(41300700001)(122000001)(38100700002)(82960400001)(83380400001)(7696005)(71200400001)(478600001)(966005)(66946007)(66556008)(9686003)(186003)(26005)(55016003)(8676002)(4326008)(316002)(76116006)(53546011)(64756008)(66446008)(54906003)(110136005)(66476007)(6506007)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WOqkp+jr7HExa46RNQbnBtU39KYIEoTwrUkVhrms2o7RBSr+LysUlc6iZcuz?= =?us-ascii?Q?hA1zE4V1TOZUcD4LmkLCtmc7Sq65amcH7P0z7/MtKJQdHbBBKOdpYeMYQuBS?= =?us-ascii?Q?3qAZD8T74sTOPaT9wSum+AbklK2yT4vq9p3EwPob6KlouBoWCpvC3l5XUswW?= =?us-ascii?Q?of627uLAn7fkwrB5uAYkHVOh5t7J6VwJwXgkhrINiPZ/ol5Z1xD/EnebdKzI?= =?us-ascii?Q?gZNGW0DZk0WtByyzDVfupEsZMjnbDDZAouihZ6jwXDQQt7Jh/HSeAiWMbXfs?= =?us-ascii?Q?18eTyPhFVDm3tqJ/umZD+SqfOL807CLcBNxJ8I1Ianaf3DNMWXvfnPgNupyy?= =?us-ascii?Q?QAi5WOjHnzLR7D91EXSPngmq/ZIRM9a38NiezK2Zmh5KjyCmFUBa2XHMyeET?= =?us-ascii?Q?y67/0F6lgFAM8ACtOnHowR6EPZreUAonbCMjifroUR7fv+aBO4BEXUwV9Vll?= =?us-ascii?Q?fkqUWZZv01P5QuEay6OB/fMxDzwwpJf6jqVdo51f0RpFtt3XxS13qxTJN/2P?= =?us-ascii?Q?l65tYJK7J6xzzjcZmuL4aAszIZmkU9QIsXTQjfwoPreCbL/FiqThStwFmx4H?= =?us-ascii?Q?CNnLU6KQ3t50mYlTfLPRQiRGFznyZ403sq+IyIOSfBdfnar2FpI/HqnRmZ5t?= =?us-ascii?Q?TjJv4uxb+8QXuk48p5HPziBwMhBK4nRwsDaT4BT0dMaAgfnDoa0QJ9mo120Y?= =?us-ascii?Q?OJRTfjuJCFekyBkHIpwAfYnpJUJViRF57tClSf4QgSQKWeJUmH7vjc801UeB?= =?us-ascii?Q?Ibcmr0OPsbMb/gXDu2edr5muu6HdH4DP0YVOR5BQ/7nlS+kiNbuOpXNlLXGo?= =?us-ascii?Q?7BFJwqrvmxri48i5PYIZpKb+K5neHV6MJuQ4+xZ+Y7RjNnvlNggzCT0PmH8o?= =?us-ascii?Q?aeFCv/rP7f644ldDIN39GZ1klpsgAWbiZuHJcfkqLFlEEpaLzU0ZoKEF6oXT?= =?us-ascii?Q?6MdG9l2u3fDmFKb7B1soiZsREkWRuj2Cg+49qfi82xe7ky76FB0R6WQponHX?= =?us-ascii?Q?t7hc126o68aMSyoZN1YPGLf4IrvwSvNUo3ms2p1676Kjy/l458keBtfrQlYD?= =?us-ascii?Q?t5Ga96VJaB29fv3BpzBVzyWhCnSPYe4TgkgXxykYQ/pOYpi1anienkVpS3YS?= =?us-ascii?Q?Edi4VnIuBhYIFMWsK4kY2VP+LSnp/z1nEY17ngBFHXjOfBj2S1VHeJxdLMZi?= =?us-ascii?Q?iJ5Jpm4w77t1lIwA/rXHgdf7MVZ6cdm8NZPWVkhuRR/Ae2HTr9r2YzVl5by3?= =?us-ascii?Q?y61O07sZkIlhihN4gV1S+UoXpL80RQRSqIy5WTIMJnP0eS0wBj1ICKdOB3BF?= =?us-ascii?Q?oLlWkhVR+TVK6nyTz0QyIb0KOlTm8GRAe3mBVn+33OLDShtGNPi4yxr8spCa?= =?us-ascii?Q?TyTf2mTpqSveCGd16Sj386i6sGVS7b/J6ZA4eCA1ddRa2921ifp9V1d1dmTO?= =?us-ascii?Q?Xqsqo4BYc78bbu8naq3Y989Ufk3jRlpvq+r6f6qZIaQ39+PniSPGBMzC5kLz?= =?us-ascii?Q?4fqyi/R7RutFCeSS/Tqo7lPElIPOZ9a+Va99BOmvBgzoN9LTw2NBcaC1biMA?= =?us-ascii?Q?IWrgw+9oPaIXMsvwdoI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f67027bb-b8c4-446f-69ca-08db0da44050 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2023 09:25:30.7397 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FNcMRTnpV3e2t3ssJLjRejj8W+kZia6ARkdzS4nq1ZblQ6Z0sWGKFPIyHckM4b/f0cmeNHKZ88dp51x7okAtwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB8265 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Wu, Jiaxin > Sent: Monday, February 13, 2023 4:44 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, S= tar > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [PATCH v6 1/6] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid > InitializeMpSyncData call >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4338 >=20 > No need call InitializeMpSyncData during normal boot SMI init, > because mSmmMpSyncData is NULL at that time. mSmmMpSyncData is > allocated in InitializeMpServiceData, which is invoked after > normal boot SMI init (SmmRelocateBases). >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Zeng Star > Cc: Laszlo Ersek > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Signed-off-by: Jiaxin Wu > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index 655175a2c6..2ac655d032 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -1,9 +1,9 @@ > /** @file > Agent Module to load other modules to deploy SMM Entry Vector for X86 > CPU. >=20 > -Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2009 - 2023, Intel Corporation. All rights reserved.
> Copyright (c) 2017, AMD Incorporated. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -369,13 +369,11 @@ SmmInitHandler ( > if (!mSmmS3Flag) { > // > // Check XD and BTS features on each processor on normal boot > // > CheckFeatureSupported (); > - } > - > - if (mIsBsp) { > + } else if (mIsBsp) { > // > // BSP rebase is already done above. > // Initialize private data during S3 resume > // > InitializeMpSyncData (); > -- > 2.16.2.windows.1