From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.17696.1674054374895011277 for ; Wed, 18 Jan 2023 07:06:15 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WdixHWsP; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674054374; x=1705590374; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=69Auq2KfqXflGUSRqVHRKej6l0bn07PUmZ2sbl13L3k=; b=WdixHWsPtbjbcxL4JrNbcH3AfyXjGF9/P0es+mrXY7hLDqJCzzlIWvo0 6+l++ju5JTiEZAJppcsaTbztIWltFVmT7bbayTh4pnU0pZdku0J36whHa S2wXwO4lIIUOad/MILBU/r+Dgi+QDQvnAbAz3nDezARYY6wxV4U1oPtWC 11kcTZDtIWJtZ0na16JQCL72JqqYLCTJkFpyXS54EGVOia0Smj46NJVrO FZyIhPwAukV2t8nn2S1hGxJrLotLua6fQJqzbu6OnW2h/HYLTbK7J+gjC exkkOXXJJEO+RVe4QVNglybAbrqBfp9Uo+KCheesJSEqKlaiMum8B/B9D w==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="325053808" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="325053808" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 07:06:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="692027377" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="692027377" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 18 Jan 2023 07:06:13 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 07:06:13 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 07:06:13 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 18 Jan 2023 07:06:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=atgwNjZBtBUFvSw8AJSnmSPrWzZ/Nq4IeqrxtNkPNUwd2TXOVaiIcw5Q+OSTrN076wDd6gX0K7D2fJcJZlze6gzaIduezNocxJb55GQMOQ+hZeQZhtDClk6z5Dp7812fKaHGBJpUFWnnKlVgxNnCpjxbee5pvE8ua33ATXaNeBCzSItjW0orkD1fqkvWvWFrIUDYVgcNpSXdlvW22dYZjQlxYEaoA9sxp/loLKkEHwKh/PMGfYePDZUNRHvV/F0xrJK5BgQ7GdANeiNI0NOB7OiU2KSrh4BDwrcOorT6Qv0/rL5B6zFs7aPekQnTwx+PExxEzCaMyzOFP4p/qDs0+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=liMqi6zXqR9l0k/EsaHVv5Fex4bDyAUfuh/wRsHbC2k=; b=DprJmXHBKdnWjyp4uvqdgF0kzGv6qYRLEHGlaB/gS3F2V8Z1uJZfzCJeXy9WOwb2277+9x6jOqfi69vXxzQBTBQW7JGtzlDb9u3kzGKsn483XxCeNtwb4TtDEi5KRpCoa3jT4ZCePOIfUyFwX+SqUn2zq7JMAJStUaZVpBFVlbm+nCfSGp2Div9t60GzSxXVY5zvkYHAq3Y0wx9Ea1kcEnBffkVrcFXeoppZHB5zBp3bVF1HmhGIKrcEKaPBKx/OtEbBj3F9b8pqWcC+wVKPSuiP3I6ZZDShVf5zLAbLIIMitOamkVYYypnf1FHeDLGm4+pQgowR4UQsr3h5oIt/oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SA2PR11MB4873.namprd11.prod.outlook.com (2603:10b6:806:113::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 18 Jan 2023 15:06:11 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%3]) with mapi id 15.20.5986.023; Wed, 18 Jan 2023 15:06:11 +0000 From: "Ni, Ray" To: Gerd Hoffmann , "Wu, Jiaxin" CC: "devel@edk2.groups.io" , "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , "Kumar, Rahul R" , "Kinney, Michael D" , "Zimmer, Vincent" Subject: Re: [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data Thread-Topic: [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data Thread-Index: AQHZKyMs7t74sVIYH0SPAgkW85kk6a6kBxyAgAA3bfA= Date: Wed, 18 Jan 2023 15:06:11 +0000 Message-ID: References: <20230118095620.9860-1-jiaxin.wu@intel.com> <20230118095620.9860-2-jiaxin.wu@intel.com> <20230118111913.xgjlxdhngzwhvf76@sirius.home.kraxel.org> In-Reply-To: <20230118111913.xgjlxdhngzwhvf76@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SA2PR11MB4873:EE_ x-ms-office365-filtering-correlation-id: 200167b2-bedb-480c-b5b9-08daf9658928 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6qSAL8oirae79M6cFQVC2FjZJtyChWiC37wdLk+TdUpC5JJDFLN9O9O2/bgFvE4xmu6jQFk+mNc2TYbDgMxkdDdaLP0ICSXsCFXUiu1/ngq2yQHiiPhUWvIHd/yny+69oYWfMX3UI5gzDkDIPK25Hh/iHKbJ7t1GqaCEfECIlIEOW1z5I6weeDTyXuIg3Zu1eQxusFJbtLo2xrFYnHX2B4qBwrwlwBE87CtMbIl27CDQG+FyycOFHxHuh3noCnbqCPzqUDVzlUqOxLhlxfApaooUE+sSK9b9Plqy2TtcPomO9l10gOqLBVfgoM62m3wAPqV0+lB1Qm/6mwLle0Ey7vXexbW8z6TwJxBEN3lH10PlVU3TsEUkwU0JIbjh7wcibI/WMSyKKx4/m8hdgUJNV93NIYleISCqMN18TWK5fmLnWVK5Mbl9SRe/1rKsy0XeN7YOemvI8NeyI2UZzj2eauqE2hebykysZeLlgwM/b/xo0/mSmm+9nXDoKi+48PJUCpv2oxm2aK4/jLwAavyJgchc4VHyOT4WshcSUp7lak3w821xdEB4zNc7BK3G8w1lO7iTXt329uLwlkV9WfH/qA0oXBLhXr5jFI9FYQMdgNi7ziGgUO5vitJZbZ/yevubOzDIz/BxYSBv6ShF+4mnzAUwlQzqvx1dHVs+jI+vH37bFLxWfqaoVaZwQAY0GS6/0aty/SOK9En2vdn66hWmMg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(136003)(346002)(366004)(451199015)(186003)(2906002)(38070700005)(54906003)(26005)(9686003)(71200400001)(7696005)(66446008)(64756008)(66476007)(66556008)(4326008)(8676002)(66946007)(316002)(55016003)(41300700001)(19627235002)(86362001)(83380400001)(110136005)(6636002)(33656002)(76116006)(52536014)(478600001)(8936002)(5660300002)(107886003)(122000001)(82960400001)(38100700002)(6506007)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nM5aE9lGTRyJtQif0xPMprxyE/+XP/rsgDsD8VomXj0kyCxc0lkoMO1rKYkV?= =?us-ascii?Q?DoibveNyHdjkZDT2a1pZcB6S4owey9Fk5xg4MN1bWEzbwFj17DJtSJNk8S1G?= =?us-ascii?Q?sEv/LN2chbLM9JWJhz1uVOu9GbR8Lk9zkJOGwJ4y7/UiDKR4Pm++ifFJAj5c?= =?us-ascii?Q?4lgtHE/irG59vkCO7UzyAdaiCKKJktSpn9xoGenoq7H7strrUdAUnlY6O5rJ?= =?us-ascii?Q?4m7Nr1hFzudcVW8/WoKL3k9msIQlu3V54K+tTQDMGN+MHhILSKCDAsOyMSrJ?= =?us-ascii?Q?EWxGxWejvm6Ax/ouIvISeybpTwblazZI00IouZAtP289X9QCyQ5iuruF+EBj?= =?us-ascii?Q?2Fvul+11lkvtQ17//aufA9JMhOgB995CDmumNhgQq47t4wr12S67k9mXhISy?= =?us-ascii?Q?hCZkAcWFwuBN4mryIkpIuhFY5O6p0Yvw7Vsg9p9ks4WixhDD1OBrAUmk+A1b?= =?us-ascii?Q?uILeTMkuYtz+fZZCwAtjV0xfAd4s/P+QpiMs9jyiGFqXpnAkVHVFtNuU5cc6?= =?us-ascii?Q?Wk/CHdFpNmMPeReWY7UQkgsiDwxyytt5yGtM1WT70LrCFs2V5YX6M2UZBpAn?= =?us-ascii?Q?91+6MV/jy618u7DwwBucdfpF8dIhKh+5md0ROCW4pcKVqbUeH6LnOjQiwZrx?= =?us-ascii?Q?i/1pfHWerY0obYTH5KgM2tG+Df1n+1dTK5NPL+OCuBP1tTG549bUrYdc/Rep?= =?us-ascii?Q?hgcvmhlWou7/Ho1PsXmgeQXtN9EAInuFYcHhflGPQNH5fRw4TLK6roqhZCp+?= =?us-ascii?Q?MrSeBHN9gCOSzGVw0zVtom5LMVsXWR/8YSbCnHpwxb9ILIZVJXWHgokt1tav?= =?us-ascii?Q?y0AoMe9blvk7JC/O7lRhz0UnKSLKQuCZlHW2IdaJqL3dYN4hPiiJtb1dT4ZB?= =?us-ascii?Q?ohakNTXu6ULJK2KN1c+ND3UOi5dLiqo0BJfIfyI9qrnNuerkhTBCsPA7Af/N?= =?us-ascii?Q?Mj6I4cEOBMeqmOYK3fN1E9IN5axqJOMIkYyTQUy0K7IzzA64CgFnrvaeGukW?= =?us-ascii?Q?ZJ2Mw7jfoAVkqRBYdo+fg4JuPI7liBMZXnk/F+nFtkGk34hsYT+1TCTKxloZ?= =?us-ascii?Q?XeFjalfkzITTtTIA+1jORhepcaAZoRBmeWQglq3yaylwYlsPHygbXz0q8fBf?= =?us-ascii?Q?Bl5aXxqjxncKR/xxlciCbC2ogKPhvdCtVFg06uuTHCvn+/wnISqrsS0OuV7+?= =?us-ascii?Q?J3iNDhrKmH/whTGwd+Ifw+OfXpfD3SqJmk9mqvX+pNm0Zoh+keLDcKC612cZ?= =?us-ascii?Q?27xCKIZT4YJO2StnxOrXKQKKSdbW/+xMKmdCtdwQAoRum4loKqsTeWBzX+J0?= =?us-ascii?Q?hnfJ5Bv+4b8g3r8qN3k5cMj6f68FMUQN8gy2DuU6g/mhem2PyOKn+AiY2BLx?= =?us-ascii?Q?Kr4ibhuFTE6ouw1xQpKE7ZrNGvcrHpMnYT1zUUb/2OVj5QKdSmYwF6poZPp+?= =?us-ascii?Q?zvqxyEw5FmLzYQXlYG+ZVFmgooR9RT677LeRjRogfWrPSKbpjWoprJeK35A2?= =?us-ascii?Q?lIMi4xb2ZaKsKfI2c8BicUxU5aIh7BkZvcWxdrAXkydYDFnbkLh/RwlJ288k?= =?us-ascii?Q?eghUgF5sYTL8VlbRvVE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 200167b2-bedb-480c-b5b9-08daf9658928 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 15:06:11.4190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RKDvt+Pmvl7IQVhyP7ovAoNdRywXwoJxylv3Blr2W3hX6og7ZMPXe8tWF4y8AiWw2kNtBdUce5DNG7WQdvP1tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4873 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gerd, In another mail with title "MdePkg: Remove Itanium leftover data structure"= , we are discussing the HOB EFI_SEC_PLATFORM_INFORMATION_RECORD2 that helps share the BIST information with CpuDxe driver. That HOB is of format: ( ) +. Very similar to the format of SMM_BASE_HOB_DATA: + So, if we use a pattern here to remove the 8K CPU limitation, the same patt= ern will be used by EFI_SEC_PLATFORM_INFORMATION_RECORD2 as well. How about a new format as below? + Mike and Vincent for comments since the = same pattern may be used for EFI_SEC_PLATFORM_INFORMATION_RECORD3. #pragma pack(1) typedef struct { UINT32 CpuIndex; UINT32 NumberOfCpus; // align to EFI_SEC_PLATFORM_INFORMATION_RECORD2= .NumberOfCpus UINT64 SmBase[]; } SMM_BASE_HOB_DATA; #pragma pack() For system with less than 8K CPUs, one HOB is produced. CpuIndex is set to = 0 indicating the HOB describes the CPU from 0 to NumberOfCpus-1. The HOB list may contains multiple such HOB instances each describing the i= nformation for CPU from CpuIndex to CpuIndex + NumberOfCpus - 1. The instance order in the HOB list is random so consumer cannot assume the = CpuIndex of first instance is 0. Thanks, Ray > -----Original Message----- > From: Gerd Hoffmann > Sent: Wednesday, January 18, 2023 7:19 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB > Data >=20 > Hi, >=20 > > +#pragma pack(1) > > +typedef struct { > > + /// > > + /// Describes the Number of all max supported processors. > > + /// > > + UINT64 NumberOfProcessors; > > + /// > > + /// Pointer to SmBase address for each Processors. > > + /// > > + UINT64 SmBase[]; > > +} SMM_BASE_HOB_DATA; > > +#pragma pack() >=20 > HOBs are limited to 64k in size. So this can by design support at most > 8191 processors. Adding such a interface to edk2 doesn't look like a > good idea to me. It probably is not that far off that we'll hit that > limit given that high-end systems with 1024+ processors exist today. >=20 > take care, > Gerd