From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.5895.1675410205578745895 for ; Thu, 02 Feb 2023 23:43:25 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KTTVTQJF; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675410205; x=1706946205; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5zuBoJDO4IC9EjkxrF0+a3HMm1YLErfvrAyxS1QkOS0=; b=KTTVTQJF6fpzvFYd+7t8QkpfMhqOsinQCZjAoaram6aiMnoixi7Wmjn0 e/LNdQ7a4GqfJTCiJ3Ev5QNhLSnmOYS3b41pd1aWj07N3uHCyX9FUlKUK gnWFAY+JA2GI6ee44ZYz6isYDGFlkDOaprMFKMDRyA6BRlkq1zESF2S4b AvyMPB4THTVsDyZKSXazK17X6jDwAsVx7Xk5usrzM1lruFeagUyNbUunc sq3i3LGISep3PuqKHeAAavxoJdFUg7HbhUyTHRSU2Ud/diIJvMGE+zF6L JHDPpVgHOJK/iNQUZ2x/vECXumQfleV50ar7RfF0/iSU5p1X1wcmo574C w==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="308324305" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="308324305" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 23:43:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="734237304" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="734237304" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 02 Feb 2023 23:43:23 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 2 Feb 2023 23:43:22 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 2 Feb 2023 23:43:22 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 2 Feb 2023 23:43:22 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Feb 2023 23:43:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EqaBrqWL17328HzzALIymdRwS8RHfFRBpHE+1qwRFU1A4HjUUtgNkVEgM/+tzoROvMw1wIV4lO7R+0t00dKvri5oh9ieDM/2Yz/j6g0yEH66PGch1IXe8hZfXQ/jOibiOsihhg3nrn36lCR/tXrKQm1BT+pR2jjgfYf2hMmV7l7W5LiWo1DVus/wHJFt7SdcQ7R45yZJ2t5bWfIAesgrUiOk8dIFWY9sYHgerG5uy3YrU22XmLFaE0klej1wGK0e3GIAd3iqk52dnsX14dTKteWU45NLJTkohvPan6749g71qoe7db3FfO1XlXc1y+XKtve/gl/6OhgyitLhWSGCIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nQvn24ACOw/4MPr8xURmlouudwK47AlsF3MBpscTxwM=; b=J950o3/oXQD8FiXsxP1Tvo9B/wJ8lKtNN0bTA7haM31OFt/TwzMh/M9JYW0jHdIxrUYmRmGVpjbQBZOnGrg//W12oDxGkIuaQ/9jZmA8F/JBUzvPRZc+Z2eDrB07shMNzxOmvpdKr1Sqp4fCJRs/Op5gQg8OV4t1cbSsyLAj1cT2oBWY9voACFk9K7GMztkVra63QfZ55itouTCtTtg1+ickp1rvhu+lBO11kUFuGVWIDZoqY2lI8XMj5ywjNfa5yHsI9JnxdENESKIH7UVyxNmqGXjfQe5LRl5CRHkWbiBsBEvrdIMU02VaX43Z8mPU6J9KKeqGb94BxUfG29poMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ2PR11MB7453.namprd11.prod.outlook.com (2603:10b6:a03:4cc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Fri, 3 Feb 2023 07:43:19 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%3]) with mapi id 15.20.6064.027; Fri, 3 Feb 2023 07:43:19 +0000 From: "Ni, Ray" To: Gerd Hoffmann CC: Laszlo Ersek , "Wu, Jiaxin" , "devel@edk2.groups.io" , "Dong, Eric" , "Zeng, Star" , "Kumar, Rahul R" Subject: Re: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Thread-Topic: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Thread-Index: AQHZNqeAxFUa6iu5OEe/oLGopZyeS667XCqAgAAuugCAAQRMcIAARqIAgAABFTA= Date: Fri, 3 Feb 2023 07:43:18 +0000 Message-ID: References: <20230118095620.9860-6-jiaxin.wu@intel.com> <20230118121958.cxbfh3fljedvebis@sirius.home.kraxel.org> <20230119075303.nkyno36h25xscwkn@sirius.home.kraxel.org> <20230201134051.7jlc7a74cogcskw5@sirius.home.kraxel.org> <20230202090003.5vmmeyhsv4zn7wn4@sirius.home.kraxel.org> <00b01cd3-7ed2-b0f1-e2ef-1d48930a0083@redhat.com> <20230203073144.pdrwf7logbgbow3c@sirius.home.kraxel.org> In-Reply-To: <20230203073144.pdrwf7logbgbow3c@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ2PR11MB7453:EE_ x-ms-office365-filtering-correlation-id: f770bb21-719c-40ff-0969-08db05ba514c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4uBCdT5B3D5+GcsPlqPnSoMFVnyf9FLsEdIVLLo2KsAu5kVMWh9mY0xfEiBuCLhXNXMIEdZOEJSUfD7joDIjPV+PLN10OPEN4coilaYEKXOSOKOnYioLMAn0NA+X4+MbzdapDr3ypAkB/mCUwZy7Ug76f0JivhkJYL1ddmezIIiNLqgUsH2tKWjNwPXE9wPSUVzKxOxI8nBpWwaislUW7mQan1TehF49jDrWzrJgQyVpG+LuYgHnLGyYcHhOBy7Uc8ZcEwU35AuwE8CioEaQvC/I1uCTAYl9F71cgKWhnN1XGGJAd/DlnbmNafDi+OytT35R+hUVsJwJwwOAzK5JFgEEbOdzGy1ca7/shiZd8bNI+Pb2MwjKZIg/RthQejrKKGzZtf4vMQKe8j07WsadSvNIeInob8Tcd4MIpk+ItzptqA4owNvTvULKBEju55uo+PfyyFZ1MN5Tw6QL6NMwMes9bBNBLFt3cNJe/aANK58IW8YsHp9bH2sta7Vr9pO0hmABa79eOC0wTkJzv02TgLyMZbuioujsU+ZFJVv9jB3VsuEgenK7UjRustAoOgOZWuAmYatkK053DCXTMX/cS8VUS5VZwZjjBoFvmAO0CgT3uU3zBdsJ+6gyb21DoGZUREKF9MGwjKirWu/f7T8ZMcDfSi02dCb9DQ93tVyVY0xIvmcaVKv3Lhmvlhen8X0+ktoBlhPTrK8rc2M7c6cwNg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(136003)(346002)(39860400002)(396003)(451199018)(52536014)(6916009)(2906002)(5660300002)(86362001)(41300700001)(71200400001)(83380400001)(8676002)(316002)(38070700005)(122000001)(55016003)(38100700002)(54906003)(82960400001)(4326008)(8936002)(66556008)(478600001)(64756008)(66446008)(186003)(66476007)(26005)(66946007)(107886003)(33656002)(9686003)(6506007)(7696005)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cHEhSXzjXE/ccRoUTjLg/SKS7Wa2LGUiTD9HEz5/TGXb9g/y558jUNupaFl4?= =?us-ascii?Q?ydu2eB0UCImfkl5ul6H9/I8ZUMWEvI56WeFoumb4kaj5d8Xu69wjunvDawbn?= =?us-ascii?Q?9FAfPQKSV1+V8hBVWUp2tkfpWkG6Fl+BzY9rv9MZ9W4hdhZkSube6bNvbppf?= =?us-ascii?Q?ATY68pblL8m6Dj4jvxH+nOtPwV9X1PJa4y7kJsen6PgskWkbTw+pCMOXEFvH?= =?us-ascii?Q?3PnYyDWUAd19S1BWx/okWArT1+rqegpsO3PhiO60DxOXYeFRhOQKyC+Mm0Yw?= =?us-ascii?Q?Xp0ACenbFgE9qyRhJuhr5WjRdCXnNeaNvlU4JOp8FN3al1ZDr6SfNj/sbjUr?= =?us-ascii?Q?qJ6sUYjruh3CwU2zqbC3YVEBfePAC08J3KvIZn5waL1i+OAfgi79tycEYvs3?= =?us-ascii?Q?EdyDSNOa4O8QblNVU4I27uuDuE7EZg6EepQeQsEeInhzI5rlufeBXn6abEy1?= =?us-ascii?Q?sAhLvoPniCzgxBh4YDbSTTE9G7X3o4/oSp8KvBFIWp1EWTuLCiubjmvLUuoF?= =?us-ascii?Q?RYC33hBaVZXUUtHBrp/BOXZftc5QVhlwaTTkIigKNI8r/JPZNy/Va8WL6d55?= =?us-ascii?Q?7OomhfaTLP8TFtc+VjZV1JH+FmOQPHKVtCaRQFRKKuyECKAjBkcu9yGkmx89?= =?us-ascii?Q?GTuyIFweOqit2MeCBaotcdBacTLVbyO24IPEaNfATNdlTBh6V6+sLKhNkiaG?= =?us-ascii?Q?mgctilEqfKt15HDHoFNzFO28yLoZGIaHUC4hBxYfi+kaD11kFjUGGk7PW2A3?= =?us-ascii?Q?Ys0jUj5dfpMo4zA7zqrQop7KetaYw7vRfZUlGekx9RXVr+qzAO+Nj193ovnl?= =?us-ascii?Q?sCwBhpdZPWwgjRarcSy3m+1nlEQeQg3wVFQaFIy5wAKyLydyqPKakm90ct0m?= =?us-ascii?Q?ezZqYm0avm3mb6jZwoNeNHsXRewfkf1Dfl3cXmogu66YE5oI9OGw6z295DJZ?= =?us-ascii?Q?s9N1Es2OnWU/feavMhPHoBgr0utfjvc9ytz9wTJHn4YR5bjX61/Oi8U8Dp+L?= =?us-ascii?Q?T01hEdU9lRwaIlVs57nU5zWntVE82tUiywmoaDFHv99kDQXZj7IQG1ap2KSf?= =?us-ascii?Q?EdisaQktCdJIUNXuRbL7MZ6ZWuqeeonvZ0CyJb68cImkozEwZM+2WFZAMOOT?= =?us-ascii?Q?gQULN+LB25M2EWCOBvuU92PbQsPxz1RiXFnzGn9YYCGZY2W0C6R1lMvw6mRC?= =?us-ascii?Q?5b2/cZpIQlrIbMOo6jvx1OGdXJGdGzFSGUgMUDOsbu38Xu7iuuXD247hLEEz?= =?us-ascii?Q?yXkmyT7v+HmEKVs9z5PcMFRlEDKZRJoZm08+9wqbt7ODmMnYVUV11eH1d6dJ?= =?us-ascii?Q?ouVCl/g3gdAAqd6eIgW2u3qboJ8+e9Xqb/h0QcrhiLpE5K9fOCoO3R0o+0Kg?= =?us-ascii?Q?XrOUH+57vrn/NH2BLM375ODO46XwMoWdu6/lmhgc4qUiP18ASaOK+aXVvbv2?= =?us-ascii?Q?74iyBwUwQty32MCX9EmDMndM0qlJioayryLEh9laIfwX6BySy41smT5IFRPN?= =?us-ascii?Q?CvrkCblHjlFj6uV54SCm/wfncCXEAFgIqxQvbEPDcMRFJ836DUlAiKwINp7r?= =?us-ascii?Q?cn8jQe3dudgwTQZ4nhk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f770bb21-719c-40ff-0969-08db05ba514c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2023 07:43:18.8738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pqW0tv2Gkk9DLXTx0VuIKioYqS6mai+xkgDpMDF2CwqNd3ZtN5GVlRUx0curZkNJt2Rq9071+R9mI+PrSwaoqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7453 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > > > > It's doable to program the hardware interface using DXE MP service > protocol in > > CpuSmm driver's entry point. > > But, considering the standalone MM environment where the CpuMm > driver runs > > in a isolated environment and it cannot invoke any DXE or PEI MP servic= e, > you could > > understand that why we choose to put the hardware interface > programming in a separate > > PEI module. This is the major reason. >=20 > Ok, *that* finally makes sense to me. Can you please add a source code > comment explaining this to the patch series? Patch #1 (which adds the > interface) is the best place I think. Sure. Jiaxin, please. >=20 > > I admit that a minor benefit of this design is we can isolate the > > private hardware interface programming in a close-source module. > > Otherwise, the SmmCpuFeaturesLib might need to expose a new API for > > the hardware interface programming. >=20 > "benefit" and "closed-source" in one sentence while discussion patches > for an open source project. >=20 > And you are wondering (see parallel mail by Jiaxin) why outsiders get > the impression you are trying to hide information. >=20 > No further questions. Gerd, the benefit is to have a better modular design (separate PEIM instead= of extending existing SmmCpuFeaturesLib), NOT "close-source" module. I don't have the power to argue with you why not open source the PEIM. Sorr= y:( I like open source world and the open-discussions here. It's the open-discu= ssions that help to produce better design/code. Please don't imagine that "I" want to hide something. If I cannot tell you = something, that's because the information cannot be public for now required by the company policy. Maybe people like you working on all open-source code cannot understand the difficulty of mixing open source and close source cod= e. >=20 > > Though this new HOB is not in PI spec, you remind me that we might > > need to add more fields to the HOB so a way to distinguish between > > different versions of the HOB should be considered. The way could be > > to introduce a new GUID for new version of HOB, or add a field > > (version?) in the HOB. I prefer the second. >=20 > Established practice is to use a new GUID. We should stick to that. No concern from my side to have a new GUID once the HOB format changes.