From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.7368.1672900148520868797 for ; Wed, 04 Jan 2023 22:29:08 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Xi1y2eE5; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672900148; x=1704436148; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+hogcK+wS8zEOTd1aF7XRAFa5o2Hs+S6osIOaC+0mdQ=; b=Xi1y2eE5lp4RTtSrQ7u9VUgGgiWieN0BkDjYt3IlVNiwCbJbV7nlVJog 2T8+M6uLNGtq8fnHkUP4gyHokxkebeu5/DNqmXoIlK55Ym+uU5GRCtQX9 nL9RG4o8gG+q6wEGTpyOAXrFWLlYHdxV8qZmmNomiPivAaaxqwHNMIjGV c424TUstllV40wMlgxDWuMDpPpmrYzBNBX+P7bSer0gWrOWzb/prqNXMc pIRU07LslFIJztcvX8PFl+Qq5UkZCbM+OaKGOlzUXsscLM4OfL8WGunMb Qa/lN67Eig9pZMVxNnTkYXiiATMchyWqdUV+YrzxWgBOzMHv58PoUDm9P Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="319833703" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="319833703" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 22:29:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="687782800" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="687782800" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 04 Jan 2023 22:29:07 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 22:29:07 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 22:29:06 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 4 Jan 2023 22:29:06 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 4 Jan 2023 22:29:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BqcdaQNmRbSkciPM5+A3v18iu3LGo8ceWV1FTdlh/bry+sAX1fS/UrJ+sRUHSDtejZ+6tyQ45ZdpMnFpzmzGXEtQKcFrH0amZAeLDiyWdkKX3rxuRv1f272leqeQyu04jICNH3UCw4S9+/5VSmYHj89/yEWWuTRUDCqc81vwa7kNUgTzCqPRDj4qV5qRvEqqnjac/VYWabAYImYjkeQpuhGufUY87Y5xiOxNVgh7n7Bn6teCOoq4y0Kdq/+8Bvo0+Q+ak0y4SevWOMy/g6596FN0nQOOMQ9/FfRqfamwcmO8tTbbKTYNqYnXuKAZazE4JHGZ5QFkeiZBkipXpkUuow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+hogcK+wS8zEOTd1aF7XRAFa5o2Hs+S6osIOaC+0mdQ=; b=kp0m9caM94QuYTftIXSMz5OmPO4B/vV+AkDYmktyAjyw8RKhbweuid4+Wp7g7sdby23YetDzbA61dUN6bK7Z8LSCzX4cFh2eEYEF/3tgoz10/vTnP8It9cSaySdbGD+btufmbChO6v6QYtA2CAOemjw3YVrNtvPdObqLqFHUY/WwoF1P9Y+wGCJtQ3NaloEUbzQtNT5gyLA+pE3aukzLpfxQ70lsX8c4/gVL2vKXpgvyCmpODJmVl0aW4kPpAiy8biXHN7GN2O4nEALeABqx//G3ndLp3F+ecIcwnvgfB5F1eGqCoEgnTDDFM0lAbd/Lfmty7LFq3rijNQEnc6QkhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BL3PR11MB6409.namprd11.prod.outlook.com (2603:10b6:208:3b8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 06:28:59 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%4]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 06:28:59 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Xie, Yuanhao" CC: Laszlo Ersek , Gerd Hoffmann , "Ard Biesheuvel" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB Thread-Index: AQHZIM3y7zRguZhih0CPAG/4hrEpf66PW2FQ Date: Thu, 5 Jan 2023 06:28:59 +0000 Message-ID: References: <20230105062108.1796-1-yuanhao.xie@intel.com> In-Reply-To: <20230105062108.1796-1-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BL3PR11MB6409:EE_ x-ms-office365-filtering-correlation-id: 90e5cf11-2af8-453f-836d-08daeee62163 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5lJsNBY5/7U5LX466r9q7kryudHe3B3oMj+74TkIHnGaRBQZYkjHksuRPoQlD905AJO1JiEj8Y9b6BuxDrZyPyM4mKmPYbqeY5zyTYnGvKh1vLKjxb7qc+g8AfrOPm2sBc7GScDIe2ngcgoBNE1NngH8Bp3co+0aCEqPQ72kpC3e0+aGpC19Ik/SoDC3K4L6L/F+vKr0K+teOVtCfK2XkGUyMynJs4ONlGECgO3FKRoSAgeK5gKjlxHr5WRz0AJ02FczRM1gAjocWa27PZIG4OwDCS8Axccez/HyqRBVA7LJinm7GAV5J68JB2nrcm1ffikeDQb0Y9/4FxBgXIXWaERjT2rqvdxTFUrm4UxvoHPRD/mqFHU8PCEIP9v1Yld2kq67adqIxbuiiGZ0gNh1807X4xgMFRtCI8DX6PL4rTjOQk57+yQOFSOPTVBeQmPiOuispmSMQPIaTPjnnbu4KBvJxSrh5+Jz0neTQKCNwxxEgB71LybKUQlt5hKtEs0Iu/UqbGw2PYAw6SxlIfaOdMo2DZFXRZCRN9dTdazeF/AdeuZEs7sz0WlKwgcOm9eZX+phvmn0X3sGYGk266Fv28dBJ5N/zxAZWnS5W4erv9LZpKziv5Tb/TpyVbldumaC0+ngm6uf9a8j0k8yC9NsKYaSZiBI13aUu85OuQaHMo5T8J1sA2iICvDSVXQU+1f77exSPGnUPP7aMjKQaQBVCw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(376002)(346002)(396003)(366004)(39860400002)(136003)(451199015)(86362001)(8676002)(54906003)(64756008)(66476007)(66446008)(4326008)(76116006)(66946007)(110136005)(66556008)(41300700001)(82960400001)(38100700002)(122000001)(6636002)(38070700005)(33656002)(71200400001)(7696005)(26005)(478600001)(6506007)(186003)(55016003)(52536014)(8936002)(2906002)(316002)(9686003)(83380400001)(5660300002)(4744005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8AbnKHk/o8+C2fOtBEiNb6kitCJ5sb+uQBhT0OSkgke+uw9WFXZM3fwdrFTO?= =?us-ascii?Q?uo7r3Ew3iOqEKj230gAMNxoWxKaZ/+fRbSdyqZcs8kaOe6KtlGEeKSTpM+Sk?= =?us-ascii?Q?+JisEijrs+BPdk/0NiWZiaoq+46bn/JSjCbmiDGRMBbkkY6pSnf3jS7nrTtG?= =?us-ascii?Q?zIXw5LaVz1NNJTMosaF3PasGpgUBkJVkMGAsm9PmfGbxRBlUEeRwteG6Mri8?= =?us-ascii?Q?DWiHBfysL9aPX4prz4LJiot/InvvO46CW7lD+7yQ8zhoEQv5aZWQE1s++EZR?= =?us-ascii?Q?Tubmm4Wcl2KFyuv1fvaUP7C+vQKS6ShKKqSRTBAa9T7K20Rxbo/Gq3+DoEOl?= =?us-ascii?Q?dz5kiVlWBkupFNlu8QiNI67/u9pELC9OHYaVkHS8RDISVOTGUBlfwXdRChq7?= =?us-ascii?Q?nJQSlD9sFvuEw6wLrS8d6K5bBt1nl0TdCD+yYs1bVf1iVS4YNCt6rLjgipQB?= =?us-ascii?Q?9dZ0cPNDRT9mC96Yh9/ManEHv34+a/dCzv9rJs3BaSQlOi+8TfyWRBXiPPoS?= =?us-ascii?Q?zdM/5MrD+bY8uteOLqBydWlBlhZ/Qqewhzf16uZgt95kLVUy/hLT0SvaPygD?= =?us-ascii?Q?p59jH7NJD5N92b/1noFPU7yoMkvX5xtbwpfvz7Y2noU3wY2RRaWYUUhKFSan?= =?us-ascii?Q?aulEWPsx16F00YrDMXl/6PV7VXjHyhld0Btu+uzj5YtE29zE0eXMvke7AkeQ?= =?us-ascii?Q?xliOXr9Pyv0fx54LrHTkafJx7QHmFR3xqBa1ZjrQLZcdXGRz0TXIV5GLvjHi?= =?us-ascii?Q?UvZG73SuHn1RZlmusVS7ZY4Qs8NPqiTiH1go+Ekl9GrbLLJbAqrOBUbRQE2h?= =?us-ascii?Q?rzloR3/xO4GSZ+SbOxqmV8CZ3smSrlJsAWF17AWxxb98xplRhpfaz05sM0xt?= =?us-ascii?Q?ljklGFsINYG40gw2FzXlvyZk/e8CPf7J8+o9kXrOwR0NqdvG5WrksGQWeB8f?= =?us-ascii?Q?yRO+ykh11dIuODrX/eh32u2GCQg3eik3M8SKDx6Rt4ctdb44VP7hGSBgAz59?= =?us-ascii?Q?DU06GNPbWEWJZZ1smyQP6iI8TQpGDIrSgmP/2iSViFXTu2EJPbeaOubKZzt7?= =?us-ascii?Q?aGBsXEu1sM+yYgIsBzMPQKJui9hIQ0LaCZBwhEbmDf1hgZ4dge4uqkytCKVY?= =?us-ascii?Q?9bErlnilkwMocSDFn1wWt7++NxCgZlKs7FE4AxgOqk4v5IJjKt5rfsCLbfn6?= =?us-ascii?Q?gGczXUdq4ovMP0Rtfywoxh+XiidzuaJNPOvo1XYCubTaCBvhCZtZiL5SG6HP?= =?us-ascii?Q?FyPmGY6BGZCVTusZYbdaS8GjLcL+vF0FHM/XMBxpCoL/ttVRCQekkwyiwHYE?= =?us-ascii?Q?a3FKeYr57B5CuS5eN/4TKChAPjO3IU/MwofpNtv4hG+jcnJgOqLKk/KDdCXW?= =?us-ascii?Q?Zy95NBqjv8mAJbtDkLy96abXN80w1PTqFnnnFIJcexsRtVbqFzQ2n8mcU6jU?= =?us-ascii?Q?5PlU1pssTrMMW4o3qdwjiqrU2LIOy467ShdZOCM/1kVWIumj/TFBcJBssk3m?= =?us-ascii?Q?XbUl7XYd1t9R/ZpzH4zQ9jU9sVHp5eRM/znWHzF2M+tgUzJxQiERi9FgMN9O?= =?us-ascii?Q?Md9p8fLaKVnRdPE6prc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90e5cf11-2af8-453f-836d-08daeee62163 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 06:28:59.6248 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6gshVrCv9uSerwg6KC05z59yFiW9LVPByUvOSw+pRljQEBN/McdHX27ZsKRvkJcOPCtQUYjEsZP+d8diKAxjSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6409 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > Fixed AsmRelocateApLoopStart stack offset in Ia32. The above commit message is not quite clear. How about "Fix 32bit version AsmRelocateApLoopStart to retrieve the paramet= ers from correct stack offset"? I also recommend that you split to 2 patches because the code change here f= ixes two bugs. Have you confirmed that the 32bit Linux boot hangs without the changes and = succeeds with the changes? Thanks, Ray