From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B2664AC0999 for ; Tue, 26 Dec 2023 02:18:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NmPvMKJviSF7APlNoo2UiDxbStUZIwy99x/k9SRFN0g=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703557101; v=1; b=ECnhELPTEl7pRRXjXPVjNbmZzcjqVL9gRDG06TWxBwJAVT8twCv0tY9It7QnI0drwnabPBbX hzTU6kiz45EMXAd3Omoj4V9MzaEuNLFu+AD+xdgV5PwHaQQzSyV9Er08p4eFbCuUrLy7JfWJdM0 kWnU8LOuuxmVQgw9moTOQLJg= X-Received: by 127.0.0.2 with SMTP id b6CEYY7687511xzwY5wI4Ith; Mon, 25 Dec 2023 18:18:21 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web11.73494.1703557100636114249 for ; Mon, 25 Dec 2023 18:18:20 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="3607038" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="3607038" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 18:18:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="921450358" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="921450358" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Dec 2023 18:18:19 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Dec 2023 18:18:19 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 25 Dec 2023 18:18:19 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 25 Dec 2023 18:18:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TA9VUkX2BIq41xsHusTzbdYtWEvbdtwPYY2p/NKIIMrA49EW2fuj71+9TiC1ui1dAVUu87X1s2H7zRRWVj4ARxrXGozMa/OxX/imeVnoEY/5REuutgk2MLA8Q3DHeo8tJdzDy68AIC7TSWbA4V1U9x0i6iF8wTXmgTgNhHObCK/Qw1vJxjID000R0FlOawP9JvBKfVKD9vIwKKZAPQLYArbnnShZTBub5MRKPOD564EllKC9D5sjEK4G9sSgvxvLdMANY+XPkkdQT+LVpHuRvFZQjMWKto5WbeXqMCq5A3cLFFH7MW1zI3V3ACTS70UhVlXFpwAQM1tVgtzp29HVQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BKRcz1T3/yw7JgRL5yu7q59nUfbtdCpCUHtnlzzma4k=; b=JelwmN+eJ6/CoN7l9QpJU9GFCJJwJm1MM2voOw3Q1fMRX1dEPQhQJdvR/qXVXQB0gurtYYyNdXd1DYJ6oghb7SoFxWOv7HEVPP1ysVoLwaAe9pff1D0FeSv0xjnQIDGNQxx7Anj6xbPNZoDYnFqSdBHh3K2sP1mm3m4Z4fj69T2VctdGkba3brpKrXOEEipsD0Iew21pht5PwcJK7D9QmMnmc7QWDCFLA3Hh6iBBoClrsSjAJ9iZgTFeRUiZDlFED1hzPPFQXpoR7n8kEySrOAAJAuDbXrHxHwFIsY29OgTqTkiYHqVFKEeXXY1s49bOSsDrRMJva1W600QptvIMbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB7804.namprd11.prod.outlook.com (2603:10b6:8:f3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 02:18:15 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7113.026; Tue, 26 Dec 2023 02:18:15 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v2 2/6] MdeModulePkg/DebugAgentLibNull: Indicate SMM Debug Agent support or not Thread-Topic: [PATCH v2 2/6] MdeModulePkg/DebugAgentLibNull: Indicate SMM Debug Agent support or not Thread-Index: AQHaN05STQFAiqgCRkGoMzqtsxReNLC61Lew Date: Tue, 26 Dec 2023 02:18:15 +0000 Message-ID: References: <20231225162034.2052-1-jiaxin.wu@intel.com> <20231225162034.2052-3-jiaxin.wu@intel.com> In-Reply-To: <20231225162034.2052-3-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB7804:EE_ x-ms-office365-filtering-correlation-id: d2a9b0ad-746d-433e-38b3-08dc05b8eaf0 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 3KZH+Zr7DJYKxMmpXruO3MQcQuHA7KXbcV4VpwKZQoP3T7DZzHbqmfGkQZ1tK7IXexSmI7691IRs77pLcUqPc8vOIY47ZCmP0D13CZWbeK5Apmzxv9K+bu8d+9pbJjYcu5YHhC6rI9b5Nm8d05okgEYtkfa3sLBgT87Z73/p21fo6GKYf+dOIL2wpKb0sB4vTNdI2eK+lcGZr8maBtmKNFt1JnFB2r3DKLtWlRIkx4C0Z2hkbJP6tIBBauuiWj0q7PNExOrBRVEy64zbCMQzSG/kL3ydpkNrWe6vSpq8FKKH46fywU6ZcGG2OXoFB4TY5zw6udM+5uSo5o1N8rmkCgLF5lR7ymqnTLNpdAcs5lgA4ONXZDsLQpSLV7WhDWunn26zumWg3qOJyLRiWUxtPDk4Cn0tlyx+VamM1oJPrZ+Y3tORtzjXuvczVD07tGHEHHXMUMjdIpyl7gcq0vUFEu6B4LAugyKTSNKsGhmzeWg8cJGGTZYoCsAP3lQaVbwmm6gezPKllAmprFa6giz76n5WQLipbJfROiBsGrB4ORKWzehWZClq9X7JhX5zh7BWmrDoHGmrdjcX8iXJ3DV2x5tywFXcGdFjPx6Fsv6kr9gPFjKwx7AlTw61vjvwqWPp x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1k5y51NiJ7ioNh+JRS5X+Bp+dSYy9ysEQFzpNJBeDtszwMRiDvrykg1Kg6Tb?= =?us-ascii?Q?00RnzsUse6TqEZzoAZQ9f9Ip6j/04c86P+AM/P8feRoREiGfizu3XS9k30tK?= =?us-ascii?Q?oQSmpn29AhekyqwcKNLBz7KKrZlpOQ3+Y8sFql3nNh2IWony7UI8J/5p6piA?= =?us-ascii?Q?GtaCbUU1nRWKOoVsSLkWCEErXwCZvAsGjR7WzmqKNxJB0ZYLF1qWM6gfR2jv?= =?us-ascii?Q?skQMb8tGQzD9t+xevrv551WbE4EZjL/c5W0LWfgz8hBnDSMFQbGCUVFFKkQn?= =?us-ascii?Q?B2rk6Xc5VmvQ6d26lhJMIOQfLe9au6zVPLWL6US83ZrREDOqcL3d8RqXNGWE?= =?us-ascii?Q?yPTG5LPWjADdO46zHjJZxp7ZRO/Roqsn3yG6wEH1+DPEvtE2biefG9pgWSYB?= =?us-ascii?Q?eoOlrHm/zzyI3ZOI/7M5oIc2y/pF7fLba6YnODdsBjYJalSayB+l0k8CusOA?= =?us-ascii?Q?WZUu+3O5gV5psTfSlkTwegjnl6liMFbaNYNDOoJQIZD3brNIS2Zulf1uMWZM?= =?us-ascii?Q?EWq03ecTT8tuor0ViJMe0N8AGVvAm+8JUYyCmfcgcoWrS4Z9bWUAhzoR8Tr5?= =?us-ascii?Q?AI2nbN4BRVHO4G/l2UmMFUfJjAdlX1wigRQhNl616BDYYjNCMqDF33j93ndz?= =?us-ascii?Q?2YzDE8SwPk2lSbDxg4U9Yca2qPe6wVXijUdvAKN4fJTDtBUzauIBKBxH+HDX?= =?us-ascii?Q?QUBRdBe9Ij8jDxqzkS3oOadCaX26uEISwOHwIoOGZk99yNiGGZ7lctp6z7tR?= =?us-ascii?Q?qEoPoWrV27+25p/E6xdMc+BRvWSe7QrVMjMnaE7bA5UQqayCKOIvFm3U230L?= =?us-ascii?Q?+/fnKbbBc5w7YbXZFf/YgLGwXJk8IFBXifceoIl2ALYhYW9gDzTmkpvyrk2P?= =?us-ascii?Q?9d0zmDj6IZLdN+h4Qbk1v+JYR5fCGnFawLkzBOBWoTBUaMNaucM4GxQs+RYd?= =?us-ascii?Q?ZVdUXt1sv7yhW4Eur/RDHruc5/556+pHCKSRCe+pILJkpAhj4E7eSl3Mn95f?= =?us-ascii?Q?TNpiWCDH0nYJ5+4CcQCmm1zKOb0Lk2gUpjI97gZgT02E4/nf8/G126Eu55H6?= =?us-ascii?Q?a/z9lHKPEmJ9CGiATHX7d+7REHPBDFGSk+ifPztZtTPEAEwp+NK6liebT6R4?= =?us-ascii?Q?uTWeunWfpfbXxzYlnayNkxwGLSWW/1mN/jPW1CXdDdurVtfo4hyilAAqkFvg?= =?us-ascii?Q?mv9klZt8UD/2J0lMUeOL7g1KxdY8dJNcJd6kpuGrJOgDmeaaOKayRjEh2L2A?= =?us-ascii?Q?3TgD5Az5G2zcCLN3WJz0uhveuH0zJMvtAebUAg1RJ1JyrbBo+xMILy4qOo4Q?= =?us-ascii?Q?PTZmbEw3hBy6mJGRPyfUK7XeOVGB07Fi90Q7XzWy3T/iBCNueIOtaQ3q+MWY?= =?us-ascii?Q?pgtSRWF0vb8i31tjPFg/V2ltUZ1D2yA4vQBAsBeenmOhnzJ0vnnwIFCU/88o?= =?us-ascii?Q?DwaZ1i4DsS9/PpDymrfoSr6vTaYrfo/zBkaJWfBuO7UwRvhwlIhndOZxayvA?= =?us-ascii?Q?YCQQpW4j9742Wb7YOX1nSgJK0FrAsG96xWmvPIjvdyh2vsI6ylK91jb6BhG8?= =?us-ascii?Q?BPHZANKCERP0YrVbY7A=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2a9b0ad-746d-433e-38b3-08dc05b8eaf0 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 02:18:15.3462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZHmbjTGQsp24fvHDo2leIuN/NbBRGXMOLjXVJb/mo0CoBaYW5/JRchVCIf3SJ9LKAwxeiNYUi+cxq0YkRT6UDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7804 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qMtLQ2nJNhwNNHmSwEvF8Exxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ECnhELPT; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Similar comments as #1. Context could be NULL. Please add check before the assignment. With that, Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: Wu, Jiaxin > Sent: Tuesday, December 26, 2023 12:21 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Liming > Subject: [PATCH v2 2/6] MdeModulePkg/DebugAgentLibNull: Indicate SMM > Debug Agent support or not >=20 > This patch is to use the Context to indicate SMM Debug Agent support or > not if InitFlag is DEBUG_AGENT_INIT_SMM. Context must point to a > BOOLEAN if it's not NULL. >=20 > Cc: Ray Ni > Cc: Liming Gao > Signed-off-by: Jiaxin Wu > --- > MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c | 9 > +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c > b/MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c > index 8e70705eb6..5596ee3bf9 100644 > --- a/MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c > +++ b/MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c > @@ -22,10 +22,13 @@ > passing in the Context to be its parameter. >=20 > If Function() is NULL, Debug Agent Library instance will return after = setup > debug > environment. >=20 > + If InitFlag is DEBUG_AGENT_INIT_SMM, Context must point to a BOOLEAN > if it's not > + NULL, which indicates SMM Debug Agent supported or not. > + > @param[in] InitFlag Init flag is used to decide the initialize pro= cess. > @param[in] Context Context needed according to InitFlag; it was o= ptional. > @param[in] Function Continue function called by debug agent librar= y; it > was > optional. >=20 > @@ -36,10 +39,16 @@ InitializeDebugAgent ( > IN UINT32 InitFlag, > IN VOID *Context OPTIONAL, > IN DEBUG_AGENT_CONTINUE Function OPTIONAL > ) > { > + switch (InitFlag) { > + case DEBUG_AGENT_INIT_SMM: > + *(BOOLEAN *)Context =3D FALSE; > + return; > + } > + > if (Function !=3D NULL) { > Function (Context); > } > } >=20 > -- > 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112900): https://edk2.groups.io/g/devel/message/112900 Mute This Topic: https://groups.io/mt/103360803/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-