From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E2456740032 for ; Fri, 23 Feb 2024 00:24:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VsNHxlvfdCRPKd/MW4N75W1Lu2W/DzSVRvsKkWx1J5s=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708647880; v=1; b=KR+3Y+jqEF5necKEywVzbEhR1Cekiik/bf136W0hP9Ua2CC12T8GJUXVphwWdfgCP0WFUuQn nH3tl+nN6jwIImtkXX6wLA0jWwhKjL7p4d60gPNCaWMz4SLQgxBIms7Uu57fqVlUFeJOB7aRGRM pj9N2lqhS6jW065hlaWf2dKI= X-Received: by 127.0.0.2 with SMTP id t7ycYY7687511xVaR2QLuPWz; Thu, 22 Feb 2024 16:24:40 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web11.214.1708647879784294175 for ; Thu, 22 Feb 2024 16:24:39 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="2791659" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="2791659" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 16:23:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="43142541" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Feb 2024 16:23:06 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 16:23:05 -0800 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 16:23:05 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 16:23:05 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 16:23:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X48t3NjAAhOKbcVD4ld0bIN/aY7yWtjv4F7b6b7LRcschXIn+8IURnLsu5hcJkp7/KMsJVzjWGKUdua0AtKz4tLxHFlszfxkm1KqQim0QjecEDhilKu27pXaI0VuaDvEnc0aqjggi5+8PTsPZM84texJ1pYszRc5b/DXrfvd5V/2Cxnvcxfyp20bT2gJIEwMK4HkqYIB+PY/Y+/AXUQ9GJHHsIbmFPb67IKFesHZ3JbUXd71Mp4yME13nkljRvhA0Tv36fS3mX/uUsOJUtbioqnGBcpkV68tXgY4COBiHJkDQGXZ8ugL13vjYcHrSKAP5sia094SYI0Pjr40so7hBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RMuEJy7HoPcB/vteiznieZEQgHrFkCeiNsapKKm6ogs=; b=NF2sHr4qZec3/HMHosW/+52uezHox0Z6t6Hx4nWYi5D0vPXArbdvm9yvR2YjUwiroD2DZmQ9XlNXmufSlYGutkbKAkVg6V2GNDRsaU6DULeu+97yfy8WyJ0ekwPOeShvMLF14Lix5FQAojfIlNz63F6xZ/RdeB1uJou4zeNsdA8bTgUHZddu2qlPYM0u4sakdNdffsrg2/0dLNWy1xtio0xCO9fXdLmd2W6B8BV7Rf6XJxUPUcfTMbBg+076jrsg4MS5WpJh+FCZUNmuM93sUGud5nNTJuKSqzX/KPNmT2OCBrUzIny96+9xbHJ0xDOS3kDvHSz4vWYYcd0OZ1N9Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH3PR11MB8494.namprd11.prod.outlook.com (2603:10b6:610:1ae::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.40; Fri, 23 Feb 2024 00:23:03 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8985:d1bc:9df6:61cf]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8985:d1bc:9df6:61cf%7]) with mapi id 15.20.7339.009; Fri, 23 Feb 2024 00:23:03 +0000 From: "Ni, Ray" To: Gerd Hoffmann , Laszlo Ersek CC: "devel@edk2.groups.io" , Oliver Steffen , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize Thread-Topic: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize Thread-Index: AQHaZCU5su0EHEqO7UyKenYPSCAwfLEVj/eAgAC9C4CAAMc4gA== Date: Fri, 23 Feb 2024 00:23:03 +0000 Message-ID: References: <20240220174939.1288689-1-kraxel@redhat.com> <20240220174939.1288689-5-kraxel@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH3PR11MB8494:EE_ x-ms-office365-filtering-correlation-id: d5c34c7e-3d75-43ba-8e1d-08dc34059960 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: nzX/xL9sKt18zq8Rxd6X5JaIHhIBOtg6KFWkk8XW8z92qU7izIVsXvI+VN1WXnFTRc8qo2aGp+Nq00pfzzrWdLA5wYqdiinN0y7zi38FR+CxQsBvXdyiXvxfmMaw2M7gka+fnoqVDXwQ3vvu6lUfZUYyJsdLEUiv19JWWaggClHlLgSQ4Er52zcigYCXE7vn1OMONrL4WqAZLPCmrI66hAy/u/L6uEWaFMJ2awJr5JbtgwL4qXIMUcXX9kUlU2XbIF8uavUxQhoINSa1lTU3NNfw1GhDfcRRwkupZNqiKe2VCewxQf/srq5JRS+YUKFe5A3wZAg/avMxKTFa+0Fi7TTv1jcJgQxoUJU0XwjZyOhLr5q0HfFOF8NxKjCV7oglCqUvn8LF+CPtr4PT1+p/7w14bAGJT51PPZ7Xuhb6sYmIPoov77qnuWnXMRFBc6cDVpXgGL8JU2J2Jrn0DWC2854BHDEDdXIIdM199dPInv3kcYC3Gdoc2P7EWCQMd8tZgmSRH+0DDowMiGZdAs4crN5AV5QrdxOeqz9/6ugREsHuYPddzdT+B7l2AkhVYh36HJcBcx1s01zL1BO8uuzhw69od8MB/bKUatfajt+XufHVFC9dwrL4phihT9p7QrxP x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7QGMJrTzVcPYis1/qWGPcLua+qCGNOVjWPosA6LUeYA7aj0S65PBPUVjFbK0?= =?us-ascii?Q?RyXigYhKf0J0TaUbI3JyswZpALYoeeGvcn83ykRR+Hx1A5NeUW1v5aj5O6Xy?= =?us-ascii?Q?ugIFoefE1csCmI6PeWtjV3RmH0QnZmtYJRmy2ALV30tkE5Pd/SFI5q5Fw0Dp?= =?us-ascii?Q?05z+x1p82GszTV3Vp9miEWWm0KMuckXewNBfQTuPtlbAhfTK5DmxkrRcIFES?= =?us-ascii?Q?RSmpvi2BX97/6r2dRFMSTFh+eWXBU8z3FNxkfJEwc7mjsLnIoH/YPGTnJb3d?= =?us-ascii?Q?MUqJ7q5dRv0wR+uBZFfz3Eh9yPEnAW/4/Ite7U3PERaNo5hUigQzggI7kZC1?= =?us-ascii?Q?QVg61IHwxPm4/SAFcLgUeZ4cSNX7JAGIw8RfnqZyhdph5QPDn2qku7DJbCkx?= =?us-ascii?Q?dd6eCoqP+hdsIov8XOwbRD6kgsC2iq/I62Vgpe29aO0aLvirFMHDm3JlxF24?= =?us-ascii?Q?YwP99nVBIBzj1IuXKvOb/23ALd/ngMD8hSbgVbMkE/NYeF/JylHKNGH9YmN5?= =?us-ascii?Q?5RvG71VkDpRxOd60AxurInkOkt8pnQOmBBX0up5ZdDsy0v3ViY+1LnpYSHpD?= =?us-ascii?Q?JJ6Wd3bkpbbk+7JH1wjD9tzJAG2A2407EnYKgVf8ycpFyfTEDJocx4ZZLap2?= =?us-ascii?Q?cfKjqLgssZ6GQGMcjLS4jtfhasRiKJp3SlCDwQrUXc4itLgn9Xfoha4r56Jk?= =?us-ascii?Q?erxKOILJ1UOX08ZUIMQXIgVdjed0QvU8/+nekb8zk9qnxAeF4VLm1Nppvc7a?= =?us-ascii?Q?DoOmPC18qKL4RV/Vh9aRKnC5Chc6zzC4U8K0DNfMJWe+E6pYzvOZQc6tdNWQ?= =?us-ascii?Q?OrinQ+VohOnaewas2Io7A2bgj4q37UH6gEXfo6sX0kKxYvtqJFenkXAo20Sd?= =?us-ascii?Q?2G7GlA5R7pJq+oX+6+/ZQDgVeXgSA3CcW4uY2PnV1Bo/TDasGUHGVQhuB4S1?= =?us-ascii?Q?UX2+tVz60MTSW1l3eQY8AWpTzQ0WXlXUNTzxpaASUCMDibMmYMBPhWayh5JP?= =?us-ascii?Q?SB0RJmOGE6ZL9nIlQpNPY8ud80BsyzdG0ANQUDsgaazYyNGoHHkGIb8Wgh6F?= =?us-ascii?Q?OJg748G5+pGZEEx0EP0L0eRFC2aitgPm5pxRPA1zyLvX9pOsYIGReiqsuPRB?= =?us-ascii?Q?AaLackYE74EcHaLEVDA/20CW36t78Foc1iav90AXt1hjBi9CCu00j31R1EQf?= =?us-ascii?Q?axgwH596lp2jOapYaCYFLP9T2CWxLqS8Y+7bdbOGksk5nPgTLpwnVUHBEPgq?= =?us-ascii?Q?m6JUltkyyprOSBQsKGk7AciWZrWAbq+PxW8abYLPmKnbOybDuVkQ4eyhV9Ct?= =?us-ascii?Q?nywwbzlQz5hTIrkBMdet7QYy0yVLoWbBEYYPvcv4mCbAsIEO0P8MmdTa824I?= =?us-ascii?Q?DTIFJKR4N0IG+WDDMS54LDr8uYoH7Zs9SU7xbQWM75xEwR7g+lDnPIUJWWAX?= =?us-ascii?Q?yb3/m/sPRmuducEkqyn054okub49n8xumOS6k4FQ4tzDSYpVW1iGC/nnsbk2?= =?us-ascii?Q?WGBw+NpWObMq8Dov1NWJxwfLbN5wzrRCsmu7JS0JDmFuvahfLUgq6oEFSgaZ?= =?us-ascii?Q?cqt7RpsoNdT7ZzvWpPo=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5c34c7e-3d75-43ba-8e1d-08dc34059960 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 00:23:03.2242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sbWUd15kEikuwmz9DxFBkbU6PL6L2hk+t2lEnCoTgwkvxm3DNNIkU5UMhscdQKBLfmvZpk69DqUiyN3LTVq01g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8494 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2TNktSbqdpQWDBkGf6ovY8vHx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KR+3Y+jq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") I prefer HOB instead of dynamic PCD. And let's keep the new singleton HOB structure as an internal interface bet= ween PEI MpInitLib and DXE MpInitLib. Thanks, Ray > -----Original Message----- > From: Gerd Hoffmann > Sent: Thursday, February 22, 2024 8:29 PM > To: Laszlo Ersek > Cc: devel@edk2.groups.io; Oliver Steffen ; Kumar, > Rahul R ; Ni, Ray > Subject: Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add suppor= t > for multiple HOBs to MpInitLibInitialize >=20 > Hi, >=20 > > The code looks otherwise OK, but I'm not happy that > > WaitLoopExecutionMode (and StartupSignalValue) are replicated over all > > the HOBs, just like in v1. IMO, that will only make it harder for other= s > > to understand the code / data structures, and therefore it increases > > technical debt. > > > > I understand that Ray is OK with that, so I won't try to block the > > patch, but I'm not comfortable giving it an R-b myself, due to the > > increase in technical debt. >=20 > I can try to address that, but this certainly will be a separate > patch. >=20 > Given that the HOB structure is defined in locally in the library > I assume this is considered private and there are no compatibility > concerns when changing the structs? >=20 > Any preference where the fields should be moved to? PCD? Separate > HOB? Something else? >=20 > take care, > Gerd -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115861): https://edk2.groups.io/g/devel/message/115861 Mute This Topic: https://groups.io/mt/104472311/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-