From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3EA87AC0EFD for ; Wed, 11 Oct 2023 09:15:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tska3+zsP4Vir/4LIkicYvwlGc/X0X+uh+/2Kh4RiC8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1697015700; v=1; b=frRXbUX46IKP8vh2EMFRq38nlPTDQcqOcPyNia4FKQkMCcOGLUxgIRxevg1nPet75ktHuhYI E43DHD72UywjI49UgrvFGKUqMYahH4pXSd2T4cygGvyMH9kJQuiDdDs79b+ROcgDYtsIz5v8Yy7 XDo0C54irNojTOgAXKYDFpv8= X-Received: by 127.0.0.2 with SMTP id RcSpYY7687511xLdKmGFIcJ0; Wed, 11 Oct 2023 02:15:00 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.12466.1697015700276778993 for ; Wed, 11 Oct 2023 02:15:00 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="374958984" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208,217";a="374958984" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 02:14:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="927492898" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208,217";a="927492898" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Oct 2023 02:14:59 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 11 Oct 2023 02:14:59 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 11 Oct 2023 02:14:58 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 11 Oct 2023 02:14:58 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 11 Oct 2023 02:14:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ElsVvvS2BCYnPtcyVP4Xq5QXFvkYn71uFH5zQfWsI7SzI5fNbXo+r5WlPWf4ctwCymmUzjXNQoG1zP0rDEQ2PfPGcryYnBcI6qpD+F3IMFhZ5Uny7qvyiHkqZWcWiO+MssZT8me00DqVjnDmycIFGMbNbtAWoUVOBcMtL84Gm60il4G1ENgfnU/BsnJ51kq0YR6QNODRFDF987KFzmeOF6FID9NeFasr0SED43TO3xZDshM2IPbyutMbAaXUFD3GvQbmo8r2/oPixV1nqEnyNSBgosS7C8Np7DTPIYG2nN69ipDm0wx85nc5FsuDmaAB4RDAja9mVp0g0w3wvjEA+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rLp/dYjAKbi9y6SNqjyXm9IIAzBpJHG63JekHHEU7vw=; b=gpdUxmCntoBSqEoiNTUDTc2NhEW5WC5vOnaLCIkonxqT1r/1UPh5x9kImEasMllhr2lbvpEKSVlbpVGohJ3jW9efgBJvK/Zvl2Hcw6yqS+D5MpfUa4E7hoirg3V33LMUli2rPTVcfEIWyT77XGQwC66BqtT2/9HPEp33zM6MnZVFprUW6tmLOziX4ZMXUfU8phqumk/euhlKbPs6D4To1kBVhcq5/02desGaAqdXd4QkFNJUKhkg8tHG366RyDtdf2TXG+Ywsn5qZ+GW5ikAqhABlK6cb/J5wimV9ZN9syKLSo5v4nuLcdqiI4c1fl4PteaNCsK4G23i2wb/A8qpiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SA1PR11MB8374.namprd11.prod.outlook.com (2603:10b6:806:385::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Wed, 11 Oct 2023 09:14:49 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::a08f:5d:118c:aee1]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::a08f:5d:118c:aee1%4]) with mapi id 15.20.6863.032; Wed, 11 Oct 2023 09:14:48 +0000 From: "Ni, Ray" To: "Xie, Yuanhao" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V2] UefiCpuPkg/CpuDxe: Eliminate the unused variable. Thread-Topic: [Patch V2] UefiCpuPkg/CpuDxe: Eliminate the unused variable. Thread-Index: AQHZ/CKLVjVTk4KnoU2hX5yPnv21bbBETmcT Date: Wed, 11 Oct 2023 09:14:48 +0000 Message-ID: References: <20231011090823.1164-1-yuanhao.xie@intel.com> In-Reply-To: <20231011090823.1164-1-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SA1PR11MB8374:EE_ x-ms-office365-filtering-correlation-id: 437793d9-f8ce-4977-7688-08dbca3a8496 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Ieo21Gn9h5AAjlmldG0xDoakpAvUQQcrNdgn3jeXnTiP81rHIXJ43qn/XXUWJPoUoLfPo/tpx1JJ9PokwWj0iwi6GjCohXp/QDJk4ASAEwTUb8AjMgZN+BfrnnLH7CHx2f+gBvq+RMzG50k/7QzIvIXbWQYTPVWTLtnTwxewNoGC+YteyFkZXvSoN2DhGHGqE5lF6LujwQnA4mZQ3rexKt7R13atyveuTp813eTwNvy/yT84bzURIA0wi9qyntqyrrHOybdW4fsIj6dD35FSSlacSD/RedRwqHURWljC/9h8Zgy4kXcTIh+cwNiNlIbMZgRoUnTZm7xzuOvQds6UDSHfGpZpau4JajXzbpYxCp7JbTAos2dU398kgFfqLvm7vhQ38YCn5blunotX7p3edpHRlmLi+qzi0x0iVeU+HhACwm+elySbk0Meoh1FRbvtyOR4TO2Q2oeEzOwwV6/Lsr1+EGo79ePI/G+6MWARKD2OgEY8c+CydlDQh9jdlXPWvwsWn+jszh/UeHSsIFLRKOAh0Djk9q+X8SA/9Ft9l53fgzXi5J4EWiT/PPta6D0AgfUrVhTgBungD+EYO1qYd0g3YVd5MR0PjBz9hK4VajIo7e0akTSNLiufQwTCBeL6 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3FyyUh6lD+nA5At44GxMd85s2PqEiVstXEg5+SS4sCwdzlYvpSsqUs9inBft?= =?us-ascii?Q?JALj36desIc++5mep6T9zzuOrHMwDnvd0Se+8VFTKYEJk1JO2GRpahjuSeNJ?= =?us-ascii?Q?+P5vObJhRg0SU9u6dy55S369C4HC6UJ60cT25C97SyWs71dF0933YO+/Yqb3?= =?us-ascii?Q?hbdeaLCdtc3NcdhcYhyRPlAkk8rsESMDJQ85fOOVYkeU/n9aQEoedUMyEapT?= =?us-ascii?Q?DUDX6diF9c3impsvhFP3o5o3TFRwTcPpfM4cAbFjUcXeyV6kx3vpoYnzoqGv?= =?us-ascii?Q?zLMSbk9Ki8P0UkPiw9aAwKGOwMzolQiWXysHdRxGl+BWj4u/R42ycihKqXnj?= =?us-ascii?Q?o5Q2qStmIYdE5uh+hjy0+SDr8Kqpxyc42gamKPn1MkRZUFcYZelH9NyWfOXJ?= =?us-ascii?Q?tZiHpf61Vmepa/ZXXi5ZjE0EtbAKy7QEocxXHbUypej8ySaBsBkbBUb0qv/+?= =?us-ascii?Q?r/HaRX43McbIvb9VZnq2hIiLpr7DE/b4D4ga60jtLZMT4VOMR9KgMgDms8jO?= =?us-ascii?Q?DJUWBp9Wv7EFhO1jpSOAGHyumEnn73TfSymgnEruSS7BVB9ErB6LLSVvlfwd?= =?us-ascii?Q?d9nE2cO21BzkEQuSUN7pcGkI+QMOB4VcyX1VtWQb/y/88qv0Y8UvmIGtSA/y?= =?us-ascii?Q?RevwF9ZxZ7nk8cRO0IsxFdMW2h/rBjs5BW5MCP92TGwPxw2LQt4aoj7aVCx0?= =?us-ascii?Q?3ZLLhiD31iqw510tHESzeJQrd8XcnvA260DvEPhsIaF4vM77AyqJk/HAAarj?= =?us-ascii?Q?Aha5H74TtwVAHrvIvTuf9Wp2phuJHHA4RZ0Bb72USjx4e4RXXa5L4f1XzgOL?= =?us-ascii?Q?HSsp2ob73ceZt4BhfnUsmBVuwclx7+dnSWH2lJLCQzQ7VYyULLYacinaN4LM?= =?us-ascii?Q?G1cRJtQCa4dQaU6+vSN0VqsFVaoDXdU8ik8LJ4S/Y9yf/qVmjEezWaviHX4V?= =?us-ascii?Q?uU3XzIQvpLq34SmeGSEDsqC5vS4sTxYff0gf/u7mm1VSb2gSg1N5FXjpBKTN?= =?us-ascii?Q?86sWouQ9hpo8M88Lu4qClCvjXakGcErJPWa+oXhLp1meFIY1Mn4I9QQnIwU/?= =?us-ascii?Q?GOqnjIaehIc2XrqEFddK+oeiEvxRD2V+Z0hlgbgeFNU5p9lcjNd0gsd9Zxtc?= =?us-ascii?Q?X5MqaqCO3DKh6FFHXuEDPUbah/aq0dXf4Eqn/fkWgu8pICt4z28rS8u07V2R?= =?us-ascii?Q?mRszC5XVX9V6fj0FixJ2sW6AfUGc7zvNgbzk01xguvXffYhIb2jamvSnZWHK?= =?us-ascii?Q?DFF1F+HQZQ74GsQybai0CWm8vPso037oDUY33vuTqOZzq0CBGPain0Me7egS?= =?us-ascii?Q?ZR3yLhiKZ9dQwPB6vifdt1p8rtXDGC3jcFJNB6pMwuvBAUf+ZqVLnMr9LSa5?= =?us-ascii?Q?ykBikXCS3QbniFBr421jgWnY03ab4yndjJop3oOEaRHfTxUh53vy3fyBi++N?= =?us-ascii?Q?AdEwzeUohqUj0lgDzj+aT5BSRTZN2a5isq42ER/yG2UxkA/H4OwvFj30wFck?= =?us-ascii?Q?xRYqKb5teU33JvVhc89WPi68/ckwD5bU4b4aCcEGk9bIZbNwm2HBgnmE0lPh?= =?us-ascii?Q?vz/a/5L+yzXzlyCi6Tk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 437793d9-f8ce-4977-7688-08dbca3a8496 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2023 09:14:48.4378 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x+mC0shVIVRH4CJkRkfs1PObOwy6jk36Rl9ln/zCgQFyUm1kq0YLN6gf02UeMzain9NkAAHOhULcw74idf3nhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8374 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sWMgx32npAMpnBDYQLaD1Hgox7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82446D1BFDA693D3F3F223168CCCAMN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=frRXbUX4; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB82446D1BFDA693D3F3F223168CCCAMN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni Thanks, Ray ________________________________ From: Xie, Yuanhao Sent: Wednesday, October 11, 2023 5:08 PM To: devel@edk2.groups.io Cc: Xie, Yuanhao ; Dong, Eric ;= Kumar, Rahul R ; Gerd Hoffmann ; Ni, Ray Subject: [Patch V2] UefiCpuPkg/CpuDxe: Eliminate the unused variable. This change does not introduce any functional modifications. Remove the unused mValidMtrrAddressMask and mValidMtrrBitsMask. Signed-off-by: Yuanhao Xie Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ray Ni --- UefiCpuPkg/CpuDxe/CpuDxe.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c index c5ac624f9e..bf8d0eb5e5 100644 --- a/UefiCpuPkg/CpuDxe/CpuDxe.c +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c @@ -15,15 +15,14 @@ // // Global Variables // -BOOLEAN InterruptState =3D FALSE; -EFI_HANDLE mCpuHandle =3D NULL; -BOOLEAN mIsFlushingGCD; -BOOLEAN mIsAllocatingPageTable =3D FALSE; -UINT64 mValidMtrrAddressMask; -UINT64 mValidMtrrBitsMask; -UINT64 mTimerPeriod =3D 0; -UINT32 mCpuTargetCState =3D 0; -EFI_CPU_ARCH_PROTOCOL gCpu =3D { +BOOLEAN InterruptState =3D FALSE; +EFI_HANDLE mCpuHandle =3D NULL; +BOOLEAN mIsFlushingGCD; +BOOLEAN mIsAllocatingPageTable =3D FALSE; +UINT64 mTimerPeriod =3D 0; +UINT32 mCpuTargetCState =3D 0; + +EFI_CPU_ARCH_PROTOCOL gCpu =3D { CpuFlushCpuDataCache, CpuEnableInterrupt, CpuDisableInterrupt, -- 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109522): https://edk2.groups.io/g/devel/message/109522 Mute This Topic: https://groups.io/mt/101893039/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82446D1BFDA693D3F3F223168CCCAMN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
From: Xie, Yuanhao <yuan= hao.xie@intel.com>
Sent: Wednesday, October 11, 2023 5:08 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Xie, Yuanhao <yuanhao.xie@intel.com>; Dong, Eric <eric.= dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd Ho= ffmann <kraxel@redhat.com>; Ni, Ray <ray.ni@intel.com>
Subject: [Patch V2] UefiCpuPkg/CpuDxe: Eliminate the unused variable= .
 
This change does not introduce any functional modi= fications.

Remove the unused mValidMtrrAddressMask and mValidMtrrBitsMask.

Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 UefiCpuPkg/CpuDxe/CpuDxe.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
index c5ac624f9e..bf8d0eb5e5 100644
--- a/UefiCpuPkg/CpuDxe/CpuDxe.c
+++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
@@ -15,15 +15,14 @@
 //
 // Global Variables
 //
-BOOLEAN           &= nbsp;    InterruptState =3D FALSE;
-EFI_HANDLE          &nbs= p;  mCpuHandle     =3D NULL;
-BOOLEAN           &= nbsp;    mIsFlushingGCD;
-BOOLEAN           &= nbsp;    mIsAllocatingPageTable =3D FALSE;
-UINT64           &n= bsp;     mValidMtrrAddressMask;
-UINT64           &n= bsp;     mValidMtrrBitsMask;
-UINT64           &n= bsp;     mTimerPeriod     =3D 0; -UINT32           &n= bsp;     mCpuTargetCState =3D 0;
-EFI_CPU_ARCH_PROTOCOL  gCpu       =       =3D {
+BOOLEAN     InterruptState =3D FALSE;
+EFI_HANDLE  mCpuHandle     =3D NULL;
+BOOLEAN     mIsFlushingGCD;
+BOOLEAN     mIsAllocatingPageTable =3D FALSE;
+UINT64      mTimerPeriod    &= nbsp;      =3D 0;
+UINT32      mCpuTargetCState   &nb= sp;   =3D 0;
+
+EFI_CPU_ARCH_PROTOCOL  gCpu =3D {
   CpuFlushCpuDataCache,
   CpuEnableInterrupt,
   CpuDisableInterrupt,
--
2.36.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109522) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82446D1BFDA693D3F3F223168CCCAMN6PR11MB8244namp_--