From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.16696.1675229122211916486 for ; Tue, 31 Jan 2023 21:25:22 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Mrb0mQgv; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675229122; x=1706765122; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=s423iuvVEc/xgMyDIHebpimKefXvxDIT+cCRN+XCwFc=; b=Mrb0mQgvTLkWVE49fGSKvdZ4KplvktNRvmevjLbq+sD+6Bb5eYAkm3LI 7aruNkWW9U1eLQU13+5+wvt5lFnuhVLWJ23y5myP6ZcIUy7FhyX5rhAZB XEXJVFxDPyuAFQXVjx+Kr+5ga+qzNO74hQbmZyuuypLP1Jw1Qw/QVruv7 pS8THl2ZdaLViMUs5ObqwlphBsnRZYB/ZABGZz7U10Y3zA30r1jb7Yq/p hfq9gpCKP4nyYdtMoWbHHAv29yXVVY/500aF4NcoM9u8ZqxNd/uxZvIJ7 RoCPpHmx8IHILzqbQu4Y6fWs2OrtKT7RQA05gKVAPujfZpTY9ZsXHEdHU w==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="325748705" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="325748705" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 21:25:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="733408781" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="733408781" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 31 Jan 2023 21:25:21 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 21:25:21 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 21:25:21 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 31 Jan 2023 21:25:21 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 31 Jan 2023 21:25:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EKtZyasTBD9AwqCgsMemGZXsMcJPjCrMclE4sbDlWhIPnNAOWbTEhwVe7bI7+WHUcguK1da7XzT1+kWT/BChKQc93/XvoGj5so0+aFbFPz/FkM5DKrpor5nYszIPGu9e481Skt7Y6BtuFiIK2/Fb1mibFKdi0nKuKGLGbxmuHc28pPfPFfCFPQlQCvDGb+DElQCSMRyHtRkIv7TgLhYAmUodhWvWeRn7y6ORQ9mm1Uo9D363STtAHAv1LkbD/ziNFgazaIRwmmXE3gGFHluC5Sa5Av3uUTL1rWczrz0fppleD08xuECQZ2crxj/G3GlFNjfIZ7ShUYwwBpO6X2s0SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FFzzPEJKR/UhlvaCq00+HxFNB4cWCrjuAX8BE3bmztw=; b=ZWRHu1/KR9YFGyYmIzIcVhPwExRSkJDj3Uipy6TmyUFD9I8GNikFszGVKWoXj4nwuoGBpPOB1Y2//i/v9k47+4N9tP2e9TfwEJkKVSQUoQbx/AJ144RmvUHDZMfRbDbBIQ8zgDZzFLnWyW/koxlrpTsVTxg1tUjOcFPaVom85YdpCJ8Wg/O/M66/RWWj6nkOzbgf4I4p+f9NBOJXzwyhr0xX6S+KtJSeDm8lqutXpr/0DfDQgoxDabbbENtCQrEdgtQ3HNJvwHIHE2ffIsTuVlgoZn3pHpX3WoHh9/nIs1RSP4gWSA6v6mKsjZghvdm3cmsgaJFaOgXRiex74dRJhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BY1PR11MB8126.namprd11.prod.outlook.com (2603:10b6:a03:52e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Wed, 1 Feb 2023 05:25:18 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%4]) with mapi id 15.20.6043.036; Wed, 1 Feb 2023 05:25:18 +0000 From: "Ni, Ray" To: Gerd Hoffmann , "Liu, Zhiguang" CC: "devel@edk2.groups.io" , "Kumar, Rahul R" , "Zeng, Star" , "Wu@sirius.home.kraxel.org" , "Wu, Jiaxin" , "Dong, Eric" Subject: Re: [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging Thread-Topic: [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging Thread-Index: AQHZKtuPlV+UME7tiEGiILTRVUG/qa6j4k6AgBXC/IA= Date: Wed, 1 Feb 2023 05:25:18 +0000 Message-ID: References: <20230118012348.1195-1-zhiguang.liu@intel.com> <20230118090529.bwp4qpluagrpk53x@sirius.home.kraxel.org> In-Reply-To: <20230118090529.bwp4qpluagrpk53x@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BY1PR11MB8126:EE_ x-ms-office365-filtering-correlation-id: e6f928da-2047-428e-1ec1-08db0414b502 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CzZY64rMu56+ll6UEObZiDfDz+3XmFcDJtlKO8GsZuNzIV2sXLnQAFx9Xb+UvJ9b4K0Bqo86I/YuG0uQrbpkNKQi36guL0vTvNEEqPqbcpGtTjOWYZnDXNd2X65oUROCueszC+Jhe98p0AUzLkYI7XWqWX8HvPZ3Sc2QlfIFamij/QdJsm+4DN6SjYr3lABmL5wdBDEZ8A7WuQoxj8lGt7rDAL5r70OJQCvgnLbbH6QWlAMLn6SkAMRYnttasbMsoKp+/w6RiFT72ldyanzF9dG9vb8TEKUuC8dgxy+wNC5JtbbHQ1o/v/IKccWxa+KEOpXID7U/yJyYdedUeE1M3IZMpXZCfBURep5l618rGZ+tfnAbITteZkspWLcifRvKbHY7VsKaY55P8Y4/ORCngsynnM7MMMJ+qV+38hryScJ04sang59r2IU+AbhdXM1CplJACTeFB+0GFs+W7fRZmC1gV4otBRJcv/FFyVD68iP+9T08YvwX/+6weZIIZZGmbijjTrL4lUhwFikhfHRpXpWszi5rxC8xMqCFwZRZ3feCHHTDOqE5sIrCis67HEaaYK7bWmJX7ZFoDyNZyKJSA57K5os+8cz/kUsRB3kVeRvfMCm91WXg7ofJyULvpkeGmcHNBTXextFNvZmDX/ZzGU6GpV/tVoWdvwbS/woq8s8sEtygX0+6vYeGsBbO5wvSW9mCpHQ9BpVhXennNyMpjK4X/ib+uJtsifZwLbw6xWc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(136003)(366004)(346002)(396003)(451199018)(38070700005)(4326008)(66556008)(66476007)(64756008)(66446008)(41300700001)(478600001)(122000001)(6506007)(33656002)(107886003)(55016003)(83380400001)(186003)(53546011)(9686003)(316002)(6636002)(54906003)(8676002)(66946007)(19627235002)(7696005)(26005)(966005)(76116006)(86362001)(38100700002)(71200400001)(110136005)(82960400001)(2906002)(52536014)(5660300002)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MguqFR01EinWF+setaRAyIy2zotcZzam4YJZjwVKs2OM6R00M9XdSj0h/wqp?= =?us-ascii?Q?BcOgjyxVHfNrceW9B8PDTl0bY7BYDwUaeCJml7+/aufJtTq9H0LAl81TFCyd?= =?us-ascii?Q?2HKoo6IFwT9WZuRJX8cPjsF2IXJSQfRshHMeFAjoMTz8FnlbHxfvTArQS4OA?= =?us-ascii?Q?6a4HhbC/4f+M9051vl1TlJbo7h1LUnloiB37qWOUVDoOJn9nrmwKHSPkLo0v?= =?us-ascii?Q?8Ciw0eZ6IX2/d6OxItMlmhP7PBMdkBH/eunDMervDINW9xGjznS0SYufft4I?= =?us-ascii?Q?3QPjmEQAog3BMLualxKUQDnfo/Btfpka1+vB3XQhzAcuKeAql8wbhYfpik06?= =?us-ascii?Q?7AGIsxkGjUDQO2U7j3vboH7WHyvWNxxnHx9K0b7ofjP7p3UL0BaLcPxjyLPX?= =?us-ascii?Q?sU1sjfhWPsxCiv78/rFlgxUnsBq7VX2yL0VxVzcwrBmKUkXb/D2Or1xvfHLm?= =?us-ascii?Q?XCh0dwzQFKFqr9JGicfKY1XZe9MXEqXWSk9wtfDkVJd7VOUfZuZP2WkUIxpU?= =?us-ascii?Q?4yjOl+0C67NlCZHFgPGkYna7b3u5dmYOteQnZGtcdsDNcFCiWmSEvQUA6G3f?= =?us-ascii?Q?rU9hcZxOvDvcR+5O55P1l99ulVfSMbO5ts2b34UtK8xwR6Ydb9S8CdDRiBRF?= =?us-ascii?Q?+DkFh9HboOK5qGFSI2Zr3G8wFoSHtWeoL+q+qq/JX/jGAyb5En8NomfU3k3B?= =?us-ascii?Q?yRjMb5ZP4UN7dILJt9BxoUn2EKj8eWjRuq4+yJ7tAR2vVnD/g3OW1WrprfBr?= =?us-ascii?Q?eZio7M3quI7hRqsKgDeQFmdzNIDb6UuidnrC3iEJbU/gGN4FSDhnqTYtvUW1?= =?us-ascii?Q?ku5+BHrIRV04xQq8OPB0ZN4oPpa0Fwz7NBFA+hMDRuL9+jvLbNyVocMqOyY7?= =?us-ascii?Q?OjKUGFu6mewY3DLefvHEH8iwGzWs0Q16yHwVQhAiiNc08hKoGl0ffK9zV+fE?= =?us-ascii?Q?wf/PcXxLtkg8qKyFkcwMya0JBjY5fSgdFZ4TOS3paIK12+F3s1RSzHZmQhge?= =?us-ascii?Q?BqMvWY+fwipNuvV1xPnHQmH2wxUdqmSkOv8oAi3KPb0dWWLAksItwo7RJzT7?= =?us-ascii?Q?bIMr7fB7vm9Z0eYwEfAFlFkWmDQblgTEZUsUvC5LrdtuEOB/gZNisz9FRvPr?= =?us-ascii?Q?9XKcLgn9L7Fz1RcHzCNS7VLIlO2e1w/zz/O0afkfbyCloRYJQS0B4FbJX2UI?= =?us-ascii?Q?XOWqCp5Xyk7I4uNuRuImAquKlNja+mqFECDUrk0hEdKxKIX8SsZRDj0vYv3C?= =?us-ascii?Q?0nZ5YRbNulilSyZTA58Y2c4JTpNud1bYfrQS8sQSkApJRdXtO9vVxSSzLghB?= =?us-ascii?Q?0aERz8SExw9+GI1wot8fexSpM0qtMgs+49c6Fb5rUa0MuhvNRMuWz7eoUHBJ?= =?us-ascii?Q?VGjtwgOG71PNnGu18K+P4OsTLraopW5zvRCUZM28uGWJ3IgVaUl+yBSNb6EC?= =?us-ascii?Q?ipUokgEOzRGNq/sTo5tevHzNYbhCyyv58bYwo/Oi9hKxmm/oaWS899CyoKhd?= =?us-ascii?Q?oArPmuI68RB6ZE/UGGYkhX5yqo6ZZF9dQ1u+Rr4XfwPOiKbawEYiBA17MNCb?= =?us-ascii?Q?QH+Hh43Jbec5z9Z9fTg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6f928da-2047-428e-1ec1-08db0414b502 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 05:25:18.5572 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CQf2LtmQKz0wKA8EZBM64+dyLBX4LBwjreTtye0dka3///T1RkWFfdatN7wOSg9Ry2Nt79uB8ZY2oY7pdGFHcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8126 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gerd, I saw Zhiguang and you had some conversation in V1 mail thread. Was below question answered in that conversation? Any concern if I merge the patch? Thanks, Ray > -----Original Message----- > From: Gerd Hoffmann > Sent: Wednesday, January 18, 2023 5:05 PM > To: Liu, Zhiguang > Cc: devel@edk2.groups.io; Kumar, Rahul R ; Zeng, > Star ; Wu@sirius.home.kraxel.org; Wu, Jiaxin > ; Ni, Ray ; Dong, Eric > > Subject: Re: [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging >=20 > On Wed, Jan 18, 2023 at 09:23:48AM +0800, Zhiguang Liu wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4246 > > > > In function InitPaging, NumberOfPml5Entries is calculated by below code > > NumberOfPml5Entries =3D (UINTN)LShiftU64 (1, SizeOfMemorySpace - 48); > > If the SizeOfMemorySpace is larger than 48, NumberOfPml5Entries will be > > larger than 1. However, this doesn't make sense if the hardware doesn't > > support 5 level page table. >=20 > ... if 5-level paging is not used. >=20 > Hardware which does not support 5-level paging is limited to 48 anyway. >=20 > This still does not explain why this fixes code hangs. >=20 > take care, > Gerd