From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 25621D8027A for ; Fri, 23 Feb 2024 02:16:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Lskkpxxv7LcUmgTpC5yUZYXu+8AsTGX7mGn++M75iS4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708654616; v=1; b=grL/Zl5bVP0Vmr0DSu2EMI72P/23x9tBiEVfwkc28BG6DgqX4c/8qS/cSt4rKbUeMXMUVWhA 0dOHdXoZaDTc3XnUX99x0w5dvxG9gUNGeG8t2R1vlzV4rOG6FId2BxPDN9jPSA31xjaOY744dzA DMCPcVbQ0AvSWm4KFGVU7dYY= X-Received: by 127.0.0.2 with SMTP id h0NuYY7687511xFuSTaBuvZn; Thu, 22 Feb 2024 18:16:56 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.2177.1708654615439311265 for ; Thu, 22 Feb 2024 18:16:55 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="5894843" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="5894843" X-Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 18:16:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="5914931" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Feb 2024 18:16:55 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 18:16:54 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 18:16:54 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 18:16:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWRb/xf494hurgjLe+zc6HOp4O5tD662ZznDget/H3jkRsSuQmirkAxF64RofCVWEh7+x9ofj4JeF5AUbJceL7xR2xabPGS+pOb9ScUMMdPFeN9K/fiGZ7QaLi+WsnYFur9cgG0w04roty9K1jektZ8yR5OgHnWrkfDdEHziPxGCqPLCXul65AkTRILBaSt7eJev7sUpFXYVYx1RMcu+dOClz0qGXd6nzP8mAehxobOoTuCP/RE2dZP8kPABl1M1eG+mKnAoAk1BlBn4l7ptdNVfH2u8jpzZNQUKL6bbyNoQv+7Q+O+O0y7RJ6gEnmtv1bhUCez9EWsc8kkaxzHnVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p5lJImhBK63RvrZuOWung75AeSpKIPQr93ICDwJmQSg=; b=PoJgavr95+uTveBm9gWMS+rvfFNXY0mPpE/Vzq2E4HjSWBjUBVTDmjZGQ/wZD0N1TYRogoCaDSxQUayoxB+wJ1HS93vZKamos60cTfW6dFhpWPbBodHO6Rqx29KXDvvXTjkb5QO42/O15l0dekVTpOxrmaM4H31BB0+oFqBWaxk4qTjcJKvv9HukxjV3pVlzliV7UDaCMEVsr0/4BBJE8XYDIMorjBWT0yz7D6CE88Vo7077OM6DqGB4kpOyaSMT/sTOdjdosMk8PsjE3gnSEHJ94KrN3xMf7SQb0GLgNa+3ggI3bAwY4DwwlwC7T6VWMiPbHWI4/86khKldFJ3Dtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS7PR11MB6199.namprd11.prod.outlook.com (2603:10b6:8:99::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.10; Fri, 23 Feb 2024 02:16:52 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8985:d1bc:9df6:61cf]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8985:d1bc:9df6:61cf%7]) with mapi id 15.20.7339.009; Fri, 23 Feb 2024 02:16:52 +0000 From: "Ni, Ray" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul R" , Oliver Steffen Subject: Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData() Thread-Topic: [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData() Thread-Index: AQHaZaiV044fI6l0y0iaQS7rM7mAxLEXMPJg Date: Fri, 23 Feb 2024 02:16:52 +0000 Message-ID: References: <20240222160106.686484-1-kraxel@redhat.com> <20240222160106.686484-6-kraxel@redhat.com> In-Reply-To: <20240222160106.686484-6-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS7PR11MB6199:EE_ x-ms-office365-filtering-correlation-id: 5d912634-2821-4f43-f2ed-08dc34157fcd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: H//7wE7Gma+RQmkzCQ75zJT1v0taGyA4a9/beSKxyaUn4xh8mZoMDjDdyXi7/bKLciFb/K0o+vbzXGKGpaH0JypGnIAcxvLOyaT5j+eCGmoqOIJMeYyQqPuGkcLMjTkPskXIs4dp6jZrEDBzvDrRDxMlbgDF3veyCFtie96PaZW5H+lAOOAwS02i8eFkOp8cdFMf/PNdNXt7O/cseTSNbLWm+oJP2jKuEChJNUI5x2HbjrUm3a8oUKpPHdJUOoXoDwpzWOzQ0YQFl8To+5P1HWJERG3Z096GVyHTBhol50PFCkAMcpTnPvCyQUu1oloJt83ADCU4QSTrxRtg5r/4ThNXh+nZIW12csJOhQamQ3swIV9YNhkYpK74/O5n3FMys31sWLPL4EkrhirCaB+sX4N6pt8w48CiOjJztOcq7fjVWq92A0MONw8AdFkaHM6J8dHjU7bRMlxxJVCv1GUiknC35I6gyXwyLdfEJd8rxh07Tni7wWjPFCsoDScuqcKFJhBLh5LKXJPDuV1p5tdYKxOl+S0SsVZpC7D8QHQGcvaT1ZjU2F16De9OPKGRvbBXfau0h2BXNkBvB17dFVn8M0RrkP5m9LmHU5M9ua8VVcJ2krGC8rLBZs5Uy7Ij6VHw x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+6RpOcgKgHJfg68XJ2JO+cL/aZ0IxF3URoSAk1YxhIjGEYj9wFPQtm4RiYkJ?= =?us-ascii?Q?atjNLIbW37S7pxiNKwa6uME3pClKnHgfsKxtvwRj57WQ3mtONHAgsQKIxGMr?= =?us-ascii?Q?Zo4b118FXzS+2x9qYPmOArBJsrV4V3N3JRsZcz/3kB8E3dRead+dKrcWi2u2?= =?us-ascii?Q?akncWbpCtDyjnZgKg1YWu/TmTlfvq14oP91tuA5OR/Ygxc+767tg8NJZ5FS+?= =?us-ascii?Q?CeAJyARRd2I9dXAHipr74caqK48Duh9+iNTWh7V9MEZ8FG9sP282D2WR6z3B?= =?us-ascii?Q?/Q+JadQYhU536yaA4Heap8T9p8I4eQ7LEDyhipnWDBwsugtlDgwafzG46Z47?= =?us-ascii?Q?h/5yqM1OTekR0rlipQvFNjTXLMHjRe3xo3ogMONuovSe1QN3+k/ADV0/UCLO?= =?us-ascii?Q?NxDcgaXyJ9TVoiha0l/v291zZ1ggl3/50u9FqX9Yk6i1lmPLJ1BLBnp2EO+r?= =?us-ascii?Q?8uRt4W8lSD3rAobtoxyPDflAm05zoZMxHBuI0Sw9SDIpcsYB45yIbpCcaATY?= =?us-ascii?Q?aeqgHwxuY3zPlU/4Ok6wE7DhWNbKe9NUFBzvL5MpQpIJuwtIfRDZic/eg1F5?= =?us-ascii?Q?0NOgkrHF5U4XLocByPbOeQHsGJ6S3Rhr0HcIfetFqA1Zb/4PeTQh8WovP93z?= =?us-ascii?Q?CUvvZtyC/YIGAHQcGjMNMcmLbRNTrLNQUgA5ojBT869AF+EkeCzMkEIRKIHi?= =?us-ascii?Q?fVJVMreuiutSD8Viy/d4BdmPJdzpqTnMdyR+M2LWhu/UQThVpeC7Ilin3VQ/?= =?us-ascii?Q?3WK5K423XmnnXW1zxaTFz+8vMXfGzMEvWfZ6YCsrOHqR7TzvMhigncMcM6Vt?= =?us-ascii?Q?uOV8gcbq/1jfRw2iC4Fn3/E9d+kDrxmc5rQqkrmyqGCKqKt/fvZZofZGrKhH?= =?us-ascii?Q?y7eK9cwaOYJiPXQDte7X+I6mNHqtdn9/m7fdMF7XDO7TlXuQyyg/KYPrHRgx?= =?us-ascii?Q?pEO4i7LZJKFrBNzhGuznTfU0Zdw0J/t5GbiLlXiKnlmrYX6GJu+c8csyIZck?= =?us-ascii?Q?oK+nDbHsJ73xkJeP2wc5zQn5cR3Ok9wcts9ngmHGfeAWJudQDry0DpxIKlIb?= =?us-ascii?Q?XQDdBIifxzrOhUp56meFtT3JPTCo3bX834puEe/cnzisOKjISyL8TWCHnbbZ?= =?us-ascii?Q?BDv9am1XH4GsO0lJhkFC+ZEzKomdFSVWdhkCNrzeZkfsLA0nQyp60H1iP9ZK?= =?us-ascii?Q?0KC1TQvlUOgIrHZ/9b4F3sRkmBlaebLZ7f97WgfeIE177XPGP+Re7da+u9Em?= =?us-ascii?Q?utLdxBNwmKthppXOcRkb268Tn0js6TMS1lBuSOV+37AgC5GmLyCtBCO14wV8?= =?us-ascii?Q?X/Y8e3UmIB6IYDVhOQhNW/Rzgi0nC26rQ3F8Y9afqWbUZtGRdpjVp7aEwg1I?= =?us-ascii?Q?CoZ/IkU7CeIQiFXLenXOFclXaH4B5yQHMkti7gljPLkc0juaFuY5T+dCd3Gk?= =?us-ascii?Q?Dt5ArXe9Q8+XcJNdkbBFYnr++IQyuUjzv68hTBQ/5zdzbozd+sW1uea0Ncyk?= =?us-ascii?Q?1BqWMHNyHjPy1rMfNbcKIBIfbOEs1WcbDVrFQKZNw+hUunRCE521tmuHu9+7?= =?us-ascii?Q?QTBEUQ+oXE3EBAyD5BE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d912634-2821-4f43-f2ed-08dc34157fcd X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 02:16:52.2697 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xxC59w4JwXeWAJmCpOUPHmBJTlfr+YbqyDlxmO4Di6xuiW2Rp09ov4OY74f2YkW9azgnMHV6FNUMdapuFNXO5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6199 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qzcAtmNjDPhiHFSQmWvT28Mgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="grL/Zl5b"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Thanks, Ray > -----Original Message----- > From: Gerd Hoffmann > Sent: Friday, February 23, 2024 12:01 AM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Ni, Ray ; Kumar, > Rahul R ; Oliver Steffen ; > Gerd Hoffmann > Subject: [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple > HOBs to SaveCpuMpData() >=20 > Add support for splitting Hand-Off data into multiple HOBs. > This is required for VMs with thousands of CPUs. >=20 > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 44 +++++++++++++++---------- > 1 file changed, 27 insertions(+), 17 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > index f80e00edcff3..00d48c2ab531 100644 > --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > @@ -126,35 +126,45 @@ SaveCpuMpData ( > IN CPU_MP_DATA *CpuMpData > ) > { > + UINT32 MaxCpusPerHob, CpusInHob; > UINT64 Data64; > - UINTN Index; > + UINT32 Index, HobBase; Can you please split the local variable declarations in multiple lines? With that, Reviewed-by: Ray Ni -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115863): https://edk2.groups.io/g/devel/message/115863 Mute This Topic: https://groups.io/mt/104510911/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-