From: "Ni, Ray" <ray.ni@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Dong, Eric" <eric.dong@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [PATCH v2 3/5] MdeModulePkg/DxeIpl: Align Page table Level setting with previous level.
Date: Fri, 12 May 2023 06:40:11 +0000 [thread overview]
Message-ID: <MN6PR11MB82447297D4C97F3449B5A9108C759@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230512041548.6416-4-jiaxin.wu@intel.com>
> + //
> + // Check cpu runs in 64bit long mode or 32bit protected mode.
1. this comment seems to be redundant.
> + //
> + if (sizeof (UINTN) == sizeof (UINT64)) {
> + //
> + // If cpu has already runned in 64bit long mode PEI, Page table Level in DXE
> must align with previous level.
2. runned -> run
> + //
> + Cr4.UintN = AsmReadCr4 ();
> + Page5LevelSupport = Cr4.Bits.LA57 ? TRUE : FALSE;
3. "Cr4.Bits.LA57 != 0"
> + ASSERT (PcdGetBool (PcdUse5LevelPageTable) == Page5LevelSupport);
4. Good check!
next prev parent reply other threads:[~2023-05-12 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 4:15 [PATCH v2 0/5] Target to enable paging from temporary RAM Done Wu, Jiaxin
2023-05-12 4:15 ` [PATCH v2 1/5] UefiCpuPkg/SecCore: Migrate page table to permanent memory Wu, Jiaxin
2023-05-12 6:24 ` Ni, Ray
2023-05-12 4:15 ` [PATCH v2 2/5] UefiCpuPkg/CpuMpPei: Enable PAE page table if CR0.PG is not set Wu, Jiaxin
2023-05-12 6:37 ` [edk2-devel] " Ni, Ray
2023-05-12 4:15 ` [PATCH v2 3/5] MdeModulePkg/DxeIpl: Align Page table Level setting with previous level Wu, Jiaxin
2023-05-12 6:40 ` Ni, Ray [this message]
2023-05-12 4:15 ` [PATCH v2 4/5] OvmfPkg: Add CpuPageTableLib required by SecCore & CpuMpPei Wu, Jiaxin
2023-05-12 4:15 ` [PATCH v2 5/5] UefiPayloadPkg: " Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB82447297D4C97F3449B5A9108C759@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox