From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.18049.1683873624734610878 for ; Thu, 11 May 2023 23:40:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=JT2wwUcv; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683873624; x=1715409624; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BCmUkLEgWacZoxpc1sTzdNXs3qtgs5tO+oKuV1XdFHQ=; b=JT2wwUcvsY02O8DxYnB2qk8t3SlrcBCjKxjqjOLVQoSIPep2fc6sBwdm S1ZrL7H8skcgXZK7EHLRtI5hfRWQt/mzN6GMau4TAOogaW6NFConqKbWd EKMjkIAWISj6HuzI/DCVDHaTv7W7Qncv1uKlXcybtvrYlTiVEP6LSpI2B JHe5q5YaWZQTYKqS8S56kAEMe5qF69JaOrv/PwKMhYKukSebkbgXwMsaf uHWbr9HB34JEGmcfeNHmHRu8rOwQg9K6UpW6bLYvv4BQBEHsofUcmamwF 3+qPvJI38RiAeIcx/URMz8+wVpK6iVDJnH5zE0mhAKqLENcOBkvyudpqD Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="330336852" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="330336852" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 23:40:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="694106213" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="694106213" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 11 May 2023 23:40:23 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 11 May 2023 23:40:23 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 11 May 2023 23:40:23 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 11 May 2023 23:40:23 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 11 May 2023 23:40:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LDSd2zOgGl35QJFXcWxlGDGrvIpUiyqQK+Wj8GVnAipbaSgzqFWHYW1ZWnhZEVrsM/xIID1hwTCJFM6bMXZ/XyyoERa5r+1vI4ympHeUBk9sP06KNuFHNXIFfTN48uF/x/yW/CvCQ9gLIUYvm4pAYQFeXywTge+xpug3wttwSRA2j66DBESIJztLSDsARH6+qbBO3Jgi2rrHyIrKHZJGCwepxxGhOM9zN/XQ5GMCOX0+6Dua+oELuVxauD5Pk5fGtPcku7sCQTKLNoqse6qB9KnE4MAfKY7L7D18l9D/8QOh7Ooj+4bk6xXw3BbXbqD1ldKBxRkVbGEmFi58akcrJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p8f0+sMGz0O/hgVUe7vy/qtN7pfQySymaFXAfsaeKvQ=; b=K9jGRamBVrd0w7DNa2shE3NtjL6bXeDgyplWHR1r4oaAm//Z4M3xAGY0+oGwMrHu0AxVwhVKAo9fn5A/xIWI04ziaeuG/BI7F8rVL6nUGiYyYoIV/TjrwproV1f865dZ+zU4/mTR5ROxAqgSxZwOn/oRH7iNaYRgpiDUaqMjYFpkKvIkD54+OtS7pOmB+OHWy/ITdNg0C9J1p0UpeZ+P6JyKWSE1I6pcph8n965RU4tJOYeL8bqiE8JDz99DAsWFYawmD0ZH2kFqLjznmB05d8SBXIcEHVhHfpybiRTTSFgVyLGZZ8OChQutFvrc1LhuYDZmXPGpS2VJFa+bXRpn0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH3PR11MB7347.namprd11.prod.outlook.com (2603:10b6:610:14f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.19; Fri, 12 May 2023 06:40:12 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6387.024; Fri, 12 May 2023 06:40:12 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Dong, Eric" , "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [PATCH v2 3/5] MdeModulePkg/DxeIpl: Align Page table Level setting with previous level. Thread-Topic: [PATCH v2 3/5] MdeModulePkg/DxeIpl: Align Page table Level setting with previous level. Thread-Index: AQHZhIh5Wr3bTHE34EiDAnQll2vVO69WL6Ew Date: Fri, 12 May 2023 06:40:11 +0000 Message-ID: References: <20230512041548.6416-1-jiaxin.wu@intel.com> <20230512041548.6416-4-jiaxin.wu@intel.com> In-Reply-To: <20230512041548.6416-4-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH3PR11MB7347:EE_ x-ms-office365-filtering-correlation-id: ca4e3c13-94a1-4615-9bf5-08db52b3bc8b x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lfz9Zvp2C1gbbz14NP32PELLqO6Xnepfz74lZ3nnaIqylJqTGGH8ZZ+zOXWTQrZ7aeQy+5jIz8aSK44SkRzfJOteoqiKmZhftU2N9/MLQ2EoW9D82sOJ3FgM+nUC7a5SQ1Fki1YlSZihwBnxZ+9HWCSgXkBAKARWgTEykYWEe0APCJrIAVNSRtYTZGocFwrYS9FI+YzxR5hOhzD/YiiAtDRvqC9R26QDifzNIRw144YeUcD15SrNb+49W/ZV4kqRWgI6Ru6ZtKF0qViiM1F0BxXwZUD2M1m6EOJTqV3uNB2QjCJp0BmgAM3YElWBfZSoOcDtnbhX24uToH+0Nxg8ijeAU4iArgTrvXkWtIkb/+0bgD/csicSxHI912UKcNVgYWJgCSDQc3Re/32Sr+Mjxq+Z4tomQJ9lhB/5gU5gpYb/6C+bPbgn3p/aO5tnn3bg2UeHZbGfLtI8/9cFkkTaA8jr6h8JrstnL+wrlRm1OiHkNA13B/OwLwTynP2ygpL2Rryuv+OCEWCec/Mh2FodXPAFeL84I7WfJVAQUnxCwb0EsQ1qXTnMTMZx2xhJfsZLDYH3VfQ0pCYK8972qAOI/Lhor1U3bcrHh28Hs7o/rj6NlJVibpNzEMnQ/VA+YvJ6 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(396003)(346002)(366004)(376002)(451199021)(8676002)(66556008)(2906002)(9686003)(4326008)(66946007)(186003)(4744005)(66476007)(71200400001)(41300700001)(66446008)(316002)(54906003)(76116006)(110136005)(64756008)(6506007)(5660300002)(107886003)(478600001)(55016003)(8936002)(7696005)(52536014)(38070700005)(38100700002)(86362001)(33656002)(82960400001)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bwtrmd9baOXwDl115U/Msp6WR+v3pLK89l0MBjhUMf4Mx2AVoPVy31aILDcQ?= =?us-ascii?Q?Rc+MV0x7bewciePj8M1CTZwHVr7qvTJMXADTVyx9UCzstZI3mMRDUrzETfBH?= =?us-ascii?Q?70fiIYLhfhxjCEnocqCwCo8MGSTPkrMBi6UX9/E++69te1Hdc5Yc1susUJCS?= =?us-ascii?Q?df5qO2Y/+mkRqwzEYWMB8DyqAKinNHLyMEc/ShvDI/PKdDMplbJB7jZjxJd5?= =?us-ascii?Q?sGjvtlYwD2ABRtP61Kiv8ZIMmH8ADP+hzFadoZLl+H7CLmWwXqjdfwYLYccU?= =?us-ascii?Q?uprRs+bYDZ+S0mEyzSGNUyQ1v3PLVZdu/nFCFpBXtpWXkIIGkQ85qSCow/cM?= =?us-ascii?Q?NpEmR9EtHxiGI2IhtJ81SdQd5R5yk5Wpr5oS/sjhSKoGrbQJRWoaWW53hkTk?= =?us-ascii?Q?gD+Vx6TfhbP86A1eDoxnoge619vqlfgiQc8byk+NPlZ0xDb6AlnCgwVXaAfZ?= =?us-ascii?Q?EzzHTcki7VtG+/EYvi46Es0gefppJh+zNttvcwH0qAaZ6XOwvWeVEMhvbrrw?= =?us-ascii?Q?4Lm75+dUPOZ2NceiaKjkrhhplF/YMNtXJFioBsihbLL+SGXncR/v8PdpRN/a?= =?us-ascii?Q?57nCzjk8H4OXnHtP9Kp0IRly2F8Q10LlDoDIrjC03Jmom03nIU0jq94vLYg3?= =?us-ascii?Q?EPio51w5ZK1IEXVseW2sI3icmMQHu54jFOiYH1ogwmI28VGkNLoyJeMGJBWN?= =?us-ascii?Q?DOSsZuvtGqtTmswN1qjdHbY2q6Le75ykG9PkIGEYQBUx9iLS/FjsePG+qF7Q?= =?us-ascii?Q?o3j3JYjttwh1BUOFRPs5cGHrKyEdv+IZ+Dwv8Mhj/TNWv7CXTgPCjrJNA4g/?= =?us-ascii?Q?bYA3dxg1r3g0VSv/+EopCY0cOhOyVm9AN/LSTHjIPzlmXVnwdZ0PoBn7GPcd?= =?us-ascii?Q?2xXiPGLn1dcAvuBe+yKAo3qIK4FyfJaxPj3JFPFnTa00qI0F0yteRbCO/pUh?= =?us-ascii?Q?OUEhMvBSxY+X/DES5Yac4EbbZGSnBOqcytvinUNI6ApqhWimsUiYDOGeEdhV?= =?us-ascii?Q?lLqLJz6ddl0oJDjN4NniWzN5rIv5uTc+03QCnNOv8m4d75qs26xi9ZOrCQ09?= =?us-ascii?Q?WhquOX9DtqyPqqr5kQviAbD6pnEi3arqtQ6JrRl5Bfu2A3tLRPc9v3vo9ARQ?= =?us-ascii?Q?VgQb0U3wrdmnr1gIcCZuc6W6uvqT6Xnp1d8HRToaw37ztyQNwoX62v2ZVs+L?= =?us-ascii?Q?a0xTfYECtSLsYi8VeKxVP9OxYm3TZGGZ8fqdRaDko0UgKUQ2YCP2JbjIzrZc?= =?us-ascii?Q?v1eM/hdJm0+mh5iHGlg2a4pgRnmyGib6ewVe54UUGh53dJTkKnaytlJNtAhU?= =?us-ascii?Q?VPJpyYDBiKLBEA7VwzIRkB8lsrjAzhYdDCqNqacQoAkBo8GOeJ0nDboJPLRz?= =?us-ascii?Q?LBwO2ZHEuyHEFuPUznJXMv6N58g4DRi/ciyyfC9HBowbUV08bLxPD1HgkCdz?= =?us-ascii?Q?q2tcVO44EmrYk9JdbsdgNzGQqq0cej8eM6kZg4NYhUGBRjZ4ZSFFTRe7czrd?= =?us-ascii?Q?YI8i4MQdcfSQfLgGieMdCXSUdMV3gZr5FTtxwdHZ4++2CLyiQ1VNg+WoZA?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca4e3c13-94a1-4615-9bf5-08db52b3bc8b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2023 06:40:11.8343 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8HFKi5hhJ7RHDuLtfXtWB9PoDREehJx1BcHJR8YD47pZuS5ozcgfdBTpGy/iePBuSSZW3g6TMgBytUZkvEOuHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7347 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > + // > + // Check cpu runs in 64bit long mode or 32bit protected mode. 1. this comment seems to be redundant. > + // > + if (sizeof (UINTN) =3D=3D sizeof (UINT64)) { > + // > + // If cpu has already runned in 64bit long mode PEI, Page table Leve= l in DXE > must align with previous level. 2. runned -> run > + // > + Cr4.UintN =3D AsmReadCr4 (); > + Page5LevelSupport =3D Cr4.Bits.LA57 ? TRUE : FALSE; 3. "Cr4.Bits.LA57 !=3D 0" > + ASSERT (PcdGetBool (PcdUse5LevelPageTable) =3D=3D Page5LevelSupport)= ; 4. Good check!