From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.64017.1679539536857330005 for ; Wed, 22 Mar 2023 19:45:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Hs3XxeXr; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679539536; x=1711075536; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PV4VsO6ksYQM4Wlb5YS7QHW03p+ambpvWMVnZEBLF7Y=; b=Hs3XxeXr/5hwtxQm99G0d5DhjMc6vDa5gU0BY6QE1D5M+WhzHTAJVXl1 4m1gVQ+4BwhZw8HtwoHHw0BLVi3ao5XvyeHxdiE2q4A3341vYhmD+nQcf JrGUGeILKvcqfBB3fC7H+TTmDvbFWIv5fBzoIdDaWPPXeLoLYgyWAnxWG a+sSljJzk5dBk3eIH49Gx1g9SXCp1IocMSm/NkfQvKN2Oa6Lli/U60Hd7 oC69Q8xyFefqVKSAaNKAkrBJ1IyO1EJP6m8EYSHpDR51e4UZlmBYF2eZw W5zBlSGN2LfLr5+dR12O3oJYWHLiQdpT17qSLFGPIrTeJbNkh4gvXnlhE Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="338100934" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="338100934" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 19:45:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="751305690" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="751305690" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 22 Mar 2023 19:45:35 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 22 Mar 2023 19:45:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 22 Mar 2023 19:45:35 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 22 Mar 2023 19:45:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V9Uj9+9Ed59AYNoezXo5DZ+TBy/zHJk4vKgxU59ic65/XOGDVFBgZXvflsSDdZjRLq/t/Y9BVGzUAIeymj/K8LvRrurdwuBUlzrH6gwOKsWif09+2X/xaXKH4xoc3mN/IlGT+fgBJDF69oG16Tc7GBIy1qj5NPCg3WkDIygrryKCm8JzOOEdX43LHG4VnPCcIHgJHL5EXXg821djFm82MSibtSbGpEy33XkWytznWNgNJ70lSxi+PaJ0XqwR8hJRwvDeSA/HpnvHkjuPm/fKKFdOJkRfnj64eyWGqCSkrSJx1S8Zp5Qg1a3bTjsH+xSow28MZUIORre2mw8nmJA/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NGTMtjukf65yF2TQGsdJn9EBxOcNLiVxHIWuY9fbWbk=; b=Owv7wzcmaWD7Thcj41MtfDHwurMUa3FYITOVPfNE/lpOyEnF6m6mL5fWNkVKUfVnmZD3RTdA373KKTIuXoBIEP9liPnFOqYSsaDJWBvYccT3GPv3bvDKvviz4WHSVVbCjXGkTk0Y41oHzrOx8rhXWYd8zxK9rrs+47Yy1CpsRqeYnsIdSfp1t/HhjZDYy5c8QATym1+vhac8fTxkWf2oawgO9vEwOCYYHi5kff+K3YmsecoeV9j5oxjTDAi4zVoXsQyuW+9FK31PolNpkp08juCKtuqd6DwZ7O0dmRmNME3R8ycIas7aWOHAeUS2vHcFfphsW/5bZ5yYGx8k8hHGUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CO6PR11MB5619.namprd11.prod.outlook.com (2603:10b6:5:358::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Thu, 23 Mar 2023 02:45:33 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.037; Thu, 23 Mar 2023 02:45:33 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Pawel Polawski , "Kumar, Rahul R" , Oliver Steffen , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug Thread-Topic: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug Thread-Index: AQHZUO9J2NWxJ7VKpkimWiO1203cE68DhjgggAGvcACAAotyQA== Date: Thu, 23 Mar 2023 02:45:33 +0000 Message-ID: References: <20230307122037.3100651-1-kraxel@redhat.com> <20230321115334.zq2spdxy3gfpvy2q@sirius.home.kraxel.org> In-Reply-To: <20230321115334.zq2spdxy3gfpvy2q@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CO6PR11MB5619:EE_ x-ms-office365-filtering-correlation-id: d03a9848-2fd4-4df3-0584-08db2b48ac92 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ygdeapIy6+qOWcGCyn4lMx48lU8AhbeqYAtt/Xy3tM1KO5rWFELYlee4pAtMQ1gYXtuGm9/SpELXO4ItV8g21yV4joVuiiWVvSJFh+kkI97WlYnXs0TorfPpGgLEFrQ1SK23mJTTsudvYTrGwW13tgXOpTMMYB5gnbapeY41NmYe6YKDb5TpKYN2XqHi9cI/71XuqzdaYScWhJwn1Z9VVq9H3fEM2+0ZYMvplPXerINA/yGIhgFYXr5x+OaaG52QK2W6HclGEDLVr/tJGbnUS07eTsrJoSY63oEvrN4cMhfzDHjYjhlwJj6rhLPKxDZSSJrJste5Km6i0iPgB/0DL9JD6l+row1TuvGeXU/Q+mMjhYDB8zKIip4stO2KR/fwMsUY2TUYvkmp7IX38tf9AoZleQiriqJI/jKvC8brW5PWjYbKzYWKpj4E3DH5WvdRh4UVLRHfSnDByiE2QPoasRIqtI+J+E2PiASc+xJrQ/mihsqjosUI8Y8LM23tZoTfC8xi1k28ZyuQhs0rpmj47XZfWbS+wt6vlXAPBBfa+pV4lfeBFlAuOjbR+2haVGrlkL677395pPRMsXzohWZQ8/SDa4iya+CZkAkdVl5RERSyu77NqmFwvr6hF1I/zfwmBqG5k0fWsimwV5ascmCLlnoQRvbTT1kyVC+jiQji9ild8quwOZrC9EU5OymbM1CaaoS6p5Lmx111vOQ81oI9M3CcGAEM5wqUMhiSgHytQAQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(396003)(366004)(376002)(346002)(136003)(39860400002)(451199018)(2906002)(110136005)(54906003)(86362001)(316002)(122000001)(38100700002)(83380400001)(38070700005)(9686003)(82960400001)(26005)(966005)(107886003)(478600001)(71200400001)(7696005)(186003)(53546011)(55016003)(6506007)(33656002)(8936002)(8676002)(41300700001)(52536014)(5660300002)(66899018)(66446008)(64756008)(4326008)(66556008)(66476007)(66946007)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?atbBM7C2E58xWxgS+FQzifug03EoV2h1iw2PZB6pzXPLFbChjnY/eDBTHWTQ?= =?us-ascii?Q?x4q0kGRPVj19c4vbCmDjN4PbzfxFm2wOJPr7RaimAs1fTbNS64KBa9kmb3Dl?= =?us-ascii?Q?6ijSdcm1yE6LC9pkBid4HdYoeIg9t78gMy1NPvRxW5IigH+KIYZJ/BqSgIce?= =?us-ascii?Q?LBYFQ3XgOHknngvRoMKH2ONchrWvk2qgfTRxtJ7k3KW8NtiJx9vYN2u0Y87l?= =?us-ascii?Q?DVuwZpC6OlBy3/3MljDUbuxu5uT4hU+0C7kcQz18cNnXc9J6nbHkksZQGSiL?= =?us-ascii?Q?aSXVNshiGhiPbhgJRJ+hiB+eLERVJZ5hmWqZuPPPaccP61pbendm99WGM7Zl?= =?us-ascii?Q?tEMmfkxZhrAeUHMPK9uuR/YLTVvs96gYapBRvP5REe6sWOJo175waN3FXaAt?= =?us-ascii?Q?y0635FGNrwm9GddCPumZv2pPaSp7Ru9gzrAUg0f+W1EeqQAbUYo+uSW1Zljp?= =?us-ascii?Q?6VVdASc1Psww0IksSdIkJYAwIoNdV8QRdBZ9IIlaW8oRfCpT33RbeQlrKvEL?= =?us-ascii?Q?Ifu0+C6gxmOoqqmohHvWB9oOrDzvl1ZQ+lTu3TWZqLg7vd44fhbWq1H58jK/?= =?us-ascii?Q?gEu3GBxS12U2WX1gEHjehINUfDjqVAQ3Yp8OX8Xw7KOhbopwmDnMz55+j57C?= =?us-ascii?Q?4ISvVWSOnGijFM1nJQLqrw6/GB4pHh4JFec6M7ws+bW/m+QeFV3cwjz0At4j?= =?us-ascii?Q?5kLvo+kBlxbKvLn1ZyWSJ/qoGn6Qg31VNaByDqcROfgWIUzBd+Nbh5BQ00X1?= =?us-ascii?Q?+zvVWTEBwj4PNkG3mDE+CvdwxYgtTt156RUc+kw/Hh53Yr4u+VYk/QpnBHwt?= =?us-ascii?Q?aUar4zocGIRG29pQsp/Q52iaFFYpolb4BkHAdX7sn+MSyTMo8KPYCk5Cl0NS?= =?us-ascii?Q?g/jstlYqLpTSE2EJOtgpOInFWO0AkwuGXS41qn8JcAz7mBUC3ziCEWGP5WA/?= =?us-ascii?Q?jmw6pCW+R5hkaNBp2Wwf2VtLlq3V1x4Sr7C2onCc82r3UNQWjKnjug/7TnIR?= =?us-ascii?Q?G5cEhXIFktKAzr5YiEC48BRE2VLQtjJ0XoOGoswCRA4w1tvmWIAHvUSkqQjJ?= =?us-ascii?Q?t23wwPr0ybJ6Kdhntb2J5+PidruVeNuwASvzczbwfn1L0SidZayyuYy7ItcL?= =?us-ascii?Q?rNUK6/PMZxmEuGn5zjbpLIeSL9WmRF86AOKn2bsjPw9ZWMcP/zyGLfwDijzB?= =?us-ascii?Q?aDj7DXpjpeOvI1j3vCCeJDwkm3/Mb01uueSLQNljvvtxzkJ3UiIqtiP2a9iV?= =?us-ascii?Q?fPTbMyP1UPoQYuIiX4F9Bi/2HrCqdvyY18Em0OgRuKbQAjI7Dd+3uQpUJW5S?= =?us-ascii?Q?nzp14zyqOob5tdIQsaCSShsCypH0QHK05zP+ruKpeZ8rMdgN2Ih7A3yrqqn2?= =?us-ascii?Q?0hbDFsSBgb9foGmjZo+2xwPUjv/UYTVwbtTCrlTVlwLhzV8+2NpK5Fm47FPa?= =?us-ascii?Q?wviNwRL0lv0t9KppJefQo7FZ/ftOOIfVg4AACXf+G+IgPLesdSTx0RN0QTrJ?= =?us-ascii?Q?6m++tbG28jbahQAvhKwZrEuMaPiT+2na2rhEZaAIf43DbeGzYhj9fFIqu+uR?= =?us-ascii?Q?DAmnHEObQ/VBf2JKCOE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d03a9848-2fd4-4df3-0584-08db2b48ac92 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2023 02:45:33.5322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GUBZUPwbFBKQSmfvvAyPKFDVmpnI6OviOWcvilsE/eCOhncED4f/oplszr1ZokOneD+ujZR/QQbayRm4BF5ilQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5619 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for confirming that. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Tuesday, March 21, 2023 7:54 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; Pawel Polawski ; Kumar, > Rahul R ; Oliver Steffen ; > Dong, Eric > Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode > for cpu hotplug >=20 > On Tue, Mar 21, 2023 at 07:28:44AM +0000, Ni, Ray wrote: > > > + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) && > > > + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255)) > > > + { > > > + X2Apic =3D TRUE; > > > > Gerd, > > I agree with your needs that want X2 APIC even the actual processor > number in BIOS phase <=3D 255. > > > > Question: Is it possible that BIOS stays at XAPIC, and later OS switche= s to X2 > APIC when the maximum CPU count > 255? >=20 > Linux doesn't do that. In case x2apic mode is not active at boot the > number of CPUs will be limited to 255. >=20 > > I am thinking about adding a new PCD to tell MP code switch to x2 apic > > in the first time AP wakes up. Possible timeline for the code change > > is about within 1 month. Do you think it can meet your needs? >=20 > So the idea being that OVMF simply sets that PCD if needed (probably at > the same place where PcdCpuMaxLogicalProcessorNumber is set)? That > would work too. >=20 > take care, > Gerd >=20 >=20 >=20 >=20 >=20