From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BA4917803CF for ; Tue, 28 Nov 2023 08:56:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KC5JAgY2o4x/xscx1K7Q26Y02/14yjaQQAHv7CkP9Oc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701161767; v=1; b=cAxLThZ9FOiopFSqu3AD5SourbbUd+OKDABYue7pSh1SBtU8jo7l7blYZpR/nBojyeYUkxYr ItfkT0Ymf/Gyhv66zkmeJjOIpeAA6YjSLMToFL41QJuoor/nk3aj0t1FvDtwKggeLGWOAskGcdu Khr1KbkXSxH4BvKnBy1g8Wvs= X-Received: by 127.0.0.2 with SMTP id naT2YY7687511xPzdcJxDoyC; Tue, 28 Nov 2023 00:56:07 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.28611.1701161766511328203 for ; Tue, 28 Nov 2023 00:56:06 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10907"; a="372251182" X-IronPort-AV: E=Sophos;i="6.04,233,1695711600"; d="scan'208";a="372251182" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 00:55:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10907"; a="744835917" X-IronPort-AV: E=Sophos;i="6.04,233,1695711600"; d="scan'208";a="744835917" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Nov 2023 00:55:47 -0800 X-Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 28 Nov 2023 00:55:46 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 28 Nov 2023 00:55:46 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 28 Nov 2023 00:55:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mKa4wOifSBLQg/0SvoSGk6e2Ie/nbTvnCELnhfISp4U54mCKyUg9AJl9d65QFvc+9mF3NefBYTyl0sZh8w8JJayyec24thA15nxoKT2/B8VPRdmZM2bTldfUQieLuG2IdfXPyYfyNDK3cuCmfh6CulIg7nT1rjk4UqU8LkZVoVD/FpAs3iERQp5C+CXCEM1R8I0lrrrtF403zx2fEMT3qPJeweWh3xTVoQJ+ZIj+iY52Ebc8MBLToADaj64/7Qrc0yn5lMxagcOpRuDiyX2iJ7RKO/dR5QHruxBZlmfiXPMq+EDRpBaZPGzKlWDoj0necH7vBnT9vCcPKew0XQe4wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aMn2Oun3DKK+clyDsuvwlsu+9uycWKkbWCRDFj9oIy0=; b=kbvZwRkYyLLUu+9zrfwkst3rriFgzbtLDi3PpCvKGB3YqE0a8bcs08yhbdinQtcf0PhgHJZ1JG4d6rZae4VJgADh8bNKlFrMgkjm95SdtpfLTYrzen0lQkXEi5XPHsOCH8RleG3pmA8/M3tW9jDr2o7Zx219Vsa7Jmd86NF8nmmtARDLk/ZDRbwO8srXTVwrrtIdWHiGW5knC6N+ejZquxQDysUu2h42c6GlIRPtB+b6oX5NUthiAk3fD32xKnk+QUE+bt99ZTOGq1GBr95WmRdRBGGOjrQaNkLXYgy14snitaUz1JPDWq5L4HpD2BNouP+1k1yP3kKxA5E2yRfvDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SA2PR11MB4907.namprd11.prod.outlook.com (2603:10b6:806:111::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.25; Tue, 28 Nov 2023 08:55:39 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 08:55:39 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Kumar, Rahul R" , Gerd Hoffmann , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Use NonSmm BSP as default SMM BSP. Thread-Topic: [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Use NonSmm BSP as default SMM BSP. Thread-Index: AQHaHbxwKRgmtrSCV0OQf07FndeP6rCPdZ9w Date: Tue, 28 Nov 2023 08:55:38 +0000 Message-ID: References: <20231123032314.4353-1-zhiguang.liu@intel.com> In-Reply-To: <20231123032314.4353-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SA2PR11MB4907:EE_ x-ms-office365-filtering-correlation-id: d5dd4b0b-0a2f-4f44-a6ba-08dbefefcb20 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Y/uE96iLh+egaZaQgvylmP6eYYIDPszLumCcuvLOzgmt/4OswBOvpvNlyrpQP7H1ffGftJleZN4I5WQaGW6ZIfYtJuUHvG0GV7Qk+GYHZe7ZuSu05W40erV6BZO+tmc2z+FoKpyEzJGJlfFdvBGyPxZYRuCwxYXs8jLeFp7cyRMaqC6V28ushghP5Triep+L10u3ks4RTJa8rMQOhkYkLcV46yA62//0q1fCIg38W3oK0U8mp2Zs961OY/YgHLcexX3iicpHHD+LkN7CEfpX3bec+T0Y4tAA/T43UCrEtKG2ZE9Ar9LFMhneTfOncuaTNz8tR6/xmY82A48l2MP5FX+mURIh/ajDLyQ96u35K3e0M+vVfCAaHwFEn6fus0RmkLxS+tv6pq44FwGAg4InscrrhU5X7lcXnjO6765wuKmJB2OuKt7AtM49CX9cH/yATGKArr/tUCzmrMGQzgN0g6NVh50yjpI0kHGjxtrQB0bTSV2i0pmLPPVWNSHiaHyzmql8TBl599Yw3Jm9n18SOyfn9CHTOQA1f44hOsOKtp0TamQj93MsR2zES212DHR/4+DTG1drDK8SbPyoQx2P/3EQzr8vSzq+zIdHgi8UIm3+n38LoNIdDxLzZgLBu5+c x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Gu9GXopuv0yUMMwSquT/O3MtjHWUbJSZxv1YTqu5sy/i6T0IE2On6vVWC+0k?= =?us-ascii?Q?CpejGlCXlQouBf567mXPAdi+jniY24G4saGVpiCBLQ1n6INWEVHcjiB9VLGb?= =?us-ascii?Q?/SfKZYtcrKAci9yeFp1RdN6pBIyc+lqWS70qCk59J7Dqel0ry9KaC22MmV/I?= =?us-ascii?Q?OYFrt63I5Vmkl14EamfldWcxysJDVmLpbUjxI0Tnh7QXQOeKc9LJM4XAnIIj?= =?us-ascii?Q?hioFowFc7GGAP153i2xmUp9vMVtbpJ51AxTiwvJWLDFayzxfp52MMP/OR7AU?= =?us-ascii?Q?uGjSUpOagqlUmkgsQHk5i38+jDxXu7JpPTTHyZ8HwRgapS8GcUq3b8tZz3Fu?= =?us-ascii?Q?Ejy0eAw9mogwyzfY3nExLAKKHPmWtYg3ihNYg/NrXs6XzowHrPAYpUM3+MJX?= =?us-ascii?Q?PdpzRx3WYsQhGIS3mE7pOYEsRToVPFXCmr9PBWdQTd8cZ1kt1gSKtCPCn4I4?= =?us-ascii?Q?/9JFPnsjg/tcANCRmaVemYpOt/6k2QuQcbxH7AsDgJrdlnZkBZKFv9Fm8wr2?= =?us-ascii?Q?20+DFUn1VsBJsyl8HTlP+xm2Lc4yDGm8HPxReZSdeMX7eim3qpa98r3xO0a3?= =?us-ascii?Q?u2+plfMlB1oR7Bvheagomuw9dHkcnRSV7G+E2OMaqGbCSncIJnQ5QwwAoMmY?= =?us-ascii?Q?KeLaReKYuuJ95Tub6r0NLznOS67uxgdWD5tiB60wFtfz+w2LbcifqgWorfsx?= =?us-ascii?Q?uUeLA7RaPNarRqwbCULxjqCVp75pN/rc+sCS6L7/0cE2xLKUfdfMkV9vA3ia?= =?us-ascii?Q?i1/UoCWaijgLz83ArzgmoVs7jk2dyauYrbVpd4i4SlrxqREauwmPMsD35Uf4?= =?us-ascii?Q?+Ut9HisGoarFjqlPDz9VLCKVS/n23fAuAm/4O4J9jFywJvpJb9xElFF2v+SW?= =?us-ascii?Q?kkIEWlD7eD3Eiq4NPt7Lq8Zo05vNICXjOyenLQ7Qd9Rjxw2pPbDPK1iTXipN?= =?us-ascii?Q?CyW/R27c+kmvnr698sdDmeZPdk+A2PapKrJeDgDaDDFOFulXig+3UmupU7Y6?= =?us-ascii?Q?PlzgPKjCM5sWpXXjEZHROjiaxcTHJqA8+zOdTnyS5jNoLhPr93q8JjBcV8jL?= =?us-ascii?Q?hoOaSSFsN37Kvy7dGp4kh2KtPYsnstof1q2Y6rjUaqLXuzkjp4yzkXtqfHJO?= =?us-ascii?Q?uPgLdIMIglukbGFLs518ILktIOxHd7SVSRLPeM+Hpae0nxazbFPz9/IsPWof?= =?us-ascii?Q?KIVvJSer0bDaUTwPp0nPDrjzlW2jq7r4RWi/EDauH53JQv+SPPVKUB1QRtPu?= =?us-ascii?Q?gdzxgOsX4Q2Smf9cSZ7C7CXzFDjK0w5aydlTYLXpJBeIghpynCIcyZrt2UJd?= =?us-ascii?Q?TJJ6NkPuLXQWTo6Q0W5Pcbfa6oeiu4NdZP8F0SXUTp7Jumh4+9/5+8wyLqDu?= =?us-ascii?Q?Ailn6tkQCufhgT6IFihZUVhGqkshijoNuf5Qi2F3EqwXZIxe1T9lbrsI2lDN?= =?us-ascii?Q?AjFxlBxCuvgyTxseIiHc9nhT9hCVl9nQ9X4tYrHaHRX0LDEWG25HhXPuQBuu?= =?us-ascii?Q?yLYeYB2ejQAnxzo/oRtH3R9wMNKfpgMKTxrryMhzpaY0Zkb1nUWlDqiUMEkT?= =?us-ascii?Q?rDCgv60AQKnbFe18J7s=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5dd4b0b-0a2f-4f44-a6ba-08dbefefcb20 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 08:55:38.6766 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LhWO4i8B1UPowtpvUP1SytWNMniegHkOI3IpsXbVNsDPdvx1mTBucPVU3eQ/pe1tscn03PElAifG4iQGhhJjGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4907 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: R3ey0fH4LDTGVP9BLvf09NQEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cAxLThZ9; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: Liu, Zhiguang > Sent: Thursday, November 23, 2023 11:23 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Ni, Ray ; > Kumar, Rahul R ; Gerd Hoffmann > ; Laszlo Ersek > Subject: [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Use NonSmm BSP as > default SMM BSP. >=20 > Currently, if BSP election is not enabled, will use Core0 as SMM BSP. > However, Core0 does not always have the highest performance. > So, we can used NonSmm BSP as default BSP. > This will take effect in normal SMM init flow and S3 boot flow. > In normal SMM flow, the code is executed in Non-SMM mode. > In S3 flow, the code is executed in Non-SMM BSP's first SMI, where the > gSmmCpuPrivate keeps the data from last boot. >=20 > V3: > Add more commit message explaining S3 flow. >=20 > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Laszlo Ersek > Signed-off-by: Zhiguang Liu > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index 25d058c5b9..b279f5dfcc 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1953,6 +1953,16 @@ InitializeMpSyncData ( > // Enable BSP election by setting BspIndex to -1 > // > mSmmMpSyncData->BspIndex =3D (UINT32)-1; > + } else { > + // > + // Use NonSMM BSP as SMM BSP > + // > + for (CpuIndex =3D 0; CpuIndex < > gSmmCpuPrivate->SmmCoreEntryContext.NumberOfCpus; CpuIndex++) { > + if (GetApicId () =3D=3D > gSmmCpuPrivate->ProcessorInfo[CpuIndex].ProcessorId) { > + mSmmMpSyncData->BspIndex =3D (UINT32)CpuIndex; > + break; > + } > + } > } >=20 > mSmmMpSyncData->EffectiveSyncMode =3D mCpuSmmSyncMode; > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111802): https://edk2.groups.io/g/devel/message/111802 Mute This Topic: https://groups.io/mt/102761712/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-