From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0E9359414A4 for ; Fri, 8 Dec 2023 08:24:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KKxhUl/WofP9Bzi6K0vizLw2N4KpXldk5B8adbzRo3E=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702023845; v=1; b=frJXAVtv9WyWg/UuYeElTsqvoDrxgmjUHybQs7iMosOHyebMEoVdbQrEHKAtJ/yOB+k04qJE qUxWDkc3v9WgXLSwNDfJvuJPTPyvrgtx5t3+I8nYTLHxLwN8iExk96Rq1Rwc+4AetG6FEfzQ+O8 Sw+8mul5vOLs5tdN2qXoGs70= X-Received: by 127.0.0.2 with SMTP id 8vuNYY7687511xaMU0mLAyCs; Fri, 08 Dec 2023 00:24:05 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mx.groups.io with SMTP id smtpd.web10.15920.1702023845151725012 for ; Fri, 08 Dec 2023 00:24:05 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10917"; a="1442046" X-IronPort-AV: E=Sophos;i="6.04,260,1695711600"; d="scan'208";a="1442046" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2023 00:24:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,260,1695711600"; d="scan'208";a="13412412" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Dec 2023 00:24:05 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 8 Dec 2023 00:24:03 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 8 Dec 2023 00:24:03 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 8 Dec 2023 00:24:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JJwc4/Y70ogsmUL91hg9rkHBwQdcGYK0lZGt8zs753mpj2hhUiMRW0vtul1ubH7//Y6gGdpSDbkwRriW7N+7NBc8ToBlS/dzExqfV7X0PDWwVJkwKhxM0LoLDwA7YenWpjGegO3A+JSrLQzYIuAdc+LrgYm1bbscQly1vaKmRlafEfCbxQ//5pl/PixP5iq2AKlJ5EcOgXKEDTKOvXGiL7c8Rc1CPahhnoIYwehb8tFR5saqXP8FCjMDYrRMFFCl7kFExnu2nifALBOipWSWtrm5Wqkv9MKAogJF+aeVkIEs297FiQsNMRm7z2g+lKKWpD7YPJo2wkE/EUz52wRBbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yL79oDJWWP39CrN9b1WKsJdGJJcGEcFEsjpa08kAL+Q=; b=BoOLEyPpLbCMNkNkIaX55xepX5av1s2N33oJNQyJBQwBsiJ3GAuLGcQj2clfJdCmiqwtcrfvEjPgwNMk5JSNGzWjAY99QOmerD5jbtr7nP4gXUVpYcSKVXrda58zfK10ghUNAQxZVIzwxuyMIP+Xf8v/SsqtJoW6Uf893KIi+aKci0FKddEn6IdvWr8zObe/P7cWztHWMkZNkUEXD5aztzEA618WnBqEIabfvqZSEIoGMUIbHkFaAAuycjDk6Vno6Iip7vBqibM9BL9Y59cqqpa08m4a44tWGof0f09JKFCfVimR9sRwOEVn7X9z1Yztf2YGNzVDXlLMYRpcIjNvMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DM4PR11MB6286.namprd11.prod.outlook.com (2603:10b6:8:a7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Fri, 8 Dec 2023 08:24:01 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7068.027; Fri, 8 Dec 2023 08:24:01 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V2 1/6] UefiCpuPkg: Create gMpInformationHobGuid2 in UefiCpuPkg Thread-Topic: [Patch V2 1/6] UefiCpuPkg: Create gMpInformationHobGuid2 in UefiCpuPkg Thread-Index: AQHaKN+aWY1M8BKNUEOfglEAdkyjrrCfDdEw Date: Fri, 8 Dec 2023 08:24:00 +0000 Message-ID: References: <20231207073230.264-1-dun.tan@intel.com> <20231207073230.264-2-dun.tan@intel.com> In-Reply-To: <20231207073230.264-2-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DM4PR11MB6286:EE_ x-ms-office365-filtering-correlation-id: d6b68f51-44f0-491c-6772-08dbf7c70828 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: mLOOpv4JNJ+/P5+8fUqnL1f+Fu/+MMwIZB7h0UAoh5lU0qV31FX0o2D8P7gILESWr3wxbXmOLWdUkhkbZA7cYmAu6uZlfKq0Hb5gku3xQYSMTuNTC77SCldf6OVZ2LaPGTe5kJtbabas8qJ/5BF/Ab5cRd70xlfwY2g1Rtv5/l3XCXgX/yas0xEQU3bbBpipQfDgwbLV7NjuwuDzzTq5va+hmqeB+KbWkBjSdHSHHb42vOFk++m6G8QXk4+1nFo9mm7+4qvrxEjhAeKm+TH+mbnnp//J73hOilfJMYL099G+wKwfs97gGCSQZXGlAdZWV/jauMAT8/Ra8ND3t8Qhnxa7vG1dX4JBHchiMnBU9+N7ZWuC4qDZEzOLNt+6ocnycBvvGGpS0M2Ztdpn4hxQO8ONroYNqWB4JU7o5uWYw7rWnTYrZX7+eAqYDBuancxBGhs4zmg2tJ+7SbGD+bIEVtDvUQbn2PfWHj8Xd9UALED0h8lEqkestel7c4jhjYe8kU7HddMHkEEFz9YsTDkxX1CMI3LlSJ1wI8q2VedP/nkpO1Ujd2OWQvS3fJ482aOA0rK6Tswx55V+DTS9DYUv3yVGHuJDZn9Iw+Tj01GhdEmMux3nl2ABDIZkO9r/N5zP x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WzgrF6oaAfhyz8p7ABtaoVu8uF4almkWVAJgpvgAL+CMMLsS3oMoKAWp7AIk?= =?us-ascii?Q?+l4vt/cy4vYW+SuKq3H+QJdWZtS2/USvlxyUDwyeX5VgMsWjPveZSQi3zMXS?= =?us-ascii?Q?GODeHzY5STEemT0uyc9WkBVPRQxSVW0QToFFhTPvBTU/gDmVdcFNjBKlzm+J?= =?us-ascii?Q?ZUx8YZU+7rO4xyMWuIZn9a36f5c1l6a8r20vvg2SQzi3J47LAY+lLT2KFL3Y?= =?us-ascii?Q?30LxMSChiYYM866HObYcC8bShX1E/n+MLxivieCJ82rXBKjuv3CJo5WpueK2?= =?us-ascii?Q?DsEkQMkkt3Oc4fvCKvkuUV+5AXsbEvf9Ic4o+iVcKzvMph1r9E0XRDpajExf?= =?us-ascii?Q?mOX7zhfqZdrYwNP4sODMldltAI7pFyKQt6EY2RzykRQIzCbDnDttBQFHh7/p?= =?us-ascii?Q?C/MSiWRSc++Q4F5v1A6EgfZmVXlJ+nz7yEJZ7LACQ60afAzLOzR3iFiBLKZk?= =?us-ascii?Q?Q3BGSpMpE+nYzCjNR2NQBW7guHw/vL3GVZ6lLvhuo6vSdI9GeM3jeUiLb3a8?= =?us-ascii?Q?gevYsDJHxlRs7MkITLreKxg9selXYsPppzDvTC5PwaoTta50E4gFu2xhD0a+?= =?us-ascii?Q?PBikPGbU3z/RJQogqvyr2MG6izafAKMj8UUuPwe1OTTeqTMlh2W6+7Wo+bUR?= =?us-ascii?Q?q424C/QQNFERBhHp4GiyzliGvKa2jP4Qr3JeaDRyP3LoNZEW7KONB6pcz3aL?= =?us-ascii?Q?GRydTSrXUtRQI4x5AGTz2GeUXEeFwD9pFR5iB7lKNMvmRw79l7ABABMg0kaf?= =?us-ascii?Q?vI5vGe3AbO1mpb5/2jicv7XBLzfnjPGLVrj9yvhkE4B9fB+pS4ACLdkX7NqI?= =?us-ascii?Q?6VbP/H1GPIYq4g2ALhNFc7mOtx+ow80ro9dP87HXzfX9Zo5pI7WOy+bj4/Cl?= =?us-ascii?Q?Ngww1z71lC2EEzVHrW2iHeR/cKxfn7NC5TwNMfoJ2wu+whgTE9I2DTN3kQhL?= =?us-ascii?Q?u+uJ2HOq+3mzJjl1lpixoojm0eH6kufC+r+89Q4TCY2GmNC690zE6ZPl8SN4?= =?us-ascii?Q?ZwVfmRQkRj16MGgSaBWeVYpu2Z/781uS4jY60fjCPBb/N8QjsX8+7Z0L+rej?= =?us-ascii?Q?OFXcKan4OpFpmLKVGFo9J7pjMnSzs8Ul7wPi56YchgFlOck85m6qTPh7nfgt?= =?us-ascii?Q?BLKg1e9L1lGCcDpjadBpGqpazrlru/6SY5vefM/ir7VxC4B81yYwqIghjxpG?= =?us-ascii?Q?u4CPgpb5oNGZncnkEHUhCHrFZg1b0DS+UXycYz0IL3JAkvdAHPyS6DxA5jUY?= =?us-ascii?Q?1pC9Vt9b7EN3jinoO0HPaK3ur+DkJ0RoJAEPEXxValQ6ihMH8DT5U3E8rTkW?= =?us-ascii?Q?3U5m/uPhlVPvJm/0I/sp8wrK2T+T8zZ94w5I/cbgiZu3TI5odA1tTziz9SPb?= =?us-ascii?Q?GE3Hm6a+Pa3YNrK0JyorlW3wgJ78aozZJUGFKkUIzu5wM2ra3wNdBW9Vd+sF?= =?us-ascii?Q?czzweoRNUqTs7cxuWnv1CWF7aCTpXi5JCmYaXYmdXLlhq+ShCKb+nU2zGhdX?= =?us-ascii?Q?rkMOoUQPOrXsLvPIK8gDRRpdnM+AMdQiLAswqHnFUIzHEA6meuH9Rv3AlB+z?= =?us-ascii?Q?PEW4MvOYAmS8VythBu0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6b68f51-44f0-491c-6772-08dbf7c70828 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2023 08:24:01.0150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dg+Y0EiZJkcLel36p1QL8j9z9PBGsLyub9Ku64CLdRG6kVxz3PVbVBSiT+C41F2Oig7ZusuonWvI2GD5aRWISA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6286 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: H7PWhSZifZaPpy4g0nu82Zrjx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=frJXAVtv; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: Tan, Dun > Sent: Thursday, December 7, 2023 3:32 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V2 1/6] UefiCpuPkg: Create gMpInformationHobGuid2 in > UefiCpuPkg >=20 > Create gMpInformationHobGuid2 in UefiCpuPkg. >=20 > Currently, there is a gMpInformationHobGuid defined, > created and consumed only in StandaloneMmPkg. The HOB > contains the EFI_PROCESSOR_INFORMATION structure for > each CPU and the number of processors. This is the same > as the information that PiSmmCpuDxeSmm uses MpService > Protocol to get. >=20 > This new gMpInformationHobGuid2 also contains the > NumberOfProcessors and the EFI_PROCESSOR_INFORMATION > for each CPU. Also the HOB is extended to support the > case that the maximum HOB length is not enough for all > CPU. So there might be more than one HOB instance in the > HOB list. Each HOB describes the corresponding CPU index > range. >=20 > The plan is to create gMpInformationHob2Guid in CpuMpPei > module(implemented in next commit). Then PiSmmCpuDxeSmm > and other MM_STANDALONE modules can consume the hob. This > can avoid calling MpService Protocol in PiSmmCpuDxeSmm. > Also the issue that one gMpInformationHobGuid might be not > enough when CPU number is 1~2000 or bigger can be solved. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > UefiCpuPkg/Include/Guid/MpInformation2.h | 56 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > UefiCpuPkg/UefiCpuPkg.dec | 3 +++ > 2 files changed, 59 insertions(+) >=20 > diff --git a/UefiCpuPkg/Include/Guid/MpInformation2.h > b/UefiCpuPkg/Include/Guid/MpInformation2.h > new file mode 100644 > index 0000000000..7a25fcc2f3 > --- /dev/null > +++ b/UefiCpuPkg/Include/Guid/MpInformation2.h > @@ -0,0 +1,56 @@ > +/** @file > + EFI MP information protocol provides a lightweight > MP_SERVICES_PROTOCOL. > + > + MP information protocol only provides static information of MP process= or. > + > + If SwitchBSP or Enable/DisableAP in MP service is called between the H= OB > + production and HOB consumption, > EFI_PROCESSOR_INFORMATION.StatusFlag field > + in this HOB may be invalidated. > + > + Copyright (c) 2023, Intel Corporation. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef MP_INFORMATION2_H_ > +#define MP_INFORMATION2_H_ > + > +#include > +#include > +#include > + > +#define MP_INFORMATION2_HOB_REVISION 1 > + > +#define MP_INFORMATION2_GUID \ > + { \ > + 0x417a7f64, 0xf4e9, 0x4b32, {0x84, 0x6a, 0x5c, 0xc4, 0xd8, 0x62, 0x1= 8, > 0x79} \ > + } > + > +typedef struct { > + EFI_PROCESSOR_INFORMATION ProcessorInfo; > + // > + // Add more fields in future > + // > +} MP_INFORMATION2_ENTRY; > + > +typedef struct { > + UINT16 NumberOfProcessors; > + UINT16 EntrySize; > + UINT8 Version; > + UINT8 Reserved[3]; > + UINT64 ProcessorIndex; > + MP_INFORMATION2_ENTRY Entry[0]; > +} MP_INFORMATION2_HOB_DATA; > + > +// > +// Producer of MP_INFORMATION2_HOB_DATA should assign sizeof > (MP_INFORMATION2_ENTRY) to MP_INFORMATION2_HOB_DATA.EntrySize > +// Consumer of MP_INFORMATION2_HOB_DATA should use below macro or > similar logic to get the individual entry > +// as the entry structure might be updated to include more information. > +// > +#define GET_MP_INFORMATION_ENTRY(MpInfoHobData, Index) \ > + (MP_INFORMATION2_ENTRY > *)((UINTN)&((MP_INFORMATION2_HOB_DATA *)(MpInfoHobData))->Entry + > (MpInfoHobData)->EntrySize * Index) > + > +extern EFI_GUID gMpInformationHobGuid2; > + > +#endif > diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec > index 0b5431dbf7..61bd34ef17 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -85,6 +85,9 @@ > ## Include/Guid/SmmBaseHob.h > gSmmBaseHobGuid =3D { 0xc2217ba7, 0x03bb, 0x4f63, {0xa6, 0x47, > 0x7c, 0x25, 0xc5, 0xfc, 0x9d, 0x73 }} >=20 > + ## Include/Guid/MpInformation2.h > + gMpInformationHobGuid2 =3D { 0x417a7f64, 0xf4e9, 0x4b32, > {0x84, 0x6a, 0x5c, 0xc4, 0xd8, 0x62, 0x18, 0x79 }} > + > [Protocols] > ## Include/Protocol/SmmCpuService.h > gEfiSmmCpuServiceProtocolGuid =3D { 0x1d202cab, 0xc8ab, 0x4d5c, > { 0x94, 0xf7, 0x3c, 0xfc, 0xc0, 0xd3, 0xd3, 0x35 }} > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112219): https://edk2.groups.io/g/devel/message/112219 Mute This Topic: https://groups.io/mt/103030292/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-