Re: [edk2-devel] [PATCH 13/16] UefiCpuPkg/MpInitLib: Always use AP Create if PcdSevSnpApicIds is set

["Ni, Ray" <ray.ni@intel.com>]

Thanks,
Ray
> -----Original Message-----
> From: Tom Lendacky <thomas.lendacky@amd.com>
> Sent: Saturday, February 3, 2024 6:58 AM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Aktas, Erdem
> <erdemaktas@google.com>; Gerd Hoffmann <kraxel@redhat.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Laszlo Ersek <lersek@redhat.com>; Liming
> Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Xu, Min M <min.m.xu@intel.com>; Liu,
> Zhiguang <zhiguang.liu@intel.com>; Kumar, Rahul R
> <rahul.r.kumar@intel.com>; Michael Roth <michael.roth@amd.com>
> Subject: Re: [PATCH 13/16] UefiCpuPkg/MpInitLib: Always use AP Create if
> PcdSevSnpApicIds is set
> 
> On 2/2/24 00:20, Ni, Ray wrote:
> >
> >> +      if (SevSnpUseCreateAP (CpuMpData)) {
> >
> > 1. Is it possible to rename "SevSnpUseCreateAP" to some name starting
> > with "IsXXX"?
> > I originally mixed it with SevSnpCreateAP() and thought you created a
> > bug.
> 
> "Is" doesn't really fit for this, how about UseSevSnpCreateAP() or
> CanUseSevSnpCreateAP()?

Thank you. I prefer the 2nd "Canxxx".

> 
> >
> >
> >> +    GhcbApicIds = (GHCB_APIC_IDS *)(UINTN)PcdGet64
> (PcdSevSnpApicIds);
> >
> > 2. Can you define a GUIDed HOB to hold the contents instead of dynamic
> PCDs?
> > Dynamic PCDs cannot tell whether the value is updated in earlier code or
> still
> > holds the default value.
> > Also, I prefer to minimize the dynamic PCD usage in CPU code.
> 
> Yep, will do.

Thanks!

> 
> Thanks,
> Tom
> 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115095): https://edk2.groups.io/g/devel/message/115095
Mute This Topic: https://groups.io/mt/103986469/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-