From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 08AFDD81113 for ; Mon, 20 May 2024 07:05:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nP9Bld90MSL2CyAkxUBLdJXMCB0ifyJBMOOJetDFj08=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1716188726; v=1; b=1JJDXAsoasiA9RxkpVbg0T/Fjg/ouGIMNMnH/NK7dZGRRjZHo3B3I3YNgDok2fmMd6upqqpZ C971Ztxs/M7HJZ4kkp/6z+q987Z//fZYUqqQwGRWMwWKa35TESaRUt+Myh9s+iJ1E/IsYSfHEhv tA2sJel3YcZn6/j0qVlGaEkZa2HrJuLyzEMfoZ79A7JgNG/ltqDjZGsPjpZNHQ2p0qZeTUYRey+ 0spAbbYny+cvnE2udWVj0W1vGeAYR/ukFbySvclTAd+b/27sqxC3pn0jS4ctiM33nPflrJAVhLa +ohj669EHrRDTjCcIW5vo9b/q3ri2unbUsdgoOX5C+w+Q== X-Received: by 127.0.0.2 with SMTP id iLZyYY7687511xb0fgWQUYEL; Mon, 20 May 2024 00:05:26 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mx.groups.io with SMTP id smtpd.web10.54537.1716188725537677118 for ; Mon, 20 May 2024 00:05:25 -0700 X-CSE-ConnectionGUID: RRySY5tsTq6vayhv+oSwqA== X-CSE-MsgGUID: u+/bR7GqR5WaqJtuCrTQfA== X-IronPort-AV: E=McAfee;i="6600,9927,11077"; a="16129772" X-IronPort-AV: E=Sophos;i="6.08,174,1712646000"; d="scan'208,217";a="16129772" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2024 00:05:20 -0700 X-CSE-ConnectionGUID: ayaKjdShTaeYQsUD6B8qgA== X-CSE-MsgGUID: f3NvdkfuTbeu9IrYgsW3Fw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,174,1712646000"; d="scan'208,217";a="63262491" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 May 2024 00:05:14 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 20 May 2024 00:05:12 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 20 May 2024 00:05:12 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 20 May 2024 00:05:12 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 20 May 2024 00:05:12 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH7PR11MB8033.namprd11.prod.outlook.com (2603:10b6:510:246::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 07:05:09 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7587.028; Mon, 20 May 2024 07:05:09 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: Liming Gao , "Wu, Jiaxin" , Ard Biesheuvel , "Yao, Jiewen" , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [edk2-devel] [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver Thread-Topic: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver Thread-Index: AQHaqD8laERs8LjmtU6V/zkQKilvArGfto5O Date: Mon, 20 May 2024 07:05:09 +0000 Message-ID: References: <20240517094610.533-1-dun.tan@intel.com> In-Reply-To: <20240517094610.533-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH7PR11MB8033:EE_ x-ms-office365-filtering-correlation-id: 3dd0921c-2aad-4141-b541-08dc789b2fc3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?8TVuP+66X0D/i6JoBSVTMdH88aHWKjCiiS+kHob8+a92N4U1juuytWvUpn3I?= =?us-ascii?Q?vsR/H/7KqfPCho7ibmKt2zfpq56hXwk8DWxGL2LER/bzWyF54GdqClG1CQX4?= =?us-ascii?Q?vY81QPMgTqmnk/vsIk2GM2BcPZiA9Bjt+FM+VsQtAta/ndDcsJPqQNKwbK6b?= =?us-ascii?Q?T55k4XyiOHzsM42Mu8ZML4jlLitryn0BIRzXBFYh9Q84cj7XBiv2Sj9oTGhL?= =?us-ascii?Q?TB8ydEWFyUHcoLfmAk+GGwVbuBrvA+p1nIr+WC/PkyNK1fw7nRxvJTTO53GT?= =?us-ascii?Q?WjmQ/QhPhQLtmCvaeI0ebEG7lOXiCAr6OL6mlCN53mPp2DhQ8dc/R3j/qtvc?= =?us-ascii?Q?oB+SfQghLq2kfBMgvQ607FtZXPWeoivd/p2owlttFeloA6wxk50mb/I6zznD?= =?us-ascii?Q?eJA14sE7/Tn8mTJBBX2iHi3CT+t8DbH/Bl3sU9ePMTH+hY1ZVXlTiHXb26Ap?= =?us-ascii?Q?g/MNhiJl9OcUqTKVmCV+6a3NLggvSfcXApnrplBnhicGOQVEJI/sh6Pn5eLB?= =?us-ascii?Q?R0KNzZVMjAD0mdFYLYf2AlDRkjEOEEWAd4Fy7YHjtyg0B5PtK4ZwlFHhweRl?= =?us-ascii?Q?VJADKuMNe1B+USxdIwBUgCe6j1jPQY4RBHNrCROgP9FrpeJKz8xJiGA28egv?= =?us-ascii?Q?l5cBO4cQYD6xTphJeEJpyO0NvXMdAMGEdJUWCBhI8TaiycmjI/D5e3q3g++3?= =?us-ascii?Q?ssAI59/h7H3dPjfLuvtzCIrOpj1i0p8mA2Pv9+2/OQvA7JUQ79T/zjG7u0Mt?= =?us-ascii?Q?km0hiupWgI+4nsaMlboClBrl5S+pr6H0gtqzW7KgMzMUM2PtmucUxm2M4hZ0?= =?us-ascii?Q?1lOIcA8KkNHwhmPph5PsaUZCZ6rNyO1uZqISZf2c/BNyJRlc3IogyvfhxPNw?= =?us-ascii?Q?CYx5WVRkIthj00WsuMRsX6ualgM4bqJ6s62/T8YznVdXg1sFE/LeE6kNoyGq?= =?us-ascii?Q?vd3gEnD2CsftmyVXy+Ko31WZwuDZG9+IFFu7roHgkYoMMwQd9/WCopO3uwlB?= =?us-ascii?Q?eOSqYdjg5uRos6H6ShQsEo54w9WXOzwoq7x9vPEVPKIV4Iz5IEJTSrZGpcT0?= =?us-ascii?Q?TMVh/3wSu/tYN4dL37cPHCC+IpItvZvkN5B2KeUppMj/OHgujg1YGLr2zycG?= =?us-ascii?Q?oc073llWy2E5+69fgRChHzMG7Tu+Fc+nMyTH0+S552ohnSlSMY+VHegNizz/?= =?us-ascii?Q?ccCPrr43oaQ5/BtMyBlICHwu7ifQrIJBhVXRmPuhqMBXslYnjebri+OXosBp?= =?us-ascii?Q?7ZVYGUqt+XIIE9Q/ok5NoYH+KCLkU+0T7aAI6hp+qQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rjpte9UBm8UwlV5yoZJi/GGJNfJhHICdYVuvN0rlZDQQ6t+JB9yjS23k2eQy?= =?us-ascii?Q?vwD8l9/OnqIXNEwkCTfjkTO5ChQZ2iRAb7tLWOIzIAdOIpVoFh8/9ykAiIfq?= =?us-ascii?Q?/o2hGjuGFherCy7K21XcBKz1Avix0HsoVBY3e3h6mBrH7t7egmK47rePSX4y?= =?us-ascii?Q?yFB2x+AFbUFkE9p6Hcv5SpS+Hn0Uljx9WKRPH+Txli3xFWJ6nZ9noQSlyRWF?= =?us-ascii?Q?Ja5eNHcls9mhmFyfBMD7Zmw/yGk4bjRIZ+fgLU2CjNxhz0vnyLG95lVHgjWd?= =?us-ascii?Q?jvg9b7/qxvWvX7kJ5tGNC7Hcq1ti7Dlsrzztye8W2UodbV8AGpLtRES6s9od?= =?us-ascii?Q?/sXvunnwBIG1D+OaxLf9HQwxRXZxUjmqxs6hQG2fE/WQR8nRzbeUh7rCAhHX?= =?us-ascii?Q?XfUA9TDXD25HhxC9xp7qDs98IWhf3MTcnolH0nJGfZP0olewg6dCzO/+NwkH?= =?us-ascii?Q?nTTJ9ZyWS8CXURzz1sOgWFdpBbWt4Qk+S09CA3hwsysbZGEjBc7Hh/65a6vV?= =?us-ascii?Q?IqF4sn829AYBVRt69o+rd0vVCfFCYrjPEilLbMuzT4BgUKViuc+6KrgtG5NB?= =?us-ascii?Q?K7O2f44bve8Qd6LWFIHnFZC4lEqixrvdV45sXeKqey+1UVvjT3yvr1ILTKl1?= =?us-ascii?Q?96xFGJoB7ABTugn0gXbpkserXY9EJoO79evpR715ZfzIzd48wt8qQ3fngc8s?= =?us-ascii?Q?7IpxpRDr7WiZYDD1r0nt4uEz3KcWyhVKJdqlC075w9I93AdK5GfUbVsP2AjK?= =?us-ascii?Q?3Ni0cj11wU7CUt5Dv7U/0EKHZZjqmt6+HdSTy0N7BFsF9PhrweG/zdctOFSh?= =?us-ascii?Q?k23SjHgQiqGd2fpE0AZTNSPJbTC5hPNZPPtEYjjWYGzuRjciUgZ8sNfox8hn?= =?us-ascii?Q?g1+bYglckhNu31K+cvWcem5zocBCqH+pTwNVZiibEZaRa+SplBPBOIp5uyWx?= =?us-ascii?Q?ijKmEZ8EAf7arom3plnFMJQB9l01CMtvzd3whoJgHdtE//pnUK8eh/Ldar0n?= =?us-ascii?Q?3sLYx19XBkTNybB1Z9DU3dBif5v2vB2iy6Hqfmmgid+YnDRbtDwPmN/IQR8f?= =?us-ascii?Q?2HB2wBjcQwU53sflstKZAoy7ZLgkQocJJTDD10gijZI1WgmmKX+dilr4UIWN?= =?us-ascii?Q?QCAh5F6Szp+kJeedZsvMcBqDvwC+Nfg7se6WsuU7BzMbFimX7ssDShIqyq8T?= =?us-ascii?Q?IyjYTFY15tn3ppYDMApGOrDB6hanUuXQACOnH6AbBAacrYQG8WbZ/WJDQaCO?= =?us-ascii?Q?JUFcITXUhpnTjq/kToZA87FDoQXMg/jJGu7lI2qRYzPyZhJgMzzd2TmpVN9L?= =?us-ascii?Q?Zx9XLjVMS6BuPy3oC8PR4S955zFyQO9vhUIROEHo61ZCaofZ4J4BVMg532/U?= =?us-ascii?Q?c6+rHMgYkuqDzokcMmE8CE3S4a+EdsQUUvIXnLW7P6sgmIX+6yT213A78ScP?= =?us-ascii?Q?I0N3v60W9gbZV0ROS3OT9rt3TUpG9po7Z7rhfKnX6rT9WQlacbGxU27m9UBt?= =?us-ascii?Q?0yezWbgK1Q5l/oMqQQYV5oQF014BJS/y47ZjEEy0t0kikhpJvNlx2A3El5xa?= =?us-ascii?Q?5ewEyIylA4S1dzCOmv0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dd0921c-2aad-4141-b541-08dc789b2fc3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 07:05:09.6244 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6Nz3dmTqVvhrBsSCl3mVNMOGWvQBdyU3w4aWoVnqSMRd/Adgst2J1Kf37x6rOgwQF8jtrwxQuv4tj2rYFxZLzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8033 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 20 May 2024 00:05:25 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 49h1VVoWbxvyIaRWX30Sa1Tfx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB824475E86C398C8C686C85D68CE92MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=1JJDXAso; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) --_000_MN6PR11MB824475E86C398C8C686C85D68CE92MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Following 3 patches still require the Reviewed-by from package maintainers = of MdeModulePkg and OvmfPkg. MdeModulePkg: Add gEdkiiS3MtrrSettingGuid OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE The patch set is a good move to simplify the X86 CPU SMM driver by removing= most of S3 related logics. I hope it can be merged next week when the stable tag freeze ends in the en= d of this week. Thanks, Ray ________________________________ From: Tan, Dun Sent: Friday, May 17, 2024 17:45 To: devel@edk2.groups.io Cc: Liming Gao ; Wu, Jiaxin = ; Ni, Ray ; Ard Biesheuvel ; Y= ao, Jiewen ; Gerd Hoffmann ; Kumar= , Rahul R Subject: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu= driver Comparing to V1 patchs set, the V2 patch set only adjusts the commits order= ing and modifies copy right year in some files. This patch set is to remove some S3 related code in CpuS3.c of smm cpu driv= er. It contain commits to: 1) S3 MTRRs operation: > MdeModulePkg: Add gEdkiiS3MtrrSettingGuid > OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe > UefiCpuPkg: Add locbox lib instance in DSC > UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe > UefiCpuPkg: LoadMtrrData for all cpu in S3Resume > UefiCpuPkg: Remove code to load mtrr setting 2) AP page table unavailiable issue fix: > UefiCpuPkg: Disable PG in IA32 ApLoopCode 3) Register table cleanup: > UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE > UefiCpuPkg: Remove code to set register table 4) S3 ApHltLoopCode Operation: > UefiCpuPkg:Abstract some DxeMpLib code to function > UefiCpuPkg:Move some code in DxeMpLib to common place > UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume > UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib > UefiCpuPkg:Remove code to handle APIC setting and Interrupt > UefiCpuPkg:Rremove code to wakeup AP and relocate ap > UefiCpuPkg: Remove the duplicated mpservice locate > MdeModulePkg: remove MpService2Ppi field in SMM_S3_RESUME_STATE 5) Remove code to get AcpiCpuData: > UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c With this patch set, CpuS3.c in smm CPU driver can be simplified. The whole patch set has been reviewed-by Ray. PR for review: https://github.com/tianocore/edk2/pull/5606 Cc: Liming Gao Cc: Jiaxin Wu Cc: Ray Ni Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Rahul Kumar Cc: Gerd Hoffmann Dun Tan (18): MdeModulePkg: Add gEdkiiS3MtrrSettingGuid OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe UefiCpuPkg: Add locbox lib instance in DSC UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe UefiCpuPkg: LoadMtrrData for all cpu in S3Resume UefiCpuPkg: Remove code to load mtrr setting UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE UefiCpuPkg: Remove code to set register table UefiCpuPkg: Disable PG in IA32 ApLoopCode UefiCpuPkg:Abstract some DxeMpLib code to function UefiCpuPkg:Move some code in DxeMpLib to common place UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib UefiCpuPkg:Remove code to handle APIC setting and Interrupt UefiCpuPkg:Remove code to wakeup AP and relocate ap UefiCpuPkg: Remove unneeded MpService2Ppi assignment MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +-- MdeModulePkg/MdeModulePkg.dec | 5 ++++- OvmfPkg/CpuS3DataDxe/CpuS3Data.c | 13 ++++++++++++= - OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 4 +++- UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 13 ++++++++++++= - UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 4 +++- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 183 ++++++++++++= ++++++++++++++++++++++++++++++++++++---------------------------------------= ---------------------------------------------------------------------------= ----------- UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 6 +++++- UefiCpuPkg/Library/MpInitLib/MpLib.c | 144 ++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++- UefiCpuPkg/Library/MpInitLib/MpLib.h | 56 ++++++++++++= +++++++++++++++++++++++++++++++++++++++-- UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 6 +++++- UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 154 ++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 993 +++++++++---= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ------------- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm | 153 ------------= ---------------------------------------------------------------------------= ---------------------------------------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 29 +-----------= ---------------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 8 +++----- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 26 +-----------= ------------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 5 +---- UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm | 189 ------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 30 +-----------= ----------------- UefiCpuPkg/UefiCpuPkg.dec | 4 ++-- UefiCpuPkg/UefiCpuPkg.dsc | 3 ++- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 78 ++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++--------------- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf | 4 +++- 24 files changed, 531 insertions(+), 1582 deletions(-) delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119073): https://edk2.groups.io/g/devel/message/119073 Mute This Topic: https://groups.io/mt/106150757/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB824475E86C398C8C686C85D68CE92MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Following 3 patches still require the Reviewed-by from package maintainers = of MdeModulePkg and OvmfPkg.
  MdeModulePkg: Add gEdkiiS3MtrrSettingGuid
  OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe
  MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

The patch set is a good move to simplify the X86 CPU SMM driver by removing= most of S3 related logics.
I hope it can be merged next week when the stable tag freeze ends in the en= d of this week.

Thanks,
Ray
From: Tan, Dun <dun.tan@= intel.com>
Sent: Friday, May 17, 2024 17:45
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Wu, Jiaxin <jiax= in.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Ard Biesheuvel <a= rdb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Ger= d Hoffmann <kraxel@redhat.com>; Kumar, Rahul R <rahul.r.kumar@inte= l.com>
Subject: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of = smm cpu driver
 
Comparing to V1 patchs set, the V2 patch set only = adjusts the commits ordering and modifies copy right year in some files. This patch set is to remove some S3 related code in CpuS3.c of smm cpu driv= er. It contain commits to:
1) S3 MTRRs operation:
>   MdeModulePkg: Add gEdkiiS3MtrrSettingGuid
>   OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe
>   UefiCpuPkg: Add locbox lib instance in DSC
>   UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe
>   UefiCpuPkg: LoadMtrrData for all cpu in S3Resume
>   UefiCpuPkg: Remove code to load mtrr setting

2) AP page table unavailiable issue fix:
>   UefiCpuPkg: Disable PG in IA32 ApLoopCode

3) Register table cleanup:
>   UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE
>   UefiCpuPkg: Remove code to set register table

4)  S3 ApHltLoopCode Operation:
>   UefiCpuPkg:Abstract some DxeMpLib code to function
>   UefiCpuPkg:Move some code in DxeMpLib to common place
>   UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume >   UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib
>   UefiCpuPkg:Remove code to handle APIC setting and Interrup= t
>   UefiCpuPkg:Rremove code to wakeup AP and relocate ap
>   UefiCpuPkg: Remove the duplicated mpservice locate
>   MdeModulePkg: remove MpService2Ppi field in SMM_S3_RESUME_= STATE

5)  Remove code to get AcpiCpuData:
>   UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c

With this patch set, CpuS3.c in smm CPU driver can be simplified.
The whole patch set has been reviewed-by Ray.
PR for review: http= s://github.com/tianocore/edk2/pull/5606

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>

Dun Tan (18):
  MdeModulePkg: Add gEdkiiS3MtrrSettingGuid
  OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe
  UefiCpuPkg: Add locbox lib instance in DSC
  UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe
  UefiCpuPkg: LoadMtrrData for all cpu in S3Resume
  UefiCpuPkg: Remove code to load mtrr setting
  UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE
  UefiCpuPkg: Remove code to set register table
  UefiCpuPkg: Disable PG in IA32 ApLoopCode
  UefiCpuPkg:Abstract some DxeMpLib code to function
  UefiCpuPkg:Move some code in DxeMpLib to common place
  UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume
  UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib
  UefiCpuPkg:Remove code to handle APIC setting and Interrupt
  UefiCpuPkg:Remove code to wakeup AP and relocate ap
  UefiCpuPkg: Remove unneeded MpService2Ppi assignment
  MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE
  UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c

 MdeModulePkg/Include/Guid/AcpiS3Context.h    &nbs= p;          |   3 +-= -
 MdeModulePkg/MdeModulePkg.dec      &nbs= p;            &= nbsp;       |   5 ++++-
 OvmfPkg/CpuS3DataDxe/CpuS3Data.c      &= nbsp;           &nbs= p;     |  13 ++++++++++++-
 OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf     &n= bsp;            = ; |   4 +++-
 UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c     &nbs= p;            &= nbsp;  |  13 ++++++++++++-
 UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf     = ;           |  = 4 +++-
 UefiCpuPkg/Library/MpInitLib/DxeMpLib.c     =             | 183 ++= ++++++++++++++++++++++++++++++++++++++++++++++-----------------------------= ---------------------------------------------------------------------------= ---------------------
 UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm    = ;      |   6 +++++-
 UefiCpuPkg/Library/MpInitLib/MpLib.c     &nb= sp;            =   | 144 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-<= br>  UefiCpuPkg/Library/MpInitLib/MpLib.h     &nb= sp;            =   |  56 +++++++++++++++++++++++++++++++++++++++++++++++++++--
 UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf    =        |   6 +++++-
 UefiCpuPkg/Library/MpInitLib/PeiMpLib.c     =             | 154 ++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c      =             &nb= sp;    | 993 +++++++++--------------------------------------= ---------------------------------------------------------------------------= -----------------------------------------------------
 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm    &n= bsp;        | 153 ----------------------= ---------------------------------------------------------------------------= ------------------------------------------------
 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c    =        |  29 +--------------------------= -
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c    &nb= sp;         |   8 +++----= -
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h    &nb= sp;         |  26 +-----------= -------------
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf    &= nbsp;       |   5 +----
 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm    &nb= sp;         | 189 -----------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= -----------
 UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c    &= nbsp;       |  30 +---------------------= -------
 UefiCpuPkg/UefiCpuPkg.dec       &n= bsp;            = ;           |  = 4 ++--
 UefiCpuPkg/UefiCpuPkg.dsc       &n= bsp;            = ;           |  = 3 ++-
 UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c   &n= bsp;   |  78 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++---------------
 UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf |  = 4 +++-
 24 files changed, 531 insertions(+), 1582 deletions(-)
 delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm
 delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm

--
2.31.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119073) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB824475E86C398C8C686C85D68CE92MN6PR11MB8244namp_--