From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7BEDF7803E7 for ; Tue, 6 Feb 2024 08:57:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7x2BoNH4PBb5ktcx+p31wXhcf4lyEw6bL0rKbQ53Qgs=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707209843; v=1; b=v5Gw5Ae5i94VqqOEOicGP0oyfrq8U4waEyfGxK6XtyK0Rxs5W2kwIky5BtcxQ4HjYOy/lAKg 0jKYbE9XGNb1J0crSsXMtx/7LPGSYqX/N73JoxQEeg+y05Fv/bc6GWL+9rmBDdgV+0R4VO5niwf Ca29SbAwfoQss0PogiWEP0BI= X-Received: by 127.0.0.2 with SMTP id xMotYY7687511x0nZyKjaTPt; Tue, 06 Feb 2024 00:57:23 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.17582.1707209842602884352 for ; Tue, 06 Feb 2024 00:57:22 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="435838150" X-IronPort-AV: E=Sophos;i="6.05,246,1701158400"; d="scan'208";a="435838150" X-Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 00:57:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,246,1701158400"; d="scan'208";a="956914" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Feb 2024 00:57:22 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 6 Feb 2024 00:57:20 -0800 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 6 Feb 2024 00:57:20 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 6 Feb 2024 00:57:20 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 6 Feb 2024 00:57:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l5T57s7SDuL1OqrO3GcOzIMryruYh6KoErJdQJw5VHmZHglxU55+UaPS/6TEMelnq3pNf3fJkO+zpyyDUKUIpb4j0KKWgGXkjcq5l1ntUQMsTXzmfplUaDfzZ5O/OSkrtruZru7lYC2FvBY9yhpRs4ti5TrIeDRESgNIAeUpsboI3LKGUeJkA65fe50HIlsu+OH8iIUtNuvn7NHrYBNIL9O6c6ZMIUg45k6q9bxvSFq9gVcvbrJGBu0g5jR4idNw2MsI82krPAtJVx40A28SsWJ01Bb7M0eRPL4zX5lJ7BckVDdzZ4u0+zSNOL57s++2GFDuoBnjEizRmQvHRaGtAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xF7L1/aiSKy7ERe18P65dgfrNOX57WNQISXrQ8dZqXw=; b=DLxrAE7JPiQHA8kTHRcijrffJJngQoC5/RwoAFRQ8HGblpl0Dh28+girJ8l/EI6hLVHMY6FMZ9qmk5D96rmp1GCHBEzDQqk+r9T22OGmyP+2fe/t3r2G92Kub5PlLILFwKj6rXZbZXl/tLbBHr/eESw4PIVsCMb8kseFAtNkedaIV+EwnGYG48HbgcLpPRoUsBXKJsjVyz7f4DW0FK8rJVvclyalvKZEnkLEPa/iu4DOZMqPk8br9rBgayfECK7Yattor/cUxY9b9g3kKZ4LAIx465OW8rNujSSdQc0I03mib+E1Efl4haTl/TOfFttVBIAiMYM2KnkYFyBVT8RUZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH0PR11MB5444.namprd11.prod.outlook.com (2603:10b6:610:d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Tue, 6 Feb 2024 08:57:18 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f4e6:157c:2058:8b1d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f4e6:157c:2058:8b1d%4]) with mapi id 15.20.7249.032; Tue, 6 Feb 2024 08:57:18 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Dong, Eric" , "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Check BspIndex first before lock cmpxchg Thread-Topic: [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Check BspIndex first before lock cmpxchg Thread-Index: AQHaWNJGH6v7t4q2YE2fM6XkUth3k7D9AyOQ Date: Tue, 6 Feb 2024 08:57:18 +0000 Message-ID: References: <20240206075804.15152-1-jiaxin.wu@intel.com> <20240206075804.15152-3-jiaxin.wu@intel.com> In-Reply-To: <20240206075804.15152-3-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH0PR11MB5444:EE_ x-ms-office365-filtering-correlation-id: c24f6f05-887e-41a5-18b8-08dc26f19f70 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: r8DoYI/4Olkmt1seD+hQ99IBxw4jdvNQWphH9ckswfSJEzkRrsfdvxK7dPXDtJXtHX6XyE3GsjNX6jftX5IWrKaRZPJRd3vKlGNhiDpsWBrDjbkoYhd8j1kuF5XFiCL2w3CWzCcAyFBR03GSQzZzuKjH+XQB72Jl8LjMm1Mg1MqxIQHvMFNkk2+1Se/fP+2E9NvZm4roGP2McX2zfw3WJIXrxW6vkmNfocave/+dcJKhaZeXFt56665w/sLy5iVnNUO271W4ib8eWiKB3wUQAlY8MEm8JNySexKIRXsV9i1RYISjK2o0zSE5dR6jxzCDVIjM8BM9a4cGUh9UJeJheuzus3AItYCRWeR3a66zNm6spe2XqMwc1cSydtSithg/h4oSxC5w4O6eOgYHlIgI5LY/eQpQSZMonsIQphYfehcw3rF4371MbZaEo2h+uXFjaFlD5/+b5OCKotQlsvAATBuK2OOsnRwAB6vyNHbdggM03ANS2cTVAu/hmV+vKnNXCvMyfk5dm8B5tYvKc9hgzD90kE6ldLnNyljHR53RWzznTtQCq4AG6kmZ25SLeL73ipDp5pacz0pbTgNpBwAh59Dtg3ZZH2aYQx2EI84nznnjM5fzADTb7IwS/sAzz2J1 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rUjLzzSTN3ocmdNRNaq+xvmr9MkNINKePdu8dRea2hDhH1PFAzNr2O7uNKzX?= =?us-ascii?Q?N6Q6JF5+d2NAK3VZXNVqG6T/qS9G7fUuuk7wZJiQ2KxQ91/auMpJI784ZKib?= =?us-ascii?Q?BAAhYgDc6FPtrjW/Z2jeAjMZs/E4LRnnavMoqShwbXw9vXS0waDFLuXGjosb?= =?us-ascii?Q?eTuY+d5i0MY8V0bKP3N15QzoQc2ugRCIPaCfjLZTSv3aXgPoyLR5TRCI44V0?= =?us-ascii?Q?Y9vpykPsbqUojiLn4gfTnFwzsVE9S3TK8lVhWtWu74N8iIE0jIubcp+lZzcV?= =?us-ascii?Q?GXgf7C+h+SDQ1maBJpIAVJQGlHc0sEwCfjocuTa8v2sKECFVWOXZ/3MAQGDp?= =?us-ascii?Q?t/vNr09rRuM9PmMSnmdHrxykRj1bxVKB0iV2nsCOmMZzvF/8ORUOu6/cHIXy?= =?us-ascii?Q?mXIqaKOQCVO5DL7YsjEGA0MuXMLpNWy18EcnbqwDjacWwDa+G3R6YregkCsc?= =?us-ascii?Q?DqGDhhvvLqAaXPEqO6qdwtF6H4KKiyNHdVZ5gWsJakDUNHKGVWJKYyOECuMT?= =?us-ascii?Q?gde3MyAOFL1stoy3IeWsH4XM3Niv928nL+Q62ksOZd4/RDaEx/dE8XN1WCD8?= =?us-ascii?Q?TTchD0D5MpCAlj86GD1kgs619YXSTqa2nxSMaDy1Bbsg499xo1QhfU10Sorl?= =?us-ascii?Q?iA480PWD07qwjVwI8GgaDsMGiC8lydQzmlYjLOJWCDAW+ByUEgL1ggSteZIP?= =?us-ascii?Q?wN6HtkFIAFYJ9QPvnYNSjGEDCTh59XcXCnlfMPTzyPJyOXIoJAtZJtsZWmhD?= =?us-ascii?Q?Ih37rOIDP4jJL/kHiCF1NsxnudTMQjh2LAi1QOY5Vgbh9rLgirbwDdc0OSLt?= =?us-ascii?Q?fmmMybhPBlga03QnBsEQx0PM++VhIXQpU5BKBEygiepYeO4Hda7JarzcdDCG?= =?us-ascii?Q?TAQJfgBunq9KDl8c2oMiaCjwS1cZIiNZwW6raXdZg6FVj3fMREKC1ifCZFrv?= =?us-ascii?Q?xBEDqlEBaJJWO/cnBvTaR+TCPln2lMs1cQeOjyei7v5mDJdN1N1motTKNA8n?= =?us-ascii?Q?mwE/c/Uba88CeLk/gb6GfL1Ayf9oj3ZQpHBViRnZh80eeGzCbFribuFqskQm?= =?us-ascii?Q?RWeW9wMJQ/BkJj7LeX/Gq4xXJ/Yh+gnSpwWB6p9S4CD03TgjVPX7ru24HVXq?= =?us-ascii?Q?fm//xYCITe82++43pyRZSfjsJoD7+hyq6LQmf4h3gU6U6aJJ7mW76B2TGGqj?= =?us-ascii?Q?H1g8/nZ1KiH/V1OtUFnhIpxh+i7CxUFGKmW7Dad4k99NGYuH2NNFmZw8zI/3?= =?us-ascii?Q?KRRv9MOf5uCON6K+tt/lIrBYjwwkAtZ5h0G+fD+3tlFL3enLyBrqfRZwtEh3?= =?us-ascii?Q?fJjQ2/iFChRJWCxjEtU+l0+aFI1F7mWEY8/v9OPRHZSZgjN4zw9qMZttdWo7?= =?us-ascii?Q?5LqDyWyEh974+Hpjh272stNlGb6Wy3m+w8IQE9If3YVJcGRA2BXN/0nYeWK2?= =?us-ascii?Q?wE+RhWHFZmFaxfOJwzxxXncACzasWjScaJyWHFALZn+GeSuQ18NDRc7YcsuL?= =?us-ascii?Q?l/JKclSyx4n1Y9dz0Avaaa4IDtK3K+6iqCqPoUGa4rkmCqol2WPI31R5EMjx?= =?us-ascii?Q?2/LSFl1jU2lLqTkd9L0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c24f6f05-887e-41a5-18b8-08dc26f19f70 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2024 08:57:18.3044 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1PcBsPluC54cMde3gY8ZtYlYlkjIGwXSq1hXK87p6pf0qXk3UePyW5WzT+8YAt439LDHXNwxpDKuL3EeTHZvSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5444 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VvibOmRfWOaZ7IT9wKVBrwEvx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=v5Gw5Ae5; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: Wu, Jiaxin > Sent: Tuesday, February 6, 2024 3:58 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Dong, E= ric > ; Zeng, Star ; Gerd Hoffmann > ; Kumar, Rahul R ; Kinney, > Michael D > Subject: [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Check BspIndex > first before lock cmpxchg >=20 > This patch is to check BspIndex first before lock cmpxchg operation. > If BspIndex has not been set, then do the lock cmpxchg, otherwise, > the APs don't need to lock cmpxchg the BspIndex value since the BSP > election has been done. It's the optimization to lower the resource > contention caused by the atomic compare exchange operation, so as to > improve the SMI performance for BSP election. >=20 > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Eric Dong > Cc: Zeng Star > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Kinney Michael D > Signed-off-by: Jiaxin Wu > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index 71d6b0c6d8..081f0c1501 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1652,15 +1652,17 @@ SmiRendezvous ( > } > } else { > // > // Platform hook fails to determine, use default BSP electio= n method > // > - InterlockedCompareExchange32 ( > - (UINT32 *)&mSmmMpSyncData->BspIndex, > - MAX_UINT32, > - (UINT32)CpuIndex > - ); > + if (mSmmMpSyncData->BspIndex =3D=3D MAX_UINT32) { > + InterlockedCompareExchange32 ( > + (UINT32 *)&mSmmMpSyncData->BspIndex, > + MAX_UINT32, > + (UINT32)CpuIndex > + ); > + } > } > } > } >=20 > // > -- > 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115154): https://edk2.groups.io/g/devel/message/115154 Mute This Topic: https://groups.io/mt/104194206/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-