From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.2394.1678845076676688721 for ; Tue, 14 Mar 2023 18:51:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Xi6rFHyg; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678845076; x=1710381076; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FxesaDza+kL9rE3qG86H3m4IQbAo9DGoJhLEHFrRc98=; b=Xi6rFHygvjFgqteOhGg/KTRVzs0D5J2gRi79oyD6Nn7RJAAUXmXKXzbI eyop0tWHxo7gr656EYUF0LAcpQJTo65P/L6N1gqCjfX0zMZ/JAvdvaGLG oCACCxCnEGk4tP7SCPtfkErHs2n0bFN3hUk4L6aORoYP8OLu9mdSwTIoe JS+WlJO+Qt0ifCqLozwv/j1IopV4Fgp5B9Hsd6SOlYcu+Y6TnGKQYh4o+ gLwI238t7OEBXNx76mbCEShlwB5IKDC6SMLTwJdufEO3kcWcL9HDc5BNB XtSGM7GlpB4AVZcfxeCY3e20s8zQzJNYb1mb+N+wSQRAQXRGQ+V1feefD A==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="365264871" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="365264871" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2023 18:51:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="743512836" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="743512836" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 14 Mar 2023 18:51:16 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 18:51:16 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 14 Mar 2023 18:51:15 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 14 Mar 2023 18:51:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U9AcIPC1heklglDmggRfdw7xHTmCNWedUVBZ6+SuHjtHxw4JyHST6s40Ts7WhYPJ+VLe815W3JZ9QjC+QpK322wZLmom9ykeUu5AhkbHRjHBYLL3cF7g2P+pe3D6Q2fe53h6b4Q1nP5wFwMuzlDi93nO9rlQ/weIy0RgSE/P9UX4Kt+prEJg0rHqA7T9M5w6WNNWLde2Umq7ft2IaN2XKWu3LCEennBkvlnqnQAu/jjlhjzdLzoGniJg7YZyRH1YuezMYzQ6ZwhAM9xhT/ti/cYtBiQ7BMqzSrMmFEosL5lwYiyj2vSec4oFP1V0mvB+LMGumwTipygduNhpfv9L8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OKPMdXSo5qP6KQDy92JyBtSZEveTZ03b2w4GlrUn2KA=; b=V2XkoxkJp2z/yQBQCAwXf6NjW3nTYDsKsMschUh7RhYWDxw36s+4DzfnQJZ3mEMO8fc/AJTflvcHy1S4bzC3N4D2pbo1aw/cTEaoNLaA5t+/ctZ1bLF0Z1WnNhPqxmvCmSfjprBQtgQfQspQcuaO/bqj4XelSPoEQ5sp4ZWj3lCFbll4ojVwxQk/0fCUbNCFJLwKQkgmI2t3RNz/etnC0rcBaHU9D++15dR1X+WLXevE9JPjNkYHQQRQm1kJlexOwIkZPDk0CyjTmiYuuAcKEJ8RCf9VcxgW/IJNoFd9JyYrIX5HY0LIim5apO0JFmDZRfASnOa2Ph/MALApeus74w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH8PR11MB6705.namprd11.prod.outlook.com (2603:10b6:510:1c4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Wed, 15 Mar 2023 01:51:13 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.024; Wed, 15 Mar 2023 01:51:13 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V2 04/14] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry Thread-Topic: [Patch V2 04/14] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry Thread-Index: AQHZUaYEQHoFRq6MtUuUhPVzhdj2fa77HZ4g Date: Wed, 15 Mar 2023 01:51:13 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-5-dun.tan@intel.com> In-Reply-To: <20230308100758.669-5-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH8PR11MB6705:EE_ x-ms-office365-filtering-correlation-id: fbf74841-42f1-49b3-b10e-08db24f7c1e6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k8VYUWAwtYQ0ZFdGnGLeaioiV8eUV8ojpMlH6NEF9Py8VfCPx+J+BLm37Hj25SijyB7JrDgSS44B6MuGqoNRyXiozs2hosxYrJj0oLxac/r/Zd/z/lsADENRnXBOL+1K84yj6DZ3cZ9KMcyv63cvCX0mxNkzhrH9Jw57S4tPPhCY1yVVQNVbRZ4wsRrw+sgIood+NtMi5rFwih4Hk4WatG7bIUmUOQgWsQrXxugycY8tZ3RBFjAjZpWb80LveOgEf4kKSUi1jQ/wZy43l2JPKSIXEvZgiDQtcLVBbifsZuEACBxmW7zgq7JZaLQHlDParf5qBMwmyGJEFpVjGAEUmnTMpz0HoDXGfHG1unIlgWBIKY8zryKpB2BnYxvpax4y0jv0a74Cw/pNhBM9v//gRKvmmn5tt3LCNy+2I98OdqEX404TV003HUer8nV1l9xuAjEKzmmQXVtLzwmozClm+nd0QpK8TZnoGNokVv0LjTPiez8uQOQoqow1d7D/8kg6bdJ14QC+uCaQCizh9HliRVErYaK6c64PhT/MN5P18EsEYLQfFamijj0ilBNoySaLvBTxvOzSNhhqW4zCykyv/pn6kPA9RHpGVH/DpZ7dw+/7kviZm+umBzZGHxUX3kh5OxApu8WG2bWVIWxTdsbB8SHIrs4YisfAcQPwy8crTmURQkVgTGYj0c34lLt5XhYbQfykt/6Opx6DreRHyq+8Yw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(39860400002)(366004)(136003)(346002)(451199018)(4744005)(5660300002)(54906003)(478600001)(7696005)(26005)(6506007)(71200400001)(9686003)(66446008)(186003)(33656002)(38070700005)(76116006)(4326008)(55016003)(64756008)(66476007)(8676002)(66946007)(8936002)(86362001)(52536014)(66556008)(316002)(110136005)(38100700002)(82960400001)(122000001)(41300700001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l3xI8p5AB8LFr5YL9XDObuQoWtfOClvWPo5x/H0a2qIe8puPpcrH9bb2vmIR?= =?us-ascii?Q?S4XQ2ByAIyXxT+Xs95gK+Xmt9bMPPDS3jdINuge9+kC9J1Rg7YUtvUBcEkSP?= =?us-ascii?Q?BK7jBNsfS3YIWH3feuR+3wnw417bIB6uFlnRY40JkWOI9ewOk1qmzQ0boLUd?= =?us-ascii?Q?n2FkwJXEb+OjSm5zqlnVB29KEk7YxYNHuY0vlaaMeuYgS3XMHLVU8vDAmIny?= =?us-ascii?Q?N/uak/dMHdalmA4QyMNw8+rKd3GRNR9kMgC74iSHuveLpTe4cs3hCbJ/3M2y?= =?us-ascii?Q?oAm1tkLRgf9Zr+btTLMG2AuXoXFudFh8FrVN/ejMmxySmzyURiqeoyEYCmjo?= =?us-ascii?Q?MaDSJhN5f8q70IYQZILJ9mqEfykAsbityMxeN8Tbe2ttZt6oibaPog7lR27H?= =?us-ascii?Q?5FU2i8y0HrPPYN3uuPfxSV7ZyShzdeAM218IUu2kf7O5yz8LbJTVaCoACAhq?= =?us-ascii?Q?L877Ts/SEgO58u5586xCrzCUH6d5+/I+3SijOU2FNf9J6i9itLBNzl2sK64Z?= =?us-ascii?Q?VHLxaJ5aJaTmAq1E2lmyktKGAvlrLzliCtOcmmvnVHZcFX8Df9wqL0JZnpbG?= =?us-ascii?Q?FJKr1ZOjsr+Yn15gSfrpFrkf2xRhsUZbKWhFPrqiDSNdkVaDx5eYxTT454/K?= =?us-ascii?Q?Bbl7SnKAmK1oG5+gTAG1WtbJYTXCvmdgf797/ZlUsv4C0qsQhWmeBexd0tb3?= =?us-ascii?Q?vX+BqobCCDoojI2Yuy44EwWbaK3etwCNt177N9DZtAj5ullZFLqKclMzpnw/?= =?us-ascii?Q?HfT1KZHEQyNHfu0rx3UNFr21IJU0MI15qx8WU1L8c/xBgLv/n2QuE2Clsobz?= =?us-ascii?Q?AuuONVYIzC0JDNaKvqNctMqfy4+LaNMTqdidyPOmZCjzK8DanVndInKmoKEm?= =?us-ascii?Q?YG1ylMkLJQCfAjjkDcrUo8UoOfHfSkXGLjl74q+xqR51CGfsQ/7zL6/Q7DYp?= =?us-ascii?Q?YBShoVpKbRiFUEOQfZviudS9D/Lh6/czsrMNaNO2sw90qJQeVVPXYtYqaAGN?= =?us-ascii?Q?T9Y2GuJdsQp+1WXZRCdkg4/g8V21rNYFngziN9R0KUqs6NbYGoi6et9531rB?= =?us-ascii?Q?nT2JkxRAGaL8dEtOoYW8ERVvqijby/wzKmyVqNZHmMneWjtjCj/+AWbHCW7E?= =?us-ascii?Q?5Bc2WGvFvmWrSYzJfjKjSA/8KpZGHY476PFL1xKt6ig/So+l59sbFNTRbPmX?= =?us-ascii?Q?w3d9fYDnHL7Es++d7syS4P1K+v0E1FEw+5BijBcgly7/VvpgCdl0rcZIz3Bo?= =?us-ascii?Q?yy1IZRTTPF9+nlIKFBHoS+OWRmIxHW+fGiY3lysOkal6cHxgPMMvzLBIHFhO?= =?us-ascii?Q?OKjIQxqy6UGfHZw59XxBRhNXmjXiMN6Ef9S1IPtyhY0BuReDzAGZfnEZK62m?= =?us-ascii?Q?cwaO+nLo1ydeOXcDlU/5jHOqaIh2MkuNm9ZT/YU2rfIn+1fRtd668rAGA5yn?= =?us-ascii?Q?NbUKkQzEuExIdOatCBDYDZD1covHy7iq5+SzYgd3Sl6tErrL8IlHk7wxiI5j?= =?us-ascii?Q?A6X1fOh6OevZllPT9xYdXiANqQsC9ZoILLx5cVWyABA6jhQNQlmcqbBpbCqM?= =?us-ascii?Q?Q69tehMpn/6t7xEisgUqY1gxzJLupz8I+5xWn1Qx?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbf74841-42f1-49b3-b10e-08db24f7c1e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 01:51:13.1387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oGoA2vm0hC4UDy85+/AVLYiaknKp+s7EOn1I3t62A/vM2h9Mp4H1LIngqbkYAXvWFqJdTmlD1M4aCqRJFebURw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6705 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > + > + ParentPagingEntry->Uintn =3D (UINTN)(VOID *)PagingEntry; Only address field is set but attributes are cleared to zeros. Then following code sets the attributes. Still a hole at this point, right? >=20 > // > // Set NOP attributes > @@ -363,12 +370,6 @@ PageTableLibMapInLevel ( > // will make the entire region read-only even the child entr= ies set the > RW bit. > // > PageTableLibSetPnle (&ParentPagingEntry->Pnle, &NopAttribute, > &AllOneMask);