From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.5093.1677722286409435418 for ; Wed, 01 Mar 2023 17:58:07 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DmJqgAKN; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677722287; x=1709258287; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=c5rxz4Ke7IsgHTux/o21w7HXZgnUwGN05unQ6KuIsY4=; b=DmJqgAKN61NmQF12e/7kZJjSVTu0VyhHUMz3n1jSG3if+hpR92Oqtx6q IJcL6SIL4+sVX9gMhhD5hhbutjI3PwVpD9gdt0lbqZ6ORe4ykMxpqEkvw 1SHDbd1qxG+TatBeRIzxyFFMtiKEQK5DnWWy18GTbme8zFqiZzs+Qz47P eBqI3CsRdyn2VFviq1yo5ifBKZPxCD0Pyvw7HR1BTO7aLtqeEnTkK9Qze 4CuIs+Mbm8EuOmUz3XEPiEdsYTKh4xLhikGRMVgEXsj8ild9fb/kW9eHK oP13GeNxwzHXoRViKk4Rwurw8hGWKo5pb6Sm6fiWSAB8vEHj4kFX3jNSq w==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="332064684" X-IronPort-AV: E=Sophos;i="5.98,226,1673942400"; d="scan'208";a="332064684" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2023 17:58:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="743648377" X-IronPort-AV: E=Sophos;i="5.98,226,1673942400"; d="scan'208";a="743648377" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 01 Mar 2023 17:58:05 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 1 Mar 2023 17:58:05 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 1 Mar 2023 17:58:04 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 1 Mar 2023 17:58:04 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Mar 2023 17:58:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J3RDxCVAgvbRdtiTCe1RKc/Y/TFSkKnOMJNo/WuWBn3wsk65LYuvqzMsnNlUqOF3Vns/vUMC9buyC816zNdsAtRVNbXPPR3v5XeUSlyHO9lyOkN1ANrxgszu8JFg0GCz1f/o/Y+0qW+qCEDGJqhP062x6BtqoR/qc+69mjLF/3xHE3nuj8/heU9hqVchjzWDVEFOyEzUq9DnstUpA5r9g/b7vgl9swWoh7jZlOIZfyizOVjoXjYirkVPb9KAMpJrkh2UF6V51cY4GVIthDARzDNio2ApGxZfjfMNc8NfNbyJWICx7S8n1bMqxK878Q94h6QAZWGsEWMMn6Oo/9sgbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bBIlBuEJ5kKZYL3FbAccRq93/bIFQmsh+9dl6NHALas=; b=CwOqzXQO/YmbJ4vC/8ScYBjkpsgJeWbgVN4hrCxrzwzmfv01rv4WubwCHtDUhIIajtzmegHKcxM2pp5bMJsk7a6Ldu0gtu5II66MRp9YyArr/4bJTbmj0crjWMARZKOUb9qWNqQe8WRYinA347IBJoyfj8AWBMv05svtMGH3sE9jceTVilUO7E4WuFTtiUtqghIT11NjDmBc7GB2xVtNgtQcAc0ilmDV7bFeYr2qjyCPpTnn8fSz4s753xo8f5T16BCifiEVpAgT8LDE+/BYlSs2F/o19rkCfuQ6lxai/mTBZSQ3GIBA3ErRGYKRYaeG3T9/tmd+Zvf2nk/GRg7ilg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CY8PR11MB7876.namprd11.prod.outlook.com (2603:10b6:930:7d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.18; Thu, 2 Mar 2023 01:58:03 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::e342:cbf5:6c57:e8d6]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::e342:cbf5:6c57:e8d6%8]) with mapi id 15.20.6134.030; Thu, 2 Mar 2023 01:58:03 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly Thread-Topic: [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly Thread-Index: AQHZTKYgzHcJxmFWCkiPotUo6VOdga7mu5UA Date: Thu, 2 Mar 2023 01:58:03 +0000 Message-ID: References: <20230302012649.1512-1-zhiguang.liu@intel.com> In-Reply-To: <20230302012649.1512-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CY8PR11MB7876:EE_ x-ms-office365-filtering-correlation-id: 888528eb-8832-4805-143b-08db1ac18ee2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AUTkDLps7mxHqt/AgFxIMmiEsNkC1JWoDxcTx+XtN11mVAkcTX3qCub03O7QO7ltrsKXCD6oVLto846pC4jT4vPCfnmVOsPRqw2Jh207j6B2Vj6euZWsy4y7OvxRzjNC9kYI4Tb8qdOQlN0ghbE2c23LyGPlRA35H9COyUnbNj410HnaBInt0v+v0cUxT65tUyTmx2U6rUP1PD4n7GInV3q1JH+bWeagycKIykzfjMnYfMLvRGgfLWv/1oiOOvschuLYoMXoy5ZX04ylHA20dL9xZezEPNXHYgDI1auPPXpKZ1MFtU9bEM3F8i1+nRvpn/FHDSA14Z/tzkCXSvZHMBh57zXZhL/ociaiRdaonVDqiel9HtM90mxe6wCU9svaHVpgE5mq2hLFPvxCPD+iUP6rDdQ6Tb+pJw7ASKVY/msPCwPCoEfl6EWkKDNGehPy2vkfANdZd/0/U3lHMB1Cgvc6xfJQ7OsVTZLgSOyi1PLWii8s1fmKmyRKsMHr7CzQLYV85dlfPGih4BQTybULltV7CsUC84Yvlh0m6mjxueTNrqe50vhwkL0uz54NL6p4yh9eMckW+LJQKAo/cg9PB/qTNpJo0PBjgBtGsti0k77cm58Ot6jM/1u46urQzkSiqAVPthhMEZYnuUp+M2JjWFkERNY5f6ms5asztToFwg+3g8zprSzl2VP95gOs52cq x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(39860400002)(376002)(366004)(396003)(451199018)(53546011)(966005)(6506007)(186003)(26005)(9686003)(316002)(54906003)(110136005)(4326008)(41300700001)(66476007)(66556008)(76116006)(66446008)(64756008)(7696005)(2906002)(8676002)(5660300002)(71200400001)(8936002)(82960400001)(478600001)(38100700002)(33656002)(122000001)(52536014)(86362001)(38070700005)(55016003)(66946007)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?k4ffGxnrqRk7PP5IvFrbdj9sm3rEN24nAPW4Di+a5ZuALDCFsjrVpj0wpXXg?= =?us-ascii?Q?BjJP3R1X356+nSRApJtpmg7GeW3swTGRNeUCDPrPWWxx2T1hGQPMkL4PyuXX?= =?us-ascii?Q?rzu8+8b2A4sHxUNucz4ZqRlM/kiLpM/nCn9bEgJLbJ6FGR9COOVPx8cskJcx?= =?us-ascii?Q?tnFeAISq6ekOZJ/9RlEhpnKU2NZQB7FZGK+EgSSnvuZ83WtW4HRF+JpmrMbw?= =?us-ascii?Q?kZvcrDUlJh7lbma3IxvikHE3PoBdeIjDRbR/yGSN/pr0Bd/MoFSKN34pbu8t?= =?us-ascii?Q?d0g3Jb+IqH/B+KKyz1HEe+vbKCMbC5Qc+9yTKZSaQNtKqRqq4tLyCdRcvIBH?= =?us-ascii?Q?aUbc0b1tPuaiwMAXxjOYlk9JsKXve5NYCQkzvA+2P+wTry4B+B9sviGVm82l?= =?us-ascii?Q?Otvzh3UyNYdieVAPG5rvq6uW/5vG8hQJTkAC9XJuo8JpZ5L0Br46pm3+WbZI?= =?us-ascii?Q?Gk250smWplZsaHKFgKZRPYUjGTf6EZ1r40/vvf/nY6PCDWx2NfVywNn5Ajqg?= =?us-ascii?Q?uhu0tlllYFYAxfGR8kvjneAr3h9HfEO7zGeczEhUqP4kYN8i5r0kwUYdJGbg?= =?us-ascii?Q?PinJJG01MT7b7QJbzRsVa8qfywAHwBqLee1x+9JghVGVOqPbsOsC7jyY8hHi?= =?us-ascii?Q?INGRrjFMhgkUz1bo/phwfOLxWdRm5LUjtVyKALoAUZoHjHTpt0Hf7882yP5k?= =?us-ascii?Q?oDIdaATLiFDDRsRzFDxpGzUEPaqHNSHGO/BHapDB062eczOQ7EuTAvvTg0wG?= =?us-ascii?Q?p9sJ4r/MMtH1sh6cXdQdNwaB2lo+46ikg+vMFHprJfjm6b77Gf0F+ON1Zz17?= =?us-ascii?Q?CFKrp5mOe/2zyLgnlvWTDDO0uX7t/5IY5SI7bMDvaDz1p7cb7Nk5zsCtSSx/?= =?us-ascii?Q?3bUoGt8b9rfvrpDAMViGS8NHUMa/h7WvgBB0+2sNChAjR9ea93TdfXMFRXM6?= =?us-ascii?Q?0n2rb36pBrmJbKWGOSIuDZmSIchojznEhU+Redfko4ZdPl0PiS5ly5NlwAKF?= =?us-ascii?Q?oCB8g70sauS3F0LsMz0Uz3VO0XC1dxFskJ+MFN/KI7iMzSXf51MN4gTfrUuh?= =?us-ascii?Q?Jry/OgUgQ1taR18HUJp3OaFgMO7NFPutGWKnGRvJusEMUQv4bz0do1/Ny7kq?= =?us-ascii?Q?BN9bhz4clopk9vA5clRRh9stn2F76aYByGK/bAA6wm0BseeJfP8LkLb8HvU7?= =?us-ascii?Q?S2AA3LCznFSbWmTqLsJ+rv1HUOJkLELkEeP4vBxj7MR7utl1izyiV0b4aSW0?= =?us-ascii?Q?EEK0P/wj6S4e6uVl9ssLsDDAd+NWtNsH9hcmre6qts/or6OdVR3sPXqO/jv9?= =?us-ascii?Q?ugnUZND98pLxPyCIofaTYBo+XMUPEPNrDfmC4ZUPfz/6Tqe8j62Z7er/ZTze?= =?us-ascii?Q?bixImePRC7Z6qQ2EX/3KpMen/+oS8EPGoCwcrNHdvY6B+Y0R2jCXuRqRvtAt?= =?us-ascii?Q?heP7KAE0WCB3jZoqol3tFyIqotml84McMu3NHst+z/pB3FketCmUhgfD3xbd?= =?us-ascii?Q?WQrvoA84S5WVTCaUzIMET6oBN9k0gk136PZxE+eunXY2fAB9Upv8teGqNtVp?= =?us-ascii?Q?kw2URldg1nVtz61XA0hJKIINWscywNpk7D+VgJ5F?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 888528eb-8832-4805-143b-08db1ac18ee2 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2023 01:58:03.0935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7kAsDkA7LlFAyUQ60fUOSLwo2U276OAuTK5ZlfaiafZcoKOfc4RbC8D25HhvIeh3bpuXWmW9nL1fF8GNgtK/uA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7876 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Liu, Zhiguang > Sent: Thursday, March 2, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4238 >=20 > Per SDM, DisplayFamily =3D Extended_Family_ID + Family_ID. > Correct the related code. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Signed-off-by: Zhiguang Liu > --- > UefiCpuPkg/Application/Cpuid/Cpuid.c | 4 ++-- > .../Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c > b/UefiCpuPkg/Application/Cpuid/Cpuid.c > index 372c6ef87d..51c463fb10 100644 > --- a/UefiCpuPkg/Application/Cpuid/Cpuid.c > +++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c > @@ -1,7 +1,7 @@ > /** @file > UEFI Application to display CPUID leaf information. >=20 > - Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2016 - 2023, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -217,7 +217,7 @@ CpuidVersionInfo ( >=20 > DisplayFamily =3D Eax.Bits.FamilyId; > if (Eax.Bits.FamilyId =3D=3D 0x0F) { > - DisplayFamily |=3D (Eax.Bits.ExtendedFamilyId << 4); > + DisplayFamily +=3D Eax.Bits.ExtendedFamilyId; > } >=20 > DisplayModel =3D Eax.Bits.Model; > diff --git > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > index a8e4f920fc..25b8958252 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > @@ -1,7 +1,7 @@ > /** @file > CPU Features Initialize functions. >=20 > - Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.
> + Copyright (c) 2017 - 2023, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -67,7 +67,7 @@ FillProcessorInfo ( >=20 > DisplayedFamily =3D Eax.Bits.FamilyId; > if (Eax.Bits.FamilyId =3D=3D 0x0F) { > - DisplayedFamily |=3D (Eax.Bits.ExtendedFamilyId << 4); > + DisplayedFamily +=3D Eax.Bits.ExtendedFamilyId; > } >=20 > DisplayedModel =3D Eax.Bits.Model; > -- > 2.31.1.windows.1