From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.8360.1681199443708090869 for ; Tue, 11 Apr 2023 00:50:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Y6Mpq/SZ; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681199443; x=1712735443; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bfvRZmbVoT0OS4RK2eZ+/VWvARayfwgR+q4cZqD3FB4=; b=Y6Mpq/SZK+JPL4/HpbewVscehGft/2a+2e3W++Az0WJ8h/QwvZ27VoNY Cp/vREByQRFpMtS1F0Ud/1dMr3HivK+uN86C2fB2DIyHlv+DDViH+jMjI ilzEAsb071/FO5QQRKivmpxLsyG7loIUBvlghPAZ9cZ4zTG7HhOSi+/Sx AE4V+Ux6j0gC1w9Ou9MT5+StJh3b3BgIaWmd1EuPuEItUzP2ZwZCUWKpR 4nLqgdk8Fz0+AlFkCaGNOTzpfFYamyI4p46FakUDwfHrpHxFGiOxszamE X/eptS4CsmuoATt3l2AYLWnpAR0cXeDQKqEQWP/omb4mY+9dxYqRZniMV A==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="323912470" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="323912470" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 00:50:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="757724344" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="757724344" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 11 Apr 2023 00:50:43 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 11 Apr 2023 00:50:42 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 11 Apr 2023 00:50:42 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 11 Apr 2023 00:50:42 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 11 Apr 2023 00:50:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RtpHTocPoZTPk1wyHI7iPQXFcO9CmQ968r/bmU8C/sZUofvU7kvlg2upngRuLi6yh3ajqfX8wXoCXFGKupKQyGwPWDLRpowpA+S4TwDpOs4mtTiNvJI0ZuIU2ViZ7X3k8suqP84p2RZYLn5IK+iQJlVnwS9JJ6Px1/swg4x9GEYBRl6OB6QNQaJGaK1niiOPNl5hV8gCVA3oLtMJH6rFOiwMeLMiERTNoOrA93KSIvRba/7YPn9EyAQNtfYHHFJZyZDoXZGxq/zkpm38BCop8fZrzODm1gN3ekLXuehA8ktYWVr1PCpYxRIwALERAUf2EgssZO54C04uWKMLcojcWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oNkwyOBpTK3uPJCE2vym1QO6W4LFppHy1iToKhmmcNY=; b=gXN8CXZeY6V9vML87Ki5MTUhtUdjQEy1qocpEIRQvLxKnxhgFMdSs1It+MgmCVGO9FfXlgEzTDidwaOPdEflbb3akgY8e+wKmP2Ygkxom97AzOvAGQxiccTB+uYoFx5KFw1qXwPdIlf4ARb+ulJmEUirEpL2+KjWfYP7vC4gbRMgH3SF8lgv/X1Ip7qgpinjFv7ziZH+0Iyc+VpH1qFXukax7AyND0kt6ETSTIZJe1o/g7pvUOwg+YEVaGZeoCyIYLydQeLfp47Yk+odVIiuyJUQ/P7R/5hXUSQldzlyvPIsG2ZQLG4yX2HKe7jhHkq6rGtKaZ0wrzgxcjHGMJpxnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH7PR11MB6401.namprd11.prod.outlook.com (2603:10b6:510:1fb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Tue, 11 Apr 2023 07:50:40 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6277.034; Tue, 11 Apr 2023 07:50:40 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "abdattar@amd.com" CC: Paul Grimes , Garrett Kirkendall , Abner Chang , "Dong, Eric" , "Kumar, Rahul R" , "Gerd Hoffmann" Subject: Re: [edk2-devel] [PATCH v8 2/9] UefiCpuPkg: Adds SmmSmramSaveStateLib library class Thread-Topic: [edk2-devel] [PATCH v8 2/9] UefiCpuPkg: Adds SmmSmramSaveStateLib library class Thread-Index: AQHZa50uFCCp8JcvXEqW7Maqrbr+oK8luvNQ Date: Tue, 11 Apr 2023 07:50:40 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH7PR11MB6401:EE_ x-ms-office365-filtering-correlation-id: 7a98334c-e9ed-4643-596d-08db3a6171f4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3kl2+KrW1PzKm3ZkLI0stK+JpgxCjMikCekLZNeC/guf973UtSG1XGfN76CDmLUHuB1J/xmsF6ytZuPQGpq3DrH1bqGOjrBa530YgzD1RD6qkr5G7HEzf/JrJxDzIjQUtNg7nVSQW1cehzDDH18pxGoHtaTmdxLstJciMH/TmM9EJBPQirbjlfhcFk7BBm9ErC2e9q2E2Sw2UB4C92oK6IvkA+H3ev0PPfIGgbPus4Sy9Ygaf2jysd2pOWrwdsxnCL2XWjrZpTeJ1lwkRuQsE19Dg0Qx66qOh0YdLxL85qKP6Y/5seIuxaVHv3ygg0w0aP4bDhAAYGQDC6NOscI1deQQbDs/uNmlVbJcjLYvFaBnk3g5p/e/CljIACmnavvWulSyWMTPxPfcvWuIZj9nEu28TO5m/aqU/rlGfx6ijH0x+gFML0h2IyfmUOJDIvPcG3bOuWqg+gZVcR+alMDAiyFDnvg7SllTzsnjuODPIiuBEg+aRrrCjFP5NfJD5cI/718srboCrUG+GL9UDce5t5BmGevmPhyQIuQXBGejqkuqDli5G4jwOpF4zcIvewuOj2hUuJ1NuK+Ra3Fsbx6o6wuAxKDgHlrLd3dFWBepDz7kvDD/fjTGtv3ewTzg/T6ONllqZ212MF7BomDIbTzicQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(366004)(396003)(346002)(376002)(451199021)(71200400001)(7696005)(478600001)(86362001)(33656002)(55016003)(82960400001)(122000001)(38070700005)(38100700002)(4744005)(2906002)(9686003)(316002)(110136005)(26005)(54906003)(6506007)(186003)(66476007)(66446008)(41300700001)(8676002)(64756008)(66556008)(52536014)(8936002)(5660300002)(4326008)(76116006)(66946007)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tta0XczpKjC43aKQMImLFr6Vw6QEGiMJqNAD9vScgTtX2iaYra3jb/6KZIkv?= =?us-ascii?Q?jyp3sCbVqwOpZDCo9F9Cf+Mxet7urQqe3HcKDTNS+IUDZHOA9YKRx1Tt241G?= =?us-ascii?Q?+5CdR6HUV0dCAhUZYsiTLHPdfUGGc3o7zViAAxrPerNt0/GIX7dwXBPfj4nF?= =?us-ascii?Q?Sb0IT3QBk1I9WDn7e+P3O3xMdK2t1LBB8MqFBpEnPgHwKzyGnqbPEVhvOMv0?= =?us-ascii?Q?bLCyXNJhVh1bVREPDvdSAf5dcFfZllumWETON8STTtkgZLvRUmRX2r3rtTn0?= =?us-ascii?Q?J+khNeUzgZXkw03QX5z1rhtsrmYrcOjKvcoXuRPL/HZL2WknOdvbA0t/S1Ss?= =?us-ascii?Q?9ND+XZDiBO+HWBTIfwLssarzmT8s+CoLFbJToP/5OzDB0/sp4hCdXHCHoq0P?= =?us-ascii?Q?63WCD8aFaKEiZiUc6izoS/j6gwJFxTy4Me5cXaJEtq7gkAJU2qeT7YBs5LLU?= =?us-ascii?Q?5nNmxb9P7IlOQud860pII9eEf6t1LYJkmDEGJiDpj7O4yVGOPW5b/iGCyAT2?= =?us-ascii?Q?ZXDAroNO5kwm+LzCGzg8CophHXWmX+4zpKKvjeXOBPwkWvzYGYuApNWayIuD?= =?us-ascii?Q?ZJONNyu9cbTrmOPy8tZZSx90GOiyRW58ZohYRl5MUaRTLGjB6H6WPOo677Y2?= =?us-ascii?Q?a+BBhRWZ0g1lrp+y8IXoDqi2HY49YdBU2yIFYPAyPK7MX05z2YxskCcAp+QU?= =?us-ascii?Q?ZyrCexkbCRZIeZrv6+dhoumva1vPPpSk12H6j1oMSmpV5TMkQT0elwyyTv7b?= =?us-ascii?Q?ckXO90GBOvFHKp/7Eo1ZmFOFbvCDPdzjcBnhQLuLtELNrTPXZsT79R8D4U/A?= =?us-ascii?Q?VxHYcwQkK4IFV1rY6GXkCeRaYA+rtWmhxXr1Sd+ioZ49OXr+NikJRL6FDmpb?= =?us-ascii?Q?iRBaUPqnJ1XqfaJPoMBGE7O3XsK3+ulisR0H0tck8jT4JgoTzszYjd6/ncPD?= =?us-ascii?Q?JntrNpc+3Hit5N1r2xBjlK7usbGpOTqk5foRARxA/d2qgzao7/dlQMlw6xsv?= =?us-ascii?Q?JN3R6zKV00tfCDreksX7QLUaABNXL2IVXSL3TxCG2iinF0KBY1AHKTPBanrK?= =?us-ascii?Q?h1AT1HMGmWtrGSAMv59asypDltOh+PZV+6/DMLNhro79W5oRx2sfof6vw4tG?= =?us-ascii?Q?+pz11Ndvh3yBKrgjfDsILdomM/IjtNC5iXs/1mCCeYutG99MQSiGTgvO8V/v?= =?us-ascii?Q?ICkd76MYPwB1VWR45kGP0Jfaw11aTGO7NvUMbhDuj+kZMgYt/tJUqn/lL8vj?= =?us-ascii?Q?0jYCUhTUEIMtcRUZuJAe3SJNlMA/izapInQLb+vwAqEk4pmLxzn6PbMgk0KV?= =?us-ascii?Q?SsAoQuiumtfbtsu4hlsFuCsXdVLWjSHQHH2ebDkZFOkP9xCp9pWVCIocjWSx?= =?us-ascii?Q?CaWTrElLkPsgc9YxXb5AcvqGfM+probBYWbk7GLplBdEY5JzNwV0YIYsDHGf?= =?us-ascii?Q?XEoeKJhrAHkx1aGYjmMgzQUuByiiJi0PthQ/HGLxQa3mT9EPIwyZXt0yxcPc?= =?us-ascii?Q?zz+1nn9mdUCGPttzddYoGiw5GTrKo0D4ekT7UPQ6JqtmUy/8M72EgiynSIkX?= =?us-ascii?Q?t1002NdwYjbSTOItRe8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a98334c-e9ed-4643-596d-08db3a6171f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2023 07:50:40.0574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EetgOj/BESWjtK1uImGvexibblDpRM1RvR2hv4rKNiIGxxiPbY9xkGzlTlqe5CUXt3Fsq4UWQ3KoRuQ2jfE4Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6401 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > + ## @libraryclass Provides functions for manipulating Smram savestate > registers. > + SmmSmramSaveSateLib|Include/Library/SmmSmramSaveStateLib.h 1. Can you please rename the lib class to MmSaveStateLib? So the lib can be= potentially linked with standalone MM CPU driver. 2. Also the lib header file name can be "MmSaveStateLib.h". > +EFI_STATUS > +EFIAPI > +SmramSaveStateReadRegister ( 3. The API can be MmSaveStateReadRegister(). > + IN UINTN CpuIndex, > + IN EFI_SMM_SAVE_STATE_REGISTER Register, 4. "EFI_MM_SAVE_STATE_REGISTER"