From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.79735.1682431053686141322 for ; Tue, 25 Apr 2023 06:57:33 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=c4ct3+3i; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682431053; x=1713967053; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=RW2LNv0RGe9x05kLemGBk364V29ox5mcIz9WPMOS/AM=; b=c4ct3+3ihFaR5N1MqEDDDqs0iaXuXbC/5ZbDiWyPjZxYIUuIW6qWBSQH upz8Nh2di0kbVyvGx2J5VfVkxJMAeRS96u87WQe3ToP9yrA89mqOnmMHk PKCJIQzPpKuwaQVQBnge+ytZPRcPbaIc7NRM82Befl7aLyOcappU07TTc NHUVx86vGZ/PYDj9E1OTdzWpotck91emSy5h7QKsn//3T2mgkb1R9byhK Cwgib21RQ7IZ6FrVP7ZOu1JEwOOT22hZTfpS1OU2pbHfwbkiC2PYC1NcF mZynVHe1xr77icryrzcxzVexH/02tYPTWqErkJwHF8miZp2uxJbNCieH9 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="433033099" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="433033099" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 06:56:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="805078205" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="805078205" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 25 Apr 2023 06:56:01 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 06:56:00 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 06:55:59 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 25 Apr 2023 06:55:59 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 06:55:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LKFq7xbHVZNpgBOACFGXy1+xRe3NvwUfeBBg1eTzDnpabz4aWkHET5PXg+zwLaP356xhEk6OMKCntvbRFqUBMEEERFbd+VmXxT/W0kyM4tgvo1eLeKA1XTCHvUBiYT5yyRtdKjOnpSIDynOrqk/+qthzNuwDA2Yx/3UfZFWHqzXqpFtoRP7gCmhiilGi2bRKnZN+nN1lppH3sZQzGmfclZnQ+RJ3uXX0AyrBTy7/f0nAPH++B+4MYjRI+s2Dqr38NnjP6rtUk9So1tSmhDT7xhn2XSwBD7DpHt4xcjc33Sr+w5CPoSQGopAx4ubQrOH/8VyHrUC3appXTHiMO3WrEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BwoHsqAnCK5d7WBV57t4vfMj60pCCtEDuZ3qt9hfhP4=; b=SxF6jcEmWonHjpWYcQV0JaOrrcpQsAHGkG09ALa3wPy7DjsytKe/jxbkIadiMwiE6smPRpz4op/TBv4ZVX5D3V+UhcCgfIcOe1AiAMLLuOPMCzF5gklU7siMhe9wiDBhZ4F/eoZhqJ08aAbkbX93a6j0I31mJhUEDSdPQE3cUJpDU++g2iSCjIXlQWDv9mMmSuVgJrF2GPzrDswSCG/QeTpIkspKufw7elCIkuDMdl5e/T/h+NT/7YgcEr9/FTqz9MmsRsYFX3x95RyNt91HHwe01j76ItYTSYQtiCzjOcnMOS/MyD98uQB1gqsKmz0Gom3CYE1lZ2hcB9tyWHKsVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CO1PR11MB5074.namprd11.prod.outlook.com (2603:10b6:303:97::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Tue, 25 Apr 2023 13:55:57 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6319.033; Tue, 25 Apr 2023 13:55:56 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [PATCH 3/5] SimicsOpenBoardPkg: Use SmmAccessLib instead of SmmAccessPei.inf Thread-Topic: [PATCH 3/5] SimicsOpenBoardPkg: Use SmmAccessLib instead of SmmAccessPei.inf Thread-Index: AQHZd0QW8eeYNeE5FE6B/S4NURAvYq88DKfw Date: Tue, 25 Apr 2023 13:55:56 +0000 Message-ID: References: <20230425070304.2120-1-zhiguang.liu@intel.com> <20230425070304.2120-4-zhiguang.liu@intel.com> In-Reply-To: <20230425070304.2120-4-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CO1PR11MB5074:EE_ x-ms-office365-filtering-correlation-id: 61562718-cab5-4fba-bce1-08db4594cadf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gHsKKpkFV3nJwp0R6Mj7cO2EzLCO6u3iqW6JZddMdZhsRrnPDT0XW1A4qDo6txOpJoT1RMA6h3bNCfxvNuUF3STzivArkPhdZEQ+nHqlFxTCBi6DRO3bA8W32ib2iKb/hqMB8UhLjItTYJNacQew+juen6SGCOH1xRwurpuGnpfHb+/Fl7/T4BcGijeo5SduIYZ0l6e1w+HpIYrkAWxY2oxPO5Q1hIbe3Ix9EAAOGm/QjL6aLVAZ7lREsOWXDmc5PMF1eINPy93gJqIdnTlsbpgo7QQaNXHnN3Vwu2qckqZQrTjefkcxD3gml4LDSgem4hpiicgnuj/GNqMs4MamBHEj2sdxgR0GTK2jx5c8TeVLSdEJT811C+6SK53YNA35tKCCo99SUAVGFF+qC5I8LqK8nFeWJyXmXg0JXj62YgzUcNgVCC3OvvTBKEByj/papOpKeSUt6GwvNqvw9Bv/mI8l5lqcyO48dA99h2sF/jOhW0OtiLnE/aCISaT5XyuJXUeen6xq9kcMTq0gP9VXKHBX2xgb7FvA3qi7Htga+i5+eHQqVFiN4a0iKUY4bT3rv8xki7QeOGt14xWm1drBevVYmNXxuCnNChxACKQUB/fmU7cXOHMHK8mj+DCPd0Dq x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199021)(9686003)(107886003)(53546011)(6506007)(26005)(38070700005)(55016003)(83380400001)(186003)(82960400001)(122000001)(38100700002)(66946007)(76116006)(86362001)(478600001)(66556008)(66476007)(66446008)(8676002)(8936002)(64756008)(19627235002)(110136005)(52536014)(5660300002)(71200400001)(7696005)(41300700001)(2906002)(4326008)(33656002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SnrnV+GqkHsSAKeqkIeGQ0zsD8SX/NfX3idZb30QK3C3SfHRpVCcPPpJiLES?= =?us-ascii?Q?LHbiFiYoySsEGdt+CZto63/j58dLTQdKjK4IFRGltewXj6aPc8vdhrcjJd+f?= =?us-ascii?Q?nQ7Iv8PX5q8BX85wNw+gyNNVtqVcNX/ra/V83WOJckMn28Chi4kx/Tso0IK/?= =?us-ascii?Q?929o2ta5ZHBmyfblQhGze1NsaxEA6nDpfhAdUg93HGMsZnYOUN+eAXnlJrsY?= =?us-ascii?Q?1kpjPpu4vF+mD1thcRxY5iPNcNinCAEFE4j/6NOJ267YyIPpZU9wo0CHnk4c?= =?us-ascii?Q?+TscNkS2+6EynjWfqcllSKMhb5Uwi2H5kyXOKE5OAOVM6qI1/QnGvblMv6Qj?= =?us-ascii?Q?2jMEDnR4soepOqCf2Sv5liTeTg37XA2h+BmfVfHNAFf1EXZWKEkQofne1sh2?= =?us-ascii?Q?XWr3GaJ/1wK5YSXjSc2/xrNG7w153PrhVonm2acCX9Q6KQ29ROdsXLB4/Lu1?= =?us-ascii?Q?LktRGlVFH7P5DTy+O2088d6aTDdgwqwwR9BsqexWHTNAjMUwoh+Y/NMcrhQs?= =?us-ascii?Q?7HjGS5jKwBUItMkM8bUZfIr9Ah2/dx/tXFfc0C0+J9ewnSLuA0lMHseEU/2d?= =?us-ascii?Q?pEOez9FnBU6XaMDOIG6S0Fc35vG684P/1JvtTi+j6GY6SjlN9plfCjmEkekE?= =?us-ascii?Q?LfSZyZ0Ep4dAM8o6lmyaRfLHo4LE6ZgGu5/WQKwdNoatVgkfdYniXnTrMHS2?= =?us-ascii?Q?H8sW71pyEyAMA2HAmTat9n7Y1B0hHtBEsiemlxoaunjRSB+dC5KkoszgwA0r?= =?us-ascii?Q?9FPTeqLbUkFOI8q0JziT0/nkRqqXuLKnCJyREoEaTfiqN1AVLuO0FCYY80iG?= =?us-ascii?Q?FOAStlD9Ky1mb9x0gxw/ewuB8OIcH422JYgH8IZclajPUla0Zt355Ynw62F2?= =?us-ascii?Q?AtUdhrrR+GGiY0Te7673oAcY1mq9tQ1bpKfgSPJ6IyB0aftE6/ce6yRVkFRp?= =?us-ascii?Q?S57sCXldP725jwLwIaCCDKsjUlUl1oSSATN0h4w3R2pUuuKUN2R3Z1QaqYhI?= =?us-ascii?Q?YkZpG4zPt26rJMJSVB7KEkUBM599/3+C/iJIha2JujbsM50G9wCvWcVHCnDH?= =?us-ascii?Q?3EdNVsgxORG51R/TD8GldzbDgLSJNbmuYih57O7dLpQSJ7PAkqIak2O8cjWE?= =?us-ascii?Q?vbMxnjQQbMsukW4rsMhRjixUM4rTr8fgKLXaiSpogdIIyGbZHOt06JxvpmMz?= =?us-ascii?Q?FO8YGrJ2hEDVvd3oEiLNU7HKqMaRUML2ShuTgxX/W357sV5WUNOcY/6qCukR?= =?us-ascii?Q?Mex2tjy8UaAgbLQcQi6Wx4f38m9Kn6zMWEPxDIdspfg+gKjJ2aGhMrIaqgxI?= =?us-ascii?Q?Pp62qfw3OsXhRlLqZS/nya5ozz0T7S5Y0ghLDuUIaVjN5rAg4qqxb2ixzCx2?= =?us-ascii?Q?LLxahmrAnwyogbvKyJpI1ZyLK2jb5tx/wm96ERyCugCZMWZAXbikxiyath4/?= =?us-ascii?Q?riFEdBcfmYnwkTSCPBqzgD9/PZzX+VWkTTeGrHLHrreyZVHpJFI+IflfDuUa?= =?us-ascii?Q?HqjKrz7fBlOnpXwbVlH9oMESkBuEe1/tFJ4yyvPKaZ13ccE5RfO0/P3Qbegr?= =?us-ascii?Q?JWLaXW6f0/14HidbSJnaKKl/pHsbZPRRIgp+9Cow?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61562718-cab5-4fba-bce1-08db4594cadf X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2023 13:55:56.4167 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VWYAj/VPAq7umw9dUetjkfdvW06g3edRxIjxiEILexWOBFTs2Iu7Gk/wOeFCrbM3IVmlMbz1gld8GbuAWqj9Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5074 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Can you fix some typos in the commit message? With that, Reviewed-by: Ray Ni > -----Original Message----- > From: Liu, Zhiguang > Sent: Tuesday, April 25, 2023 3:03 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Desimone, Nathaniel L > ; Ni, Ray > Subject: [PATCH 3/5] SimicsOpenBoardPkg: Use SmmAccessLib instead of > SmmAccessPei.inf >=20 > SmmAccessPei.inf is a PEIM we should deleted, here is the reason: > 1. It programs registers MCH_TOLUD to set the Low Usable DRAM, > but reading LMCH_TOLUD always return zere in QSP platforms > 2. It programs/reads MCH_TSEGMB to implemte some Smm Access service > such as open/close/lock. However, this reading LMCH_TOLUD also always > return zere in QSP platforms > 3. It returns the hard-code Smm range information. However, there are > two improper things about this. One is that we already have the hard > code value about T-Seg base/size in MemDetect. The other Smm range > informaton is already saved in gEfiSmmSmramMemoryGuid Hob. No need > hard-code value. >=20 > So, this patch uses another way, calling PeiInstallSmmAccessPpi from > SmmAccessLib. The lib instance we choose will use the > gEfiSmmSmramMemoryGuid Hob information. > In a word, with the patch, we can avoid additional hard-code, and > avoid programing unimplemented registers. >=20 > Cc: Nate DeSimone > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 7 +------ > .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 1 - > Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c | 9 > +++++++++ > .../Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 2 ++ > 4 files changed, 12 insertions(+), 7 deletions(-) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > index 7b98baf764..fcae343146 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > @@ -142,6 +142,7 @@ > # Silicon Package > ##################################### >=20 > ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLi > b.inf > + > SmmAccessLib|IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLi > b/PeiSmmAccessLib.inf >=20 > ##################################### > # Platform Package > @@ -190,12 +191,6 @@ > ####################################### > # Silicon Initialization Package > ####################################### > -!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE > - $(SKT_PKG)/Smm/Access/SmmAccessPei.inf { > - > - PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf > - } > -!endif >=20 > ##################################### > # Platform Package > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > index 221706ae03..844f9b6dcf 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > @@ -165,7 +165,6 @@ INF > MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPostMem.inf > !include MinPlatformPkg/Include/Fdf/CoreSecurityPostMemoryInclude.fdf >=20 > INF UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf > -INF $(SKT_PKG)/Smm/Access/SmmAccessPei.inf > # S3 SMM PEI driver > #INF UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.inf >=20 > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > index 13ee415f40..f9a5487365 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include >=20 > #include >=20 > @@ -472,6 +473,8 @@ InitializeRamRegions ( > VOID > ) > { > + EFI_STATUS Status; > + > QemuInitializeRam (); >=20 > if (mS3Supported && mBootMode !=3D BOOT_ON_S3_RESUME) { > @@ -544,4 +547,10 @@ InitializeRamRegions ( > ); > } > } > + > + // > + // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case > + // > + Status =3D PeiInstallSmmAccessPpi (); > + ASSERT_EFI_ERROR (Status); > } > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > index 618ad4075f..cdc30ad582 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > @@ -36,6 +36,7 @@ > SimicsX58SktPkg/SktPkg.dec > SimicsIch10Pkg/Ich10Pkg.dec > BoardModulePkg/BoardModulePkg.dec > + IntelSiliconPkg/IntelSiliconPkg.dec >=20 > [Guids] > gEfiMemoryTypeInformationGuid > @@ -55,6 +56,7 @@ > MtrrLib > PcdLib > CmosAccessLib > + SmmAccessLib >=20 > [Pcd] > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsPeiMemFvBase > -- > 2.31.1.windows.1