From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.9439.1672911554386248427 for ; Thu, 05 Jan 2023 01:39:14 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gnfg0Bou; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672911554; x=1704447554; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4+B6PV1TzjFG/nGSk5acQaLSASVOUSK4sQD8VpyB4eg=; b=gnfg0Bou/6GdRd7R1Wj6y6x5HSC7V1R+zzVjKJPpNJSEDDNuMBko9+g8 LEDxxt7xaoJYlbJwx+Vzo/8sHnBtdT5YQ/GQaaz4si/FuZVVJM3qJ8MhC /VkHukfMh0iMTUsT8TRlbAaMlsUYbgmHNxrLCG8sZc8GEjD8Qea4jTs9/ hy8EmLLh2hofJfEnsZWINOlrZ3y705FJL9pHhNcSzykdonaxpBXvTvH9n y26zYc3trkEEpxM87cga3wFgdotBAN+gepkc6n4zrdf7AblvcrZM8KrVe Wo8He0iPFqEZn7x5pCUu+zoplk1ajIw8x7jetGQU/Rd9+AIxTgH3yecCz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="386595843" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="386595843" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 01:39:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="744168888" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="744168888" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 05 Jan 2023 01:39:13 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 5 Jan 2023 01:39:12 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 5 Jan 2023 01:39:12 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 5 Jan 2023 01:39:12 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 5 Jan 2023 01:39:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GifZdEvhUJf1IYzHhjJfGLQVqMj9SJLYR/dAtQBz7iiw4Q21GQ7HOxquaOPzh971aTRQDyhlug5WNvljk49SbBPye2sZD85s0X5w0bmfrLzxdhNNqcqAt5OPJ3S4RvWuYK9p6eYsnWvZLcbmRtjer1hKyjAeHwAW+RYGxjhSjP67n/GE+NRvhEeuLGQ8xWwucEvQAqUwm9CL6sECe602T3nD8Beqv/5cpeT49YEz1o8jkBt3WqS0oSBRMAy+xP2MHkILe7Rwsg+H+enFRrhEak6kugMpoF98yOEbllNhH12tcteISC2Of2foxXJNvV2owX+0nxoN6A6hu9mkCOEJdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vk/Ddvsv6zxjQnpFC9yk49bFzbWOGBK4ebP0ZiMZhxE=; b=BJyopUr1FEsvzSudF05kX2fGeW7qb261p2rjm74alASEvmK2XBLsiFwp/VlMKYsUrm9ClEkfMF0dWZyI0f1fO8TqOindg1321JLJCV1L9XMWfc6bv4NqR873VgDDTQg38LRJ0oSgLyfTltFaBjCI7B1QXOQKrE7Hfb5QsNnDl5siTki8PFaXnzroCZoegrvx6LP86oR0IUYL4nxV4tjKU1Soi5BGkWjThBJ5BhIuaAHDAfVDGEZbrxT457DNSdOTIfOh5rGmPFfIhcQ49I+PtO7TjCyXk8WWZ7k9RU8Dc78cph118kbX86G3vnbUnh30EGofQTXm/FzGTk68J6IsmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH8PR11MB6976.namprd11.prod.outlook.com (2603:10b6:510:223::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 09:39:09 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%4]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 09:39:08 +0000 From: "Ni, Ray" To: "Chang, Hunter" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Oram, Isaac W" , "S, Ashraf Ali" Subject: Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h Thread-Topic: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h Thread-Index: AQHZIBFQ29MyYFVVB0+Ere1ZhXnyaK6PZ+hQgAANwoCAAB0rsA== Date: Thu, 5 Jan 2023 09:39:08 +0000 Message-ID: References: <20230104074715.1782-1-hunter.chang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH8PR11MB6976:EE_ x-ms-office365-filtering-correlation-id: cb83217b-38fe-4f5a-9edd-08daef00b171 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rR5+p32ADoNOmCUsYEe/F4RnQrjbiGidHjcvoqN+oCdAf3X/ERRHZMaZOOWCTLVjHHJlaOQUMhxoZhwvYZelFRE8TsjBS8+O3heuu9awcfz5R3hSbKOD9VmylYtNEXEQvQj5nO/aRLHag0DdRbx2Inh/xlhuZQ036Ya7C4xrzq9mdmznBU3V9FZvN1s1ZJmq83pc1DnKCe0S5vzjYGjDakvg7HRI/NdPrShuatjJTdGJ9/CwNwhzSk7d/Ujc0gXHSkB9Gc+RE/KXCaP3RcvyGNyteUVtQj51QWtCiHoHtXCd9lG3V7/skGOBxtZV2tZwt0zi+tsMUrvX/qwzRVacZfFFgrPNX7ONOObFoDruxnZk5qzURisossoHSFHMmj/KgPNGuDJmMIq5Gbg8DNNtP06m1A7jGxpfE5ik8sHiv6O7sAQyQXrJTmEcEw9Co+5PkUVwm22WeCaXqyoExxCkmWP5eTBM0dt8WyBcz3R5PVMLyTKL3mTpOEdVaIElPjZNVpju9CDLK26q7ZsT5Sn9TEiHaZY12jE6HFphnqNSlbzrQ8TUNTVyRQnH5fyiNb8eZCtGR+NQZA6AkRj2ManEspcH8YSx14ydzDLogov/U7OUuJdkncvjPcFhnNyQHMUqMwHzVx3xUrqykaT7CuYG1QebeT2EKHQxJhoShRXvC2P4GVpRUXhGU40+7gvjxCZwiz+c70mm96GREJ32xcen2GcHR/gI0wvZdpv/BcRrmPM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199015)(5660300002)(2906002)(52536014)(8936002)(478600001)(41300700001)(316002)(4326008)(8676002)(54906003)(66556008)(76116006)(66476007)(110136005)(66446008)(66946007)(64756008)(71200400001)(966005)(9686003)(26005)(33656002)(6506007)(55016003)(107886003)(83380400001)(7696005)(82960400001)(122000001)(53546011)(38100700002)(186003)(86362001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WUc/5/qVzNyHeylAQscscqah3rC0wH+fVKEGDqL8t28jID3HFvZdglrrkVEr?= =?us-ascii?Q?vpaOMVUDKgryyqewu8MR2BDYs8vPLKbI8eVVwKYwavspzLU3whiF+belTPcs?= =?us-ascii?Q?Gnf73AIwG2AQ3Or6b1YmQk7oQwsrJXQlM9nazc6JmvQz7EO0rnGckyBwJW41?= =?us-ascii?Q?adKYItvUdvEHEl1AoYFQqz3R+VcfEE+f8jwCiI7c/oaWNhZcTA5LpqGPrk1r?= =?us-ascii?Q?U/jLsBqegi1dUbt2+0s4ZZ1GfD7GKNQdPji2A4kor8OHwWUUgkFMufEqpFjx?= =?us-ascii?Q?OJwPyQ83xdymfcJROKqxoFj6c1vYhPVskL0AjXJUjqf9G17SH60s+x7PuywA?= =?us-ascii?Q?OBU7juyGdj8+0qwIOn1qnjFUCKsd+qY+7fX17WGoWgJ1gLo79yYDfgEAVyeG?= =?us-ascii?Q?Dk+yaLgt2/nZLM2ehineEf5lAdskmvxaoj3cZ6Z9R5rqETB4o867eYEvpcP+?= =?us-ascii?Q?Iqup1+ut3Ff8shNbWrrTirZMOPYB9taNQbX6IhIIZfRtc8Di5t/Yq+1FnZ6W?= =?us-ascii?Q?qJQfQoINOyS+LWAlmWOdHMcda5mGixElqX4oxiC1Ly2JZvNr7s/pj1ePPOCw?= =?us-ascii?Q?XGsXFKFsq1L7xr7YDocPFSYKtEnNqxxXDRsl+Qm64sfe3s5HxNOieWGTZaDB?= =?us-ascii?Q?LVT2GpgQFGWitOERJPgv0/u3NoUdBjOrD3G+PLWdyaBm+K3eJj8z/l0U/j+s?= =?us-ascii?Q?6Wf9b+YmusHQkc0jo5Ip9aoJ8YF6KdG3iaXGyU0ausDU+VR916pDvjZ5kiub?= =?us-ascii?Q?5oiMM/bHoMVusksT9yuatSc+rtqWwTZMEHen53YjI0b7pPsh9Ac8hdKjfPn0?= =?us-ascii?Q?QQm6QvL2uvN64HK3DTpFSbFjlUPIsUUsGs7VjcT5O8W4JZdfw5GYPxWx0hXc?= =?us-ascii?Q?5UGXKT7F7APnrnq6AONYqBtcWemSyHktrS8cqyqAHHemhWBwwvpfg9Z6BtSm?= =?us-ascii?Q?JcjBsB78hON+KwBs2A+Me2YjPsZNJejdAvisgFUijgpfLwVQupvZehyKzPHM?= =?us-ascii?Q?TREj2Ztvr8F4QtxdN6i9+0m9cKI2e+C0lRk1kikc+I8mLf5mkul4TfBuk0Tk?= =?us-ascii?Q?pjsJGNFsz8ogju8m62eyJTQgV+EuqXE0fACARwJpm5LNYz5YL6qtoCc44ZFl?= =?us-ascii?Q?PFxuC18E91gHc7jRRTNkn0V98NUuTuF5Yz/3YA9JOIW1y2mKXa5mD4jrx5JD?= =?us-ascii?Q?2qdtEEesvu1mU/tDuZLp+Es3rJCtRI4Vn2jqQoxlQVcXO8NbWu0ivBrZPsS4?= =?us-ascii?Q?G0mRODKsYbuPMDYD/MyPMZ6ABrjUTvHAU2LE2PCtKo5dHpKbw6wpfV6XGf01?= =?us-ascii?Q?mB83R759Z0JAThZ5HE7w1LgN9j1Md6u9cbVhlHp5FtISW6gpSbRdMuIORa1z?= =?us-ascii?Q?dEvRYy2GPjWmQWUIBhbdywaFBKd9oQsJLJMj88Sa2THmm8V10kwDqpDxHO/I?= =?us-ascii?Q?XbCaSY+19YpYqUGXCW72uCkJJCy/2Rgz2riivVpnvUpTNneDTGJQotU5qCMJ?= =?us-ascii?Q?NR7PnUhj4eeHn48Chjv+Fmlkt17Lop5aPpKc1gDdmUTu6zXGVcsoUCrIzzJB?= =?us-ascii?Q?MZa9c4sp+e1kQa7Zxrg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb83217b-38fe-4f5a-9edd-08daef00b171 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 09:39:08.2085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UcikE//+kz4VAohvE0u4RjVMlTEdA87s+w5ylXa4DvenCafRBmp1MWjNpETYGjMhFbVUUG4CjtD3tf7LXnlYdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6976 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable If it's not defined by any spec, it's probably not a good idea to put the d= efinition in an industry header file. > -----Original Message----- > From: Chang, Hunter > Sent: Thursday, January 5, 2023 3:54 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Oram, Isaac W <= isaac.w.oram@intel.com>; S, Ashraf Ali > > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition i= n FirmwareVersionInfo.h >=20 > It is from Sipkg.dec > gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD >=20 > 0x00~0x7F are reserved for and defined by smbios spec > 0x80~0xFF are available for system- and OEM-specific information >=20 > I think there is no spec define 0xDD. >=20 > -----Original Message----- > From: Ni, Ray > Sent: Thursday, January 5, 2023 3:05 PM > To: Chang, Hunter ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Oram, Isaac W <= isaac.w.oram@intel.com>; S, Ashraf Ali > > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition i= n FirmwareVersionInfo.h >=20 > Which spec defines 0xDD? >=20 > > -----Original Message----- > > From: Chang, Hunter > > Sent: Wednesday, January 4, 2023 3:47 PM > > To: devel@edk2.groups.io > > Cc: Chang, Hunter ; Ni, Ray > > ; Chaganty, Rangasai V > > ; Oram, Isaac W > > ; S, Ashraf Ali > > Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in > > FirmwareVersionInfo.h > > > > From: Hunter Chang > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4242 > > > > Define a macro for SmbiosFeaturePkg usage which named > > INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in > > IndustryStandard/FirmwareVersionInfo.h > > > > Signed-off-by: Hunter Chang > > > > Cc: Ray Ni > > Cc: Rangasai V Chaganty > > Cc: Isaac Oram > > Cc: Ashraf Ali S > > --- > > > > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersion > > Info.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi > > onInfo.h > > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi > > onInfo.h > > index b30bc3f9e7..466cb8e7d2 100644 > > --- > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi > > onInfo.h > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV > > +++ ersionInfo.h > > @@ -18,6 +18,7 @@ > > #include > > > > > > > > #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version In= fo" > > > > +#define INTEL_FVI_SMBIOS_TYPE 0xDD > > > > > > > > #pragma pack(1) > > > > > > > > -- > > 2.26.2.windows.1