From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.4028.1687772215926357007 for ; Mon, 26 Jun 2023 02:36:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HJeKY48X; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687772215; x=1719308215; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lB3O+wVtLfdt0Wc0w/VBf9btCUK/7+VL/3Aa5ygfhPw=; b=HJeKY48X0qhJkNs3JIUu+m3w01FSJtpbZSOUJ+T+vTLIswg4p0wpLPQq SMmiIYBszLketU7fWwRvI9wLtctDYUp8V0nLC0jWv+c/ekjVvs/pYm7D9 5ofpQrIjuhTYslmAgBUm5+wlMmOq+9E6dgpWDbXUqS/9FUg6GHt4mV/5H 2mD6e6MLfwhLU+zxLQV45iFQ35gtX9LPTIev6yvSwsx4Ek4jiMF0yrZ87 XeM8lv9vJZFHtyeySYGrNLeVTsFGyaGvZB0PldnOayaTWirr9r9QJMXxL 6XkcePYPMz6WYlELHRsuGjT5HZ8k805SJ70QwDpMBkIjHelTb0dTfgWwf w==; X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="427219361" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="427219361" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 02:36:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="693424990" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="693424990" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 26 Jun 2023 02:36:55 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 02:36:54 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 02:36:53 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 26 Jun 2023 02:36:53 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 26 Jun 2023 02:36:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T1Up7KiDlJ6Iwsh0TR2LIDkv11M+4uZnNPp3WtAWzya6Sqlfh/kQho3L0V/lqEgGdVr60fIfAl+dSknt7OIoEB4XwbEvAXeZE3Yf4QZmySUPZ/cnYzRtUEhVq6+kJwWMFne/WvZFRhcPN2LgZrBgImvxLDRS6OD39dMM6Q3yV8zk1ZU5SOvfP/uE926oh9XKoFqbMP1jn4TmPlPbGa7I32GNKlSmAZDXmr/F2Cdd4dPP2XyePUJIrIEM+AuOPtdmnchYG0sSKqFTiYI+TMhRscoc39NLRfP/VwSWWVD/tHV5d98B4D5C0icnxGl6QP+7y2OqUiRv+vWpH1Vr2CSEGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Td7v8sxdhiS+mPdNGal+bhYRwoef6H+g4wIRvgKEGTE=; b=fEefXvlNZH8z7+0ci+oJwHgzKGhDCKvVB6LrAeEiC6SGpI10L4jQV2rx3sNHO1kC6Us8t1rmCXzhjtihEH2Bk4/w6uitcnzYDKqEXbIs+rL8bOUt9Ewb8LUTyHiiFy9Yi1gjGNaSELtQg3rmTIXaec3Umq4ZA8MspV9mPpFu341FxMgYzjjVx6xjIOqePLObfsd1LOrnRFVtllrcfQTFEevsTqF5ez6WZ7sLaQXRSG7fIrKXvQu/MKnMb3YZNpEAh8eDcYML8SjAolabd5iH9k0dsyTqmliMXszz1SzdJYb58UdfZz3xTcgmb7ze9ZUkOfruBpkIW3mAE8piza8Jjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW3PR11MB4731.namprd11.prod.outlook.com (2603:10b6:303:2f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Mon, 26 Jun 2023 09:36:45 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%2]) with mapi id 15.20.6521.023; Mon, 26 Jun 2023 09:36:45 +0000 From: "Ni, Ray" To: "Xie, Yuanhao" , "devel@edk2.groups.io" CC: Gerd Hoffmann , "Dong, Eric" , "Kumar, Rahul R" , Tom Lendacky Subject: Re: [Patch V3 4/5] UefiCpuPkg: ApWakeupFunction directly use CpuMpData. Thread-Topic: [Patch V3 4/5] UefiCpuPkg: ApWakeupFunction directly use CpuMpData. Thread-Index: AQHZp/MgTe+Kc58qr0yBCgoN1Nex9q+c03VA Date: Mon, 26 Jun 2023 09:36:45 +0000 Message-ID: References: <20230626055705.57145-1-yuanhao.xie@intel.com> <20230626055705.57145-5-yuanhao.xie@intel.com> In-Reply-To: <20230626055705.57145-5-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW3PR11MB4731:EE_ x-ms-office365-filtering-correlation-id: 8aec5140-6f74-46af-89b7-08db7628db43 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SMSGNFqOwxbhnJaqjRvs/RT5UPYM7Hayd2J+4LoF7S+ra8ygC954X4WvyRCpl6uPWLjZyFJKxMmfGBbLwbI+toHL76iWL2BtHACiGKrpdzlQPF+0Td0cO1/U93PVHvteaY8bbG8oePIOCotkIjPSDCDX379ZCPp+5nVQwmvW/3NRJIFb6DA3MRTBvzvVsUphuZfbowngGAh9YPJXPWYooSrh7TbowTN+IcsjifjL3xPWqe9kC9VHaicAhcyFlRg71mZopQt/g0Mn5VTD/OVECFTgoMGZihK6ohR+TQEaHIbbVofkdjZnACKMG3Juo8jf7PCJS0EQS6MCduS4+diBJ4KaRIAKDG98S7ScuezwbK5wt2VSAU3q9OeNieDV37T0tdBjtf5K9j/nK6iDXBC6p+bgFjiKxs4zK0XEpPxFFUALmXzZ1VR4hDABJMLUHkoH3N+rJTwffKExMa88wQf8eeLK7B44I8A4YjgNxKIid0J+v4hcVg4Xq7BFCcfXXPwFlZ9Iz/0zc7ULP5myxthnan3bYKaicY9fPWNas7b2KggPH5BUUOvlRwyPPZwIU/eDNpID8Y5T+D/Jrz3OTpTY9HAIX0O2WJlmG6A4WNhn3rsRRtl5qzB6zRsBYVfUOpQj x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(346002)(136003)(39860400002)(396003)(376002)(366004)(451199021)(19627235002)(66446008)(71200400001)(7696005)(83380400001)(54906003)(110136005)(26005)(53546011)(6506007)(9686003)(186003)(2906002)(478600001)(5660300002)(52536014)(33656002)(55016003)(38100700002)(122000001)(66946007)(82960400001)(4326008)(316002)(8936002)(8676002)(41300700001)(86362001)(38070700005)(76116006)(64756008)(66556008)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?scOAMRan0NTkLS6Wq7O+UFuW1vOrNoaSZk6cYeiIBTWFhnOrHuqR08n3Fn/+?= =?us-ascii?Q?ctB++aP1DMVy2MLU7M/DzioTUSsogcfI/6E1CLJNbakIrrZskBcTykJI+zQE?= =?us-ascii?Q?yiohPSTBGByGBMYwlzTBp3XcZfSCT+0Zyvkmi0d8npDdn73nt2W2tgSWrc0m?= =?us-ascii?Q?M8VeDb9eNqr2Va/otBCBC5bUccAYfx1g1FY/JBuAZXKlYGw0k4lU4Hc6BNvM?= =?us-ascii?Q?kwQScK3IieD/Gd6cdB3MknDcrMwPcfcFELF3enUADO3QnSpUDjzfTo4WznAw?= =?us-ascii?Q?JP7rZzgMnaH2byILiGw3Dd1vFZ9GtJYpyluu9szOv4GJn+68j8QTtbmNhQ67?= =?us-ascii?Q?uwIqDGH/YOPmpyDMH6P98l/QMHM7L4VlyW8Cfby5H9bBtFVxynL6qxKtm1DC?= =?us-ascii?Q?3Z9bi9AQZTGw/Pzsf4HTL45xWcXUCZpkTA29EsC9vxQ+mtGNKBYAvqMR7tYi?= =?us-ascii?Q?fcOd8VW8gj3PiF/1Z1kgNxZ1i8niG2sSA9GvskBP8ZfiiIagEf0Nzg6+eafP?= =?us-ascii?Q?FrbPFWpEDInWN2lC46hCwnronu8JyKAL79cn4m5Jh7P8Yx2SvzvAT6J5deHP?= =?us-ascii?Q?j8XXJJdyTjQQiAyvN3ATqPNcvf0MIpfhatoJg8ZnWoV2zDtv8oj1kHx90qg0?= =?us-ascii?Q?F6w9hEToPXginPHNq7DfjDLrCta717ZvU0WUssQzcaxLH91XT9xwKcADNIap?= =?us-ascii?Q?9Vp/MWDbca8SXyN/nePtFwMz+DuLexa8tfbJuHFC4f/vt8FlcROab52WBcFK?= =?us-ascii?Q?VrYwyQF/91RI72PpLtsPWL/SLYdm+ZIy8hvgyKtjWKOc8UwWXbxEg2HA9oOI?= =?us-ascii?Q?+4k1Sonn2Y+QntJfhxmS/+T5bnaKjc6zrxINVJboiq/pGXFR5KkXjLHkV0pf?= =?us-ascii?Q?MFpWVROH7qvnIWAS4sKqXY6vOWxsdA+5a78osOqjLalP+lUmR2dSbanoY+WO?= =?us-ascii?Q?gfhkln7DnBSmXuJGTUvHE2X2SJ+Hg3FlDi/uGd8DGVGX/PrCXhzFRU42TSkm?= =?us-ascii?Q?X29h1ZVCtPEVhofg76NT5DApZsatT90g3V2rtNGghFocQAr3dGxMpIjDL6dD?= =?us-ascii?Q?NyPwz7GYVl/xoANTfl7JDlGCsFOf5fblNXgwG/4RCD+iAe2U7rKBdICNNfrt?= =?us-ascii?Q?L574fh0R3aB3LvHNRp3/CyN+jrvv3+6fHfiU5PrT76oKZ51ho/KcVbZnNHmw?= =?us-ascii?Q?FD7wPYZbdO3zMoCrjNdmURVoh1otqSZFeSTd9Xdy8eRuBv0j/oc9WYKKWmdG?= =?us-ascii?Q?mPliuCkFQptDtOVu3Vm+jrhCSdOC7sf0z7hVAC/vIJc67Xb9CDcv7LoFenqS?= =?us-ascii?Q?NR/Ifpr8w6l2rzQBTlpIzvt1gk+2xBDowOPYHmnKe9fjEAwBwyE3q75jQNwY?= =?us-ascii?Q?8dmrLVNz2pNgS0SxiDRIocyQMZxIWgGREYljaufnKq2AKfkd8NEe9yMaeaD5?= =?us-ascii?Q?ffwv1mL+qAgdw37C7TIl5NTEZ/HUuHwiJcKTVu79AusAdJ7w7+5svuTLcjc6?= =?us-ascii?Q?ZgUfAWDjDlkKmPyhszWNQG9J3zHUozTw7mh9lsvcST8aNZhQ3npbmpPa5GeT?= =?us-ascii?Q?rD3atHn/VFzRR0SXgtE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8aec5140-6f74-46af-89b7-08db7628db43 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2023 09:36:45.2143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vRK/OhttUkeIdVNr12W4hBTmO0hcVF1B33BP1Tse1FOHcCEdY8eJIstd0al8HtGaEejg2sryG/XTOVQMmRIYbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4731 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Xie, Yuanhao > Sent: Monday, June 26, 2023 1:57 PM > To: devel@edk2.groups.io > Cc: Gerd Hoffmann ; Dong, Eric ; = Ni, > Ray ; Kumar, Rahul R ; Tom > Lendacky ; Xie, Yuanhao > > Subject: [Patch V3 4/5] UefiCpuPkg: ApWakeupFunction directly use CpuMpDa= ta. >=20 > In the original design, once the APs finished executing their assembly > code and switched to executing C code, they would enter a continuous > loop within a function. In this function, they would collect CpuMpData > using the MP_CPU_EXCHANGE_INFO mechanism. However, in the updated > approach, CpuMpData can now be passed directly to the ApWakeUpFunction, > bypassing the need for MP_CPU_EXCHANGE_INFO. This modification is made > in preparation for eliminating the requirement of a second > INIT-SIPI-SIPI sequence in the DXE phase. >=20 > Cc: Gerd Hoffmann > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Tom Lendacky > Signed-off-by: Yuanhao Xie > --- > UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 4 ++-- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 12 +++--------- > UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 3 +-- > 3 files changed, 6 insertions(+), 13 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm > b/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm > index 59db4081d6..d117f09ef5 100644 > --- a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm > +++ b/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm > @@ -197,8 +197,8 @@ CProcedureInvoke: >=20 > push ebx ; Push ApIndex > mov eax, esi > - add eax, MP_CPU_EXCHANGE_INFO_OFFSET > - push eax ; push address of exchange info data bu= ffer > + add eax, MP_CPU_EXCHANGE_INFO_FIELD (CpuMpData) > + push dword [eax] ; push address of CpuMpData >=20 > mov edi, esi > add edi, MP_CPU_EXCHANGE_INFO_FIELD (CFunction) > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c > b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 1252ee9673..15b24b1805 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -710,17 +710,16 @@ PlaceAPInMwaitLoopOrRunLoop ( > /** > This function will be called from AP reset code if BSP uses WakeUpAP. >=20 > - @param[in] ExchangeInfo Pointer to the MP exchange info buffer > + @param[in] CpuMpData Pointer to CPU MP Data > @param[in] ApIndex Number of current executing AP > **/ > VOID > EFIAPI > ApWakeupFunction ( > - IN MP_CPU_EXCHANGE_INFO *ExchangeInfo, > - IN UINTN ApIndex > + IN CPU_MP_DATA *CpuMpData, > + IN UINTN ApIndex > ) > { > - CPU_MP_DATA *CpuMpData; > UINTN ProcessorNumber; > EFI_AP_PROCEDURE Procedure; > VOID *Parameter; > @@ -731,11 +730,6 @@ ApWakeupFunction ( > UINTN CurrentApicMode; > AP_STACK_DATA *ApStackData; >=20 > - // > - // AP finished assembly code and begin to execute C code > - // > - CpuMpData =3D ExchangeInfo->CpuMpData; > - > // > // AP's local APIC settings will be lost after received INIT IPI > // We need to re-initialize them at here > diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm > b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm > index 5bcdf7726b..40e80ffab4 100644 > --- a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm > +++ b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm > @@ -259,8 +259,7 @@ CProcedureInvoke: > add rsp, 20h >=20 > mov edx, ebx ; edx is ApIndex > - mov ecx, esi > - add ecx, MP_CPU_EXCHANGE_INFO_OFFSET ; rcx is address of exch= ange > info data buffer > + mov rcx, qword [esi + MP_CPU_EXCHANGE_INFO_FIELD (CpuMpData)] >=20 > mov edi, esi > add edi, MP_CPU_EXCHANGE_INFO_FIELD (CFunction) > -- > 2.36.1.windows.1