From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.16331.1684224377885357616 for ; Tue, 16 May 2023 01:06:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nokP0RMx; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684224378; x=1715760378; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=vGw0sq0Bg38hTSLnlypCcm9gk1GS3hFje4q8URckxUc=; b=nokP0RMxYoOmYZY5OacVS4Vp5TaI6DwfM7zMJH2ovhMC1f4ZV8PXNbEr V0UXOjxW+xMbK1hRmDmCa6/5DkvLFpkIE9wN3GNDrweCY20iFrP6nVN7L 7pMEFofwZnULlsqsq1tLhu8tNXjy0e97YAv1TkRvdgQoTRXSRMr0qiYNA E3fuANdDFa6ZSuCD0uUrYUf8jkQAU+X/GKyNqO676PkMuDCLYAHD/3Oyo RWN65O1uJeChc2OlEg7SEartyiBwNpauhYWdyfs5CBHlmZJnOJpIF+t/6 whyZ4JVZJjsSUNFpGS+06IAVkvW2DJHIRGQulRV07gUImkOIauiD6+u8q A==; X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="331030373" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="331030373" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 01:06:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="947743738" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="947743738" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 16 May 2023 01:06:16 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 01:06:15 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 01:06:15 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 01:06:15 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 01:06:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YPul/be2fZDSC9pKooKHcFkfnkneWu988xhIR4nckq0CN3/3OX6x3Sy87xeYaQCYKzQ1sqWBYJl9M+0DVIVeAlWO+O9nhQqVUIGcU6YCmnsGhUSRQWlN2+2SfTdHwHiQXEevcImRVxoBsY772XAwXoqo1VQNArjp5sx3lOIkRHVDPYg2UmvzSgQErXrZgeuk91DVKGxncxI58Q3vnm1YIboXngWRob478shd0ZUpM92yQGW+YPxMUTBQBNfhjsKVGMhPYaENXFerKBw6mWOpdGdqaFvksFUYoJZvEsrSS+0raI7KGjkW4gI//h8L3HmYNDl2GPxNkKgxwqfcuZ3J9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iETaG2j2DRH9sBjPhEehpxN6qz+KmWFyP+ghusWiZMU=; b=cCdMoIMixTDC90FLiedrlrjMI/8eZKTn9/rqN/nf1DidEHsEYQNV/UdmHfcvlp2WUi6RZOyWEDbLvEtb9PSFUgYO2zAdOhPLbKg03n5l7KW3Z2y5mgPj4ARiJpcxN9q+wdycsS1YhuN4/LKXmcoKDQ+Uh7ND3pXYtfOUksJP7bZdDlxiNROp2T5VeysJpaZKSbjeK44fR9eeokrFgQnVA6PqW7LISPYhRN3ixgErd6nFw98pVLmPCorrJoA5bdabkUZ26ap4p+o71Tn1Zl5rf/vkCGRO0dWPRW23I2VYyxcN4pnWsIEbTflqaihPBOC+BTTxNCdgQcZyRvp8G/xfZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DM4PR11MB6501.namprd11.prod.outlook.com (2603:10b6:8:88::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 08:06:13 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6387.032; Tue, 16 May 2023 08:06:13 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH v6 0/5] UefiCpuPkg/ResetVector: Refine page table creation, and support 5 Level paging Thread-Topic: [edk2-devel] [PATCH v6 0/5] UefiCpuPkg/ResetVector: Refine page table creation, and support 5 Level paging Thread-Index: AQHZhs516p+Kdx5xYEumQbEbw4MiXa9cjN0d Date: Tue, 16 May 2023 08:06:13 +0000 Message-ID: References: <20230515014138.1321-1-zhiguang.liu@intel.com> In-Reply-To: <20230515014138.1321-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DM4PR11MB6501:EE_ x-ms-office365-filtering-correlation-id: caebb5c3-1d47-448c-e479-08db55e46ac4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HTdPM/DPnelzlCqtNokmr6Q+SVlKVZ1MonZYHsJk0O0UV9YJ2wOXjtI5KPxXw6VQ0W/GXUqAFJYppDa4N4BopcfENZoCQLurMkyiOJbF1YiP0Hf/fdPqzsCdrlq9XzYQth0TZam8itlyDi/N2j+U9PoIRDMA1GOH2aW/d++ZfBTusWjUFz1ePxLCcGO1WKhGTJ9n0eucldnrWoEpXSK/Av6kt8HjH2DRkkZMOGD3k+ycKU1L8IUz57eqV9NVPPIUjHRRizXVeP4I7Y4USrTeL0s5+1n2+xD4JdxBVfOlHNK9MYFtIKEzY3d54JOIKLzlcpwVwLoc4AgCmFbpk+M28uco6btRnYMukoPahX64x4yxZ8v0YHACKsh7E/4ZDrF9iVWWT4MEN0hNBNqWh0LjYJuttZmmpIeVfV89WZpbsPrEbmUa+BabMu4zP8eEkKN6yQ7r22XVQ7pqlSebp7kIfJ+J4K86ijmlDKHct9qUUacphOppH1c99ojCejYIDNUY+n0QtokvIuFpaFZj71fuxCtnsEIPXFFTbc1kqpRmRtTR16dl2YqrBLPaUlTmUEDhEUy+BPxTyZngOt6BtDfkC4cTmqQnAK8YFOh6CRZBQVJcFCcKSsYHJjf28rtxIobU3b2I3DURvCBht0wA5w6C0g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199021)(66556008)(66476007)(110136005)(91956017)(66446008)(478600001)(64756008)(6636002)(66946007)(19627235002)(76116006)(71200400001)(316002)(966005)(7696005)(8936002)(8676002)(2906002)(41300700001)(55016003)(52536014)(5660300002)(26005)(33656002)(82960400001)(122000001)(86362001)(38070700005)(83380400001)(186003)(53546011)(6506007)(38100700002)(9686003)(66899021);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?2TbO/7lOP4blICoAb/DJ1oSuEiXYlnSgeVNhAD5TyHShrwjBTxixlAnrnQ?= =?iso-8859-1?Q?0WDj7qLxwmWbUXdNThh9X2naimyFPHFHGgu17rEB8SSS9SPD56CGqR+t9D?= =?iso-8859-1?Q?CcV2eRwcf3SBn9r83PmlcXnTcx7s0p6VkbNGiPs+9ugP1yolpJIxkJZTPL?= =?iso-8859-1?Q?cS9/kq6RxwHDpxmeJiEhxLV70FG3r4QWW9VS96sSF/u78BVYnW6a4ULNWC?= =?iso-8859-1?Q?UDTyFaYJEHAgc2sY/dbVprUnP6iF1RP3tjAUx+0ZQl/w6YzjmixWdCzrtL?= =?iso-8859-1?Q?SI/k0i7IhwXXCNnWIB6uMlVPfkYzY2iPbmt1V2+wbApNPPEiXkRglmWyFc?= =?iso-8859-1?Q?l0lSLVfSQYpGd+b1tg5l4nJIXHEvU5r8Mv5fluoTtxTqx5TZ/pIHg88PC6?= =?iso-8859-1?Q?p8JHmn+XPmTd2TmReUTTCojV4mKiAhh72/TC2xP3NBo1zeZgAj1krxATrS?= =?iso-8859-1?Q?Ohug2ZTxl6hQYO7Y8InHJM+REbXNw6fbdyZ4WPAW8ivVYugAGt7grR33Gp?= =?iso-8859-1?Q?1B4ZksXjtiDlvShBODYmuyroEbfx7b6IFdrykygzLaZHUHtD8j8ILYXFvp?= =?iso-8859-1?Q?2Xn5pU2ksvZoipa/M/4PmZwrn7uV00OrvvbpJMGLQ3L9ybeY/bRaQ3XsUi?= =?iso-8859-1?Q?x+6cViuu5S/dYF7ERrLLxv6s1MSXk/BRZT1vRYRlUyWNZzHX+JOWVf8My6?= =?iso-8859-1?Q?ODSuu5Tf+KIeBFpX4xZCU5zEpXKj6vR4SJbYz+u8pbx2VihvViVj3RH//U?= =?iso-8859-1?Q?zTdmObQ6y9vNJcCQ91etvubApAsw16P8l7VJxWmwR++aXv493Z03olvyG8?= =?iso-8859-1?Q?wQS2rQMizl2CFkcmUSKpY6hm+2ZH4ONWDKwWRVnO8PHQv0wWQWzSswo6fA?= =?iso-8859-1?Q?qySGAh+GF0aXkRxUPi/zLzh+fWtB4lJOuj06dhJW4ksUZ1ULe1V3SvNitc?= =?iso-8859-1?Q?QicmXi9jQfjYa+whHDRNY0Kl5krBw0EkiqB47fJFhbkJYrG+Nf4+McZyfe?= =?iso-8859-1?Q?TX5re5seZI4gPJq/QTnBYwp7FNPKRxmd/0qsA7+WUtCkhvKCSU9Bv1eKvE?= =?iso-8859-1?Q?0+N9yhdrbe6DD7H0hPQhCLBTc2u2cuYc4HHJVVJK0PA5Rq3KxbKNv25n+k?= =?iso-8859-1?Q?sPO/pwwHQvcH9651rd+7EPQkPqCArAae37LqYS7QvzkanlkY+I46/fS5VH?= =?iso-8859-1?Q?wXL/kPb8mSGmKPywDXlccybrRlz440R3k133/BDCInUXdYPlnmDktZitJ2?= =?iso-8859-1?Q?8RePUQYdYxlzBKmzpnko7ZRva64erRu0nbzOA7e89XiaGSeA13x0HuPbve?= =?iso-8859-1?Q?sesDBq5t6TFU20h+Mq64/KCIVFUqQpCSMJwF8oTnrVqrlONUSk9hj6IT1Z?= =?iso-8859-1?Q?t5pDLOX1wRxlu6UsZmtEFxHmfLC9CEPEbSKFfz+DqYP51itvk7PrcBe+fH?= =?iso-8859-1?Q?tUkaUt++RcPouXScChABYiT4DsEBjISplOqj0Qpa1WftxnSkQPCtBV32oy?= =?iso-8859-1?Q?txBjeGxJptsYYS6xFq5sqTRjCjdnywnzBlj2B+l+I4bRj4hpKD2KjzqQYB?= =?iso-8859-1?Q?M3jQiN15LHfBGh8UsMdhCaM/iZwwCo94uHNLBwoHsNC/aZOX/9Kb0QbOMc?= =?iso-8859-1?Q?mOY68FwjM3syI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: caebb5c3-1d47-448c-e479-08db55e46ac4 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 08:06:13.4649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u+us9vW9gLynTSbyYxTkaLKh2x98osmjMX0BQugam8iwSM1Zyt8zko9iFUuYj8QlYqRHkMhofQn4MjIv9AehFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6501 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni ________________________________________ From: devel@edk2.groups.io on behalf of Zhiguang Liu= Sent: Monday, May 15, 2023 9:41 To: devel@edk2.groups.io Cc: Liu, Zhiguang Subject: [edk2-devel] [PATCH v6 0/5] UefiCpuPkg/ResetVector: Refine page ta= ble creation, and support 5 Level paging This patch set simplify the page table creation code, remove some hard-code, combine files and support 5 Level paging. V4: Refine comments and update below macro names: PG_NLE -> PAGE_NLE PTE_2MB -> PDE_2MB PDP_1G -> PDPTE_1GB PAGE_BLP_ATTR -> PAGE_BLE_ATTR No code logic impact V5: Update below macro names: PDE_2MB -> PAGE_PDE_2MB PDPTE_1GB -> PAGE_PDPTE_1GB No code logic impact V6: Only change the 5th patch to be compatible with reset vector code from OvmfPkg. Other patches keep unchagned. Zhiguang Liu (5): UefiCpuPkg/ResetVector: Rename macros about page table. UefiCpuPkg/ResetVector: Simplify page table creation in ResetVector UefiCpuPkg/ResetVector: Combine PageTables1G.asm and PageTables2M.asm UefiCpuPkg/ResetVector: Modify Page Table in ResetVector UefiCpuPkg/ResetVector: Support 5 level page table in ResetVector .../ResetVector/Vtf0/Ia32/PageTables64.asm | 24 ++++- UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb | 8 +- .../ResetVector/Vtf0/X64/PageTables.asm | 93 +++++++++++++++++++ .../ResetVector/Vtf0/X64/PageTables1G.asm | 53 ----------- .../ResetVector/Vtf0/X64/PageTables2M.asm | 60 ------------ 5 files changed, 117 insertions(+), 121 deletions(-) create mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables1G.asm delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables2M.asm -- 2.31.1.windows.1