From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 840F1740037 for ; Thu, 23 Nov 2023 01:48:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gZO3gwozAm7JaGCazc27YIgQ95SgCy5ZTiVuKcgh+xc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700704132; v=1; b=waM3O+IhOz8Pm5DzJjUk6AVwQIp7V7kkxl4mlnElxbz2JFKGTNrUepvuRh0y93g2t+7gPsr6 jM2RE22NeTWSK1oKVxYzijT+Xd9s3EHR+7c5IklatcN4swwD5GokT3lL6qumD8zwb6cHU2928Zc c/XMIlTqVHWEw97mlbPYVGe8= X-Received: by 127.0.0.2 with SMTP id 4ZLAYY7687511xBKhrfd2HFS; Wed, 22 Nov 2023 17:48:52 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.82853.1700704130663960590 for ; Wed, 22 Nov 2023 17:48:51 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="458673464" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="458673464" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 17:48:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="1014464492" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="1014464492" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Nov 2023 17:48:49 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 17:48:48 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 22 Nov 2023 17:48:48 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 22 Nov 2023 17:48:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S5Xwgbbm1b3L42Af0alT5ZBplwV05IfuXu7B6mt1gk3/HdkjuSEqbcWGpryLKaqnQ/cMC43QC4jJtjjEnHENUo8FuRBqQP/D9iR+DQsuJyWSW/ZVZOgreZc4mmNN/JMIHI+hyRFXj++BagP61i+6+9s92KiMupZlk9arYB8mTQm8nihnBnlDB0ilYw0S7qsPBpUB/De3QagpYEaWz2bZY4MhiDdGlEw8XWS6eRrgm2zRuOfBS5pu9dWBexHGwCxPj8JrMjtV2OqxYxi9MPUukPwijvI0uXwz/MUHXrDC+p2hj3PdD52tEEIcUNc5TN2ZBbOb6e158yzrh3afyjY0wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5jbKZil35Yn/u9hqJucxix4lx+cBs10OXi8ksePGsNg=; b=TnKiI2lXU7OwNJWNgLf4ya/Eubh6sl6ulmLV4O5BfehvsPeIdRUmqz8DwOFQViFzUxiqYKfld5jPAU59jy4xJBrRM32sXwueiuXoEDLKtmJjYwQvVcEI82iZLH9yruObGYFxfLBH2YJyydTFgFvaRwEA5iaqF4Z97uy874HxZX/u5M4ApBQC3XBaI8JAKV9YokMmSI8uOCxaUNdq8pvGVmFc3PZUfPKCaniPneiImhFeP8otR65ERBlQhzu/TPMwQalbhJIDLGnfQR0iryHI8G2Xg+olqZZi+Kzs4YafZrNMJF/b2cDUkEbfKPiy1gyFOYc+wqMU6M7sonRBwv8R9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH3PR11MB7915.namprd11.prod.outlook.com (2603:10b6:610:12f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18; Thu, 23 Nov 2023 01:48:44 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7002.028; Thu, 23 Nov 2023 01:48:44 +0000 From: "Ni, Ray" To: "Xu, Wei6" , "devel@edk2.groups.io" CC: Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered Thread-Topic: [PATCH 1/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered Thread-Index: AQHaG4vnkIr37mLa9Euo7X1Ku8URO7CHI/Nw Date: Thu, 23 Nov 2023 01:48:44 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH3PR11MB7915:EE_ x-ms-office365-filtering-correlation-id: 3a1db387-679f-400d-7822-08dbebc653cd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: aeTMgKaRMkqS+0tmZ+mFOe5xDhVf8C2EUZ1ZhxoRzAxGHnnXCWJUb6+1/cmbsUNlt9d5Hh0DMHZ90WEVVKy6O9ehaC4zA6awAAjT7U4wQbSkx41ye0FQtzwE94hJA/hfZdQJqylYbR/VUsHyrpPZUBMMVJcP+5F2/Lzhqm01mPgHYKAaucz8lzBdtyQ2h3GImkIOTCninDdXZOxRGidpxBnnZKWCoO5+nUhBlpirapm8w58GXxKubfAchQ6lwPJC3h/A+YpWuOLA0WbRnxftzbTYFdNcvfma1CNotggidCy30rKLvZtaUQh4TISyr4uITqngu96/dD9Iv//oPDAJmPjBX9FhidJw7+5bcHizH+5KmX2apfB/bzN37X9K8drMFfNzGW0eV+PbrE9VVk4EUt82zjujRIi179+LGVz3bw9mMI6H9H9qxOM/S1uUcEEfSgmr+kNl6Hq+YTXFRaRHTa/El33uRXPwCFB5504EFxGB5X096B99nzW6nGDu2H8YcAbRy0FGEqlQ5sygZvAepHCvJo04ye9AtEJhowJI5mKHr4nuIOMRdGh/i0gkmHYFWY1PUVF0O0sA3lXzdchK/kloD13vhYa/SXXwxM248BIUAvqjifY//QWzaboLv0XK x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iBHBp9j1SLvylDkDs9K7U+c2Ap2FQ2A161q48eoeUXUE/8YLIKM6Z4Obfau0?= =?us-ascii?Q?t783+VTPqMBsPTCh5vRszhcaQw8elzPmTvUPOUbFaW/ohWZxKrGOAaCRkRat?= =?us-ascii?Q?3qiKAxxjtkvPKovskXJTqsSN4k+p8hIwjQF2KQGxYoKU1O4unkc0Ab7Tjld2?= =?us-ascii?Q?NQNN0gcwUNTGrSHj1QJ68hDmhKX5aPDxOaIbDlslbHAxue5aiL8B4cTfbg0x?= =?us-ascii?Q?QFVP7m76J/1GMu4hCGs6wqQXsfDP6brkAkru48QaFcaYIeM3neGC9kFWg2jM?= =?us-ascii?Q?kiYp8oEZHh6k0JhwdktNmklZnnhizPfYX9gLGGj+rb27YRE1+Ajv9NtQTMTT?= =?us-ascii?Q?d/PoLmwTpWK3VsdbOZECsR+2JLJS8CVlgTdwuMGmBBEW6U5ZfH3EFQi4pNKA?= =?us-ascii?Q?MnCeTDsf+3cWDZaaUpqH715551NjMf/0oaBvvCfPiorwK5MkPUkyj4hd123o?= =?us-ascii?Q?sYkD1h+czxymV9IjxoIdZxEpzCfEBZ3yMkHBuuoj4hGIY4AkCfpOYC6Nwp3z?= =?us-ascii?Q?ZX601wQgB1ONCPclB0SaY9eJVLJMsJI6v8yTk2h5KWu6SXiTh7zGzbdTl4Sk?= =?us-ascii?Q?MbVDHqjYDNSKEYe/sY0dOo9ozNiMsU59N2zQyYnQURYIjj7RElxJCkgK3gxO?= =?us-ascii?Q?7/uwPpqDhHPalj58u2Vl/54Rndxp62O5qOQPJRPvbVow50oEYwlxQVrBrlI0?= =?us-ascii?Q?5MZJhFiEI11SFSxafd87qJKuFhg2TN+ifI2wgCc5YQFonQeHuSjamrzzYLfT?= =?us-ascii?Q?lthQjFWLBjmz0IASY2VArnP562Od9h3BYcCcB0RTxaUUxTfZGp4zgvmclkgK?= =?us-ascii?Q?0RvS0hpai7Y5VqLYrO4wh30BKeucQYE0vT/AWuVq4V/8r7KR4gaiPf/+ER3I?= =?us-ascii?Q?tQeknxYvth3XRKQVs54fcNquTAd+Foa2DSVo4XE9rQ/lnA0h4gTHcn8XPIPY?= =?us-ascii?Q?sal7FukLY3XjZFQEXKwRZQQLl1RF+2+JkfgZTdfxKpG9PzfUeOaLkxONK8zP?= =?us-ascii?Q?2vnCyy8UFu9kWSEGL1/mCiT+f89lqIp4IwlZ1EUfkEfl6cAymrIEyZKGTxqc?= =?us-ascii?Q?W0Xgcur43cpgWatTPai/3GoYYzhC4YYaO0EWhDmE2P+UkfL3J4TCIzoSqnHb?= =?us-ascii?Q?/4nfMBAg6srOLnJTjb/SMvIWDHagRzZuwPuLtZzyq8EiCqQZ6dJ7+P0+dtD/?= =?us-ascii?Q?u1Fpxc79bA1gPZwY3/LEGneSAJOt0Q/b9KTOSo2LsfzMnV+MH2gxV8NNBB+5?= =?us-ascii?Q?ciGu0z6N5QxZPke4LjiW1HlhtdOHPl0YBZ9AOG1iEk2ZsRGqrSZ0q01ngzQ3?= =?us-ascii?Q?YDP3c2chGx9/o+/pLFl/fPdsI/N+aEKhChWS6zY1HvQ1eSpkLAwtvFMRfkNq?= =?us-ascii?Q?bdcm/GySyzJ+58ZjZZRS1wnG5Yy75Qc+LZ3Ais8l3amwvQ/0Ty3pgxPB/q7O?= =?us-ascii?Q?9T5coPlYqpZwGWoInzjtvacLFSM9W1SWMIZPg2g8cFGlyuFG/wo9jQFn5Qb7?= =?us-ascii?Q?0NgMubcNbMQZeZqpyW2PA97vz3PaYCWhWuPcMuHqiS12W6G1PElVtSdeDYPN?= =?us-ascii?Q?5R1rbOlAy/i/xCRw1Qg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a1db387-679f-400d-7822-08dbebc653cd X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 01:48:44.4604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZVShkEaHG5Ev+fpxoZBLkeKOoiiXrV7nwjBDa0EzMLF+6w2KZlwwGcIIZG66J+ak5edktIiJDWLZmPCMuiivig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7915 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6DL6nhzZuow3X5f2SucYmSjFx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=waM3O+Ih; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") > + gRequestDispatch =3D TRUE; > + gDispatcherRunning =3D FALSE; 1. It's good to set RequestDispatch to TRUE as it exits unconditionally and= very likely more drivers can be dispatched later. 2. Since StandaloneMmCore registers a SMI handler, it's possible that some = SMM driver entry calls MmiManage() to explicitly request to dispatch. DispatcherRunning is a flag to avoid re-entrance. It's= good. > /** > Traverse the discovered list for any drivers that were discovered but = not > loaded > because the dependency expressions evaluated to false. > diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c > b/StandaloneMmPkg/Core/StandaloneMmCore.c > index d221f1d1115d..e65edee6d8c2 100644 > --- a/StandaloneMmPkg/Core/StandaloneMmCore.c > +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c > @@ -84,6 +84,7 @@ EFI_MM_SYSTEM_TABLE gMmCoreMmst =3D { > // Table of MMI Handlers that are registered by the MM Core when it is > initialized > // > MM_CORE_MMI_HANDLERS mMmCoreMmiHandlers[] =3D { > + { MmDriverDispatchHandler, &gEfiEventDxeDispatchGuid, > NULL, TRUE }, 3. I assume the StandaloneMmIpl won't respond to the DxeDispatch event sign= aled from DxeCore. Right? > +[PcdsFeatureFlag] 4. Can we use [PcdsFeatureFlag.IA32, PcdsFeatureFlags.X64] to make sure X86= CPU always have the PCD as "TRUE"? This could avoid possible platform DSC mis-configuration that causes all MM= drivers dispatched in non-SMM mode. > + ## Indicates if restart MM Dispatcher once MM Entry Point is > registered.

> + # TRUE - Restart MM Dispatcher once MM Entry Point is > registered.
> + # FALSE - Do not restart MM Dispatcher once MM Entry Point is > registered.
> + # @Prompt Restart MM Dispatcher once MM Entry Point is registered. > + > gStandaloneMmPkgTokenSpaceGuid.PcdRestartMmDispatcherOnceMmEntry > Registered|FALSE|BOOLEAN|0x00000001 > -- > 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111640): https://edk2.groups.io/g/devel/message/111640 Mute This Topic: https://groups.io/mt/102703852/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-