public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/PiSmmCpuDxeSmm: Get processor extended information
Date: Tue, 21 Nov 2023 02:24:26 +0000	[thread overview]
Message-ID: <MN6PR11MB8244830DAA01DAB193EF9B978CBBA@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231115111553.6592-3-jiaxin.wu@intel.com>

Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
> -----Original Message-----
> From: Wu, Jiaxin <jiaxin.wu@intel.com>
> Sent: Wednesday, November 15, 2023 7:16 PM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek <lersek@redhat.com>; Dong, Eric <eric.dong@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd
> Hoffmann <kraxel@redhat.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v2 2/3] UefiCpuPkg/PiSmmCpuDxeSmm: Get processor
> extended information
> 
> This patch is to extend SmmAddProcessor function to get processor
> extended information. It's to complete commit 1fadd18d.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c
> index 391b64e9f2..c0485b0519 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c
> @@ -169,10 +169,20 @@ SmmAddProcessor (
>          &gSmmCpuPrivate->ProcessorInfo[Index].Location.Package,
>          &gSmmCpuPrivate->ProcessorInfo[Index].Location.Core,
>          &gSmmCpuPrivate->ProcessorInfo[Index].Location.Thread
>          );
> 
> +      GetProcessorLocation2ByApicId (
> +        (UINT32)ProcessorId,
> +
> &gSmmCpuPrivate->ProcessorInfo[Index].ExtendedInformation.Location2.Pac
> kage,
> +
> &gSmmCpuPrivate->ProcessorInfo[Index].ExtendedInformation.Location2.Die
> ,
> +
> &gSmmCpuPrivate->ProcessorInfo[Index].ExtendedInformation.Location2.Tile
> ,
> +
> &gSmmCpuPrivate->ProcessorInfo[Index].ExtendedInformation.Location2.Mo
> dule,
> +
> &gSmmCpuPrivate->ProcessorInfo[Index].ExtendedInformation.Location2.Cor
> e,
> +
> &gSmmCpuPrivate->ProcessorInfo[Index].ExtendedInformation.Location2.Thr
> ead
> +        );
> +
>        *ProcessorNumber                 = Index;
>        gSmmCpuPrivate->Operation[Index] = SmmCpuAdd;
>        return EFI_SUCCESS;
>      }
>    }
> --
> 2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111501): https://edk2.groups.io/g/devel/message/111501
Mute This Topic: https://groups.io/mt/102602852/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-11-21  2:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 11:15 [edk2-devel] [PATCH v2 0/3] Get and use Get processor extended information Wu, Jiaxin
2023-11-15 11:15 ` [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/BaseXApicLib: Fix CPUID_V2_EXTENDED_TOPOLOGY detection Wu, Jiaxin
2023-11-15 14:44   ` Laszlo Ersek
2023-11-16  1:25   ` Ni, Ray
2023-11-21  2:23   ` Ni, Ray
2023-11-15 11:15 ` [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/PiSmmCpuDxeSmm: Get processor extended information Wu, Jiaxin
2023-11-21  2:24   ` Ni, Ray [this message]
2023-11-15 11:15 ` [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Use " Wu, Jiaxin
2023-11-16  1:30   ` Ni, Ray
2023-11-17 21:05     ` Laszlo Ersek
2023-11-20  1:44       ` Ni, Ray
2023-11-20 12:42         ` Wu, Jiaxin
2023-11-21 16:12           ` Laszlo Ersek
2023-12-08 13:28           ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN6PR11MB8244830DAA01DAB193EF9B978CBBA@MN6PR11MB8244.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox