From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B447B78003C for ; Mon, 25 Mar 2024 02:46:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Jq1ItgBNFqAiUimoWG3kGAJ1rR9Ce5sxCozUQSyyuks=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1711334780; v=1; b=49Df7FXzF4NrOJmF5QlLYPzE9XsK2pkoFFd6crdzZRQfTmgDdmBr52Bgvdf3ORl8DbY4Morf zX24zCGH0vlfNPPltw2UchaSBJSa4G2aQhP+Ep/7HGvaqCYhNU0Gpx5Sea1fZC/NS2wix2Af/tP seXso1pIMWGJKoF4J74KLO5qPh4qHo1iy20pMbc4NiSfsVJ0ptS5uIO8HOLT4H0Vr7Q7LhgjHfK O9HxEKIcGEWSgGkQTCJQ3C+HrBl9U8jNJ93BCf5kRWDsrKC8PcFBCOwQlKttAUUTFCDfKU9Z51n CbpOx4Wu3CYb4gn7SyC0BH3C1F1Bv1OSwAuskORARLn9Q== X-Received: by 127.0.0.2 with SMTP id p9LKYY7687511xwFKNSVSI3G; Sun, 24 Mar 2024 19:46:20 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web10.43631.1711334779985508698 for ; Sun, 24 Mar 2024 19:46:20 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11023"; a="17752550" X-IronPort-AV: E=Sophos;i="6.07,152,1708416000"; d="scan'208,217";a="17752550" X-Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2024 19:46:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,152,1708416000"; d="scan'208,217";a="15878369" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Mar 2024 19:46:19 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 24 Mar 2024 19:46:18 -0700 X-Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 24 Mar 2024 19:46:18 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 24 Mar 2024 19:46:18 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 24 Mar 2024 19:46:17 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MN0PR11MB6253.namprd11.prod.outlook.com (2603:10b6:208:3c6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Mon, 25 Mar 2024 02:46:10 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817%5]) with mapi id 15.20.7409.028; Mon, 25 Mar 2024 02:46:10 +0000 From: "Ni, Ray" To: Gerd Hoffmann , Chao Li CC: "devel@edk2.groups.io" , "Kumar, Rahul R" , Sami Mujawar , Sunil V L , Bibo Mao , Dongyan Qian Subject: Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg Thread-Topic: [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg Thread-Index: AQHaeqKOwBdqqtDKIUqwU86L2eCtHLFDts8AgAQOACM= Date: Mon, 25 Mar 2024 02:46:10 +0000 Message-ID: References: <20240320084152.268323-1-lichao@loongson.cn> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MN0PR11MB6253:EE_ x-ms-office365-filtering-correlation-id: 9ab162da-fdae-44db-c328-08dc4c75ba57 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 5ncqlPXSZjPTmyn8UW1SY69GRril0FbdHu2ovYykhBZVJ3RChkCEusfs60IZ+vl/sM/EKr4zRBgk92sq9lRrsyC+l5yXyaH9RijTC/foclb/4VCSGYD7T8mDNlki3bzeFV+1I+VsgbesreJMml4oiEWJuZt9Jajk5l5jGJn4pjYM5eMjWap/8bN5E7YXlecyz1nEZCj//SKZUCHY59irjjjuB6U8V3gHz8jbVn5WRoAPItXE5lUVp6ge10TbZbGs6N6AGxKg8c/0zq7J1Jt+rwMPaq9+u9KRxut3RaawT+ACnJuZOMfVTT1zHtpED6kqbhz2bV8/20afTmyiWCDsro/WyP6mBpoKtF05BX53vt9NF2qEKBsdJu8Kgf+Mb2ygMtdjSmR22L8YsyqTKunDOQKub9EbXZ4szAqVoUlAK4aSXQo8Z2eJHz45rRi7+AIBHr3D1KzAbCTv8oIPo56IZ4O/xxZk1I6xAHIu0lc4Fc9/PRr3utQ7bWKMExa6czYA1nJqDl2Vl8PNziyL5a1omgCxVu4hC1gCwaHoPgJqfYuThVPJcK6++IqAKfIiyUt1RpyzTc56T2hy7XmkaUhgal02FGCOIk2ZE47c178inhevvGVtzYQffNS/bNJasus8Srx4Gz5rH8ecF09pW5+pSbioM1y+DAakNHQon1astWqgYGkpvZxVVVYe4CCCLLj3 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HkP2BOD2k7WBs5vhGQT/cj6kFhVQcvHddQPcOSL/D8BXKWms5jlbAc88Aa7g?= =?us-ascii?Q?rFbZjR1KZXtZ7cme9uvA3nI0V9OF67AhhPtvo8y5lbvoHTVIPR9lJ/FwEjv1?= =?us-ascii?Q?JIqaL6opONxIJVMxwTzKEq7wvvyytpEUeGcqmgRSP6r0Co4aX/G6UKnoKrau?= =?us-ascii?Q?cmcvAp5PaojlNzJnzn342gRV9jOYSTjGL7d7ymuTijsOOtwlP0WMjywWn7W0?= =?us-ascii?Q?K4hVPlcvlEJfsf3rc6//OTVGa39Tt6OGmqTbJFECzJbFMLdGCaAPi+I4tI3c?= =?us-ascii?Q?rt/A3+OoCoStzRWJtxwq0lyqa9u6yQobYBAdTOKR4zHUg71gh7OneRbqbDO2?= =?us-ascii?Q?C9KZIGGmqg3FFiHgq0AQaJNlcFYy5pfuGOJOXLLdioJvdQ/qlHRTcgAodE18?= =?us-ascii?Q?U4DvFkkzFuzrhhkRHuT7VN5RPvLw8fghcKNpYq5JTeVxmLqrp2XOjwq5xCqQ?= =?us-ascii?Q?r/in3O0qFdlsWiaH5Vije6z1+oUb4JR/ICzFiGBnoJataTjEPGzHf+/nd9Rk?= =?us-ascii?Q?29DkBO4mzWTv+1qR+lBQuBUa6k63QmxZExkW6C1yDsNs8QDkVJ5ZUd+19OtQ?= =?us-ascii?Q?h+NeWrM60GoKj+3elRWC7b9sMyNmD29KN7eqHCW7pssGYcK4EqAytFRZFkaI?= =?us-ascii?Q?YEGB7m7P39Be6rrhUjy1XCZrLheqHZiGmvgyXXD3eTHfmVCO8X7IZxUmQOEj?= =?us-ascii?Q?lQ2K1kTb5Vv2dTGx5xlykwv4/YnKoDXop4Om5BzfrBaf7xpdq5I7nudn5xrs?= =?us-ascii?Q?P6oXvkv9NSbU4YXuv0kbeFQMzdmcFZn3VQw6YJ1L6AbQoYY5/cec47kZjbZ9?= =?us-ascii?Q?TWX9dOSN97QFIL4+8UrcXOySngjyC64Pt7RYTKD6PyiJ4V9cYt1g6Y+aBvhA?= =?us-ascii?Q?yD9RT5iR4TF3Y4lL3nibVWn1EbsZ/3a2rO40ghbRLgOmiqa+seeg9o9uzIMR?= =?us-ascii?Q?J1CIywpiv4wFgbfcQptkFLjtIm07X41rf03ABRX6Jrfu4+gxP4dbD31qx2U+?= =?us-ascii?Q?qO4p7zBLtzaXi6aDK7lcWBdT8iKA7kongWUdvtdJArTf2uKTQiqqxlU1t/Li?= =?us-ascii?Q?ZCv/7CYP/tP3Iaci5yCNQaXx0viXF7dSert7o4WgDfqV3CZ9GlZNLmvVj9vN?= =?us-ascii?Q?gTLCgEdmXOU5LJ4ZZCxLXKuhgrO30SFFpftFaesDsvLB8JaAAS8sDl5na9zZ?= =?us-ascii?Q?QRtwztlq2lEKa+apfgKZVHPYTRSHRRt3n2uVagvQ9mPA84PtepQaWu6c+H8y?= =?us-ascii?Q?DpZOUX3H6R3Z6D+fDjrmtaqZgKdPNJhuyji98gqNws2f/NkwgvOOsFZ9/7RA?= =?us-ascii?Q?Fh0bhU80Pa+HKIsdrtrNCOMKHylfA86IKKbX92IP+/mk7jsq5ojNYskou3PP?= =?us-ascii?Q?0PsQO8K6FW9LB26ti3S5WFPYXMSYp84g8lU25c7jAJXAhmM1WRMEOptJaYTq?= =?us-ascii?Q?uH0SgsC7N7KDUG3s3wRwY9rv7nBcen3mfxq0RyQ679bmF2l0nJpxCck3gyUU?= =?us-ascii?Q?zFSXxnskS6b1P/ieeJSJcuPUnZ7mUjAMctwIDG5AmYJSPAzQcLUempKGimR1?= =?us-ascii?Q?2OWseOytm/Q1yKeLLb8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ab162da-fdae-44db-c328-08dc4c75ba57 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2024 02:46:10.0793 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iN1xSj64bM8u1MIL1meVi2G8C6pT7jB+FXWv4PrnBFe8x6kBUl/n2IqfKGONU+XCaQicRCddFSfR9NvrlIW0Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6253 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 24 Mar 2024 19:46:20 -0700 Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: i8TtMapFfQ6mxF4hizyfBRjPx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244841B7FCE59986AD124688C362MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=49Df7FXz; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB8244841B7FCE59986AD124688C362MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Chao, Thank you for your patience for preparing the new version of patches. However, I still have following minor comments: For patches 1~6: Reviewed-by: Ray Ni For patches 7: can you define meaning of bits in the Attributes/Mask? It se= ems you are reusing the definitions defined for 7.2.3 EFI_BOOT_SERVICES.Get= MemoryMap(). It's fine. But please mention that in comments. Also please us= e UINT64 for Attributes instead of UINTN. For patches 8: Can you rename PcdCpuExceptionVectorBaseAddress to PcdLoongA= rch64ExceptionVectorBaseAddress and put the PCD definition/reference in the= DEC/INF LoongArch64 section? For patches 9: Please make accordingly changes when you address comments fo= r patch 7. For patches 10, 11: Can the lib be avoided if the logic is implemented in C= puDxe driver? For patch 12(UefiCpuPkg: Add multiprocessor library for LoongArch64): Revie= wed-by: Ray Ni For patch 13: Please make accordingly changes when you address comments for= patch 8. Thanks, Ray ________________________________ From: Gerd Hoffmann Sent: Friday, March 22, 2024 20:39 To: Chao Li Cc: devel@edk2.groups.io ; Ni, Ray = ; Kumar, Rahul R ; Sami Mujawar ; Sunil V L ; Bibo Mao ;= Dongyan Qian Subject: Re: [PATCH v2 00/13] Part 2 patch set to add LoongArch support int= o UefiCpuPkg On Wed, Mar 20, 2024 at 04:41:52PM +0800, Chao Li wrote: > This patch set adjusted some order in UefiCpuPig alphabetically, added > LoongArch libraries and drivers into UefiCpuPkg, it is a continuation of > the first patch series v8 submitted at > https://edk2.groups.io/g/devel/message/114526. > > And also separated from https://edk2.groups.io/g/devel/message/116583. > > This series only contents the changes for UefiCpuPkg. > > Patch1-Patch4: Reorder some INF files located in UefiCpuPkg > alphabetically. > > Patch5-Patch13: Added Timer, CpuMmuLib, CpuMmuInitLib, MpInitLib, CpuDxe > for LoongArch, and added some PCD and header files requested by the > above libraries and drivers. > > Modfied modules: UefiCpuPkg > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4726 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4734 > > PR: https://github.com/tianocore/edk2/pull/5483 > > V1 -> V2: > 1. Removed PcdCpuMmuIsEnabled. > 2. Removed API GetMemoryRegionAttributes API as it is no longer needed. > 3. Patch3, added two empty line in DXE and PEI INF files. > 4. Patch5, added the Status check in GetTimeInnanoSecond function. > 5. Separated into two series, this is series one, and the second one is > OvmfPkg. While I can't comment on the loongarch architecture details the code and the integration into build system looks overall sane to me. Series: Acked-by: Gerd Hoffmann take care, Gerd -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117077): https://edk2.groups.io/g/devel/message/117077 Mute This Topic: https://groups.io/mt/105041080/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244841B7FCE59986AD124688C362MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Chao,
Thank you for your patience for preparing the new version of patches.
However, I still have following minor comments:

For patches 1~6: Reviewed-by: Ray Ni <ray.ni@intel.com>
For patches 7: can you define meaning of bits in the Attributes/Mask? It se= ems you are reusing the definitions defined for 7.2.3 EFI_BOOT_SERVICES.Get= MemoryMap(). It's fine. But please mention that in comments. Also please us= e UINT64 for Attributes instead of UINTN.
For patches 8: Can you rename PcdCpuExcept= ionVectorBaseAddress to PcdLoongArch64ExceptionVectorBaseAddress an= d put the PCD definition/reference in the DEC/INF LoongArch64 section?
For patches 9: Please make accordingly changes when you address comments fo= r patch 7.
For patches 10, 11: Can the lib be avoided if the logic is implemented in C= puDxe driver?
For patch 12(UefiCpuPkg: Add multiprocessor library for LoongArch64): Revie= wed-by: Ray Ni <ray.ni@intel.com>
For patch 13: Please make accordingly changes when you address comments for= patch 8.

Thanks,
Ray
From: Gerd Hoffmann <kra= xel@redhat.com>
Sent: Friday, March 22, 2024 20:39
To: Chao Li <lichao@loongson.cn>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Ni, Ray <r= ay.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Sami M= ujawar <sami.mujawar@arm.com>; Sunil V L <sunilvl@ventanamicro.com= >; Bibo Mao <maobibo@loongson.cn>; Dongyan Qian <qiandongyan@lo= ongson.cn>
Subject: Re: [PATCH v2 00/13] Part 2 patch set to add LoongArch supp= ort into UefiCpuPkg
 
On Wed, Mar 20, 2024 at 04:41:52PM +0800, Chao Li = wrote:
> This patch set adjusted some order in UefiCpuPig alphabetically, added=
> LoongArch libraries and drivers into UefiCpuPkg, it is a continuation = of
> the first patch series v8 submitted at
> https://edk2= .groups.io/g/devel/message/114526.
>
> And also separated from https://edk2.groups.io/g/devel/message/116583.
>
> This series only contents the changes for UefiCpuPkg.
>
> Patch1-Patch4: Reorder some INF files located in UefiCpuPkg
> alphabetically.
>
> Patch5-Patch13: Added Timer, CpuMmuLib, CpuMmuInitLib, MpInitLib, CpuD= xe
> for LoongArch, and added some PCD and header files requested by the > above libraries and drivers.
>
> Modfied modules: UefiCpuPkg
>
> BZ: = https://bugzilla.tianocore.org/show_bug.cgi?id=3D4726
> BZ: = https://bugzilla.tianocore.org/show_bug.cgi?id=3D4734
>
> PR: https://gi= thub.com/tianocore/edk2/pull/5483
>
> V1 -> V2:
> 1. Removed PcdCpuMmuIsEnabled.
> 2. Removed API GetMemoryRegionAttributes API as it is no longer needed= .
> 3. Patch3, added two empty line in DXE and PEI INF files.
> 4. Patch5, added the Status check in GetTimeInnanoSecond function.
> 5. Separated into two series, this is series one, and the second one i= s
> OvmfPkg.

While I can't comment on the loongarch architecture details the code
and the integration into build system looks overall sane to me.

Series:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117077) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244841B7FCE59986AD124688C362MN6PR11MB8244namp_--