public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Tan, Dun" <dun.tan@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [Patch V4 15/21] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf
Date: Thu, 23 Mar 2023 13:25:43 +0000	[thread overview]
Message-ID: <MN6PR11MB824486D687FE660021A6FF9F8C879@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230323074057.549-16-dun.tan@intel.com>

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Thursday, March 23, 2023 3:41 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul R
> <rahul.r.kumar@intel.com>
> Subject: [Patch V4 15/21] UefiCpuPkg: Fix IA32 build failure in
> CpuPageTableLib.inf
> 
> From: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> The definition of IA32_MAP_ATTRIBUTE has 64 bits, and one of the bit
> field PageTableBaseAddress is from bit 12 to bit 52. This means if the
> compiler treats the 64bits value as two UINT32 value, the field
> PageTableBaseAddress spans two UINT32 value. That's why when building in
> NOOPT mode in IA32, the below issue is noticed:
> 	unresolved external symbol __allshl
> This patch fix the build failure by seperate field PageTableBaseAddress
> into two fields, make sure no field spans two UINT32 value.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> ---
>  UefiCpuPkg/Include/Library/CpuPageTableLib.h         |  32
> ++++++++++++++++----------------
>  UefiCpuPkg/Library/CpuPageTableLib/CpuPageTable.h    | 125
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++--------------------------------------------------------------
>  UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c |  22
> +++++++++++-----------
>  3 files changed, 90 insertions(+), 89 deletions(-)
> 
> diff --git a/UefiCpuPkg/Include/Library/CpuPageTableLib.h
> b/UefiCpuPkg/Include/Library/CpuPageTableLib.h
> index c94d82ea65..5e545a35f6 100644
> --- a/UefiCpuPkg/Include/Library/CpuPageTableLib.h
> +++ b/UefiCpuPkg/Include/Library/CpuPageTableLib.h
> @@ -11,22 +11,22 @@
> 
>  typedef union {
>    struct {
> -    UINT64    Present              : 1; // 0 = Not present in memory, 1 = Present in
> memory
> -    UINT64    ReadWrite            : 1; // 0 = Read-Only, 1= Read/Write
> -    UINT64    UserSupervisor       : 1; // 0 = Supervisor, 1=User
> -    UINT64    WriteThrough         : 1; // 0 = Write-Back caching, 1=Write-Through
> caching
> -    UINT64    CacheDisabled        : 1; // 0 = Cached, 1=Non-Cached
> -    UINT64    Accessed             : 1; // 0 = Not accessed, 1 = Accessed (set by CPU)
> -    UINT64    Dirty                : 1; // 0 = Not dirty, 1 = Dirty (set by CPU)
> -    UINT64    Pat                  : 1; // PAT
> -
> -    UINT64    Global               : 1; // 0 = Not global, 1 = Global (if CR4.PGE = 1)
> -    UINT64    Reserved1            : 3; // Ignored
> -
> -    UINT64    PageTableBaseAddress : 40; // Page Table Base Address
> -    UINT64    Reserved2            : 7;  // Ignored
> -    UINT64    ProtectionKey        : 4;  // Protection key
> -    UINT64    Nx                   : 1;  // No Execute bit
> +    UINT32    Present                  : 1;  // 0 = Not present in memory, 1 = Present
> in memory
> +    UINT32    ReadWrite                : 1;  // 0 = Read-Only, 1= Read/Write
> +    UINT32    UserSupervisor           : 1;  // 0 = Supervisor, 1=User
> +    UINT32    WriteThrough             : 1;  // 0 = Write-Back caching, 1=Write-
> Through caching
> +    UINT32    CacheDisabled            : 1;  // 0 = Cached, 1=Non-Cached
> +    UINT32    Accessed                 : 1;  // 0 = Not accessed, 1 = Accessed (set by
> CPU)
> +    UINT32    Dirty                    : 1;  // 0 = Not dirty, 1 = Dirty (set by CPU)
> +    UINT32    Pat                      : 1;  // PAT
> +    UINT32    Global                   : 1;  // 0 = Not global, 1 = Global (if CR4.PGE = 1)
> +    UINT32    Reserved1                : 3;  // Ignored
> +    UINT32    PageTableBaseAddressLow  : 20; // Page Table Base Address
> Low
> +
> +    UINT32    PageTableBaseAddressHigh : 20; // Page Table Base Address
> High
> +    UINT32    Reserved2                : 7;  // Ignored
> +    UINT32    ProtectionKey            : 4;  // Protection key
> +    UINT32    Nx                       : 1;  // No Execute bit
>    } Bits;
>    UINT64    Uint64;
>  } IA32_MAP_ATTRIBUTE;
> diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTable.h
> b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTable.h
> index 8d856d7c7e..2c67ecb469 100644
> --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTable.h
> +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTable.h
> @@ -29,11 +29,12 @@ typedef enum {
>  } IA32_PAGE_LEVEL;
> 
>  typedef struct {
> -  UINT64    Present        : 1;       // 0 = Not present in memory, 1 = Present in
> memory
> -  UINT64    ReadWrite      : 1;       // 0 = Read-Only, 1= Read/Write
> -  UINT64    UserSupervisor : 1;       // 0 = Supervisor, 1=User
> -  UINT64    Reserved       : 58;
> -  UINT64    Nx             : 1;        // No Execute bit
> +  UINT32    Present        : 1;       // 0 = Not present in memory, 1 = Present in
> memory
> +  UINT32    ReadWrite      : 1;       // 0 = Read-Only, 1= Read/Write
> +  UINT32    UserSupervisor : 1;       // 0 = Supervisor, 1=User
> +  UINT32    Reserved0      : 29;
> +  UINT32    Reserved1      : 31;
> +  UINT32    Nx             : 1;        // No Execute bit
>  } IA32_PAGE_COMMON_ENTRY;
> 
>  ///
> @@ -41,20 +42,20 @@ typedef struct {
>  ///
>  typedef union {
>    struct {
> -    UINT64    Present              : 1; // 0 = Not present in memory, 1 = Present in
> memory
> -    UINT64    ReadWrite            : 1; // 0 = Read-Only, 1= Read/Write
> -    UINT64    UserSupervisor       : 1; // 0 = Supervisor, 1=User
> -    UINT64    WriteThrough         : 1; // 0 = Write-Back caching, 1=Write-Through
> caching
> -    UINT64    CacheDisabled        : 1; // 0 = Cached, 1=Non-Cached
> -    UINT64    Accessed             : 1; // 0 = Not accessed, 1 = Accessed (set by CPU)
> -    UINT64    Available0           : 1; // Ignored
> -    UINT64    MustBeZero           : 1; // Must Be Zero
> -
> -    UINT64    Available2           : 4; // Ignored
> -
> -    UINT64    PageTableBaseAddress : 40; // Page Table Base Address
> -    UINT64    Available3           : 11; // Ignored
> -    UINT64    Nx                   : 1;  // No Execute bit
> +    UINT32    Present                  : 1;  // 0 = Not present in memory, 1 = Present
> in memory
> +    UINT32    ReadWrite                : 1;  // 0 = Read-Only, 1= Read/Write
> +    UINT32    UserSupervisor           : 1;  // 0 = Supervisor, 1=User
> +    UINT32    WriteThrough             : 1;  // 0 = Write-Back caching, 1=Write-
> Through caching
> +    UINT32    CacheDisabled            : 1;  // 0 = Cached, 1=Non-Cached
> +    UINT32    Accessed                 : 1;  // 0 = Not accessed, 1 = Accessed (set by
> CPU)
> +    UINT32    Available0               : 1;  // Ignored
> +    UINT32    MustBeZero               : 1;  // Must Be Zero
> +    UINT32    Available2               : 4;  // Ignored
> +    UINT32    PageTableBaseAddressLow  : 20; // Page Table Base Address
> Low
> +
> +    UINT32    PageTableBaseAddressHigh : 20; // Page Table Base Address
> High
> +    UINT32    Available3               : 11; // Ignored
> +    UINT32    Nx                       : 1;  // No Execute bit
>    } Bits;
>    UINT64    Uint64;
>  } IA32_PAGE_NON_LEAF_ENTRY;
> @@ -86,23 +87,23 @@ typedef IA32_PAGE_NON_LEAF_ENTRY IA32_PDE;
>  ///
>  typedef union {
>    struct {
> -    UINT64    Present              : 1; // 0 = Not present in memory, 1 = Present in
> memory
> -    UINT64    ReadWrite            : 1; // 0 = Read-Only, 1= Read/Write
> -    UINT64    UserSupervisor       : 1; // 0 = Supervisor, 1=User
> -    UINT64    WriteThrough         : 1; // 0 = Write-Back caching, 1=Write-Through
> caching
> -    UINT64    CacheDisabled        : 1; // 0 = Cached, 1=Non-Cached
> -    UINT64    Accessed             : 1; // 0 = Not accessed, 1 = Accessed (set by CPU)
> -    UINT64    Dirty                : 1; // 0 = Not dirty, 1 = Dirty (set by CPU)
> -    UINT64    MustBeOne            : 1; // Page Size. Must Be One
> -
> -    UINT64    Global               : 1; // 0 = Not global, 1 = Global (if CR4.PGE = 1)
> -    UINT64    Available1           : 3; // Ignored
> -    UINT64    Pat                  : 1; // PAT
> -
> -    UINT64    PageTableBaseAddress : 39; // Page Table Base Address
> -    UINT64    Available3           : 7;  // Ignored
> -    UINT64    ProtectionKey        : 4;  // Protection key
> -    UINT64    Nx                   : 1;  // No Execute bit
> +    UINT32    Present                  : 1;  // 0 = Not present in memory, 1 = Present
> in memory
> +    UINT32    ReadWrite                : 1;  // 0 = Read-Only, 1= Read/Write
> +    UINT32    UserSupervisor           : 1;  // 0 = Supervisor, 1=User
> +    UINT32    WriteThrough             : 1;  // 0 = Write-Back caching, 1=Write-
> Through caching
> +    UINT32    CacheDisabled            : 1;  // 0 = Cached, 1=Non-Cached
> +    UINT32    Accessed                 : 1;  // 0 = Not accessed, 1 = Accessed (set by
> CPU)
> +    UINT32    Dirty                    : 1;  // 0 = Not dirty, 1 = Dirty (set by CPU)
> +    UINT32    MustBeOne                : 1;  // Page Size. Must Be One
> +    UINT32    Global                   : 1;  // 0 = Not global, 1 = Global (if CR4.PGE = 1)
> +    UINT32    Available1               : 3;  // Ignored
> +    UINT32    Pat                      : 1;  // PAT
> +    UINT32    PageTableBaseAddressLow  : 19; // Page Table Base Address
> Low
> +
> +    UINT32    PageTableBaseAddressHigh : 20; // Page Table Base Address
> High
> +    UINT32    Available3               : 7;  // Ignored
> +    UINT32    ProtectionKey            : 4;  // Protection key
> +    UINT32    Nx                       : 1;  // No Execute bit
>    } Bits;
>    UINT64    Uint64;
>  } IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE;
> @@ -123,22 +124,22 @@ typedef IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE
> IA32_PDPTE_1G;
>  ///
>  typedef union {
>    struct {
> -    UINT64    Present              : 1; // 0 = Not present in memory, 1 = Present in
> memory
> -    UINT64    ReadWrite            : 1; // 0 = Read-Only, 1= Read/Write
> -    UINT64    UserSupervisor       : 1; // 0 = Supervisor, 1=User
> -    UINT64    WriteThrough         : 1; // 0 = Write-Back caching, 1=Write-Through
> caching
> -    UINT64    CacheDisabled        : 1; // 0 = Cached, 1=Non-Cached
> -    UINT64    Accessed             : 1; // 0 = Not accessed, 1 = Accessed (set by CPU)
> -    UINT64    Dirty                : 1; // 0 = Not dirty, 1 = Dirty (set by CPU)
> -    UINT64    Pat                  : 1; // PAT
> -
> -    UINT64    Global               : 1; // 0 = Not global, 1 = Global (if CR4.PGE = 1)
> -    UINT64    Available1           : 3; // Ignored
> -
> -    UINT64    PageTableBaseAddress : 40; // Page Table Base Address
> -    UINT64    Available3           : 7;  // Ignored
> -    UINT64    ProtectionKey        : 4;  // Protection key
> -    UINT64    Nx                   : 1;  // No Execute bit
> +    UINT32    Present                  : 1;  // 0 = Not present in memory, 1 = Present
> in memory
> +    UINT32    ReadWrite                : 1;  // 0 = Read-Only, 1= Read/Write
> +    UINT32    UserSupervisor           : 1;  // 0 = Supervisor, 1=User
> +    UINT32    WriteThrough             : 1;  // 0 = Write-Back caching, 1=Write-
> Through caching
> +    UINT32    CacheDisabled            : 1;  // 0 = Cached, 1=Non-Cached
> +    UINT32    Accessed                 : 1;  // 0 = Not accessed, 1 = Accessed (set by
> CPU)
> +    UINT32    Dirty                    : 1;  // 0 = Not dirty, 1 = Dirty (set by CPU)
> +    UINT32    Pat                      : 1;  // PAT
> +    UINT32    Global                   : 1;  // 0 = Not global, 1 = Global (if CR4.PGE = 1)
> +    UINT32    Available1               : 3;  // Ignored
> +    UINT32    PageTableBaseAddressLow  : 20; // Page Table Base Address
> Low
> +
> +    UINT32    PageTableBaseAddressHigh : 20; // Page Table Base Address
> High
> +    UINT32    Available3               : 7;  // Ignored
> +    UINT32    ProtectionKey            : 4;  // Protection key
> +    UINT32    Nx                       : 1;  // No Execute bit
>    } Bits;
>    UINT64    Uint64;
>  } IA32_PTE_4K;
> @@ -149,16 +150,16 @@ typedef union {
>  ///
>  typedef union {
>    struct {
> -    UINT64    Present              : 1; // 0 = Not present in memory, 1 = Present in
> memory
> -    UINT64    MustBeZero           : 2; // Must Be Zero
> -    UINT64    WriteThrough         : 1; // 0 = Write-Back caching, 1=Write-Through
> caching
> -    UINT64    CacheDisabled        : 1; // 0 = Cached, 1=Non-Cached
> -    UINT64    MustBeZero2          : 4; // Must Be Zero
> -
> -    UINT64    Available            : 3; // Ignored
> -
> -    UINT64    PageTableBaseAddress : 40; // Page Table Base Address
> -    UINT64    MustBeZero3          : 12; // Must Be Zero
> +    UINT32    Present                  : 1;  // 0 = Not present in memory, 1 = Present
> in memory
> +    UINT32    MustBeZero               : 2;  // Must Be Zero
> +    UINT32    WriteThrough             : 1;  // 0 = Write-Back caching, 1=Write-
> Through caching
> +    UINT32    CacheDisabled            : 1;  // 0 = Cached, 1=Non-Cached
> +    UINT32    MustBeZero2              : 4;  // Must Be Zero
> +    UINT32    Available                : 3;  // Ignored
> +    UINT32    PageTableBaseAddressLow  : 20; // Page Table Base Address
> Low
> +
> +    UINT32    PageTableBaseAddressHigh : 20; // Page Table Base Address
> High
> +    UINT32    MustBeZero3              : 12; // Must Be Zero
>    } Bits;
>    UINT64    Uint64;
>  } IA32_PDPTE_PAE;
> diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c
> b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c
> index 797fc2f600..982652b58b 100644
> --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c
> +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c
> @@ -26,7 +26,7 @@ PageTableLibSetPte4K (
>    IN IA32_MAP_ATTRIBUTE  *Mask
>    )
>  {
> -  if (Mask->Bits.PageTableBaseAddress) {
> +  if (Mask->Bits.PageTableBaseAddressLow || Mask-
> >Bits.PageTableBaseAddressHigh) {
>      Pte4K->Uint64 = (IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS
> (Attribute) + Offset) | (Pte4K->Uint64 &
> ~IA32_PE_BASE_ADDRESS_MASK_40);
>    }
> 
> @@ -93,7 +93,7 @@ PageTableLibSetPleB (
>    IN IA32_MAP_ATTRIBUTE                 *Mask
>    )
>  {
> -  if (Mask->Bits.PageTableBaseAddress) {
> +  if (Mask->Bits.PageTableBaseAddressLow || Mask-
> >Bits.PageTableBaseAddressHigh) {
>      PleB->Uint64 = (IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS
> (Attribute) + Offset) | (PleB->Uint64 &
> ~IA32_PE_BASE_ADDRESS_MASK_39);
>    }
> 
> @@ -238,7 +238,7 @@ IsAttributesAndMaskValidForNonPresentEntry (
>      //
>      if ((Mask->Bits.ReadWrite == 0) || (Mask->Bits.UserSupervisor == 0) ||
> (Mask->Bits.WriteThrough == 0) || (Mask->Bits.CacheDisabled == 0) ||
>          (Mask->Bits.Accessed == 0) || (Mask->Bits.Dirty == 0) || (Mask-
> >Bits.Pat == 0) || (Mask->Bits.Global == 0) ||
> -        (Mask->Bits.PageTableBaseAddress == 0) || (Mask->Bits.ProtectionKey
> == 0) || (Mask->Bits.Nx == 0))
> +        ((Mask->Bits.PageTableBaseAddressLow == 0) && (Mask-
> >Bits.PageTableBaseAddressHigh == 0)) || (Mask->Bits.ProtectionKey == 0)
> || (Mask->Bits.Nx == 0))
>      {
>        return RETURN_INVALID_PARAMETER;
>      }
> @@ -396,7 +396,7 @@ PageTableLibMapInLevel (
>        // This function is called when the memory length is less than the region
> length of the parent level.
>        // No need to split the page when the attributes equal.
>        //
> -      if (Mask->Bits.PageTableBaseAddress == 0) {
> +      if ((Mask->Bits.PageTableBaseAddressLow == 0) && (Mask-
> >Bits.PageTableBaseAddressHigh == 0)) {
>          return RETURN_SUCCESS;
>        }
> 
> @@ -696,7 +696,7 @@ PageTableMap (
>      return RETURN_INVALID_PARAMETER;
>    }
> 
> -  if ((LinearAddress % SIZE_4KB != 0) || (Length % SIZE_4KB != 0)) {
> +  if (((UINTN)LinearAddress % SIZE_4KB != 0) || ((UINTN)Length %
> SIZE_4KB != 0)) {
>      //
>      // LinearAddress and Length should be multiple of 4K.
>      //
> @@ -738,12 +738,12 @@ PageTableMap (
>      *IsModified = FALSE;
>    }
> 
> -  ParentAttribute.Uint64                    = 0;
> -  ParentAttribute.Bits.PageTableBaseAddress = 1;
> -  ParentAttribute.Bits.Present              = 1;
> -  ParentAttribute.Bits.ReadWrite            = 1;
> -  ParentAttribute.Bits.UserSupervisor       = 1;
> -  ParentAttribute.Bits.Nx                   = 0;
> +  ParentAttribute.Uint64                       = 0;
> +  ParentAttribute.Bits.PageTableBaseAddressLow = 1;
> +  ParentAttribute.Bits.Present                 = 1;
> +  ParentAttribute.Bits.ReadWrite               = 1;
> +  ParentAttribute.Bits.UserSupervisor          = 1;
> +  ParentAttribute.Bits.Nx                      = 0;
> 
>    //
>    // Query the required buffer size without modifying the page table.
> --
> 2.31.1.windows.1


  reply	other threads:[~2023-03-23 13:25 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23  7:40 [Patch V4 00/21] Fix issues in CpuPageTableLib duntan
2023-03-23  7:40 ` [Patch V4 01/21] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition duntan
2023-03-23  7:40 ` [Patch V4 02/21] UefiCpuPkg/CpuPageTableLib: Add check for input Length duntan
2023-03-23 12:20   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 03/21] UefiCpuPkg/CpuPageTableLib:Initialize some LocalVariable at beginning duntan
2023-03-23 12:26   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 04/21] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue duntan
2023-03-23 12:29   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 05/21] UefiCpuPkg/CpuPageTableLib:Clear PageSize bit(Bit7) for non-leaf duntan
2023-03-23 12:29   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 06/21] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry duntan
2023-03-23 12:35   ` Ni, Ray
     [not found]   ` <174F0C7EF4E09C53.19937@groups.io>
2023-03-24  2:19     ` [edk2-devel] " Ni, Ray
2023-03-23  7:40 ` [Patch V4 07/21] UefiCpuPkg/MpInitLib: Add code to initialize MapMask duntan
2023-03-23 12:37   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 08/21] UefiCpuPkg/CpuPageTableLib:Add check for Mask and Attr duntan
2023-03-23 12:52   ` Ni, Ray
2023-03-24  1:55     ` duntan
2023-03-23  7:40 ` [Patch V4 09/21] UefiCpuPkg/CpuPageTableLib: Add manual test to check " duntan
2023-03-23 12:57   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 10/21] UefiCpuPkg/CpuPageTableLib:Modify RandomBoolean() in RandomTest duntan
2023-03-23 12:59   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 11/21] UefiCpuPkg/CpuPageTableLib:Modify RandomTest to check Mask/Attr duntan
2023-03-23 13:11   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 12/21] UefiCpuPkg/CpuPageTableLib: Enable non-1:1 mapping in random test duntan
2023-03-23  7:40 ` [Patch V4 13/21] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter duntan
2023-03-23 13:20   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 14/21] UefiCpuPkg/CpuPageTableLib: Modify RandomTest to check IsModified duntan
2023-03-23 13:23   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 15/21] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf duntan
2023-03-23 13:25   ` Ni, Ray [this message]
2023-03-23  7:40 ` [Patch V4 16/21] UefiCpuPkg: Modify UnitTest code since tested API is changed duntan
2023-03-23  7:40 ` [Patch V4 17/21] UefiCpuPkg/CpuPageTableLib: Add check for page table creation duntan
2023-03-23 13:29   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 18/21] UefiCpuPkg: Combine branch for non-present and leaf ParentEntry duntan
2023-03-23 13:32   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 19/21] UefiCpuPkg/CpuPageTableLib: Enable PAE paging duntan
2023-03-23 13:38   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 20/21] UefiCpuPkg/CpuPageTableLib: Add RandomTest for " duntan
2023-03-23 13:40   ` Ni, Ray
2023-03-23  7:40 ` [Patch V4 21/21] UefiCpuPkg/CpuPageTableLib: Reduce the number of random tests duntan
2023-03-23 13:40   ` Ni, Ray
2023-03-23  9:13 ` [edk2-devel] [Patch V4 00/21] Fix issues in CpuPageTableLib Gerd Hoffmann
2023-03-23  9:16   ` duntan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN6PR11MB824486D687FE660021A6FF9F8C879@MN6PR11MB8244.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox