From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 15743940FA6 for ; Mon, 13 May 2024 02:35:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3zNj50c6/E9EIPY8gNPYkjgfdHiShBkW0+eE369QkVQ=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715567748; v=1; b=qf8uq8VoZJc7MzN90Wd3QooPqkRU4XTvy6rEKYRGblm/jzlb5T+r7g0LSR//l1orkWxLAntC ZczEX/3D0FYjjvxptVxsjQLkwI0J1FoXypLjt2up+MjftZq+DxQXe1LTXkxM7tHHcJ1Y1zNco1z emVuqXMxRos5ZUdPXpCRMvPvufygkk0Paav8DSgjKWStDE332YM63Iuw81dyvrNuLiT60aAd48k Ae/aBCm9TMrfW3imlRyoHtRBuDQ2fnNKqEFmO+ALwmm8H5OWhD1qqLYirjAlwKX8b2RXS0+/pcQ Cxh3MMFVet0sMeYEvaDOHFvYQG1Sz65L0gwZ4eLzbhP6Q== X-Received: by 127.0.0.2 with SMTP id sBTMYY7687511x8x7rutIF0S; Sun, 12 May 2024 19:35:48 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mx.groups.io with SMTP id smtpd.web10.51195.1715567747907559028 for ; Sun, 12 May 2024 19:35:47 -0700 X-CSE-ConnectionGUID: 4M2mvvFBTUCu1kbzpzBnwg== X-CSE-MsgGUID: UwBY5YBEQli868BS/W7i5Q== X-IronPort-AV: E=McAfee;i="6600,9927,11071"; a="22884099" X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="22884099" X-Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2024 19:35:48 -0700 X-CSE-ConnectionGUID: 291mw4e/Sb2BaBVqWIxrLg== X-CSE-MsgGUID: 3OJiqMjxQTy5lerm1jL2GA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="34704736" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 May 2024 19:35:47 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:35:47 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:35:46 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 12 May 2024 19:35:46 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 12 May 2024 19:35:46 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW4PR11MB6862.namprd11.prod.outlook.com (2603:10b6:303:220::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 02:35:44 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7544.052; Mon, 13 May 2024 02:35:44 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Wang, Jian J" , Liming Gao Subject: Re: [edk2-devel] [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Topic: [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Index: AQHaosIv2r42yjR6RUyV2ktTDmEOmLGUdn1E Date: Mon, 13 May 2024 02:35:44 +0000 Message-ID: References: <20240510100827.1903-1-dun.tan@intel.com> <20240510100827.1903-19-dun.tan@intel.com> In-Reply-To: <20240510100827.1903-19-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW4PR11MB6862:EE_ x-ms-office365-filtering-correlation-id: 010c1b3d-b3d2-4678-a4c9-08dc72f56384 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?tf0GI/IeDpjCzFzNeKAbLmjYy2uY+oB9xTpIMGrrd1vws2+/ABTtR22nx2?= =?iso-8859-1?Q?ZiC6X/iNiy89o4Hp7ynR+I+lHt/aeE++7+LlhaFHC6Zyqq5xWEP/eOgvlk?= =?iso-8859-1?Q?5Y0VUxvT88b6bj1DXlHob96DaAb8J6LfF7ATmjmS9lg3pNM9ei6CnYKj7p?= =?iso-8859-1?Q?b/hdKy2Fs8FhJxE1FFQ7Xr63bofBueKWT0eZea2pZvFhwNZsRydYaghxrc?= =?iso-8859-1?Q?Rclk6K4LKWD8z7RSF2QUEE6w2WPuVHuvKR9Bquy5Ut9lW+PaqNp7iOJouw?= =?iso-8859-1?Q?TcShhfshsgpNM0kkIuHx2J+VLdczT6yiYnYwOD0klEdBFX/vDkadr1GR9t?= =?iso-8859-1?Q?e9ZDKfO6C1yLxhyFPRQhJPu0O/JjfVO7A26LuvpqWIER2FGtud/sJzM+9m?= =?iso-8859-1?Q?HNwAQhEI0Gw9hGZdnhU98Y4x6AWxi5G2BIvOVRKd4F9/BA6VE4JfMp77Dz?= =?iso-8859-1?Q?uBrNA7ZjIfLxmOmWB+I/FA1HIS59nQxOGWBxigmBJ22jvXaB/12Izhi5dr?= =?iso-8859-1?Q?tLzFlFDYIcFdL+cKvI9ML88oi0SY7pPbq2tQsCEShcOpzXWYwFmCrlRY0u?= =?iso-8859-1?Q?5t5ByFSCPPtfy0ZHLaRQRe4nqdidIQ+jaautVJTGIPzXfoEjdsOtLbszHh?= =?iso-8859-1?Q?jQanKD8BWR3yJqcAOp7215qqpl+CoPxJHfznTKzO3zbo95qCeBwcVoVkLO?= =?iso-8859-1?Q?NPWOgNGR2FjGUOTNDDKL+3vKwTwaaZwJvEKKqVRNDc95kCHjkB7qzTUrYc?= =?iso-8859-1?Q?dj3scFqtgddZq0yV3zxFwR5LvQ6w1XFfIRkIlTHdjbIVH/q0IupbCre8YF?= =?iso-8859-1?Q?U6PkID0ATbL49Fa/IflUdz3sVcrC2fPxLcglIzbA+QlIgC8EiNiEtD5WUL?= =?iso-8859-1?Q?fMOOsfMmQ8wudzieUyc2FxQMfr2jT1Ye1C+OajD2LlG7F4KNHlR2qVTksp?= =?iso-8859-1?Q?s5CGjkk/1T9Am7BJmSlvi6EX+37yJPxm54jI2nIQ1mzrW53v+H4lcH/S8U?= =?iso-8859-1?Q?5IGdsUzYC+hdqO7hlJ7oINSQ2WYofzrYkiT2aNn9Ojx/taRUPxsB6+5fg1?= =?iso-8859-1?Q?IULdA8B22RYiniscDzY1t5nqSrNbUwbPIqH9vg48AdBukhqmRifkRzfoF/?= =?iso-8859-1?Q?wK7LqDgq5/n8/nL4ig5nMHDKxshic7XXpKp6CdzuFdunFSWzNpyUQYFceu?= =?iso-8859-1?Q?e499DDmrIFMTsAMgR/l+on2ZjU7dpn2RjVHxz+Qc41jLoeDDzFzUjou4jG?= =?iso-8859-1?Q?HzedUjPzVxxXjjo5nrnxj4/xLf+P8eNjlnNDhwXIbTppDy3UmAzh2fZfMs?= =?iso-8859-1?Q?KCte8AQt7ALWhg7EfnauIbX5RQsmaXExdOPN5tpk66hT8Ho0eEtArXFPaF?= =?iso-8859-1?Q?gcr4dZYRxD/jvguiXNCgWMK5NzT0101g=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?TXDE8zAWIUMiSJVasaZiUo4DNQw2MMbPrKZdbAOiZivDsj1sDIOvgE0hR9?= =?iso-8859-1?Q?zjbJmkQ+1AY8Hnie8ELMnpxrfmlInamf0JDLrn1fCLQtAJnFkW5Qjyez3k?= =?iso-8859-1?Q?fyqcZhNkHh1I+w0bnbRoDUHnlAbtwqqG06KfhsLmWfbpWL5QO67/zkR7ku?= =?iso-8859-1?Q?0KP+TrLmS5TIVvqH0XjYMFGFjoRo8ALGJha6AXUgDX4G8ekb9r2jkOn/j3?= =?iso-8859-1?Q?SH5kxTkdt7hXLAN7WmGwY/ei7/rPmZZdll4H6aaQ3+feH+4NaKGwHFA9JL?= =?iso-8859-1?Q?4Ptp5JhGRTiRecA8RTqaweP5jffhWzoV7TZNvCb3sZhf5aDGC3ODwTrd5b?= =?iso-8859-1?Q?gjzGwGjxQiSTy/rAOrAG69/P5unr+8DBoTLFMaZHiMlCUQFltz+kYWaPh9?= =?iso-8859-1?Q?PmtPeRMrdPbckeDYVB8bfoFq5xhJmeMOu+Ejn4vZjfcO7DmUld+oATnjdD?= =?iso-8859-1?Q?0e8TarbVVLwWJuSsZmrvEtzhr6CWjxIOQkZe6BHJ7uF3By1rMsS8FjGENI?= =?iso-8859-1?Q?NalStqeQddDi1gznPdRjergSHqhq2NXK7J4507MjZOyc1XqBhCevdSX2go?= =?iso-8859-1?Q?eZKr/NIV3bzN0hlC8RimytMcn7p7+93d4/q6s5U2461mJ6rnvsE/jhZXwk?= =?iso-8859-1?Q?7pwDRVsESWTNdWNNwD2LYSYaN9WFsIiRUYu5hbUFiMgbiE9mPAEbjmLzQy?= =?iso-8859-1?Q?x2IfG7ZhjcL7Ef9EXOx+xG6LJcvm2uRYeVvBbWr29vkh+yuKhy6hf/DeA6?= =?iso-8859-1?Q?wKAcm8xggEQt5e/JwsHRsebaSlYxw96Z/4vxNXX2mNgdA6LfWdXkgNFIpv?= =?iso-8859-1?Q?ODJWYfsintO9fgLwwzYCoa/PX5bY+uk8IX052SgmKf4/xPaEiHq0FScExL?= =?iso-8859-1?Q?+LqZQd1DDVLuXzzcqjbzZFqCinpHBx586dxAjGLWPLZknM2HjBTrm9lwzs?= =?iso-8859-1?Q?cQShNbCNGpddtW7NZHCevXURIXvvW+qysCG6SMlftFips7l8eA5Ko+waWZ?= =?iso-8859-1?Q?YzDlFEl5/x05WUXG+9KO0bsfhLMDdBiEx8rSuQof8L2knZaavb5mSmzz70?= =?iso-8859-1?Q?hrO7jSEQ+VMsyQ93b12jRysAtZaQUiJatPbGzJ4zo/buLTVvAHaS2o7V2H?= =?iso-8859-1?Q?iDFOWWkTKMukeLv5rfzRbdPMfjRfKoOWCp1JVYDlce96UTOuzpwVgNMKb4?= =?iso-8859-1?Q?MWMnfNlUBKFYhVry5MmGVN72r84aFCakVKoNM25wZ7xANdIxgF/Tl9UXiT?= =?iso-8859-1?Q?lsNaUxbzOrfUFqfC8x2aGZI/R4evSoPfxD4cjeIyikfhZ4myQh1lmUGzgb?= =?iso-8859-1?Q?QjaoG0e25RfvWCKEQ/EpjGsBvTE7IDoUJ8DSSBXUTMPdajUw9HzQQYY/u4?= =?iso-8859-1?Q?pVqB62IzUWplYA/Q1UGKtPBQwqvEYtee120s0n+S9dNz9dd5+hi6VNPC7n?= =?iso-8859-1?Q?Nqy21gWTx7qbTi+K8d+n/UdvroG2drtFWKl1b8Y17/c6vwGb5L4TWInDvE?= =?iso-8859-1?Q?xk7+G+UOldORUMdobangoTcp79Lu8h+e18XilYhx6IMAs5Qx8nN6JPhPxu?= =?iso-8859-1?Q?xVNfJDvZAIryvenJEwYyb/Hq7G4ljIeNxtUS/PxxxJ8WXzYU91BYTYo975?= =?iso-8859-1?Q?CWXx3V7VtbMTQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 010c1b3d-b3d2-4678-a4c9-08dc72f56384 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 02:35:44.1405 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P038c6xygEudHZpdvKU0SG1e//tHIytpVTGkTOtiytjXHKtfZExE/nXLzeSLOyeVYnYrSs8TP8vY9LsrqjzCsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6862 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 12 May 2024 19:35:47 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LCSwoeif0nV3uyd35oS4Vz9px7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82448784DC61B8D44C5696A98CE22MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=qf8uq8Vo; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB82448784DC61B8D44C5696A98CE22MN6PR11MB8244namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable My comment to patch #6 suggested to keep the assignment to SmmS3ResumeState= ->MpService2Ppi. How about you keep the "SmmS3ResumeState->MpService2Ppi =3D 0" there and re= move that assignment and the field together in this patch? Thanks, Ray ________________________________ From: Tan, Dun Sent: Friday, May 10, 2024 18:08 To: devel@edk2.groups.io Cc: Ni, Ray ; Wang, Jian J ; Limin= g Gao Subject: [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RE= SUME_STATE This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP to do the CPU initialization during smm s3 boot when the execution mode of PEI and DXE are the same. Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup AP anymore. The initialization for AP will be done in S3Resume.c before transfer to CpuS3.c of smm cpu driver. So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao --- MdeModulePkg/Include/Guid/AcpiS3Context.h | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h b/MdeModulePkg/Inclu= de/Guid/AcpiS3Context.h index 72d173c4fd..0cfc81b49b 100644 --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h @@ -30,7 +30,6 @@ typedef struct { EFI_PHYSICAL_ADDRESS ReturnContext1; EFI_PHYSICAL_ADDRESS ReturnContext2; EFI_PHYSICAL_ADDRESS ReturnStackPointer; - EFI_PHYSICAL_ADDRESS MpService2Ppi; EFI_PHYSICAL_ADDRESS Smst; } SMM_S3_RESUME_STATE; -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118849): https://edk2.groups.io/g/devel/message/118849 Mute This Topic: https://groups.io/mt/106018145/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82448784DC61B8D44C5696A98CE22MN6PR11MB8244namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
My comment to patch #6 suggested to keep the assignment to SmmS3ResumeState= ->MpService2Ppi.
How about you keep the "SmmS3ResumeState->MpService2Ppi =3D 0"= there and remove that assignment and the field together in this patch?

Thanks,
Ray

From: Tan, D= un <dun.tan@intel.com>
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.w= ang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
Subject: [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field = in SMM_S3_RESUME_STATE
 
This MpService2Ppi field in SMM_S3_RESUME_S= TATE is used to
wakeup AP to do the CPU initialization during smm s3 boot when
the execution mode of PEI and DXE are the same.
Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to
wakeup AP anymore. The initialization for AP will be done in
S3Resume.c before transfer to CpuS3.c of smm cpu driver.
So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE.

Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 MdeModulePkg/Include/Guid/AcpiS3Context.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h b/MdeModulePkg/Inclu= de/Guid/AcpiS3Context.h
index 72d173c4fd..0cfc81b49b 100644
--- a/MdeModulePkg/Include/Guid/AcpiS3Context.h
+++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h
@@ -30,7 +30,6 @@ typedef struct {
   EFI_PHYSICAL_ADDRESS    ReturnContext1;
   EFI_PHYSICAL_ADDRESS    ReturnContext2;
   EFI_PHYSICAL_ADDRESS    ReturnStackPointer;
-  EFI_PHYSICAL_ADDRESS    MpService2Ppi;
   EFI_PHYSICAL_ADDRESS    Smst;
 } SMM_S3_RESUME_STATE;
 
--
2.31.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118849) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82448784DC61B8D44C5696A98CE22MN6PR11MB8244namp_--