From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id CC05D7803CD for ; Fri, 17 May 2024 05:51:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wSskCw4v6tOxfIae2421cQrj6+ydM9BqyZu9hBQUQlA=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715925096; v=1; b=Gdy7iTm2SgBGikNahf5R1axstlzBKsJxnHiSldCrRJeUKvLTvLjid0Kp4EsRonqf1gJ+XtSa IRNg6rZK0IOm596vc8ZZThPDiBbg5Lk6oOjZdNPxEdQcbcOrB3ETwsh2OurpR0lqdAjBLo1OAx7 wN7T2gaMgnDfFChkPINuvQZmuBe6QwHB3GRaDbxId5MGGF3fUzORPbYYP4qjSMm7ydOs8GGosBL 7cQv5dJbls7nifm135gxgjOyOPbQgQJz2CC1s06ZIMO/Sd8tM95nSG+8bdiZRI4yp5BKvSYXc01 254+ECFtBrEiRv8sHU2HLIN6sKqY4tT3ANslhPzqNPlUQ== X-Received: by 127.0.0.2 with SMTP id 3RVFYY7687511xSVvYKyFvGN; Thu, 16 May 2024 22:51:36 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web11.34093.1715925094912253617 for ; Thu, 16 May 2024 22:51:35 -0700 X-CSE-ConnectionGUID: 1Cc4BKloT3eMAzLoD4j4cA== X-CSE-MsgGUID: L4CPosctQ+uqci20x9ehwQ== X-IronPort-AV: E=McAfee;i="6600,9927,11074"; a="22758053" X-IronPort-AV: E=Sophos;i="6.08,166,1712646000"; d="scan'208,217";a="22758053" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2024 22:51:34 -0700 X-CSE-ConnectionGUID: WvHOFvLNQ+SMcDX/+Z+KYQ== X-CSE-MsgGUID: Vzc+1htzQ8WecsUU4o0Fcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,166,1712646000"; d="scan'208,217";a="62505999" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 May 2024 22:51:34 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 16 May 2024 22:51:33 -0700 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 16 May 2024 22:51:33 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 16 May 2024 22:51:33 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 16 May 2024 22:51:33 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BY1PR11MB7981.namprd11.prod.outlook.com (2603:10b6:a03:52f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.28; Fri, 17 May 2024 05:51:31 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7587.028; Fri, 17 May 2024 05:51:30 +0000 From: "Ni, Ray" To: "Ding, Feng (Sunnyvale)" , "Hsueh, Hong-Chih (Neo)" , Laszlo Ersek , "devel@edk2.groups.io" CC: "He, Jiangang" , "Chang, Abner" , "gaoliming@byosoft.com.cn" Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug Thread-Topic: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug Thread-Index: AQHaZaxEF2YgSucvR06xUiEgwmbem7EbGkMAgGZxw4CAC5cEFIAN9tuAgABXJLY= Date: Fri, 17 May 2024 05:51:30 +0000 Message-ID: References: <3a640aa0f5555ccc327588ef7bb8d4ba5941442d.1708619173.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=6af39b66-5ad1-462c-8800-a8b98572128d;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-17T00:37:44Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BY1PR11MB7981:EE_ x-ms-office365-filtering-correlation-id: 58266236-3c68-4284-2e55-08dc763566a1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?gmVBf8HuKDWMhkGGzwriT9Rla8V0b+YRm+9Ai5rDbkXPOEUIL/paSWTYDn+d?= =?us-ascii?Q?NlJTReLOBkNJ62NUxZ7zXytXcjOSUUcQ7YRwXd340s1SGxYmRVaEhtAMYUcU?= =?us-ascii?Q?8JFS71wFpdcPQk9uHQFaTXp+RR17lW54VYoyl4y8S3YZfQHSmLb/jYLSuxQd?= =?us-ascii?Q?mHQor/EgMJczEslXQAFcDK7nLRLljjjGbU5qz7tnXmks0SgN8fBaIHvMJBml?= =?us-ascii?Q?EEyChcTN1XnheJsumHiuh15TLxIXmFYWbHVLG+1Py6JEXYY1HWFzidKjrH6l?= =?us-ascii?Q?J4mzqcQTtQqpCY8n3+jFO2+n0ctd2tbJOpIrYFL2bTm++DGv8rl6a74WwYuF?= =?us-ascii?Q?G9B30NlPP0dS+btRAydPayU0UfEHttvGCvvuKHvkRlFY62ahukMCHkq9FbuM?= =?us-ascii?Q?NvEW57aiAuhlJXOpZv/zJY77Hu+uePI0LHOuYVGyMAoQmAJvdNIFBUCwNJBs?= =?us-ascii?Q?rK0QfoZMZiqCFaN3tnlR6nkTE4sY3LDL8SliDScTIHWRV8JXPO+WoM3XhNls?= =?us-ascii?Q?gm8JH3zWKdBzs8IjOJS4SV5oftSJjSJ67WQL7INs+CNbJ3KDAK8hFYzm3nHk?= =?us-ascii?Q?LNETHi2BJCJ+Nfqn0ROaYcMzVmeDYA7amnLPJYoAsBBcufZ1k6nV5e4jhYX6?= =?us-ascii?Q?rUM7CwOtrkpssbTXhxOjETEOItyBWAXDQU/ACoZolbzOHGVVsws1qS8bo2+x?= =?us-ascii?Q?Jwm5SHtO8Pf4wdieRq6mEnAoaFIssB83EFE8l6Zw7udTmzfCn4lMwqZoIhg/?= =?us-ascii?Q?fWl1xpWQ7EEs6mW2KUmKjNGbs0RhrwPkIf2n/cNt4zwIBE37qqMIXb6u0bee?= =?us-ascii?Q?vTAAzq8o7VqC7nMfN7HzSw/fqQmh8i2mq2e7ps40tTrSbLsmpuRnT5PNDRs9?= =?us-ascii?Q?3FOlukPXQhyxl34JJx8s1FMvbqdyfz0WDkSOZSwFY0/bAc8cQK6Fk67jFU1Z?= =?us-ascii?Q?mTP5DNNsPlgTriHG/q5Y/loUaAxFwVvQqD8/4r5S8JVe4lrvDKzG/XXsyA1B?= =?us-ascii?Q?lloR20/X5pyUcE1esZgNc1pTiuJMhAr4Z6GS+3be3n/khfSziREejr6ZuCdq?= =?us-ascii?Q?kBe0MRgbhFJ5C1evXATVK4CnMTTxvSq8x+f6D2lP5WSmeezEOFaL9d9zw5x+?= =?us-ascii?Q?A8HROtuP8Pv3m1IeJT+lJkrnPSwQPYugpdTx9H4kKXcuofIhwKe1P1rldwvb?= =?us-ascii?Q?zGij+R6YIZ6PMLxmp4L8AHPs8Cy65LCSLplJnBTxu8aKIK5rxze62kxEh1GJ?= =?us-ascii?Q?R5KHQWU9ry57zXeCYVtEUg7veycNEFwSnZe2n6TShd6sA6z0j5QrHVSNXigS?= =?us-ascii?Q?1E+jXmCQSfTfm+H3fn7KSuJWwCjCuxjkC219qz8yly0rAg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Zhff6TgmbItLd2grS4LNbf64GezgS0dqtdWj1Kxt5XvyGHiBQxNl4wNpY16t?= =?us-ascii?Q?wEK1YKKWjcj5o/TeE8igoIP2q+W4WvGs6PvF+GO/DDJOXHuBywrbn/91L4z3?= =?us-ascii?Q?hf/nqJOBmnY7FmmDKK/jWhnVauzQBHfEOX/NTghJh7X6i/uOBsqn9/szDokK?= =?us-ascii?Q?QXDvkoYPxqxkVQcipxm/6+ZVtrVgLo6hm7+yqxqAgNX29oO+EdGjjCAAxAbZ?= =?us-ascii?Q?tXgwVVErvuBD4sebXvZbhDXBaVesoHbN2sqaw7MUJBmVBJOEaFrXxqp5skFz?= =?us-ascii?Q?Hb5UW5jxTglV7NmZgk641ZhTqbHa4wZifz1iW3BcMKlPM19+oPmKqZK7//MX?= =?us-ascii?Q?85tia9nGvwpezSH0XovN7CyYU25VpBqp/KbMI3AHzvFEGwyIzUzOR1T5VaxR?= =?us-ascii?Q?pHl+caj5LZbD1PhY66dANBRiKOV06fc9F8OGZS2WtWe+i9cOvnlnuAVn6zF3?= =?us-ascii?Q?Nrw6cOYsOmYaVqG4d/Bj57HO5W5kkM82AyflbhrIngxFadjoMbLxqQ5a+Yr1?= =?us-ascii?Q?mXSV1oD33cPyIpCFfl0A2ZGAtVjBS6M+H+9yWIT3FSjHFAbgVt+I0yOKXJUR?= =?us-ascii?Q?SUG1nRF/Qpzqdt5wdEW/MGMeSsZrafOUilXA41LLux6PJ1BGopMq8vh4N4XL?= =?us-ascii?Q?Ubj4fyuQNyBtAAHxvDpmGBrZTMUDNEhp/ef/Tn5beaTDjFMQBow/VceGlZju?= =?us-ascii?Q?pkzCGQGTU0Hm505s+aq2v1SNFAVNUOCcGU3+3wxSQYMETMw8n24BkP7ajC97?= =?us-ascii?Q?hlhquBwUi4pI3QBU2c1PqtLkx1XZwvRweBgy6CJ8FkSGnkmQjt+jIc04slL0?= =?us-ascii?Q?K6nXhm//Teb5hb9SrjSIz5c2NszrWr26khsVfDGq0qbQrlryRUMlcu1AVJIQ?= =?us-ascii?Q?nIf70Vubg+pUQ1CqwHoecc2sVuOYksa+M+fDpYGXUCBkA1HAoKoFVRh60x7h?= =?us-ascii?Q?EHI6sK9ggS5ZFu44ETXKJnC/woxd49gTqkSY6Jt+9LE3KNrQQs9uIsv46bF6?= =?us-ascii?Q?+RI4fI7kGhfAzAh7U6I6khoLIBTDtu3dhkOR2sWWXSaTKJ748iCsinBVav6j?= =?us-ascii?Q?os/jc+FMHrbTpVYUbUnkgztLiXFwgXY5WgEu730+xxj5IkRSC/Mqb8Zn/MQA?= =?us-ascii?Q?2xatXB4OAWV336KqjItsk3V8fpXb6cehcUV6jKXX/Nd41CQyNk7Ysjewprg+?= =?us-ascii?Q?VkiwzYQnmthw3X70vTvx4CQe59Vrja/6jam5vK2CwQ4Je3tiFKnNEkBZhY6I?= =?us-ascii?Q?AClDGLJWVeAIpSp0dTIK5EEdDNygy8tMsZUkeqTfeNvWzWtYmQA1ootcb7Sj?= =?us-ascii?Q?YDw+3/6CFOHeN3UuPKjTi3Tx/+x7+hed0JHUOHopei7es40IBJJ5i653ytsf?= =?us-ascii?Q?EU34PVCtd6NAsqvDkg9bCJ0EhLYmbVay7/LF27kqVX4AVgXLYoQifdHmPHV7?= =?us-ascii?Q?TS0rk6SNSG2/2P59c0o1f535MglQoMWMZc/09Us+F9/4TLZRmLfDkz7O6dbU?= =?us-ascii?Q?ld8p4kfnV4pQdKYpLKxejIeZ2CrzA80Pus/RTUiAXLWqIjWE7DlmWGx9l3B+?= =?us-ascii?Q?iS1ivDJD4HWcMe347QE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58266236-3c68-4284-2e55-08dc763566a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2024 05:51:30.6685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3CVAW9xjnQdEzoEYRRUV9DfUfvrCMdYzfosUKvBX4o9dGLYxJeKfg9Mjq2uQn/Lne2Qi7mrBavSDr7YdKkI+xA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB7981 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 16 May 2024 22:51:35 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0et67FRMxlKFWh9uFWi6K4hNx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82448BAF80191B79BCE2A0688CEE2MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Gdy7iTm2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB82448BAF80191B79BCE2A0688CEE2MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for confirming. Thanks, Ray ________________________________ From: Ding, Feng (Sunnyvale) Sent: Friday, May 17, 2024 8:39 To: Ni, Ray ; Hsueh, Hong-Chih (Neo) ; Laszlo Ersek ; devel@edk2.groups.io Cc: He, Jiangang ; Chang, Abner ;= gaoliming@byosoft.com.cn Subject: RE: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug [AMD Official Use Only - AMD Internal Distribution Only] Hi Ray, You are right. The change is NOT necessary. Thanks feng From: Ni, Ray Sent: Tuesday, May 7, 2024 8:26 PM To: Hsueh, Hong-Chih (Neo) ; Laszlo Ersek ; devel@edk2.groups.io Cc: Ding, Feng (Sunnyvale) ; He, Jiangang ; Chang, Abner ; gaoliming@byosoft.com.cn Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Neo, I don't think your change is needed because of the following existing logic= where RemoveAllPciDeviceOnBridge() is called to destroy/free all PCI nodes= . if (Operation =3D=3D EfiPciHotplugRequestRemove) { if (*NumberOfChildren =3D=3D 0) { // // Remove all devices on the bridge // RemoveAllPciDeviceOnBridge (RootBridgeHandle, Bridge); return EFI_SUCCESS; } Thanks, Ray ________________________________ From: Hsueh, Hong-Chih (Neo) > Sent: Wednesday, May 1, 2024 2:24 To: Laszlo Ersek >; devel@edk2.= groups.io >; Ni, Ray > Cc: Ding, Feng (Sunnyvale) >;= He, Jiangang >; Chang, Abn= er >; gaoliming@byosoft.com= .cn > Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug [AMD Official Use Only - General] Hi @ray.ni@intel.com, Sorry you bother you, may I have your feedback for this patch? If it looks good to you could you help to give me an R-b ? Thank you. Regards, Neo ________________________________ From: Laszlo Ersek > Sent: Sunday, February 25, 2024 7:59 AM To: Hsueh, Hong-Chih (Neo) >; devel@edk2.groups.io > Cc: Ding, Feng (Sunnyvale) >;= He, Jiangang >; Chang, Abn= er >; ray.ni@intel.com >; gaoliming= @byosoft.com.cn > Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. On 2/22/24 17:28, Neo Hsueh wrote: > A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The action= s require PciHotPlugRequestNotify to add a root bridge or remove a root bri= dge completely. > In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return wit= h no-action on second plug because bridge tree shows configured. > Destroy Pci Device Tree in function PciHotPlugRequestNotify for unplug ev= ent to fix this issue. > > Cc: Feng Ding > > Cc: Jiangang He > > Signed-off-by: Neo Hsueh > > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModulePk= g/Bus/Pci/PciBusDxe/PciEnumerator.c > index 3f8c6e6da7..2b7af60e0a 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c > @@ -2103,6 +2103,8 @@ PciHotPlugRequestNotify ( > } > } > > + DestroyPciDeviceTree (Bridge); > + > // > // End for > // This looks convincing to me, but I don't now nearly enough about PciBusDxe internals (resource management in particular) to confidently approve this patch. I can give an Acked-by: Laszlo Ersek > but the patch should not be merged until Ray provides an R-b. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118981): https://edk2.groups.io/g/devel/message/118981 Mute This Topic: https://groups.io/mt/104511503/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82448BAF80191B79BCE2A0688CEE2MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Thanks for confirming.

Thanks,
Ray
From: Ding, Feng (Sunnyvale= ) <feng1.ding@amd.com>
Sent: Friday, May 17, 2024 8:39
To: Ni, Ray <ray.ni@intel.com>; Hsueh, Hong-Chih (Neo) <Hon= g-Chih.Hsueh@amd.com>; Laszlo Ersek <lersek@redhat.com>; devel@edk= 2.groups.io <devel@edk2.groups.io>
Cc: He, Jiangang <Jiangang.He@amd.com>; Chang, Abner <Abner= .Chang@amd.com>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn&g= t;
Subject: RE: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarch= y leak upon bridge hot-unplug
 

Hi Ray,

 

You are right. The change is NOT necessary.

 

Thanks

feng

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, May 7, 2024 8:26 PM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Laszlo E= rsek <lersek@redhat.com>; devel@edk2.groups.io
Cc: Ding, Feng (Sunnyvale) <feng1.ding@amd.com>; He, Jiangang = <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>; gaol= iming@byosoft.com.cn
Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarch= y leak upon bridge hot-unplug

 

Cautio= n: This message originated from an= External Source. Use proper caution when opening attachments, clicking lin= ks, or responding.

 

Neo,

I don't think your change is needed because of the foll= owing existing logic where RemoveAllPciDeviceOnBridge() is called to destro= y/free all PCI nodes.

 



 

  if (Operation =3D= =3D EfiPciHotplugRequestRemove) {

 

    if (*Number= OfChildren =3D=3D 0) {

 

      //

 

      // R= emove all devices on the bridge

 

      //

 

      Remo= veAllPciDeviceOnBridge (RootBridgeHandle, Bridge);

 

      retu= rn EFI_SUCCESS;

 

    }

 

 

Thanks,

Ray

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>
Sent: Wednesday, May 1, 2024 2:24
To: Laszlo Ersek <lersek@red= hat.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Ni, Ray <= ;ray.ni@intel.com>
Cc: Ding, Feng (Sunnyvale) <feng1.ding@amd.com>; He, Jiangang <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>; gaoliming@byosoft.com.cn &l= t;gaoliming@byosoft.com.cn&= gt;
Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarch= y leak upon bridge hot-unplug

 

[AMD Official Use Only - General]

 

 

Sorry you bother you, may I have your= feedback for this patch?

If it looks good to you could you hel= p to give me an R-b ?

 

Thank you.

 

Regards,

Neo

 

From: Laszlo Ersek <lersek@redhat.com>
Sent: Sunday, February 25, 2024 7:59 AM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ding, Feng (Sunnyvale) <feng1.ding@amd.com>; He, Jiangang <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>; ray.ni@intel.com <ray.ni@intel.com>; gaoliming@byosoft.com.cn &l= t;gaoliming@byosoft.com.cn&= gt;
Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hie= rarchy leak upon bridge hot-unplug

 

Caution: This messa= ge originated from an External Source. Use proper caution when opening atta= chments, clicking links, or responding.


On 2/22/24 17:28, Neo Hsueh wrote:
> A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The act= ions require PciHotPlugRequestNotify to add a root bridge or remove a root = bridge completely.
> In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return = with no-action on second plug because bridge tree shows configured.
> Destroy Pci Device Tree in function PciHotPlugRequestNotify for unplug= event to fix this issue.
>
> Cc: Feng Ding <feng1.ding@amd= .com>
> Cc: Jiangang He <jiangang.he= @amd.com>
> Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModul= ePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> index 3f8c6e6da7..2b7af60e0a 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> @@ -2103,6 +2103,8 @@ PciHotPlugRequestNotify (
>        }
>      }
>
> +    DestroyPciDeviceTree (Bridge);
> +
>      //
>      // End for
>      //

This looks convincing to me, but I don't now nearly enough about
PciBusDxe internals (resource management in particular) to confidently
approve this patch. I can give an

Acked-by: Laszlo Ersek <lersek@redh= at.com>

but the patch should not be merged until Ray provides an R-b.

Laszlo

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118981) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82448BAF80191B79BCE2A0688CEE2MN6PR11MB8244namp_--