From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E63F0D8106B for ; Wed, 19 Jul 2023 09:04:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hZVwm5PvSWhRYxcW44JKClYGe+ZFfMFamAW/anHMzzw=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ld-processed:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Tr ansport-CrossTenantHeadersStamped:X-OriginatorOrg:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1689757466; v=1; b=GTFLSCg8KGKP1B/b4A8n9wmXWn0ZZMc+GTJAqvJLYb5tVdiVYk85a+y46wOcv3jw58cUtRYf XukckORoC/YAvXK8pW0Sa8rL2lJ1GaYRpIEVH/AMdEWUwpxqlTyzTol+TpJ0n0wjpsp1AkRoDw7 /0w3Va5E0L79kGeNmOmlW0io= X-Received: by 127.0.0.2 with SMTP id Ga9AYY7687511xy2ym2SSvri; Wed, 19 Jul 2023 02:04:26 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.9617.1689757466089709703 for ; Wed, 19 Jul 2023 02:04:26 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="432595081" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="432595081" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2023 02:04:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="837609920" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="837609920" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 19 Jul 2023 02:04:19 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 19 Jul 2023 02:04:18 -0700 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 19 Jul 2023 02:04:18 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 19 Jul 2023 02:04:18 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 19 Jul 2023 02:04:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJXohF92xMKZy4kWrecnvWT7DJuytwonXIzy6h9FmUJ21bWFyhuHJCr1nyf29vet6VP7TAln4kHkVdbzMblBKS/8NT2OV9T5KjF6tkHTicpmOjPNjdYcdxLEUfw0xe30Wh1dT7/kQu9XFpd5dg7M/b0Tm3t9m47ME5KdExx+cNQgfuQmRKqmntuyCLsz7yuFRBFv8qzrB4AVEeNzCMUppttwrqAESOvWR9wdMkFdmo/OJe0zIDgahup6rCvh3wV/rMbUfFiDZyXyXJVu/uwkuVArMv9rKKXEbDASFOgS08c56SDr8GtJ9MiWzAcRfjKTA1qbUFK1wPxxT5AEallH4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iicMmamjdHW9+QvsT+h25k2zWNBBFB7deVL95romo3U=; b=Tfwd3c/iiDLqK4UiAlq3AuWcL8PpVp7nXF/i+8VEM/ZKcyYH+VU1CEMQyVV9RUQc5ZL2tesIoh6ll1Xwkdbsbh5QQJhna2e2rYbRGxXxaxXjb1mCOWumrhx6pvnfDosjJyMMrRwo7ul6jEMbt4DU+ju0Trx8Cy+yQ+1gnWWFl2YJM47uUzEbYJlArNbuh8c6IWOxdCfnd4EgXwEoHF/hS/l9DzrrkrJ+PVyb8Co/KTAtTWNup+ukCje6t2c5pQTM0AcUKK9N2OznptI0g/hR8B0Fzh2ODILfez+QR5VfWy4LmlSp0PRDij3xW7dC+ed1q2NCQh/5RuEPSKulogVwDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH3PR11MB8701.namprd11.prod.outlook.com (2603:10b6:610:1c8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33; Wed, 19 Jul 2023 09:04:16 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b%5]) with mapi id 15.20.6588.031; Wed, 19 Jul 2023 09:04:16 +0000 From: "Ni, Ray" To: "Xie, Yuanhao" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" Subject: Re: [edk2-devel] [PATCH 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Thread-Topic: [PATCH 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Thread-Index: AQHZuhT3lcGdZ+4q90WJPRuRz1ZsGq/Ay7DA Date: Wed, 19 Jul 2023 09:04:15 +0000 Message-ID: References: <20230719074435.4331-1-yuanhao.xie@intel.com> <20230719074435.4331-3-yuanhao.xie@intel.com> In-Reply-To: <20230719074435.4331-3-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH3PR11MB8701:EE_ x-ms-office365-filtering-correlation-id: f6de3bc2-e9ed-4dc2-08b2-08db883720e8 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: lFnMWp3aALh3OOuoSENxk0SruvqRxNlIWG9XSVHWW8415jD9iLCoMSVPXbzqrfQUvRa4ktJfzKBP4ILPUNP+M0quiJVHtndO3EsXF0Jw+bwftTL5KLoRg+N30t4ZyH+KX4CRlPQIwkSocVTnlcBfdjXxmZCtsIrYjZvRy0TeS2AB597Vk/aPp/xHnUZA6+ycYcb9eIgTTTeM/L5aTmSkfbtT2bkIt5hq0zDDOGa219XTANbDmrSsNxRrLYUNolDuUW1HpRx4kWIXrlmasNS1/c3dB83aXhCevYoXr4zDf5FQ6cjnusp97vXGLGUKNgTEGcDdwq0LQKHSxXZe4xCA0d0zH5BCa6yR3H4n8foSYPOuqUCfjxe53V3YCkKA0L/UuHGYSX30r96tXG7mgJ+VQYwE1L8Utti0cm90d/hOTousOhCQ4nmtx/tJ8LvFBahgMCzAhZv+d0m6bQdGMefoHsms/60949QGQwMosIrOWDq/lImlkRBUsdCsABsLrTkAwl6ZTpPxjt7SiYLDFBwr4KfuXywz8PV+/L7eb16GEnaex39Zrr+EF3fxG1ZpB9XyOrQ6JaNBhiibB4FUipIGIg1rUjjxt45ea3GPEQHsOgEd2v7mqdhCZgDSoVbz7/l5MCNLO6+hEs3T9q1DEx656Q== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dIPbyRktozupv6ph1A+hI1JpOlHx9DXWfSJBwGFWI7HjQhnR+P6MkdJpF2rl?= =?us-ascii?Q?0t91kpSKuzee03oA27FZ7/yBs34uWYxq7YhSQ88y1XJ6yDkqJ3qzL+0f27la?= =?us-ascii?Q?rDsNXXMIo8+W9zXBnPk/Y66yEYrZ269xhk50V5H0JfLgHzJmYiqV8726UhrA?= =?us-ascii?Q?qLfAxsXnOOT/Gg0e8fNz4NtVTjMFpZ0bwb029D51xZd8X08k+2T+AfE/l2eW?= =?us-ascii?Q?l32KYEPaqpb4IplKwHs/6VlzWuEM7R1CfOnFwLc7Xv1h0qYlUGGLRb3PWfWv?= =?us-ascii?Q?mmglSy8qqba4EnTnO5Y2Cy0TDmYMuli3zdb3hHED9ZrpM1HA6Lj4Q9hhhzaU?= =?us-ascii?Q?ThOfuh8akfkwviNlqhgJgzqCD8ex1StB7M/g232vT0NDmHPiUWSXDH9hUMhD?= =?us-ascii?Q?Vhuyi9UWon7TV2QurvoPxxQbmJU+VrRG3k8LhBGVPSMEV06evm/JU2AUek0E?= =?us-ascii?Q?gaxCX+DdfwmrvWBLzRfasEssjbLMonIpX1aa0hCuEgmzGgUmAy5vU2V1kbTM?= =?us-ascii?Q?a6fnBBDfJQWigHi8YerrGm/uQkIVG1dBc1q3Obo1yFo14PczL78+ftD8viIh?= =?us-ascii?Q?V3XTJEGw6aaKLbaUKNOSZ/QVxftJA6oObalbwRYNYX41Othke384/04/ylin?= =?us-ascii?Q?FKldEGh0LMs5J5zdEQPXCMUuGrSLxqVnm1/k3r5ZJs9A6aRMwmTgKmyUBUa6?= =?us-ascii?Q?lg0Fbry2Y8ZHv4aOjbNmG6CjHHZL9vfGIJlYuuhrf0dEzFmkC28xaRjOgCUI?= =?us-ascii?Q?aaIgWbt0+f2wc7Fyu9tffbEcrzCcd6lk/xz5GUA6JVU1Iw3gF0nocIBrPs/I?= =?us-ascii?Q?WPs7uO+nA+MyCpwlWsBS2l3GBHNeWN/Gqg0Wxw9rdr1DV3aRkJ9EUha1fjCG?= =?us-ascii?Q?3DjiOy/YgXb8G50eERhquOW5uE3Ik3MOZLyaMQ3KZf/yqL2X60lURm0vbIT1?= =?us-ascii?Q?2AcGNcjmZPkoYnCsZjtIR0aYs/EWlynluiZ30sbZa7RuxYDotvuJHrGiZPD5?= =?us-ascii?Q?R2z3YSQrf+Qgd+1uJ3F+q0/yAw1LE1JTGaf2JH77S4HmC7n9YUJqr5su6DCY?= =?us-ascii?Q?FXJIMLBMOysSglhaFmxwzeNlc2xDkiC94w3j+zWZAIofbJDd4bum514mk6y7?= =?us-ascii?Q?5/6j9DtIvp/hT7f1DLfvgMjEfJxLYESlSCLft4JgTnOZ/AMVWUrIqA7T3+Zq?= =?us-ascii?Q?Xx4ksQoiwUdNhxgskgmzJZGrYoa5YQG3BqDVhLKa1Typ8Kv4Drj/yJQKzfTR?= =?us-ascii?Q?CzzT9HSA16ucOVTn9ttbNp3Cn7aqy+irpeFdrRsJIcytLHSv4Qm4vt7qyj7V?= =?us-ascii?Q?JhrLD9L5g75G012dV+hMktOdtJFEr/DQYhQQkeizXGLEekL5OOfsu7D29Yz5?= =?us-ascii?Q?CCVf+zRsyCXXSPeGv6wJVuBYRiy3L9a+7NgfI0CE7g9f8jknZ81tpG8t/lVK?= =?us-ascii?Q?srbwELTidivS9Ajb1Zf6IzzgYN+VOGkjAldWZYXkZjgNMLk+tmqmaogLOJDL?= =?us-ascii?Q?dc725BSHxVWEOwzijBP+fE47aA4HuxYtk/1nrXQEZHRWJa1yjkmXxvqAKYa5?= =?us-ascii?Q?bz2DYO7OGDFY506Jvo8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6de3bc2-e9ed-4dc2-08b2-08db883720e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2023 09:04:15.9395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W/Bw5av8yNjyCQ/Bqgx2iPQLr5tC9dE0yUtNTlYYpPYUw5/5fSzuyu7Vpf0pomu4/Z5f0i9BqaTNZwKY3ML8FQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8701 X-OriginatorOrg: intel.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click X-Gm-Message-State: NnoYjv9u2r2OWeb0XoWKmHAmx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GTFLSCg8; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Ray Ni > -----Original Message----- > From: Xie, Yuanhao > Sent: Wednesday, July 19, 2023 3:45 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Rhodes, S= ean > ; Lu, James ; Guo, Gua > ; Xie, Yuanhao > Subject: [PATCH 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi >=20 > Add PcdFirstTimeWakeUpAPsBySipi to check if it is in the OVMF environment > and necessary to wake up APs by INIT-SIPI-SIPI. >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: Sean Rhodes > Cc: James Lu > Cc: Gua Guo > Signed-off-by: Yuanhao Xie > --- > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 + > UefiCpuPkg/UefiCpuPkg.dec | 11 +++++++++++ > 3 files changed, 13 insertions(+) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > index 7d45d3ad4d..55e46d4a1f 100644 > --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > @@ -81,6 +81,7 @@ > gUefiCpuPkgTokenSpaceGuid.PcdCpuApStatusCheckIntervalInMicroSeconds #= # > CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures #= # > CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase #= # > SOMETIMES_CONSUMES > + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi #= # > CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard #= # > CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase #= # CONSUMES > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr #= # > CONSUMES > diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > index 83e9028d0f..bc3d716aa9 100644 > --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > @@ -66,6 +66,7 @@ > gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate ## > SOMETIMES_CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase ## > SOMETIMES_CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures ## > CONSUMES > + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi ## > CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase ## CO= NSUMES > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr ## > CONSUMES >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec > index e7726a605c..cef0cbd43b 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -214,6 +214,17 @@ > # @Prompt Configure the SEV-ES work area base >=20 > gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaSize|0x0|UINT32|0x30002006 >=20 > + ## INIT is now triggered before BIOS by ucode/hardware. In the OVMF > + # environment, QEMU lacks a simulation for the INIT process. > + # To address this, PcdFirstTimeWakeUpAPsBySipi is to indicate > + # whether to broadcast INIT-SIPI-SIPI or SIPI. > + # > + # TRUE - Broadcast SIPI in the OVMF environment. > + # FALSE - Broadcast INIT-SIPI-SIPI. > + # > + # @Prompt Ovmf environement Check. > + > gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|TRUE|BOOLEAN|0 > x30002007 > + > [PcdsFixedAtBuild, PcdsPatchableInModule] > ## This value is the CPU Local APIC base address, which aligns the add= ress on a > 4-KByte boundary. > # @Prompt Configure base address of CPU Local APIC > -- > 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107046): https://edk2.groups.io/g/devel/message/107046 Mute This Topic: https://groups.io/mt/100231361/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-