Re: [PATCH v8 8/9] UefiCpuPkg: Uses SmmSmramSaveStateLib library

["Ni, Ray" <ray.ni@intel.com>]

>    Status = SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register,
> Width, Buffer);
>    if (Status == EFI_UNSUPPORTED) {
> -    Status = ReadSaveStateRegister (CpuIndex, Register, Width, Buffer);
> +    Status = SmramSaveStateReadRegister (CpuIndex, Register, Width,
> Buffer);
>    }
> 

I would expect that above code unconditionally calls SmramSaveStateReadRegister()
instead of having the Smram Save state access logic in either SmmCpuFeaturesLib or in SmramSaveStateLib.

In open source project, you could directly call SmramSaveStateReadRegister() because SmmCpuFeaturesReadSaveStateRegister()
in edk2 repo returns EFI_UNSUPPORTED.

I agree that close-source project which does something in SmmCpuFeaturesReadSaveStateRegister() should update the implementation to
move the logic from SmmCpuFeaturesReadSaveStateRegister() to the new close-source MmSaveStateLib instance.

We should explicitly mention the impact to these projects in commit messages.

Thanks,
Ray