public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "kraxel@redhat.com" <kraxel@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>
Cc: "Kumar, Rahul R" <rahul.r.kumar@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging
Date: Wed, 18 Jan 2023 15:27:14 +0000	[thread overview]
Message-ID: <MN6PR11MB82448E92D718F33D9F0D79F38CC79@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230118101038.75fuv5lzt7rxxen7@sirius.home.kraxel.org>

> 
> > And for the CpuPageTableLib, I think the API don't provide the
> > interface to split 2MB-page page table into 4KB-page, which is the
> > function wants to do.
> 
> I think that is handled by the library automatically.  You can request
> address ranges being mapped with specific attributes (such as NX set),
> and the library will transparently split pages for you if needed.
> 

Replacing today's duplicated page table manipulation logic with PageTableLib
is in the todo list (as I said earlier creating a page table library was in the todo
list).
The bug is critical and needs to be fixed asap.
Using lib will be done in future.
That will be great if the someone from the community can help on that part.

Thanks,
Ray

      reply	other threads:[~2023-01-18 15:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04  5:41 [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging Zhiguang Liu
2023-01-12 12:11 ` [edk2-devel] " Zeng, Star
2023-01-17  8:44   ` Wu, Jiaxin
2023-01-17  9:01 ` Ni, Ray
2023-01-17  9:02 ` Ni, Ray
2023-01-17 12:13   ` Gerd Hoffmann
2023-01-17 12:48     ` [edk2-devel] " Ni, Ray
2023-01-18  1:13       ` Zhiguang Liu
2023-01-18  8:53         ` Gerd Hoffmann
2023-01-18  9:12           ` Zhiguang Liu
2023-01-18 10:10             ` Gerd Hoffmann
2023-01-18 15:27               ` Ni, Ray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN6PR11MB82448E92D718F33D9F0D79F38CC79@MN6PR11MB8244.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox