From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.18300.1674055656899938018 for ; Wed, 18 Jan 2023 07:27:37 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Ba9zKtRj; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674055656; x=1705591656; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3As/TwJhNvpLtRh2E2pd4lusU3C2/k388xxbq8UOt6E=; b=Ba9zKtRjlpM2mWroRZCsMRhixJVIz4GFbnVWJG2Bae/GlDwEDmPIAfwN MiKleEgQzXI23KWFeNR/vfjMAg4lABKbVQq3x+Z2H9fNo/rMH1GsZ8RAm XaUT008sTzKz6sxF8GdAKwSBeS9v/ysxe4kzbvLIhBycJX+DEY3lnya2t /S46jw37owHXp0nepaKoM+YF+G9/gRuJKi9BHezdHa3gVg3HyJHSzn0bV gPU+VKNXnPNYeZIh1oTsbIWro2Y+GgcFA6ocR6FE6myakuaJacTePC+l7 MhJabC6s1Z6Q0qgPbKe1I2EI4AFsdkXvoGlQtpM4MW9IB71iE6VbEQ8he g==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="325060091" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="325060091" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 07:27:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="692035275" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="692035275" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 18 Jan 2023 07:27:17 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 07:27:17 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 07:27:16 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 07:27:16 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 18 Jan 2023 07:27:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ep93z9CYPCWdspWeO+8d3d/uXBi9bW2Nw+z4zkTfQvXGlBtkmS20KF/I3SpWm+LcJ22K7r/zBiO0i/K7XZRuvSP7lVpEiJW8YM2QXYa9d/1buqaGCAbLKV3wz+PJV+61oc0aGoaIRtZEJa7TlWnjhfEfQ+5HxrlIs/DIp5PEWCaGd/TD44fv9Z3t1W1VNmW1Ta9RdNDjhxY46Nw26tArUcqXp34LuFFCR0rh1sqP4h4Fp+7hpVd1T9taTXlxocxutPxSbd6NQ9ZaXCLxNlJnHxb2ndWxDAW39sgt++dj8qr8Y5LpwHujJLfAK1WWZiGlRJlGuf1twEFCr98f6FFxcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xpNiWXSnrpImm2wWLMMFA+2Ri7UPTKW2FGTk+kWwyJ4=; b=fiughBxCWfxGlumiEK2JfsC2iZpS9xMmn8JOyVFerZVoyj9Ui8qZcG2W4FbrQ/pIWEmkBQCDtrQwhWOulEMSmmqCUA3OlGbexjRqLWhQt7qRqwMqf5fDes80KyZVXO1Xc06zti8O1h98GUq9pcFl+hXJnx+TBXfcklY1Qvdg/utZXnyHw0YvUF7aU1LVU7nv9nr66ujXR3Xr1ye3BQRnqLBNI3c6LY6ho5ri1OPWd8n5Vcp7+zdLIPad/buKXFthpWzmTyhto2LiOX2GfVBk+KCHs7AaMwsLlnbdmkkdH6sS7qHqf28L/WW3J76T8zVlvsEWvR/LcvSOeGSYKr3pAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CY8PR11MB7058.namprd11.prod.outlook.com (2603:10b6:930:52::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.24; Wed, 18 Jan 2023 15:27:14 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%3]) with mapi id 15.20.5986.023; Wed, 18 Jan 2023 15:27:14 +0000 From: "Ni, Ray" To: "kraxel@redhat.com" , "devel@edk2.groups.io" , "Liu, Zhiguang" CC: "Kumar, Rahul R" , "Dong, Eric" , "Zeng, Star" , "Wu, Jiaxin" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging Thread-Index: AQHZH/9P2T/UYdbjFEWXX0eG9sRu/q6iZKyAgAA1sICAAAkngIAA0LSAgACAjgCAAAUegIAAEFcAgABXloA= Date: Wed, 18 Jan 2023 15:27:14 +0000 Message-ID: References: <20230104054118.280-1-zhiguang.liu@intel.com> <20230117121359.52rxmec7dv6gfksa@sirius.home.kraxel.org> <20230118085350.bv7s7spmmhkr4ozj@sirius.home.kraxel.org> <20230118101038.75fuv5lzt7rxxen7@sirius.home.kraxel.org> In-Reply-To: <20230118101038.75fuv5lzt7rxxen7@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CY8PR11MB7058:EE_ x-ms-office365-filtering-correlation-id: e9893d39-a1b9-40d2-0970-08daf96879f5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vzrf7ueSnK05vuuaLSirGJie6CYX8yfN222Z0Y0c5mZ8Z0A8s7L18JwclrcmQia9u6nq3CC6gKmYip+seUzS0Olj0mTdJt14x5xPM0wM8sjZKxeJTq+8q+b3+pKDskGKo8QjDoYkMt4YS+2FenOG9cdtZgVdgC6uO57jjxeBA954KELvpag/nKq9A+LEncPiaJ6xbwz5mXiQnTwPymBRmOyx2jRZDNiyxQN7kdSgyXIwEZUW5oAvtVhmglKnX3QFrdbMMJ6OtD5dhqnjfxBg7EudF2bo3dIlUTBl37gpDc+Si0sN/Dc52/u4jWOvkHw/6vls9K5rEe1d6wdxxhIRsQErYfKigfcVqXF0BKVliTWdGzck8xCwlrHLANvqWQ/74vLMUVhxllIUAVeaWpmPfMXcQQ7xKWuv+KvIu9jCEArkqW1ntxg0d5zU+0E1dYGGnI1DbeGn3RU8IZHKmVKbppg+DEpyodLVh7QfsNC8XIx5usDtPclJoGd5rvs+iNvYk7AuRToxKl6KHr/NDd2cwZWbkcnBW3RMMQLwbpYgH5pmj+2j1kIpiHPCwJD/+yGeE1zPkvLs9mghKZOhOuSHe0DOfePtlntvzk7z5oltIDv5cXGsAu1AyK4sbeGChTOQ2I5SrinkaPaPgmtkva38iR5djKMmIXeud3pX2ObBxJpa8IB9aqqwQNFHE/FyeQNt17Y3sKbXFwNZlJ6Y2QKa7Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(376002)(396003)(346002)(136003)(451199015)(52536014)(8936002)(66476007)(86362001)(26005)(186003)(9686003)(66946007)(76116006)(66446008)(8676002)(4326008)(64756008)(66556008)(5660300002)(4744005)(41300700001)(54906003)(6636002)(316002)(110136005)(33656002)(478600001)(7696005)(71200400001)(2906002)(55016003)(107886003)(6506007)(83380400001)(38070700005)(82960400001)(38100700002)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8hIXj0+hW8w9NbtAdY00DaeYPnVMOtmtmAeBwEXIJ0lGH/L08Osolfrx9aJh?= =?us-ascii?Q?zt8GGVT9UxDE+lfqZO64Ud2RPfJ7Lc6SojmaXdnj3fceF+mFricm8Fpg5prC?= =?us-ascii?Q?Cpnpfs9mqcnCY9mKF1xP+V0l2YpWm5AnTqway7i4TZXAWLpkm26c1hHsePXx?= =?us-ascii?Q?wKHAA6TrH9qMxmBsVP7jgF1PJGO3q5ASlrcWGEopQkQyAA4fYhhsVz14h4rg?= =?us-ascii?Q?qigA5Y2p1YudZ5CUVAprLR0ZkchB0Zb5xpXv64hlIGIB3isRpfOq58k6xdNM?= =?us-ascii?Q?Mi2Yg8azpz/vUjwHuT4tFXwegdfHfbLa4y46XJuZGKySmqIJvJv2HH6+NFbt?= =?us-ascii?Q?wvuZQDcXcCRIhg6njgTs3bSrXBLy+0+2Y6gLv3wyIl5iPnDqYlGkgjcqFZPl?= =?us-ascii?Q?e7+k1Yjk16MdpueSu5FRbziiJGX4HiMKLGUN0U8zWKcXetpbFaQZdLgGAMnD?= =?us-ascii?Q?AnW/2OQyCR3nHPsk1v++Cci6L8ijocy5lidS5HljLspoeOLSsf4r4HHvs33t?= =?us-ascii?Q?Iup2fWiVgP3duXD06LXXPzccfhWarHK18Qp/PpGS5zRVcFwhcDnkBiJZoQ9O?= =?us-ascii?Q?FgDsT/+zOWbOjMU6w3IDIcElvLFTsMnBAsJDt1I5pyfESFnZpM06BjuJ0GuE?= =?us-ascii?Q?uIBqsywh2cLWfvg2NUr71mIRZT4xG4ElgQi2aB0+ncshFYPTpaQMKXYZAp03?= =?us-ascii?Q?8zuvRNEDBxxuYz/jpYuZUXmVA6AH6PU5f94ymBspIwj1cf+8y23S6KEAeWvn?= =?us-ascii?Q?e2QcyywVYkonL9zU+YYzEn+QMGeZw0WNK2QVig7L3bgGdFZgwKT/Sqbk/QsR?= =?us-ascii?Q?Dba6bd1B3bAC133bW7FmrnzpjIm04Hw6qqZajCEXZIBWkYMd+ttXg5oNVkAc?= =?us-ascii?Q?sggkW+YtsCNFKXYoSGB/N3gu90+tY3SDZwWOEjVohIjACfhHft9MYaiu3zSV?= =?us-ascii?Q?TWgmiaA2LaBGTfDjX0BNdQm5jcloOcZG2BGUKBTTYV8j4ovLVAUfVuHwuGIW?= =?us-ascii?Q?F34j+qV1lfgBah9DSz7LB1Z3+dMBe4cVrpoUF4ZwZztP7khLAIiU5GcY95Zz?= =?us-ascii?Q?mNCZiuaX8n6cxxTwnGvbgWlD6roJn+d3Ibzwn4leMASMv8ZSpaD8t6mVIoOP?= =?us-ascii?Q?Xw4EfjAUiYVdXngREB130ZaCOSx6yo8lON3+5T63NDiJ10HMFvvDJnPuHcw7?= =?us-ascii?Q?gFL/Dl2lsl2i2jcJV63oaKwLYvZ7WF0UZL84HszuOVASmfP8RAZrU5jKDsLc?= =?us-ascii?Q?uP82Mb0uIshXwwZJ6nFY1oreRwxpXl7FVpY6B8Rp5OjRhhKnSBTBSv7EFtxv?= =?us-ascii?Q?y+XbJbXfoe6YB6BU2tIJa0RMQaJltS27DrHFazJMU/SrLUhhCIxTTkxvkWEi?= =?us-ascii?Q?SgkMI4SJur9ie7bQiPkMqNMQ02p/18uEsde0n8EP5FKFuhYDyZtdgEckvaZe?= =?us-ascii?Q?jj6fGA8bRO6oZyYE3YUiXXQW1X0AO1oGG74gJ0fAVSh7CwsmLJwPeKMrj2yG?= =?us-ascii?Q?MV5c9RNYV0n/TavH00e9LoElXCWZ4qo62yKtsUzj8l1kS82Wjl7q8OI34N9N?= =?us-ascii?Q?DhYbYAyPwOs4w3y/Zo8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9893d39-a1b9-40d2-0970-08daf96879f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 15:27:14.4207 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g1IbSqha893uw924uRB5b3yOPSv0i2J2CZ2xLesS4hSFUGKQ/T51QfFFZ1htByUT3WeJ21CeX2X0VibkInNN4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7058 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable >=20 > > And for the CpuPageTableLib, I think the API don't provide the > > interface to split 2MB-page page table into 4KB-page, which is the > > function wants to do. >=20 > I think that is handled by the library automatically. You can request > address ranges being mapped with specific attributes (such as NX set), > and the library will transparently split pages for you if needed. >=20 Replacing today's duplicated page table manipulation logic with PageTableLi= b is in the todo list (as I said earlier creating a page table library was in= the todo list). The bug is critical and needs to be fixed asap. Using lib will be done in future. That will be great if the someone from the community can help on that part. Thanks, Ray