From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.32890.1679450110723018155 for ; Tue, 21 Mar 2023 18:55:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=dGEXjMNU; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679450110; x=1710986110; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BYP/c9Ptx1fB/Ms2B9Ei201uX6WAlMPwQHBaVPLAgGw=; b=dGEXjMNU92Y/9UIadyQtFhNmkNCSN4yiyZQlnPOM9kcZQZfMvsc3qBbt UBqO1XRIHgEXcSNEoGMkjkf0oCNZwB30dL+ID0QRhrk7yk8dW3/6JkHzo pQVkLKUJdhT/OD4plYk6Ry7oYoYbWE1QjuW/hDtIlTPftIkyW8Gw+Jmit srDR/YyBQce3/X1O2EaIdpr1ug0lLT2jAqCygusznD8WTmKDfnl50qBRV +s9eGLzSIn4f6sLQ0PQR6zXqHL5HiTGIWjr93gLwA6VG6JIEY358LGZM2 eLJDzf0TonnQjKvrK/1gEtsghjBd5+leQg5x7ou7oNCMQmU0i3gjna1B+ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="339143805" X-IronPort-AV: E=Sophos;i="5.98,280,1673942400"; d="scan'208";a="339143805" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 18:55:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="712053145" X-IronPort-AV: E=Sophos;i="5.98,280,1673942400"; d="scan'208";a="712053145" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 21 Mar 2023 18:55:09 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 18:55:09 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 18:55:09 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 21 Mar 2023 18:55:09 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 21 Mar 2023 18:55:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dDDrU4sk9aVCw/V98yf1q0+Bu2uX2lBUG3r68LZaQVDfvlouGyKjvsCnqUB5AGj/4192VH6L4qnhLMgAf56j4Q6lX0mkjfl8zAItlZ/U3IuOiaDj3zyjJYXKLBxWZ39e01C0R1xmjtuHb/jmm0xM4d+rDDJSMYNzPi5ApuSdAdIzvxHd4eUZ0crIv8Gld3Vg+giXu/nKC63T2ENRXMiGKPj4AK3Hjdw/eaz+lLAmieWihQSm26NVe6PbdIQdyFkqN7c6CxkcPCd7vbaEV7rOWzIPrFpAs3n8n4NsCR2jfiNGhkWuUmNBP70ueJty90rA78iv/8HBRKcTnyggruoM8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OT0EY4ErJEI68leBJdnc2KzbZoqGIjH34PtEHbW5sk8=; b=ZRc1QZnhZsSkM6H9YuBnmangr9MbZvLnvYTEWc+ndIGTQIFVxzli+qGQ4WzsPo+HvPXsnMReHjKMUT8+s68eoVRAtRTHLOecIKW0FxwvQE/IWdzhT/90ZNTRq/OD29re0Ba1f+ewCUHeqaGVRDq2w9NO4z8UxqtkTOOVuNK37vsqLk1/iF9b02RmOtfhj83qvhGnSgdUq9VNXX892wT93WgxvrNP3Qy4/b/TNwuDL4OC6E1yTyrgTCN0JkFeK1tsOyMMijnaGGthy4JgA1clfHGq3vySKlerUas4wcD3I7l6qeIQHAkz6J7fTCDwUVGsdazH7dSZpB10lpMkuIWfQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS7PR11MB7931.namprd11.prod.outlook.com (2603:10b6:8:e5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 01:55:07 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.037; Wed, 22 Mar 2023 01:55:07 +0000 From: "Ni, Ray" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Oliver Steffen , "Kumar, Rahul R" , Pawel Polawski , "Dong, Eric" Subject: Re: [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling Thread-Topic: [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling Thread-Index: AQHZU060zcZQSpnCQka6qL3RInlFi68GG84A Date: Wed, 22 Mar 2023 01:55:06 +0000 Message-ID: References: <20230310124849.831839-1-kraxel@redhat.com> <20230310124849.831839-3-kraxel@redhat.com> In-Reply-To: <20230310124849.831839-3-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS7PR11MB7931:EE_ x-ms-office365-filtering-correlation-id: b2fd9a9b-0d41-4223-c30e-08db2a7875d8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1vrv/UZOMh0b9aX6zC30aun30LpQ4cFP003+9ZXFAUiQO+cXfY9ezS8OTaWhwgSkqhXzN0YS5sb1EaUDLxmvngN8B1m4qrvqZj7vWMzhZE7jk+ngxHUqjgvfKaleJex7KHuLSo24pYYvPlzSO1B1S8x3FwyjRFwAgBi6Ei9AWS7OxfVaegMFpviajLQAz8cqnjNyiIcmfIJT5v/szckVVm8dRKiGtvGjaRG0YS5uMMrmDZaxQ4iiQ6CzXGTT6WTa4Zp7LILFywBNHd2acsEVKLw9YJma9svZnrD5QYSkNktolWuXqAhCV6NGGJkXQa+5p7Cpkg0QLlp/Z4GuYfFZ//dDRKszrvqJTVW6It3TRaw3fflAlQ2QNUS4o4ZvAzlz3v+qXhZQWWnqJgAdtXDpQ4+Y+w1jNuP9YHDNb4/A9glFRoyZeqE2Mpix/jO3Zp2KPG2p9Cd1uK+PPWcpTXYvW0r54E0hajAG+pFrI7bDMu5DbNddPC5NmTISn2eh0iTv1smbY5SsioGnLgXaZYhKlmxrimQKnULsv29qDPF5AJ14FjhZbf3onTqrNsPGl0FW5IzX5spHcJG809kcbmBavJLO+DRtfeaSquGWYRAYegWzaiKI02d9eqUJNfaRiKbQufkbB/g2X04lBw7afNUK3yIuVPXNfCsJsLefp3IiTt+1lNEDZwPVU0JS2I+ioFLTKvcaKPX2ROg7NogTm+EFJQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(396003)(346002)(366004)(39860400002)(376002)(136003)(451199018)(186003)(7696005)(71200400001)(4326008)(53546011)(478600001)(83380400001)(107886003)(64756008)(316002)(66556008)(76116006)(66476007)(66446008)(66946007)(54906003)(6506007)(26005)(110136005)(9686003)(8676002)(41300700001)(52536014)(5660300002)(82960400001)(122000001)(2906002)(38100700002)(55016003)(86362001)(38070700005)(33656002)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TZwzF9noPTMPqEp4D5JDe8G1zktysmci5nXlkteSF2+RfqgXryk/lvL8hP5l?= =?us-ascii?Q?sW/dB9kD65Oo9YNo7A2+svZHbNVv+/d650j7pNsVczKedOxXA3FfP+Oquc20?= =?us-ascii?Q?9he0c1ad/IKxt0a9w1zbxrZWLrqihSNWI9aBsO6ssYF0t2W2/Eq68HtIuOLH?= =?us-ascii?Q?Ol3M0i9xqmeva4LtRYKSCV886B4dMc4rIzEPDFW2qtQr2+H9mjmG8amdJqHv?= =?us-ascii?Q?PXtPOQNPqOOX7BNDUV9XDOBOGW4ghrQ3AqvepeVOWAommMB4dKBOSEZ2H1vF?= =?us-ascii?Q?MkAmYEzXpiAyJBhyV9/vvO5X4fAQRyQwXwoydu4qf++C5jiRy9xym3Ec8XC+?= =?us-ascii?Q?m35Rz5fWC590WJpvBT8kPhM5AZosWHvI4GxmFh1aLN4qG6Nt9POkoJ7L0idU?= =?us-ascii?Q?impPq7nOGuEdb04y7BLSHJ/cMeYSmk3J96coChTVnVPVn+Akfky4ak18ftan?= =?us-ascii?Q?At3HIXwhxR49TJ0t6osXgyLmia9QByuMEBJb55xdlfb1gT6/f3NnqV4QVEiF?= =?us-ascii?Q?JZgwjck1fFJwp+QeECqQPb09breJhWFW68XebGMw1PgxNSEKJFTJH197BJHX?= =?us-ascii?Q?XiduVeFvTCEqnUAo6FKZvS+lBWRBUF6paZaS8OXeWLcmB+zbTC0fxNJ2HvAt?= =?us-ascii?Q?XKXM+ByLFJqtowSGQP30P9X1xk+NRLGqowHnO8lq3NREz/www9ZyQQ8WCtxg?= =?us-ascii?Q?RSMrkGNCWiXZa9MaMyYRLkbPY4TJSd+vsOjlr7dvvPTaJ3gdCfz7rpxKjEGr?= =?us-ascii?Q?HujyAUVEW+4d46PdBRqV8AeypUIZV/OXTmb+7L30VPpNThdWaJZfPnNSnCFi?= =?us-ascii?Q?WV66I99Xsy1cAsP8NnT3K8jQgb9b0bdJAYeRCsCJO1ffIp/v4Zl3lnR5XNdI?= =?us-ascii?Q?+yXxeC14P0Ugp0arzHK+dVZYn5pB82+jERrqKKgrDOtQ3AiPlHFars13BuBU?= =?us-ascii?Q?Y5rNIjj9qiLspfonmoronllsAtGXxItCIC4DtO90BB6xO/oYEx4mbNRPrUkV?= =?us-ascii?Q?0GBn49ztfEmepBBRaKy5iLqko+ESpEMWugbbfFqHYB9w3ziN+GBoV3KlfgTG?= =?us-ascii?Q?cjnDwQggJ3GG4pHlUaTtpiLKO1SCD/RUZrzCLEsJFufW9jMZ/ccDz0vPeYzQ?= =?us-ascii?Q?ysPNbfjJUgO90AsOT96YPyfh/EgaaFE9TiesSjci4yjkF5+0jiZc89dR3hKJ?= =?us-ascii?Q?fwbvzdybiby16ahEDVbtYYVtQ/EpxStx1Xc2A2FKhKYjrbyHdIq+oMkWF/d6?= =?us-ascii?Q?nJEsJBryE7/H7PrNfRuU6gkeRlwjgSDcbehhr1OidS49ZjBgZHAKnLecgEU7?= =?us-ascii?Q?sOuMibMWSywXA0nLiWn2IhRcxuvWBi4sjX7WwQ0zYbnJPfRLdtbSM5og2aeb?= =?us-ascii?Q?veF5eKeRuEZgn8X4D5O/7+Aq1ntsIi0FG5FAw3G6zzYkPS5/OqxgbH2yyxgG?= =?us-ascii?Q?GFVA47SIP4aKBZ13JcUyxl6j1FeshRpL1Pzh08kAPHbnPpTEt7rBS8NabYhC?= =?us-ascii?Q?NktLlgyEgHsuDzlYt2E0e01CUfs6sE05tiMDpS7/sAXfmvDcqKLTY8UVY6e1?= =?us-ascii?Q?LFRgcwu/aH6V7vSR+ug=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2fd9a9b-0d41-4223-c30e-08db2a7875d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2023 01:55:06.4170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LBvP7z9MeNpC+2gdrWqgdf9Layt1v38ixkn6WQdxdm0zJGf8KXQJQap8+Io571J/kaQIApODvaQuIkbZY+3CsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7931 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Just found "if (!Buffer)" doesn't follow EDK2 coding style. I changed to "if (Buffer =3D=3D NULL) {" in final merge PR. > -----Original Message----- > From: Gerd Hoffmann > Sent: Friday, March 10, 2023 8:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Oliver Steffen ; > Gerd Hoffmann ; Kumar, Rahul R > ; Pawel Polawski ; Dong, > Eric > Subject: [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling >=20 > ASSERT() is not proper handling of allocation failures, it gets compiled > out on RELEASE builds. Print a message and enter dead loop instead. >=20 > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index 55a9f79da8eb..2e41df1f1074 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -879,6 +879,12 @@ PiCpuSmmEntry ( > // > BufferPages =3D EFI_SIZE_TO_PAGES (SIZE_32KB + TileSize * > (mMaxNumberOfCpus - 1)); > Buffer =3D AllocateAlignedCodePages (BufferPages, SIZE_4KB); > + if (!Buffer) { > + DEBUG ((DEBUG_ERROR, "Failed to allocate %d pages.\n", BufferPages= )); > + CpuDeadLoop (); > + return EFI_OUT_OF_RESOURCES; > + } > + > ASSERT (Buffer !=3D NULL); > DEBUG ((DEBUG_INFO, "New Allcoated SMRAM SaveState Buffer (0x%08x, > 0x%08x)\n", Buffer, EFI_PAGES_TO_SIZE (BufferPages))); > } > -- > 2.39.2