Re: [edk2-devel] [PATCH 11/16] UefiCpuPkg: Create APIC ID list PCD

["Ni, Ray" <ray.ni@intel.com>]

Can the APIC ID list be defined by a GUIDed HOB?
I prefer that we do not use dynamic PCDs to pass the information from other components to MP code.

Thanks,
Ray
> -----Original Message-----
> From: Tom Lendacky <thomas.lendacky@amd.com>
> Sent: Saturday, January 27, 2024 6:13 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Aktas, Erdem
> <erdemaktas@google.com>; Gerd Hoffmann <kraxel@redhat.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Laszlo Ersek <lersek@redhat.com>; Liming
> Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Xu, Min M <min.m.xu@intel.com>; Liu,
> Zhiguang <zhiguang.liu@intel.com>; Kumar, Rahul R
> <rahul.r.kumar@intel.com>; Ni, Ray <ray.ni@intel.com>; Michael Roth
> <michael.roth@amd.com>
> Subject: [PATCH 11/16] UefiCpuPkg: Create APIC ID list PCD
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
> 
> Create a PCD that can be used to set and get the APIC ID information that
> is required for starting APs when an SVSM is present.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.dec | 7 ++++++-
>  UefiCpuPkg/UefiCpuPkg.uni | 3 +++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
> index 571b59b36f0a..5ffab58189d9 100644
> --- a/UefiCpuPkg/UefiCpuPkg.dec
> +++ b/UefiCpuPkg/UefiCpuPkg.dec
> @@ -2,7 +2,7 @@
>  # This Package provides UEFI compatible CPU modules and libraries.
>  #
>  # Copyright (c) 2007 - 2023, Intel Corporation. All rights reserved.<BR>
> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> +# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights
> reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -477,5 +477,10 @@ [PcdsDynamic, PcdsDynamicEx]
>    # @Prompt GHCB Hypervisor Features
> 
> gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures|0x0|UINT64|0x60
> 000018
> 
> +  ## This dynamic PCD contains the address of the APIC ID list obtained
> through the GHCB GET APIC IDS
> +  #  VMGEXIT defined in the version 3 of GHCB spec.
> +  # @Prompt SEV-ES CPU APIC ID List
> +
> gUefiCpuPkgTokenSpaceGuid.PcdSevSnpApicIds|0x0|UINT64|0x6000001A
> +
>  [UserExtensions.TianoCore."ExtraFiles"]
>    UefiCpuPkgExtra.uni
> diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni
> index d17bcfd10c7a..329255a0efd4 100644
> --- a/UefiCpuPkg/UefiCpuPkg.uni
> +++ b/UefiCpuPkg/UefiCpuPkg.uni
> @@ -301,3 +301,6 @@
>  #string STR_gUefiCpuPkgTokenSpaceGuid_PcdSevEsWorkAreaSize_PROMPT
> #language en-US "Specify the size of the SEV-ES work area"
> 
>  #string STR_gUefiCpuPkgTokenSpaceGuid_PcdSevEsWorkAreaSize_HELP
> #language en-US "Specifies the size of the work area used by an SEV-ES
> guest."
> +
> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdSevSnpApicIds_PROMPT
> #language en-US "Specifies the address of the APIC ID list."
> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdSevSnpApicIds_HELP
> #language en-US "Set to the address of the APIC ID list retrieved from the
> hypervisor, zero if unavailable."
> --
> 2.42.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115021): https://edk2.groups.io/g/devel/message/115021
Mute This Topic: https://groups.io/mt/103986462/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-