From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.97.1680836929427350020 for ; Thu, 06 Apr 2023 20:08:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CDKi1+YJ; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680836929; x=1712372929; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Sh2DoNaVSK/olqugOHW5V05oavc+FwCtVTLlm3Wh1Tk=; b=CDKi1+YJAe4ys//cuxNtCKuFsht9RN9XXfPPTzCICTFBLgJXzK6Tx0DG 7uDoEIRX07MqXSBumFaSjfQMxcuXnvA63MQD9tt2vyWBvnWMv2qyTDWi2 SeUH0V2DEtBxcdhywO/H3BZH9mZc8cHBsroL58HI0do40RW1UCWn6Zfdg VuzLd8WQr9fR2aClHEmW+RvRckOBG3aiBVl38NZjZS4DMLSEcxCao0uLD cviwRn8ecvpFNTwwP3yDQDSxrZj4YE1De55SstO29YdCGD0kIAf74nA2l wyN3hjyZm5FH0JWOrQBdltwso3r8/+AsVebBArtg6WMDblqZaTMJBbHuS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10672"; a="408042025" X-IronPort-AV: E=Sophos;i="5.98,324,1673942400"; d="scan'208";a="408042025" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2023 20:08:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10672"; a="687391302" X-IronPort-AV: E=Sophos;i="5.98,324,1673942400"; d="scan'208";a="687391302" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 06 Apr 2023 20:08:48 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 6 Apr 2023 20:08:47 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 6 Apr 2023 20:08:47 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 6 Apr 2023 20:08:47 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 6 Apr 2023 20:08:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZNtMA/LYMRHQHA0qyudy9p7U0JAJN3RoQiWoO52Zb4lWdMlIRrDykINyEK6khWwC34bhXj+cpj1ZvCQUZDpOEm3+z2v2hu5SXDs285dc6c2yUmgLZjAVrUA/+rNP5QRrxVLWvoIKPq0Qu/toHixN24gsmvWQA9SDjpE6DTFrYW3t8uPsp8cyBkSWiB9E69Vx4/+fBW9Mam5czUvz/WVrMy9VRV4qwyRJ2GYsxIvWvkaqZuCd4YUB0xJSDOxQD+iHWYzTBO4AQA5fP4Xmt0sSssTpG2AHxPqqCZJ/cVDZxYgQrXXFh/tr+zVEOd6AuuC0nO+lRqYOLo/+0ubwBfTodQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KHq4vk2PiJj12tGLwyxsInd0fG8E9EsAjoDf8/dRLZ8=; b=m2s9xb5RtUtCaMCSyPXDFr38p2Opjna6ACQkdpPqx1RPhbBPioTnIfcsqYy0Ym/kQAzg3pO83g+JlSy1aFX9eMcUs1WZLe+BerfkZIiGfq9EC6UIY9OyuX9vutQkhiE8mHTwykgB86yoe3nbk3IuNVUyIIC0T76jmVLkDOP9JocfpU9V9ouBYMuqml9GQCNBYJiOiyVd/alkqGyz0IQgjEe8KlV739LFTEr1gWlBvO4I+fm0TKFKgKftdiTzZ3NvWSJhMUP4s9G87Te7GSUr3vUVAYhfcaDVK8VoX0UjpSBenIGiGqgbJeMnC4CoOed0GNUFKZKzRaSp/rZOMiZbDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by IA1PR11MB8245.namprd11.prod.outlook.com (2603:10b6:208:448::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Fri, 7 Apr 2023 03:08:41 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6254.030; Fri, 7 Apr 2023 03:08:41 +0000 From: "Ni, Ray" To: Rebecca Cran , "devel@edk2.groups.io" , "Gao, Liming" , "Kinney, Michael D" , "Jiang, Guomin" , "Xu, Wei6" , "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" , Andrew Fish , "Wu, Hao A" , Maciej Rabeda , Siyuan Fu , "Yao, Jiewen" , "Wang, Jian J" , "Lu, Xiaoyu1" , Ard Biesheuvel , Sami Mujawar , Supreeth Venkatesh , Michael Kubacki , "Desimone, Nathaniel L" , Sean Brogan CC: Leif Lindholm , Abner Chang , Nickle Wang , Igor Kulchytskyy , Daniel Schaefer , "Xu, Min M" , "Justen, Jordan L" , "Gerd Hoffmann" , Peter Grehan , "Aktas, Erdem" , James Bottomley , "Tom Lendacky" , Michael Roth , Sunil V L , "Warkentin, Andrei" Subject: Re: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant by using __func__ Thread-Topic: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant by using __func__ Thread-Index: AQHZaNaYIhxdcf02+U28qjtGpLje0a8fKsXg Date: Fri, 7 Apr 2023 03:08:41 +0000 Message-ID: References: <20230406222319.2281263-1-rebecca@bsdio.com> <20230406222319.2281263-17-rebecca@bsdio.com> In-Reply-To: <20230406222319.2281263-17-rebecca@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|IA1PR11MB8245:EE_ x-ms-office365-filtering-correlation-id: 8d6ccc15-1e02-41da-0bcf-08db3715640e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +B4t4bFmgUt3rCAnXNk0kAR0pLcuURlz10W+BXucI5/g+vM8Oj2DpqyO9nolxE4i9TsVLxd8QmS4dqEUPUfPSSZhA6/zKh2ExyzGja98qCQYdxQa0LcSDRtfdHH7VVj7q2p2vp7h++XgpN6zkF8Qm8Cj2v35pKccnCUtQw8FunIX4rrhS+dD6mBqeUE7/SKAsnYQg6iVy7UXl0TlQj5YwSxpGtcWWG/D89yEnKVE86hx1CleW9C7ci/2NOon29QhkYyxpFHa2GdAr4qxfgNYmkAPx1aQFYevRZP2coGynC1dQSjbNcBMFaedOmQBhYIXYZp1ZHmSsgQxS5YYpKM08FFVITsP8IVqsMM55gNn3VQu7A4eJm2uJZXsMu05RkSis+ozGDbqENhcnvuAZp0jKCkNg05GzeC7Xen7Zlbh+eKJh23+35iNls92YvjSW8h+pEkXLhbtBqZkqB8D1TOVWIbzUolJLZHU9dSUdv3/a3v9R6oMJo8o/7uR5M4RmLwynfbbChSDk0ZXzEHhc5uXqpI3oWeuml5TWPsqAA6ghNvyOuY6yRjK5s7xbpk9cPR4JiM8eUCcfp8C6BzAeABViR6Wyb6KvhHhFpj6eHbdKqBCGm5D2oH5mljMx6ggAsTOen+E6OUlOXTtlGb//XrOvA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(39860400002)(366004)(376002)(346002)(451199021)(122000001)(6506007)(82960400001)(316002)(15650500001)(921005)(33656002)(38100700002)(38070700005)(2906002)(71200400001)(478600001)(9686003)(26005)(8936002)(5660300002)(110136005)(86362001)(54906003)(52536014)(83380400001)(7416002)(55016003)(41300700001)(53546011)(186003)(76116006)(66946007)(66446008)(64756008)(66476007)(8676002)(7696005)(66556008)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+NsQbMLWZf6hvzEpuGF9uweA+1DMWOtpKcju2WXHI/T84cbGWMKkm3sN0OAa?= =?us-ascii?Q?RHnK/AHQCyWtlxy28ax6OJm+8QQtrzqsH907yvcdnn0SG/FUHwy/Td2ptXI5?= =?us-ascii?Q?XQsEP6262IrU02DYmov4FBwWOAOZOUm8N0TWoW/Dfzcufox1ZXqhxe2N2yTw?= =?us-ascii?Q?61BWq/eitLQiuans+86J5VDhp3+zLsoYipfbKYNGvIGU9FkFSO6Yp0Wm2uYA?= =?us-ascii?Q?bUDtgz7d0zBRozvMVbkmuJLdjDCSmYiuppNTkGzoJZSEFGaje9IWs/9b77rZ?= =?us-ascii?Q?c7c04CQhaF92ptjUWTLt2lbrgN9pgPU/4NB8h/AAFDrlwPpg79U1V2vzUcaQ?= =?us-ascii?Q?v4/7Ko8cDjqIU0POPc0JRdLvDyAxgrKIYW8wa9qToNuQBxU2yUF3Xacq5egk?= =?us-ascii?Q?0ruiPWv4dtJWxAfeFaW9pSB5wHunjCStil9pENa9n/F+U8m4+iTupZzNmF06?= =?us-ascii?Q?q9RenH99h9PSwqNU7eUC1QNB/K3hznwybQByFcH+l32bc9iCAF5JCCPhC7F8?= =?us-ascii?Q?rwTyY7mGPHWyHgHXDPWz+VxZVYuL6lU++JLdZ4ZLE/YLS5GrvSRd4/rTo2zR?= =?us-ascii?Q?7TypckDCE3jyAX8sTEK5IGK+ijXX+bQqogsyY8eO2zhFu7BAjNVUpH46XIe9?= =?us-ascii?Q?9oC2HIFqQGa0Su4xfFuPJvcNS7MfQ56Uqv+MYMhfnLjQbFaiJjtkv0cQTLFr?= =?us-ascii?Q?c49VylIMPbBYh2tARCWPhuCcVwhOyMSieQArfvF99XfzQ6AL2yOxP7q+Mllr?= =?us-ascii?Q?wXGLLzrwl4CrFSokflMxVFOSB2bWGmUxL2kefBEdvGDCRMH2BQNbMbKXds74?= =?us-ascii?Q?G5mcQjJKgMfIVH4u+tqdnPCw6KtihrcUzOtxjt5rT59iUwz3KIqfCLsf3qvK?= =?us-ascii?Q?syVzQraIeIrjrP6ZfLyOJfHJcwhYxhT5PL211xVY0wiIwI3KzMvYQVs6pi74?= =?us-ascii?Q?bKcRW4X16g/ygVxOkVbndlSusBNI5JzigroA0W4u5fCY1uv1CF4aMY4P3bsu?= =?us-ascii?Q?OzfPJSp/w6Z+rltkPfnIQ3s74WdApYHsL0/ozii3bo6tI2+X8vuDCbMvMh00?= =?us-ascii?Q?Kkvjz52/x+W3BFQs6aqXSXvKP30fSLa8JWPJC6VYQLs6cZgcp5w32vZZw+i2?= =?us-ascii?Q?wWlqDKwfWik3LE9QeiwazlAb9ZJu4Vfwpf8DkjjNsuxGfVv1ZHaH5CZGJtCn?= =?us-ascii?Q?ZkCalWicMmIOlBrF0DofGldlfGjflmWfH7owvngvfUgRNYY6giNPaa/wRVer?= =?us-ascii?Q?SIPw7UxjM6T+rbcKEcxwnhi2BT2Y4oiUXkyyqmC82OSEqzBK9b+DDk9kYVGi?= =?us-ascii?Q?Lim8JJSIyMlKFdJ2XImIE8evMt1jf/l2DfAkvv9fwZjqO3dHDUPcL12IgmKA?= =?us-ascii?Q?X0Uvlw7gpNwku+Z9kt7oWPNMwvPa6jjiX0OZZlx4ipiXjWwKjdTycesuxZXG?= =?us-ascii?Q?0gZg1gs/r8lPuqA+RJKYWhMgdLrV4iR8kganB7cF5hgU9OeUyIAouJX+NAFr?= =?us-ascii?Q?4nk7jIYOzpsWQ2A+qJtI1l67XkK+xiwHErSq1VDbOEOKAsz1oFqjaQWmSptP?= =?us-ascii?Q?yBLIjSmIUeu6IIN6BX4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d6ccc15-1e02-41da-0bcf-08db3715640e X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2023 03:08:41.5170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zADpXakNK0LxwHe3KUHSIqUi7hXvKeNAuUHugC0oSWXFikMlG1HKCwBq/PeM8/nd/Vx56wpBSl3QakqSgxs4/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8245 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Rebecca Cran > Sent: Friday, April 7, 2023 6:23 AM > To: devel@edk2.groups.io; Gao, Liming ; > Kinney, Michael D ; Jiang, Guomin > ; Xu, Wei6 ; Dong, Guo > ; Ni, Ray ; Rhodes, Sean > ; Lu, James ; Guo, Gua > ; Andrew Fish ; Wu, Hao A > ; Maciej Rabeda ; > Siyuan Fu ; Yao, Jiewen ; > Wang, Jian J ; Lu, Xiaoyu1 ; > Ard Biesheuvel ; Sami Mujawar > ; Supreeth Venkatesh > ; Michael Kubacki > ; Desimone, Nathaniel L > ; Sean Brogan > > Cc: Rebecca Cran ; Leif Lindholm > ; Abner Chang ; > Nickle Wang ; Igor Kulchytskyy ; > Daniel Schaefer ; Xu, Min M > ; Justen, Jordan L ; Gerd > Hoffmann ; Peter Grehan ; > Aktas, Erdem ; James Bottomley > ; Tom Lendacky ; > Michael Roth ; Sunil V L > ; Warkentin, Andrei > > Subject: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant > by using __func__ >=20 > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. >=20 > Since it's more standard, replace __FUNCTION__ with __func__ throughout > EmulatorPkg. >=20 > Visual Studio versions before VS 2015 don't support __func__ and so > will fail to compile. A workaround is to define __func__ as > __FUNCTION__ : >=20 > #define __func__ __FUNCTION__ >=20 > Signed-off-by: Rebecca Cran > --- >=20 > EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostI > nterfaceLib.c | 2 +- > EmulatorPkg/Win/Host/WinPacketFilter.c = | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > index 4361bd4170e3..4332caa71016 100644 > --- > a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > +++ > b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > @@ -538,7 +538,7 @@ RedfishPlatformHostInterfaceConstructor ( > EFI_STATUS Status; >=20 > Status =3D GetRedfishRecordFromVariable (&mRedfishOverIpProtocolData, > &mRedfishProtocolDataSize); > - DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n", > __FUNCTION__, Status)); > + DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n", > __func__, Status)); > if (!EFI_ERROR (Status)) { > DumpRedfishIpProtocolData (mRedfishOverIpProtocolData, > mRedfishProtocolDataSize); > } > diff --git a/EmulatorPkg/Win/Host/WinPacketFilter.c > b/EmulatorPkg/Win/Host/WinPacketFilter.c > index 21859897c85f..a71c7e8c131b 100644 > --- a/EmulatorPkg/Win/Host/WinPacketFilter.c > +++ b/EmulatorPkg/Win/Host/WinPacketFilter.c > @@ -966,7 +966,7 @@ WintNtInitializeNetUtilityData ( > goto ErrorReturn; > } >=20 > - DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n", > __FUNCTION__, InterfaceCount)); > + DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n", __func__, > InterfaceCount)); > // > // Active interface index is set to first interface if given instance = does > // not exist. > -- > 2.34.1