From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.162612.1673860767641426359 for ; Mon, 16 Jan 2023 01:19:27 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IB5SXqyi; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673860767; x=1705396767; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=kf82WX42CxH9JWQUb3i8ShaxSlCC1lOx7bR6BphCs0k=; b=IB5SXqyiYTmCYb0UukM/4ZaB573KbzuXtWh4vc9arSsHZH/scgeg9on5 I0V7Nd7a8WHciKifLihM0gfmPOqJSQr22/YURRlMeUr8D1IeAAZvD9THy 1+Hto5iyCUAEgCmvusbGDLqqle+MPfdzyj91Xdc3EmzmcJokwWbJpPyzm HzfN8S/SGWbHvFHGh2mJaiBSPVoGaJOPbMpKtMKpDzTgdOcUtlRHyRPfN Ykh53GuASeYlcYiOHnJy9T/B/ApUwUbePDF4p4CF8MDr7P1zKYvofZMsm agQH+E0cYcs3J742Ar0nxNPM+esF7Z4pji8e0emHGzrEVTH6cFe+qYPOG g==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="322116928" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="322116928" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 01:19:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="987736107" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="987736107" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 16 Jan 2023 01:19:26 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 01:19:26 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 01:19:26 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 01:19:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AzYs8LSOBezTP1gfrom+B43Bnj17ZTbQtljOq7Iv3QcUskRcHPzFg5ZVC+qAaPXX1w0H9rBWaTcV0Vd6W2T6vcDIEOanv8mCA/BagsPm335iiQg6gw680svIOFhrptpP2QFa97zk4jQgz4PoBeyBPmcstxujbmrOMZy7o6VBHZXvuP7z49kzSakBATqFaIsHiS0vnzTGlMOc6A7wCcYBlXrdSjZsvD6D4dHMThJW0TIFOCYV9nMesz3VYxmWi9KvCpMMd9/ykWspqe1QHcFSLSAjq4Bfw36gRZZTmcCR7FLqaVAPhNgyvsWTKRnDBjY4DRPn0RJurM508Nl0NtRJJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D4mGCuKfR0qRvkYCnBorGawzhAg9kMdVJ3E69yDQyqs=; b=BlhE5cU+xvTRSeD0F6NppvgOZumFaY8t+nHkq5nPMTIAWV5wJxaVd/X+zqAplprSkcc8dbBG+5UhNue6ZUVI2MKGCJ9a0M96VAAGHHGAr1t+hfmjLtzMZKlfnud3tfBm+M6RxEmornWltpSvyGVka8BvA7McBlBwVZi8n4JZPVQRdu/hXSEicr3zzdsRI02BbIsPKymLzmLQiZyjeUnzEdozQz+VtwW7Cok9ADX9GYjbdV+2qYSyY3PaPBIppNna6lcg36EiD1FOsPIdy54msxiznCrsXGv60hR0i1+cvalM5NNmELZZw/pWnYXeTnS7DI5oL1UA6TKa4rqC0R5USw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SA2PR11MB5081.namprd11.prod.outlook.com (2603:10b6:806:118::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Mon, 16 Jan 2023 09:19:22 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%3]) with mapi id 15.20.5986.023; Mon, 16 Jan 2023 09:19:22 +0000 From: "Ni, Ray" To: "Kuo, Donald" , "Wang, William2" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Kumar, Chandana C" Subject: Re: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Thread-Topic: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Thread-Index: AQHZJyiuce2HjXLtbEOvkhcLYY67xa6gviIAgAAIn1A= Date: Mon, 16 Jan 2023 09:19:22 +0000 Message-ID: References: <20230113082551.685-1-william2.wang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SA2PR11MB5081:EE_ x-ms-office365-filtering-correlation-id: 4fbee21c-2bc8-4e42-c422-08daf7a2c103 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hFVCoc22mTWN4vRSw+4GZmaSDrKPtGLf4ldh0mxDopkDyCiFTH5p3qVEKSGK7tNHB1m7TRfB/8Y4tw6EVEFFty4bPxfBx29Xs1g94+Gx6sbbay5BW5ca4ldxhELZZSv8RDX1Ie9frz7S053NwYvBt9zrVrh+ABT257oxAlW5c5ltB7eRnOqG/BgfocW16x71mevX73tLZFZgWKlCTgw6zOoIohI3fAgG0eEfnu2HFHsikGwb3QhBHVA8GaTCYTrjv6q1HQt7LI9TNyF8oEaL6KSPa92fUnJRfbcvpEbGn4SpeAdGN5S4kWzEvib86MsOiA0RFov2Uu7qt3ZnNiosG9ErKCeWAV17y2CUERoC8PFigVlg5ZPPV7SYN7vST5GXenqyKTPINZmZyHoCNNEGbNuNE8X2fCRyoK4MJoHmAMxawkgZIKEVp3HYCzy1aVybiUmWtl3wZd5vc6G38OxxhmueFcVr6MM5Iw0UcAqZwn+SQnZf7/TSCbqDCEiMSQplpk0Aki77zmEyN2j2K4fY0741YruYsNtcgCtYgoPpQFecOSOEbSfADXdbNyovOSyWshAK4XYtQvunNWs4VjjZp8iXHIyEEqeIR/hm956W4ZOchIiFwTlcRZlXiLqggRbtoRg/L2MeSaeDHh+EmXGWHtQyGJpmDXk+xCFOCp4pJlf1zmcVkvkO9aEy1WuVEWYm x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(346002)(39860400002)(136003)(451199015)(38100700002)(8676002)(86362001)(38070700005)(8936002)(66556008)(66446008)(52536014)(4326008)(66946007)(76116006)(66476007)(64756008)(4744005)(2906002)(55016003)(5660300002)(82960400001)(83380400001)(122000001)(33656002)(478600001)(71200400001)(7696005)(110136005)(54906003)(316002)(41300700001)(107886003)(9686003)(186003)(6506007)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wWYvcx2KChhRjgXtaSczqqyFSieKL8hoiceuwZWI4i0rqQpxCEKCqtPWirbx?= =?us-ascii?Q?BrPUG7lqmYRHMfgfnU9YLWuDTeM9dcellsIHdOkUfD/15Vtq+0K+aZ/MnPXf?= =?us-ascii?Q?+BbUS/K3N3NfMEMLJlCNRvgvb4iYn6TY20uSQDn7aUzfwB83KqYvOEiZ7KZM?= =?us-ascii?Q?kW8fIQhpaSPTvfjwV5rKNSGuO+IjY0/gXtHW2k5wMcCYtWSHtE+QomDDTHA0?= =?us-ascii?Q?VJLwlllk2HUvJh9zQEfn7Jgpy62OUoyHwBvTtopQramFy6qOf1gxEcxG9WqL?= =?us-ascii?Q?7n74bkGM8odwPw4N1fh+NlYfrus9INvBoo2kSCj8tuX0CuTpEtImfsjfRgiX?= =?us-ascii?Q?skDHDNhqfVoueB1/H0PDsP0jFcgjMHbEJmHKnlpwmqgVyZzGxvUFdf3X/Bx1?= =?us-ascii?Q?c+lykTJFwDCGZtC5WTdktyW5HnXqwrXczJ+dFlf/ARzVZAtI/OA/TItt0QP3?= =?us-ascii?Q?fTODOL4Z3flSPkvJTjfHUbHQiTGzJT4gsX8q3hrkCGRj3nl2UR538dB3ubG6?= =?us-ascii?Q?AwqUvkLy51LbqOFxAmeojYkGA5ESz12QGR6Ir02mTzVn56lHARc6BjZSVx2c?= =?us-ascii?Q?JWTVXTPPvOHYAPWh61FeztKpKNLcOrMDsvVzqCoL3e+LTi0OGSidHBa+aPiO?= =?us-ascii?Q?f39fKx2ZJhbkzmRhZd9IWbDYBZkmp9E3lNLCdB+MC34OhCKK6wtB1Mye9xff?= =?us-ascii?Q?RVl8Nq/yJdy3E6ZuoVOXsH53PsZDymR0DLFEdY1MvLGm6fct9HkkWgcDPcMC?= =?us-ascii?Q?lD0eaGpJkpGl4M7F/wGrlJ66oizV1zM+A+QIPinCJtI+V0TfXwkgLNN/3Csa?= =?us-ascii?Q?tln6Rh9S2USoASP/EBgT7z80fSWiYK4Ov1dbVCUiQIY+G3+P+BEEmH/7jbOR?= =?us-ascii?Q?t/RQCJ6N3Mc8ohW7imu6aIJT77ZfIn/CH9cxboNJs9PGYMMj4soO8NWdB2xr?= =?us-ascii?Q?k6XyPTW34OJ6krsEqe/YUoUeW9cmMJ7dDQSLzjwAtQr6a9XpR+R58AjWiUXw?= =?us-ascii?Q?p3Zkf6jPGa39HIs1V6gr5lh/i9IYjiUVUyVDVUSsefWxrtAc+vz0Inbt2OKS?= =?us-ascii?Q?r4jHtey70GUBSSZu9Tc0bxTzdukbJITa9qUNffUw5E7aRupQFsdoYDmHPILc?= =?us-ascii?Q?L/nTCjDjFMeW9qi5MpVsUJQ0x543BzrXwpGtLbqKI2YrYPjonSp4pEKJNATo?= =?us-ascii?Q?lnhRiWoXVyNo4j8rGO0778Nhamoq41aUT8VVownxkmb4pZsCtx6Ba0ynEUv1?= =?us-ascii?Q?JNzdV+l6jFiwFEe4LP4D/pcQ2fj0N0PPFJms6/287z+OIDAb0lzLa7C8Sy6X?= =?us-ascii?Q?tsLZga7Tiq9byIG9ZJlU3p4SDuyU9T/kNSBEnJiceSnBAF7t2kguHR2ry7RY?= =?us-ascii?Q?2sJ77SGjpQmJpb9FhHv6nCGLxJYwYmAoKl4ononYu+Na1WLcrWpo4O+whJVW?= =?us-ascii?Q?fUu+nlSkQnjNmhpsf/xot7gtX+IreUq1lwcgRomN/7vkhS9JvT2xCJ9xeyYs?= =?us-ascii?Q?91E77LpjzMPZA4dpwQ/rYGKyYYXSl3yLcGFdA+4dACPxJPp/bi0DMJfLHzyY?= =?us-ascii?Q?ABHogVmBq3Paj7+us3E=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fbee21c-2bc8-4e42-c422-08daf7a2c103 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 09:19:22.0733 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: biA42yO1dH/INmWCcFhT0ExCJgONwUX98ODyU0Y/kFPSNiaBCB2vTLDVzX7ReBlOt+Kgb9JuFJzLpkdiOMxuww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5081 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Donald, Old code might reference existing Reserved field in the structure definitio= n. So, to avoid old code assigning value to different bits if using same field= name but for different bits position, edk2 recommends to change the field name from ReservedX to ReservedY when t= he bits covered by ReservedX are changed. Y is the next unused index. So comments as below: >=20 > - UINT32 Reserved5 : 11; >=20 > + UINT32 Reserved4 : 2; We should rename Reserved5 to Reserved6. >=20 > + UINT32 IA32_THERM_INTERRUPT : 1; >=20 > + UINT32 Reserved5 : 7; Reserved7.