From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5028C740033 for ; Fri, 28 Jul 2023 06:26:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9U/lqm5vFZdnWef7nYB3W/3ahkrLuvXRzTuV+Id/1SY=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ld-processed:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-Cro ssTenantHeadersStamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690525591; v=1; b=SB3qdz9vNEqjT64n/4FC/j88PpqosiBbeRJ8vG+lPu1iN+JPrMJJxYSWU8TFxCqaJTOK8sr/ Qu/jJRuQ5+GRh9KMnqNEEPQmrhvmaUJu9XqooaxVIEwie56Euczei9PZ74kT1V/9efG1fBfjNEB l1aQtd/cAVhk8yLeCjg9pPx8= X-Received: by 127.0.0.2 with SMTP id sLuIYY7687511xD8qTU7rU1t; Thu, 27 Jul 2023 23:26:31 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.26932.1690525589032106781 for ; Thu, 27 Jul 2023 23:26:30 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="368535868" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="368535868" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 23:26:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="757016603" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="757016603" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 27 Jul 2023 23:26:27 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 27 Jul 2023 23:26:27 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 27 Jul 2023 23:26:26 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 27 Jul 2023 23:26:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NkiWXasiVRQ0DjmTx2lfuzOtuSj1V+6LPdpOwYaWlwYdlLhDxiq0SYQnwBU8tuzk8yt5sztLuhBJl7xMnUJgVPuAwoAG0UiChLi7QcuHjMvep2IgZ8jXtOraLQGn8/IBp9D4aFXrj5ZJy+802MWlylbIqFMzb1Nd7xYne/dJr44dTqbE23ReCbBMW1U0ypG0nYZ02fRm0vaej8lKCa0bDNuPxINuKWOeg1TIfLcNxIW58VzLztNfPYpzFzFA1nQk88WEMYkt1YLI5y+iYFQEezzC4Jnd/BJFVZB6FOp6nJMUL+glaLit8SDigIeeuGAZy9USLYTIyYwEiG6OBdkTqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dGoNBApK6RerSi01gZH0n5sc9hIPQrFEjWdMqg29qRw=; b=H9ONGpwis4v27oHn7I1GJaTO8YFQqfVkc1qz3mi697MpU/lttSX+sZZr3a4ytEGfLtNRxfVb0UUrgD99I0NihQH/wFn7ykW7eQBoHQXLBjw9/FBdUNyJr9Dko13tPNHJ1q4uFEi3vm86mzo9ILqbZPeR4+iyMrx45GYyYTLum8/OI7kj17y/kfQBikPw3h44Sw+ERnASJl9MFLXnts7kVXqS4+n6SCeOXmWbjH3CW2mguz8tKa3yWTz2vLwfgp0itmY6MFynTh313vnIILmVsNzWjdgyEbHj8qPHGSNGa/+EDou/ZyWqg8/CmlCyAWxaC1HtqI4DZgpZBdg8j6B2Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Fri, 28 Jul 2023 06:26:24 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b%5]) with mapi id 15.20.6631.026; Fri, 28 Jul 2023 06:26:24 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Topic: [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Index: AQHZwDD/XsZyAZt8fUaBm07XwCVoDK/Ot5Qw Date: Fri, 28 Jul 2023 06:26:24 +0000 Message-ID: References: <20230727022040.1910-1-dun.tan@intel.com> <20230727022040.1910-2-dun.tan@intel.com> In-Reply-To: <20230727022040.1910-2-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB8718:EE_ x-ms-office365-filtering-correlation-id: b45654bb-f04a-465a-b21c-08db8f339117 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: xpS09v/wlF6KppSZCgL2zArnUYkFHSI43sjo7xY7Smmg1phxT+CbQjl3wDXk5hdNA2/A9Au6Ni0pHTx611pJjJs8PTYfx3s4x0veTHzsepBYbWDNxcc8+F0SZ+j+M7sW8xqig68usnDyL/JY7BlDFsLFRXQ6ZjN9lqMPeJo13LZbrJA5tzgi9JliNeg5i1QVN606AsbS+9p9OxMm/i41RrsexT7nIUV8qniCqMR2wSuahCDyUCpmkXVcTs3yGWlP+ZROa9qWEpuzXNGVnjN6r/8+JMPi3TzQMqstnj0ErVTe+Tn5xuuiD3iQsyeFHLKL2UXlCI/JUaRtlNbZ5MMLgOV/sv34mbetw5SO+fOm4dmIRa4y+iGkpYFq9JsykInVHVL6ZJ+F02+LKROtsUEElhN0z1lOkX7jJvm8GFFlbfOVS3yr+N5INDYefdaDrAWESZ2yaVYaPbcqG7edI3G3B2KBTx28zA+NQqUfgU8t5yIujRrgM/yK8Fbfi571GC86hwxzJOP7PP0ww8IZyWlKTtKnGjVKE84OhdUd4/NGDOLTqV0LPXdJkWKPG5es1D2PO+dyh69we7m1rIf7Wj7jhREb+6HuFT3FGncctJSXmWUJmnyC2ScqqEKtQ9NeXn0e x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a1d1La0q7eWdhvpT2ZxemrTsSxD/mNyZT9DLZcadoCNNwdn7tLRdxRsHBGqB?= =?us-ascii?Q?e63Lyr9/p39Zi3otRX0VKk8kKif2vyPqUZqzfTozCtOlQO31wWghaSqu4F4P?= =?us-ascii?Q?tAAd4KhY6zQDg1hs0iLhAzMSAwQa5VxRCM6PvahLHAO7EuP6R7b6OyXXNRJr?= =?us-ascii?Q?CItwdH9jwKKNVz5xxDm4fatngha1C2KUMekLa4PHc2b6Gx+t0gbBEVU+9x7S?= =?us-ascii?Q?697CctOoJyXrT/g8TcbB7w5rvyuAoM+8r/1yyW4YNo+AhEedbRabRL61TbMX?= =?us-ascii?Q?+T1ro/vO5qLq3nMtdOgtNUE+ilPq+REmqlol1h+rYS0wezi68Kl+sZL/F8os?= =?us-ascii?Q?wlvX3RvZ0CVSfKkr1wnOpyTsIqyFo64KR2ChkoFYhNIkv40JVDkh/O5ORGs2?= =?us-ascii?Q?Lt4kM2paFzyM7AUICTd9VRhq2YFwIn24M/64bihqNDI3c+8+srxmjQl0J2YT?= =?us-ascii?Q?JnGf9y5povqgOUI/gHWxTJvkd4GxdPAkzUJ86+5X7vJrFKdeX4Whuf9V7wEX?= =?us-ascii?Q?si00ZbQUxryZkDGwgTzDWY2ohN2FqrBz+067sWODEFOMAp9MmEdcFDni7NU8?= =?us-ascii?Q?lO3z8Y0ubqF254scED0vJdYQrqdEb53vEXZfFCtktgVWRGyIGsZ/m5VjUtPG?= =?us-ascii?Q?IZDs2SAF/vhxzaoNjEUeT7sIA9rCuAS8jHnUIFxJph1/aKn2CXDkpccgVA1E?= =?us-ascii?Q?A6Zy6CE8fmvZFr0QNxB+R5SjL4j47bqn4/P/5jIUtTzDLMd3sY3CmoFXcpz5?= =?us-ascii?Q?HXjer+ou/4zJ+eE2iudWT/rM4vtr8yLedjcdamL/hT+ZwNXWRUrtXQXjSZbz?= =?us-ascii?Q?OG0FrXQwLQVuRsf5XNWst1XYlCUImyKwq1lsMVmbF1OEnIbmyzG46/jVikeq?= =?us-ascii?Q?vt/tA0RBfT9OJoqN/xLaS4eas8xdUxuGKu4RcebuLQ+9HxOTHE5Jz49qiIGT?= =?us-ascii?Q?tOUshmadmfFsgWAD1hu0dtQUrPHWBsK6APBIFrXKfkZSCP9kgLYQzguET6Q/?= =?us-ascii?Q?NbgxJ9Hx99IzbXmcH5ONTFfKPD+sRY484RqrDJpSn5OLzlmcqyWinQ3X0cF1?= =?us-ascii?Q?ctZ+mmvkBl2Ua0rkF/Xr9LprDX6v2j+kp/s35nN0RT4MyhKGT0UIsE0df4a1?= =?us-ascii?Q?3mDyvQw5XTKJWtEzholpcL/GDi9iZETgm3j2jHbf+4Kr6/7UvQeiDaq03Na6?= =?us-ascii?Q?AwuWUWMixL+cA1MUc4RdicwMpifObfn1p9fA4GfYj7QoNfCIzCQtlP1uzaTx?= =?us-ascii?Q?4bv+6nFc9UQNTcMS/oGMe01S95ZF4K07FRS+HwiTZ5KoycFOiYQaV/HYe48O?= =?us-ascii?Q?sjZx/gxH7yZ6G994nEWlD5CXKsPwDJglwg61vOjBuvA2aqMeTRQq2XG/q6XN?= =?us-ascii?Q?GCcf0/qvY5A8VcQg8awE84y4Tv8BGkcGApi2H4I5xQies5INjTxplVcIJ7TI?= =?us-ascii?Q?bCGebEs25gpkPBDIwS3cZl6ygQ8GV6LnQPtP0wG1FHzeghs5x9ub2TltVOtJ?= =?us-ascii?Q?D7Ema7HxQwcv2OieqAi5CppcwKdEwha/nsBfAU8eGKSjoS44csGTQgTvwEjo?= =?us-ascii?Q?Y5AbD5akzWHF2IJSwc0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b45654bb-f04a-465a-b21c-08db8f339117 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 06:26:24.3319 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p7IpmOvEgx7ezdqwhEu7mcMbVuiTVSNsInguuqYKvKNTWOdBDY83kVvrgahknAI/fRa40YcFaxdCSd+4NpxaqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8718 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: GegLKMCzEJaB1ByAFkcJXil9x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SB3qdz9v; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") SmmS3ResumeState is a structure which contains two kinds of fields: * that are initialized in previous boot. E.g.: Signature, Smm***, Smst * that are initialized in S3 boot: e.g.: Return*** Your patch adds a new field that is initialized in S3 boot path. Can you put the fields together with other Return*** fields as they are a group of fields initialized in S3 boot path? > -----Original Message----- > From: Tan, Dun > Sent: Thursday, July 27, 2023 10:21 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Gao= , > Liming > Subject: [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in > SMM_S3_RESUME_STATE >=20 > Add MpService2Ppi field in SMM_S3_RESUME_STATE of > AcpiS3Context.h. It will be used to wakeup AP to do the CPU > initialization during smm s3 boot flow in following patches. > With this field, we can avoid sending InitSipiSipi to wakeup > AP. >=20 > Signed-off-by: Dun Tan > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > --- > MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h > b/MdeModulePkg/Include/Guid/AcpiS3Context.h > index 645496d191..b1c177e072 100644 > --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h > +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h > @@ -1,7 +1,7 @@ > /** @file > Definitions for data structures used in S3 resume. >=20 > -Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2011 - 2023, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -20,6 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > typedef struct { > UINT64 Signature; > EFI_PHYSICAL_ADDRESS SmmS3ResumeEntryPoint; > + EFI_PHYSICAL_ADDRESS MpService2Ppi; > EFI_PHYSICAL_ADDRESS SmmS3StackBase; > UINT64 SmmS3StackSize; > UINT64 SmmS3Cr0; > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107336): https://edk2.groups.io/g/devel/message/107336 Mute This Topic: https://groups.io/mt/100383957/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-