From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.1658.1681796298964557994 for ; Mon, 17 Apr 2023 22:38:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CV5vfveA; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681796298; x=1713332298; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=a4SLByMOZRvLuSyR1lQlPWuSueMFmQrHjAyTkPw+3/8=; b=CV5vfveAlt3o+L0St+ydGSMNMmDDYu4f6f8Cg0ArfSh8bxuGUOjO+Uj5 Un40kYYayf5Excddhn7W8Nn1VkYwCngIyS1fEB9WmGxnOQVBjUg2eq6v4 1Dr63SJs1T4oF3Z3M1I+e7oTgra0zrSondovk5p5em/qYrsVtT+ijA58I tbUMs1qgOx//osFd2b7D56jrZB/Aus7jd56mR+OQ12opefayQBwYEZoGf MJYeyNtSV1IfpYBp7VpWIXM9Ye912hNjtfvefKIqt3c/5FGQ6rlXZPyH7 EWAHOC9U5ucwS2sKFXWvRqbQkXO5q1IOA9dzwgZ3lT/rnIUXxnRAKAflV A==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="347829662" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208,217";a="347829662" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 22:38:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="937115056" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208,217";a="937115056" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 17 Apr 2023 22:38:14 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 17 Apr 2023 22:38:14 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 17 Apr 2023 22:38:13 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 17 Apr 2023 22:38:13 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 17 Apr 2023 22:38:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWOBk6yIp0JZomp9x0+qnYTS2HTeIe/YGF9odtyjIoc9l4kdEIFsE1egAUL0LTAGOmSU9nskFQfh7QuJ+76xAVVqDIKcJPxnuWpaYypxu/Zx+mo17DDMkAArhjdt9bVsgOD5UCvjWe6u6W2uVU0kL67o+YGVqS86vrtTkn/E7C4mGbzQFhl0g6W6PngZlW+Kz5So8GbfDYOEm0s50sC/UUx25hQZw8uEdY5iccg4kGYrBNX5uY13GuREIg851jspeHtcg16Y4S7v0TaXa21pksa4Qw2jKGQYEx/k+zONTC1lbo5FhsPW+B3JOJSObP7z+D4qC1osefeD0c0W660tzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w6RIDoJxW+Kwp0RTbwir9teiX1iB6WqJGnUjgdFXVrY=; b=bQ/MaryTAn3o0LasoHPUOTFfMa3KFzCuQCyD0g60ffthx9X0gfOOxC7oZbXxNNa1WleBE0cx3rKr26kTHNlL6cTRfLk7Ss//HLYvS1iWyf7gF8ArWo7ISedHRX0pslOXQ6RJFppH3IWjy0dpBQQHPsm1vZ1/4mcIFSORxXb810xCZK8rObEkJS4654bufoHaattEnko8WlHHYUMjQxat2Ml/HTq05/Tf/qBtoM7aGkenXT1VSF/36xWeoOa9KzY8m+iblhof71TlI/SnU25K7jSOYcMbRX0IQhWp5zK+N/Q9iXPAoty1CUBKujgmR2jxgc88/MwViKKbsfirSbcKIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DM4PR11MB6527.namprd11.prod.outlook.com (2603:10b6:8:8e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 05:38:09 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 05:38:09 +0000 From: "Ni, Ray" To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Grimes, Paul" , "Kirkendall, Garrett" , "Chang, Abner" , "Dong, Eric" , "Kumar, Rahul R" , "Ard Biesheuvel" , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Topic: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Index: AQHZa50porwV4JMsOkGOm2Ls0nivva8l3L6AgAAHV9CAABL5gIAAGcH3gAqDYACAAARJUA== Date: Tue, 18 Apr 2023 05:38:09 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-11T11:15:40.0000000Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DM4PR11MB6527:EE_ x-ms-office365-filtering-correlation-id: 3cc84ed2-2572-470b-3e0d-08db3fcf17d6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XmhwfaBn3/ojeOK71hbO6gMkEixqEK1qKiDmBqPv1htDL8zuw+SiV9qIrP27BAqLplBd2M3Kaao6OAP6gfeAXq07rT1yuAuRiEhIimHVjnM7ff8BzIx863ECnDK+mYlDTZkdg0EinENvIyXLE0vgIjmNtk3EM3LAfeA3lnDC0yq2ej9aH+a5ZfSG5m23entJWKKHpm2MEuduygpRUHK1q0r6hSfxM453BZQ8rBPhLLxdXqAg71PHiJbFZjt1BmNKlKqxVX5wTN7A7u0kUiQRJTiHTgqEMvb3PojEImbIVZ6dkUQtvtkaDhwYvolA5WyMhbD3+lwmYhBMBivX+2RMLcqCclZdJ0NSLiVw4qUaM4oMLgsQoOOtUsjfyHDuGX/QNHicj475AK7d6HdzChAaWRuhZk9NVaHTB3znMxa6UzTX6esEPu5sYt05HTHIAqaaoarLc2rdNAZDomiRMwCIFG22fG3u/vjlqrx0iKn/ZkaiDbj+9cQZ+IJQ4bLFzDmMnHLDQNpgDc/VBB2WZUp7XDImsy4hp3cGVWSwgkQ2duQG9n1yZMA8GaTol2l5RscZNNYLBU/gq/u074cqUXHdI5Ar5AHKA5/FqltY0hyQX0y5y3vYUHK80TGNH+hLFIBzvrLzA5+RR7CRkgLE8TdRuddXkszZLApWda2Y9091f+g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199021)(66899021)(122000001)(55016003)(26005)(6506007)(82960400001)(38100700002)(966005)(7696005)(478600001)(66946007)(76116006)(64756008)(66476007)(66556008)(4326008)(66446008)(86362001)(71200400001)(41300700001)(110136005)(19627235002)(316002)(54906003)(83380400001)(186003)(107886003)(9686003)(53546011)(38070700005)(166002)(8936002)(8676002)(52536014)(2906002)(33656002)(5660300002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UD6SEHawRh3tjqGic7HYAHmGOO2PX9HPaCy318E1uZabtXz27mQ0nS0k0NjV?= =?us-ascii?Q?qCDKjJ1/vKWzitueDVcP89qfv7N43v51WogkwISYNa5HLiMGfoeSxD0zmBD+?= =?us-ascii?Q?SJaqU+N/9b9SLEfsA0PqKBjp2n/QQtg3qh04CGw9IJdPAqSqcpkI8lizzEWa?= =?us-ascii?Q?jYmyb9/WVpY97GQuH3zHr9F5rEE+UuDNrP5lC1dhRSoZfSqpEsIMe2yZzhps?= =?us-ascii?Q?k31CZ1drJql24SsG7Q2VJpd6yIBY3AJDTGjVXdipzpwK7Co7JngSoX8eblO8?= =?us-ascii?Q?46PvHGAAgH5RH0t9+VEbQqqaGJUFpouepeenrQuoMS8Uds4eKDxUdngNTdyw?= =?us-ascii?Q?0XogwRm/+zESkrX+xAv3QUFfjhttxOorK02/lH5YQnlqFJrApHmZHHsWPnzP?= =?us-ascii?Q?8e6yRIvCOJO0D4kDNsOCToil+Wof+DArG6Jll+oguvyFEsbvKVOvXYL44c83?= =?us-ascii?Q?o9sYhp3vQuGjXxoZ6IXlDmoYhyTulvNGydE0UtPV4ape5P0um/y3RbpQFWf7?= =?us-ascii?Q?CV9xVwwjHeX604XBv0DgwdnEEo7N0TGDrU/TpWatAOjtsmatw+XNzlJUBvAr?= =?us-ascii?Q?qxIKRutv61cgEBN2yqFyI7NnbhK7lt8ptYGcj73YFaZoQ2BNygANljqYWCHv?= =?us-ascii?Q?//eHJ1wv+qxaSMH6EWPRYY4hZN1+hxcNcgXNMXtz4NvlmXQJLhklr+/xM6OR?= =?us-ascii?Q?cMUZZYIR6wrQJM1CpUjn8Wfbvvh0LC5et6gcVJGD148uySQHc1pf4+s4A5g1?= =?us-ascii?Q?pljIJr1jO32cWp2nwpv+HctDuCv0CWYcUhrSi7OhRXpkHCYv/ep66S8aIU77?= =?us-ascii?Q?ZeCXbbm2IexXpwoBZwverugKOu5vtcV11rqsj/u5HFt2jwXt/i1TYaLhhWKq?= =?us-ascii?Q?JkhDl2B0rkjAAfU67ZUhnEVXJ9uZMUJSO36cdTzlWrjofQAUW01pD/MtKuU7?= =?us-ascii?Q?qM/TA/BRLNYyB0vQcvTFaxI4gd1RmA9L8Lu+Sl0sAeqma5gKd2gXH5GyAvAZ?= =?us-ascii?Q?sS7bkMdh+nFc6nFqwBkyqmYM0ZDIpd2wDrbuNE0PVcrsky4C0Ih9iIBLqO+V?= =?us-ascii?Q?GudVvAW0SyJa+WQfiVLXZADeIuXIkJa2TE8f/+lt631VKKga/3J8SneXmxT7?= =?us-ascii?Q?3KYZJIfPP5kxPYGAelnOHLnyn5lQkN5iEGhok2p/QHxtFonWG/3nzmsKcVwH?= =?us-ascii?Q?oOP2gy6lsZl+yq/Q7K/puDlPuEMlysDdecxIszAnKPk1aGUMNM5qM1o9BMSU?= =?us-ascii?Q?Gn4YDhKrGDLhFqm9zgfiEbO5FvCFK61M9ufycwb5NBWqHfqPxRY6iSawvSC+?= =?us-ascii?Q?IIy6qN3Iefj19oqmoPPyqJmQZwS3+RUIUlJmTYNQgqA+9OZLbyamg/avpA0p?= =?us-ascii?Q?UsCJc9Er0oPYwKTCXmTe8YdWWGs5iyeZPLzakOo9yBeXUKqeIO2a5WW+O4Ke?= =?us-ascii?Q?0qj8uMJ7Z3HwAEwpGruutCyI9E3/w4R1c+t9voRwfJMz7TptnJyKFYj3vfv6?= =?us-ascii?Q?BSx8OCrOQ85nqisHhzF5OMGYB8ZdKFjPAw+Z2tZuq43SK49qMxSuthRtewH0?= =?us-ascii?Q?NxuptYtI9aRgYWe5a/c=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cc84ed2-2572-470b-3e0d-08db3fcf17d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2023 05:38:09.3384 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AS0DIOC5fsQrOnwJYzbcemnnn30ac8VPm2y1wIcEpRRqrR0zuMzEBU+R35rU+TsnKjCRvrxSeFGvIr2QfEf28g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6527 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82449A9BFAE0201AD56B4B6E8C9D9MN6PR11MB8244namp_" --_000_MN6PR11MB82449A9BFAE0201AD56B4B6E8C9D9MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Abdul, What prevents you implementing the OVMF version MmSaveStateLib? Or I assume OVMF is emulating AMD CPU, why AMD version MmSaveStateLib canno= t support OVMF? Thanks, Ray From: Attar, AbdulLateef (Abdul Lateef) Sent: Tuesday, April 18, 2023 1:22 PM To: Ni, Ray ; devel@edk2.groups.io; kraxel@redhat.com Cc: Grimes, Paul ; Kirkendall, Garrett ; Chang, Abner ; Dong, Eric ; Kumar, Rahul R ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L <= jordan.l.justen@intel.com> Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library [AMD Official Use Only - General] Hi Ray, From open-source code I can see OVMF still implements SmmCp= uFeaturesReadSaveStateRegister. Hence, we can't directly use SmramSaveStateReadRegister in PiSmmCpuDxe driv= er, until we implement the MmSaveStateLib for Ovmf. I think it's better to keep the code as it is, so that we will not break an= y open-source or closed-source project. Thanks AbduL From: Ni, Ray > Sent: 11 April 2023 18:19 To: Attar, AbdulLateef (Abdul Lateef) >; devel@edk2.groups.io= ; kraxel@redhat.com Cc: Grimes, Paul >; Kirkend= all, Garrett = >; Chang, Abner >; Dong, Er= ic >; Kumar, Rahul R >; Ard Biesheuvel >; Yao, Jiewen >; Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. yes thanks, ray ________________________________ From: Attar, AbdulLateef (Abdul Lateef) > Sent: Tuesday, April 11, 2023 7:17:03 PM To: Ni, Ray >; devel@edk2.groups.= io >; kraxel@redhat.com > Cc: Grimes, Paul >; Kirkend= all, Garrett = >; Chang, Abner >; Dong, Er= ic >; Kumar, Rahul R >; Ard Biesheuvel >; Yao, Jiewen >; Justen, Jordan L > Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library [AMD Official Use Only - General] Hi Ray, You mean directly call the SmramSaveStateReadRegister instead of be= low code from edk2/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c ? Status =3D SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, Width= , Buffer); if (Status =3D=3D EFI_UNSUPPORTED) { Status =3D SmramSaveStateReadRegister (CpuIndex, Register, Width, Buffe= r); } Thanks AbduL -----Original Message----- From: Ni, Ray > Sent: 11 April 2023 15:40 To: devel@edk2.groups.io; kraxel@redhat.com; Attar, AbdulLateef (Abdul Lateef) > Cc: Attar, AbdulLateef (Abdul Lateef) >; Grimes, Paul >; Kirkendall, Garrett >; Chang, Abner >; Dong, Eric >;= Kumar, Rahul R >; = Ard Biesheuvel = >; Yao, Jiewen >; Justen,= Jordan L > Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Gerd, I am asking Abdul to directly call SaveStateLib from CpuSmm driver. I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver an= d SaveStateLib regarding the save state access. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Gerd > Hoffmann > Sent: Tuesday, April 11, 2023 5:43 PM > To: Abdul Lateef Attar > > Cc: devel@edk2.groups.io; Abdul Lateef Attar > >; Paul Grime= s >; > Garrett Kirkendall >; Abner Chang > >; Dong, Eric >; Ni, Ray > >; Kumar, Rahul R >; Ard > Biesheuvel >;= Yao, Jiewen > >; Justen, Jordan L > > Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses > SmmSmramSaveStateLib library > > > Uses new SmmSmramSaveStateLib library, which fix the CI failure. > > What is the exact failure you are seeing? > > > + > SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel > SmmSmramSaveStateLib.inf > > This should be the AMD version. KVM uses the AMD smram state. > > Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use > actually use the new SmmSmramSaveStateLib library, and once this has > been done it should be possible to remove > OvmfPkg/Include/Register/QemuSmramSaveStateMap.h > > take care, > Gerd > > > >=20 > --_000_MN6PR11MB82449A9BFAE0201AD56B4B6E8C9D9MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Abdul,

What prevents you implementing the OVMF version MmSa= veStateLib?

Or I assume OVMF is emulating AMD CPU, why AMD versi= on MmSaveStateLib cannot support OVMF?

 

Thanks,
Ray

 

From: Attar, AbdulLateef (Abdul Lateef) <A= bdulLateef.Attar@amd.com>
Sent: Tuesday, April 18, 2023 1:22 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; kraxel@r= edhat.com
Cc: Grimes, Paul <Paul.Grimes@amd.com>; Kirkendall, Garrett &l= t;Garrett.Kirkendall@amd.com>; Chang, Abner <Abner.Chang@amd.com>;= Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@i= ntel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@= intel.com>
Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveS= tateLib library

 

[AMD Official Use Only - General]<= /o:p>

 

Hi Ray,

        &nbs= p;       From open-source code I can see OVMF= still implements SmmCpuFeaturesReadSaveStateRegister.

Hence, we can’t directly use SmramSaveStateRea= dRegister in PiSmmCpuDxe driver,

until we implement the MmSaveStateLib for Ovmf.=

I think it’s better to keep the code as it is,= so that we will not break any open-source or closed-source project.

 

Thanks

AbduL

 

 

From: Ni, Ray <ray.ni@intel.com>
Sent: 11 April 2023 18:19
To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; devel@edk2.groups.io; kraxel@redhat.com
Cc: Grimes, Paul <Paul.Gri= mes@amd.com>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; Chang, Abner <Abner.Chang@amd.com>; Dong, Eric <eric.dong@intel.com<= /a>>; Kumar, Rahul R <rahu= l.r.kumar@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jo= rdan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveS= tateLib library

 

[AMD Official Use Only - General]<= /o:p>

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

yes 

 

thanks,

ray

From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Sent: Tuesday, April 11, 2023 7:17:03 PM
To: Ni, Ray <ray.ni@intel.com= >; devel@edk2.groups.io <devel@= edk2.groups.io>; kraxel@redhat.com <kraxel@redhat.com>
Cc: Grimes, Paul <Paul.Gri= mes@amd.com>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; Chang, Abner <Abner.Chang@amd.com>; Dong, Eric <eric.dong@intel.com<= /a>>; Kumar, Rahul R <rahu= l.r.kumar@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jo= rdan.l.justen@intel.com>
Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveS= tateLib library

 

[AMD Official Use Onl= y - General]

Hi Ray,
        You mean directly call the Smram= SaveStateReadRegister instead of below code from edk2/UefiCpuPkg/PiSmmCpuDx= eSmm/PiSmmCpuDxeSmm.c ?

  Status =3D SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, = Width, Buffer);
  if (Status =3D=3D EFI_UNSUPPORTED) {
    Status =3D SmramSaveStateReadRegister (CpuIndex, Registe= r, Width, Buffer);
  }

Thanks
AbduL

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com&= gt;
Sent: 11 April 2023 15:40
To: devel@edk2.groups.io; kraxel@redhat.com; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Grimes, Paul <Paul.Grimes@amd.com>; Kirkendall, Garret= t <Garrett.Kirkendall@amd.= com>; Chang, Abner <Abner.Chang@amd.co= m>; Dong, Eric <eric.dong@= intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.c= om>; Justen, Jordan L <jordan.l.justen@intel.com>
Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Gerd,
I am asking Abdul to directly call SaveStateLib from CpuSmm driver.
I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver an= d SaveStateLib regarding the save state access.

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io= <devel@edk2.groups.io> O= n Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, April 11, 2023 5:43 PM
> To: Abdul Lateef Attar <abdatta= r@amd.com>
> Cc: devel@edk2.groups.io; = Abdul Lateef Attar
> <AbdulLateef.Attar@amd= .com>; Paul Grimes <paul.g= rimes@amd.com>;
> Garrett Kirkendall <g= arrett.kirkendall@amd.com>; Abner Chang
> <abner.chang@amd.com>= ; Dong, Eric <eric.dong@intel.com= >; Ni, Ray
> <ray.ni@intel.com>; Kuma= r, Rahul R <rahul.r.kumar@int= el.com>; Ard
> Biesheuvel <ardb+tiano= core@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com&g= t;; Justen, Jordan L <jorda= n.l.justen@intel.com>
> Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses
> SmmSmramSaveStateLib library
>
> > Uses new SmmSmramSaveStateLib library, which fix the CI failure.<= br> >
> What is the exact failure you are seeing?
>
> > +
> SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel
> SmmSmramSaveStateLib.inf
>
> This should be the AMD version.  KVM uses the AMD smram state. >
> Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use
> actually use the new SmmSmramSaveStateLib library, and once this has > been done it should be possible to remove
> OvmfPkg/Include/Register/QemuSmramSaveStateMap.h
>
> take care,
>   Gerd
>
>
>
>
>

--_000_MN6PR11MB82449A9BFAE0201AD56B4B6E8C9D9MN6PR11MB8244namp_--