From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.3670.1678872468332504236 for ; Wed, 15 Mar 2023 02:27:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DUbKP/st; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678872468; x=1710408468; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3lKMdfPEDXIWJ5IxQXgkVFg6OVtZOWsnmCRxOPvfHmI=; b=DUbKP/stbfHSCNwvEgDUD+1x2n2V/s16oOCN9iq4a4tcLuWF9kuPYu5T 6zUVexoNxDsNplkMrZmIu/fj7qOiXeXFx1ztOSPLSu/nIhdzjU3kP5xRI 1jw7AFRJ7JMDdU5HDcImMwoKbKv5/gFBT2VbpD5mstoNVFCgcdXnM7Xj2 HYr8ku0CAeAFKi2wNLxHkq6N1n8lXuz3T/BkXwfePxQv0K2FntGslBPs2 y/rta+wTReOBFYoTo0bTnndh6/Tu+g2ogmJbSAxmdiWLdG8bifbnH5WEF sM0RuM8YtJSDHMihXH+BdUX0LDcCEke6X+YOP0ANPGh8yVuzRPb9rr4jz A==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="365334439" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="365334439" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 02:27:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="822705606" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="822705606" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 15 Mar 2023 02:27:10 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 02:27:10 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 02:27:10 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 15 Mar 2023 02:27:10 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 15 Mar 2023 02:27:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RqdCg1jdY6opPKMlhPGBoRIjB+im6RgjJBNUxSCxhpJovTLthBiMH7k++73HJVWlWEj86iLYd6yMWy4rgYIi04l3bAob9R0qFiBnmHj3SEyeTw+L7vSvs/RHW+Pght470MkZcL7/1lcBusZhqG6bQ0WXL8rEfZLFJgjXQ9e87zV5AjTiFrVnS/FZbpmtZ+8xmN+7FDzpCooY3GLF1MnzgdXthNoMTH8F6IEU9yxvpcGJ8QBOKVnqVpB1w+1x9R96P5JYCJ0cwpu7EuUrClaTDrP0estXCtH4YkJMlKgBSZB5HblOTbaB4aJenOouwt4rNIPucMEuwxsi2tZGMhg+3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3muTfdcvjYTTVUmzwN40/RiAFWgRa4O6zIdfS7zveqw=; b=nYtTNBADpbfUr3uo8CciSW3pEGfQSu+R73R3Huka6oF5Pf1b9C3qGf+Rl7T6rIZB4AoAmbA4jmXu8VHukhQTqy2smCUPsZld88viz3ymjVmfZ+3SOlSizCEYNzfoXdR6UmuDm5K5BuGQtJndW1hZaiUeWDEU8pPYUf/HAIhR+h+4o0DeIC/n4Swd/2fAzOlB5zs2iCoIBQvtbsJupLnNyxnB6msi+iMje7Ag/T7SsggZMIP30Adt69xhzMWk7/1Nc/Bo3OQ3ZaisJGKj7wKzd9n82brExdMNPPUMKOZ183o7pWOyIOlku/GuNxmt7OY4M5WA3mA9ulw6buklUWhd/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB7998.namprd11.prod.outlook.com (2603:10b6:8:126::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Wed, 15 Mar 2023 09:27:02 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.024; Wed, 15 Mar 2023 09:27:02 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since tested API is changed Thread-Topic: [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since tested API is changed Thread-Index: AQHZUaYYzJ4gVLFH3kiVsdU1z5IYoq77btEwgAAuPgCAAABFoA== Date: Wed, 15 Mar 2023 09:27:02 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-15-dun.tan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB7998:EE_ x-ms-office365-filtering-correlation-id: 9010e433-e907-43d1-561b-08db25376f27 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vf0Vh+0mZje7pE545CDrL0B45QkE7YZfeMBKY9+DSmJSRJJnpCslcLCRu7jZWMSEGvjvdbOqu+I+kjR2dm6n9g5KmPLM9h+PQpYD0sjK30w1yr6gFMjDddcma7Gkjy0/+GRVV1ekJkIQzId+BPhpPPA7KXUxAmFvMAEU4R/5JzbZ1NpkKq+RE4tGENhtY0TW/NDR/Qn4iTEwIn8WyqCkC+GkA7ML09QFK6SrMnSaH6nSI1mceggvYnT8E4tQs3VmlrmjQOqvHeDFK98FKUAVO15DyGqmh2IuuvfI5XoLXtYlEWiGIrhzbl3iHujsiBzWR1pSL29blkC0tfle52NJu52cyza+6F3FXzPQqcpQjxtFxwS72NJZb+IsJ2xI7m78uIkXB8uI8w7jjkrjS11kOdLQ4d7RWMQVMjYoGl0AFTLex6gFRntzN4xwpl/A3TkRwle25/vCLvq/w8Apu1FZ5sAdwP/3p+F8KgKMvsQlyMg1+4zexMovQpdcmuLlIkS5IEG2kakwqszUDKZii3QNrF5YTp30y0HECEPOCZoUhz7R2M6oihrJPGvnPHKpYR7K7eDT7turO/PJdfUBMn36S/UIaKuAswTDZamW7HVJWNPegwli1u7/mQc9jA5l+A+W1wJWfFffm5g/8LWNUnOIJAPmtFHZJiCBhFZmQuO22JA9pmB8MFMZY9ouNgwfiU6MPiGdAxbE2vD8EwnCD5Ho1Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199018)(86362001)(38070700005)(66556008)(33656002)(8936002)(110136005)(5660300002)(2906002)(41300700001)(478600001)(19627235002)(76116006)(64756008)(8676002)(66946007)(316002)(66476007)(66446008)(54906003)(83380400001)(122000001)(38100700002)(55016003)(26005)(82960400001)(107886003)(6506007)(53546011)(7696005)(71200400001)(4326008)(52536014)(186003)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DM4prpJxgUMK020kejKrjflWZ4ypwaBNXbrT0R+lUOpW7LLEaq2lQUMuhOmF?= =?us-ascii?Q?yEPAdqzhZl4iDQQ1Iu7bCFMdQoM/vLTBH7jkahTlXuoZj9DS6W+xWjPSi01f?= =?us-ascii?Q?DBA7mxy9ckBWo2yS9TdTegtVzVbd90gmnbENuYaT4E5Ve4/bFzYBPszcQmgN?= =?us-ascii?Q?0DMKksucVc1GJbMHo1Y0bWvyAG03GCDI3j2bWVrKfW22w2Ey9hbRrQKyXUU/?= =?us-ascii?Q?W3brV4/NdXqeVOekdrbnzFqoWoB3RKX+/dqVNZfYxa2iACqon+WZIUQkEc8d?= =?us-ascii?Q?QXWRuNJI+Gv3XTtT/6CwLqSRB4fHuyeafpiB/bvsT5FBVIt94cuoLyfnbGUm?= =?us-ascii?Q?I/7L+6DoSW3ku3PSUVoobU68VekCtk2VdLkPd3AjmaBsP6p9z/hE9pCh/rwS?= =?us-ascii?Q?bH9jb1lVK3CcQwG4ID1wejdytxdHt/bFIUo5vTwtA1L+MVEDdHpksu85UAOW?= =?us-ascii?Q?/BnVsElBfGK3sto/25l1xfnoJtbgHrSQKJq1XC24NskPUKfljJpUk2DvJyGw?= =?us-ascii?Q?HDNLkHOt9GeC17+m96M27imE1//ZrzKoX+Tupa1GAveS+aTvnRYjMjxlVZwu?= =?us-ascii?Q?YVqKKBvt/vRMTIZZJ/6lK6V/vzGit+j+QcVHI9Gcd2DjARwjQhBaNJvlvsee?= =?us-ascii?Q?PnFnDpT5ZIUDINQym3InDyatVxjrV0t8p4g6ekTptOkFpMM4iHhM5ue9b9dK?= =?us-ascii?Q?QRoaqjEh1PGkdAdinTe9djXCJSbarSafHfYAPMId+ShWoYrBMljm/JFTb2wQ?= =?us-ascii?Q?U6gkKMyGx8uH6clEcUSH1WgckSsqSfEb08p6NebJg2LGH7fJIOIXB/aNRj43?= =?us-ascii?Q?sa01tTh+FNIfzgc/JS9kAUxpsIUKWix+emoAE+pYislRTPl4DH8BYMzAMHaP?= =?us-ascii?Q?6bekpC71BqvFoA/PBDgejpZGdk331p+rpaHFQA6O5lkSQr3clU8P7jdvOdjU?= =?us-ascii?Q?8T64FOXAqcGtUQxPqZALzH+bgRwSdIxKeUkdgpIM3n1eU7aUbbHfU1HRi+ps?= =?us-ascii?Q?qkRxZKP1V9kw05m9bIydt9xfbHXULl64Qtr+caSZbBOerjfbBRfwJEvfyn/p?= =?us-ascii?Q?Dm5+FdcWTs0mrkHqo2bD9/jDRRCjBGiYhXLUXLZn0VLgpFwC1t1/Gzt1Hnc4?= =?us-ascii?Q?jgZgyLrbJMDQqUD9jZZCtukMazWZ+6mDk5ZwOo3mfQYPuWwtmOoDXvOY0cLT?= =?us-ascii?Q?Ai2NAw5kD7nQXP15LdHnfq96fSqjuKRdq/Cg3KqDLIGCh1fIQaX4uC2oPiZ/?= =?us-ascii?Q?mrAY7a9KS9L6xtOJKMim/yBpbVf+U4N3H4u6f4UKnevFD9DPZRCgFADsaJvV?= =?us-ascii?Q?gYP5JmG2c1F0HCzpjDl5FAsiPVUP42l6mDle1a/Vjo8EQr0LKDnb9x9ZJCOr?= =?us-ascii?Q?lzJRXXIEemaOj8MgRljSN8A0QRLzK8epMKLIQq5Dg3NOL2cXfiLhF8duUddb?= =?us-ascii?Q?W5zzbsHWBJwqFuU7cAkDhp0WtqrjZ7IzPnBmamyTJqCVpSVmGfB4UOMEYyl+?= =?us-ascii?Q?+tv/nX4fDoaOfxZru/N4ko3JlLuWS+hS8CM+GgU1gMra1CqOLIN0gXRljj1B?= =?us-ascii?Q?1VFTbALqcLtovxkISctMW10nM+UtZZhjj9edPnox?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9010e433-e907-43d1-561b-08db25376f27 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 09:27:02.1178 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2EULuJ2bPusRvaxVubvwvObun/zJAKfgjTL12sif2+3uDGyFM5jjgpH36MDd/2fHrUUzeXTunJrkIg8noOQYzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7998 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. Then Reviewed-by: Ray Ni > -----Original Message----- > From: Liu, Zhiguang > Sent: Wednesday, March 15, 2023 5:26 PM > To: Ni, Ray ; Tan, Dun ; > devel@edk2.groups.io > Cc: Dong, Eric ; Kumar, Rahul R > > Subject: RE: [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since test= ed > API is changed >=20 > Hi Ray, >=20 > The Address could be not 4k align, "& > IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS_MASK" is to clear the > low 12 bit to avoid impact the attribute. > I think it is needed >=20 > Thanks > Zhiguang >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Wednesday, March 15, 2023 2:43 PM > > To: Tan, Dun ; devel@edk2.groups.io > > Cc: Liu, Zhiguang ; Dong, Eric > > ; Kumar, Rahul R > > Subject: RE: [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since > tested > > API is changed > > > > > @@ -413,8 +422,9 @@ CompareEntrysforOnePoint ( > > > // > > > for (Index =3D 0; Index < MapCount; Index++) { > > > if ((Address >=3D Map[Index].LinearAddress) && (Address < > > > (Map[Index].LinearAddress + Map[Index].Length))) { > > > - AttributeInMap.Uint64 =3D (Map[Index].Attri= bute.Uint64 & > > > mSupportedBit.Uint64); > > > - AttributeInMap.Bits.PageTableBaseAddress =3D ((Address - > > > Map[Index].LinearAddress) >> 12) + > > > Map[Index].Attribute.Bits.PageTableBaseAddress; > > > + AttributeInMap.Uint64 =3D (Map[Index].Attribute.Uint64 & > > > mSupportedBit.Uint64); > > > + AttributeInMap.Uint64 &=3D > > > (~IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS_MASK); > > > + AttributeInMap.Uint64 |=3D (Address - Map[Index].LinearAddress= + > > > IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS > > > (&Map[Index].Attribute)) & > > > IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS_MASK; > > > > 1. "& IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS_MASK" is not > > needed.