public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Xie, Yuanhao" <yuanhao.xie@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"Laszlo Ersek" <lersek@redhat.com>
Subject: Re: [edk2-devel] [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE.
Date: Thu, 23 Nov 2023 01:18:08 +0000	[thread overview]
Message-ID: <MN6PR11MB82449EE7CC33114CF31DAF658CB9A@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231122060834.3467-2-yuanhao.xie@intel.com>


> -  MicrocodeDetect (CpuMpData, ProcessorNumber);
> -  //
> -  // Sync BSP's MTRR table to AP
> +  // Synchronizing the MTRR table to the AP is always essential.
> +  // During the DXE phase, it cannot be omitted like loading microcode,
> +  // as the PEI and DXE may be in different bit modes.


"as the PEI and DXE may be in different bit modes" is not the reason that
MTRR sync needs to be performed in DXE phase.

The reason is some code might change MTRR on BSP only after CpuMp PPI
service is not available and before CpuMp Protocol is available.
That is in early DXE phase before CpuMp protocol is installed.

>    //
>    MtrrSetAllMtrrs (&CpuMpData->MtrrTable);
>  }


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111634): https://edk2.groups.io/g/devel/message/111634
Mute This Topic: https://groups.io/mt/102744598/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-11-23  1:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22  6:08 [edk2-devel] [Patch V3 0/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE Yuanhao Xie
2023-11-22  6:08 ` [edk2-devel] [Patch V3 1/3] " Yuanhao Xie
2023-11-23  1:18   ` Ni, Ray [this message]
2023-11-23  1:18   ` Ni, Ray
2023-11-24  3:06     ` Yuanhao Xie
2023-11-22  6:08 ` [edk2-devel] [Patch V3 2/3] UefiCpuPkg/MpInitLib: Store MTRRs settings only when CpuCount>1 Yuanhao Xie
2023-11-23  1:21   ` Ni, Ray
2023-11-22  6:08 ` [edk2-devel] [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Revision as function Yuanhao Xie
2023-11-23  1:23   ` Ni, Ray
2023-11-24  3:02     ` Yuanhao Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN6PR11MB82449EE7CC33114CF31DAF658CB9A@MN6PR11MB8244.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox