From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E8386780091 for ; Thu, 23 Nov 2023 01:18:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gQ1L9KYBfbEHsL84osC+wnZDehzQK0JIu2eBQ26e1jo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700702293; v=1; b=pQXz9UwfJP82o+PE6DFHPVwvZ0ISUGQJwR1ogaQqVyAxPe6cBhyxijkB+KnK+JLt5e8GRI5u OL7vxBuwNxvuJ6P4ZRU6nF1+cBDdEzW7PMuXArN6hR0iL05UCcZIuFu7fC5uwN1+Y1QqHbosSvi f0dvQjBq9C4EqqcS7m1sXXKs= X-Received: by 127.0.0.2 with SMTP id dIqKYY7687511xGqiqC1uXUd; Wed, 22 Nov 2023 17:18:13 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.82356.1700702292626235649 for ; Wed, 22 Nov 2023 17:18:12 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="371527540" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="371527540" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 17:18:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="940446923" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="940446923" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Nov 2023 17:18:11 -0800 X-Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 17:18:11 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 22 Nov 2023 17:18:11 -0800 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 22 Nov 2023 17:18:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J08KEznVK41uKk/oo4b4uHEpxrt7726YAskVUFoIZwx0WnPH4pddn7PMlYnCSmfYgByvntn0CD35IIwX/Zz/7lmXGehaLxf8m3DkUTgNG5iFBaUeXxGxiJMz8GlzbcxzyTpEM0FCbjqwOuoQRToqzlqJA9T6hiFQgr1SS/x63ElStQzuApdRaNGtwdWTi7AYOUfvEle4ClrG0+1LhWuUvqZqoYtwKe8VpAvmFwHcpiDsk304+j0hnN1pysN5Wzx9gxpUHTBbuQsJgiJ9FsNuMvPUefUkWzaQ77SiO/zD7R28fU3JIduHXkG2w5OBmbWmyF3Xk3QH6ovvp8Pf7y+hsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CCMEf7/u1R5/zs8KpiG2x54qpzkcMWxmyPYOsNjHZE4=; b=hwaR+Jp8fo9EBfXlqv/bnFn9aHt7w6hvV4UsDfzlqG1QwZSNHX0Yr+LPbsXK0+KNm/cHsyWkjcXxohPBPa+bY/fPzUhPfSUZHlW7ZlPuV/EozM4qP9KZgZnqUH2YYVEj/WTAew0bwLWka1GUd5L4jFLk84HY+E2LaiLqzrhbDPgnW6lSjsRXRPQc3vbDrVzX94mc7hlK5i9YHN7XNvtFMSjSx66w7sq4U+kr/qjUiL6vXWYYVfoVNGzdq9cEzd95Mud6TEUN+CgxF2HBmxve3uwT2O6FOom3d8gi7+zh9cV/mLTsivXln4jHFaS197ks+wCR66KNsjys6NOIGYjgFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DM4PR11MB8203.namprd11.prod.outlook.com (2603:10b6:8:187::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18; Thu, 23 Nov 2023 01:18:09 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7002.028; Thu, 23 Nov 2023 01:18:09 +0000 From: "Ni, Ray" To: "Xie, Yuanhao" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Tom Lendacky , "Laszlo Ersek" Subject: Re: [edk2-devel] [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE. Thread-Topic: [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE. Thread-Index: AQHaHQpkshDXt1Vcqkqsz0jJDOstCrCHGwTQ Date: Thu, 23 Nov 2023 01:18:08 +0000 Message-ID: References: <20231122060834.3467-1-yuanhao.xie@intel.com> <20231122060834.3467-2-yuanhao.xie@intel.com> In-Reply-To: <20231122060834.3467-2-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DM4PR11MB8203:EE_ x-ms-office365-filtering-correlation-id: efd9fc2e-78c0-4620-4a83-08dbebc20dc0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: lJEd+4MpSRu7XO1fct0KiJ7Edeoo0yFX+uhkd67EhmCKA4YET2JnHYtg7S2FP2JypqCemd/hYsd0uKcSSysn1f3IaBNqN+3XHPAMcit0gGAA5XSbnb/k379upiG4o6RDAHZWSqRJ0Ci7S/RAgJ1+PbsWMsHwdnpJ5hnz45qbsj+v6xz5mpPLnzom9aeFmp3EtKNjb9cE/RlCGa3E/7Jt5cCTInXvzyJvA0S9gOf43aX+aa13h6ICvMISFjTgzZh04KKFxh08LWtsEFWonRXomNASoiiDPCJB7laD+RDslBh7a2uF9ir0UicS+PoV1IjpBr322YWKyaYCRB6uqGVCEGO4QGZ0eZ8Q5F69mzybZecWBa9zr9jwG9Lp5UKag0idj9GJpdzCwpY3WrAFLZnYgI8x3AEbbU9fBvTE/raDq8pDSG2Dl+UQplZ8Tg4DsxtsP1yalYnuh2vy7kfO1xv4OcqSItyKbnRFPVLSAg8LemXVBSjhoGT6rOjt8efldjcC1L9Qx2nYJCbzrGsrXtH2B+KYN5VHAT8lmFHEHhbvXVosz44GA6pOmVbtaPo/zy5WmLjnxEMNWxRp3EdV2La+0XqL1BzFaJAYxoUEnSfd8p69Y6rFMzrQtwXIixuDk+O+ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YUkukE32bcBZHLloAUdZzWfrh3tdt1OWT6UGPEmvVHs6wCWGdSuoP12iIuAG?= =?us-ascii?Q?SFYQD7tLtWZgKaw9AX1ZSoJRz6nzhdfd2iVmfCp7z3Cnuv1jfu+wObPm1jGc?= =?us-ascii?Q?xmlehmbBBn4YdHVPRUN01TfSVq4byc6dyFoariTX0cS4qYir7wxDbC+WW3cn?= =?us-ascii?Q?TeU5ukoj+bwoNQe0a8WdAva0Lb9zbZpBwJk/SpBCs7hEJ84zU399iV21vzPw?= =?us-ascii?Q?kv+AwRgq0XK5ypd2rhVXw/7hD7ZMxJ1s4i4G9vNZ8y7k5LXHlxtgdiLI3im+?= =?us-ascii?Q?BVaYBowHTOfBwahg6L6XiwT7/LqsCR53yKqHbuArg7dla4575TbFbZPhlz28?= =?us-ascii?Q?g1l3oDPaMAPwf5rvl646EYcdWBTBnqSdOFjxLepYb9hKqjJbw8QO2sl7y4iK?= =?us-ascii?Q?IaqYHmHrCy6HzHHoC4NDDtT/xl9LHy62TxzQHqBNNlV4rYuEHB+nYnCw64du?= =?us-ascii?Q?To1/vrK4dvICnkh3noFP/kiuyKSCnYdutdSbfdXD7Ykq/w8BGbspj1z2bH1l?= =?us-ascii?Q?WTaB3GDgO7k78xRvwozCF94v8qzNti2jVZ0f35v5xeWAepEjT09E4dDcfQGd?= =?us-ascii?Q?5bjSRm2l6otxIQrekIOYybS/Ptmp+77drTnplTd44nuxuZPb06z/38qszohX?= =?us-ascii?Q?qYo2sHZlBP3zO/iZ3HhoqyRq2j6EJToQ+yIqNy8jwFhecWK+tTBfvskFBPbg?= =?us-ascii?Q?mMqGhaZRNfMgEEF2guhlv+8e24XO8tYFcgykhPbwX94jnjlCNlRVDwKukJty?= =?us-ascii?Q?6vjjrApZmonbNObXDuP/yVEgRIetREYKIU6VuqKL214hmWy+y/meYHcprAQ/?= =?us-ascii?Q?hjNVqy9Lg8WYjVB+VScQUvEgfY3DA9v4tJwGQvF0yhZuD7VaELZUSoUXMaqD?= =?us-ascii?Q?5SFI+NvQtdACXMefA+OYHf7aL8Y9SX5DJgbTDhS9zenDcj4KP/JDY0Fivgb/?= =?us-ascii?Q?eDPNWdyGQhJeA5v+E4XX62tOB9W47dyF7UQaXwWf4fuuBPplRJoQU4skvr5Y?= =?us-ascii?Q?ENMVvY9E+r0NLUOHAUpVubxbPIS3DpDcD0jqX0fGkEw+JJBvjiuNDwT/yKwv?= =?us-ascii?Q?gh2KaIvnijukqDkxvf1OVUXOo3zA3ZNrdWoaLDnl4rlC2svYM/r7QJAKjzJ/?= =?us-ascii?Q?jWN9neIQs3bPm8so3q0mmoKaemEMF2Wx99VGqIu0O0xsDd7ehWUrBafDQ+sU?= =?us-ascii?Q?vuuyaXH9X1K3uoteNmLR0gmKE+CSi0YHjPs7cC2iuaWFUvXgNMVV29FlYvc9?= =?us-ascii?Q?C+lfywqJD7BxSNwRODxiiqxffWmGM912QGxLwGfTZku0lnXYEMkFRKKNr8+E?= =?us-ascii?Q?6/Jo/v5a2PmfV9VoKe4Crc1G4lJR9ANGz0yCDd8g/XXjGYVcWVYwKsxkHHAY?= =?us-ascii?Q?Fw4z9MVJEG4NPYu4zpeR8Z/VcyvhbjIg46PsbHVo+wcFuVK5Ev+HJa1v3rWO?= =?us-ascii?Q?++5VjQ1uBe5c/Ei0RQqjXFSuH4TXqmCBxsf5EjlSX7HbqWCWgSfREiGE3Fyz?= =?us-ascii?Q?6W1kusggIhSIL2z7rkWVBMeTSKW/LAu++3QYMgYzpQhEefEkyn3dr7DVW9m9?= =?us-ascii?Q?qVjQwpVMtnsRe0iKrfA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: efd9fc2e-78c0-4620-4a83-08dbebc20dc0 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 01:18:08.9681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lHJqOms8ribY8XRev/sYhYD5XQQW0H34mjbGZEZmcEhjSHpaGsauNWPk0adEeNOrHNcYGFVhiRi2qSTkenTfOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8203 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 06ScNjX1WdOSLfwS4pVzOmYNx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pQXz9Uwf; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > - MicrocodeDetect (CpuMpData, ProcessorNumber); > - // > - // Sync BSP's MTRR table to AP > + // Synchronizing the MTRR table to the AP is always essential. > + // During the DXE phase, it cannot be omitted like loading microcode, > + // as the PEI and DXE may be in different bit modes. "as the PEI and DXE may be in different bit modes" is not the reason that MTRR sync needs to be performed in DXE phase. The reason is some code might change MTRR on BSP only after CpuMp PPI service is not available and before CpuMp Protocol is available. That is in early DXE phase before CpuMp protocol is installed. > // > MtrrSetAllMtrrs (&CpuMpData->MtrrTable); > } -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111634): https://edk2.groups.io/g/devel/message/111634 Mute This Topic: https://groups.io/mt/102744598/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-