From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.195045.1673959717644445023 for ; Tue, 17 Jan 2023 04:48:38 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AamNypN9; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673959717; x=1705495717; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=54Ok/5MJl0RB/MPXobNMELsvuEpBMmhcVeV1uwYsWN4=; b=AamNypN9KsHbr/s1sTBr/Rs9X+T/8o58ryHXC62VtdvVz7W2kP+gdVJV VL/4joqpDVVyPm4GLJV9mzmfrL2gO7WDQZ0XYtoSxv0rhDBcxkEtGv5HJ 4RpyiIDzz2BzhUcIbvPVGYGj463dLCqg/FcIoJzHj+rmL49prgNhBIqgx jV71QgHUDKf41Klzx0rnTDFHtzVbxQ1b6yXrXFbIVDjFcjaJAugcZNpaf 9K67jSQe3YhTB3Ug7MJ+Nd9X5+Or3zfPUp3571pJSo5hRh06TTKyo6pqk dzK3VNxsM/r6WI7ylhD+ccUljJ+p0qMPltcX2WB4YXbgDwn7vbLKW9SJ1 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="326754800" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="326754800" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 04:48:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="904636442" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="904636442" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 17 Jan 2023 04:48:36 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 04:48:36 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 04:48:36 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 17 Jan 2023 04:48:36 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 17 Jan 2023 04:48:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RG7L32LnmWLLZCyEmqLxgA4K9ksQgPpPzSwbkYPTwRtoqpA7SUikLqNnAEd8v+x3wC74tyD6aVV2Mf08t3YQ4Hc+CXAfgEOQ4IZ/LXsaGHgurhN3AMRWFXQrxugdX3+Nvjh1uoD3dddRfhg7ZubBbvGHXnqGg7gBVn1rKCYVTGPfT1/gPeMamLX5D6bQagi0zU8z9b/s97YGFbQw3vS1nDrY8vZaJ6xkOdyXPSvh9dlCjQRz8ulFZk1JQhAp1qD/Hz0wgF+m28w1UikHPGSQd/olEWq9eTVyGUDB26b53vz3po7wBV5+ZDQ6APmwq0vCBX3mz2lR+ubJkQzQV+GtLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tkc60ycHom90ZHQHwhrDcuIC8XXWl6j9ViZ8P3q7CE0=; b=WwSMmlre3TQd6VqjtufNXjmDZz5zwfu6odRRFOCl8my06Oej2tRH+Qw+Vjk+qXREn8vjd6Fo4IbOL0b78qOUo2WYXbA0Ibe1/JTUg0Zeu0fipubr9yZ8dy3TzrJ8whSmBN7k5U7Cirhlv4mrhxMV5XSkqSttKnG3kSepZDPcDSUDZuDZCJ9PZqqxgM696aLEiYudBhM7Q5baF7oAuG9Du8PK5i4yXwfVmyPmdhaTMso18e9rWGlNTMDZWA3BIbHOslyNcGvM8ZqGG6Gro7b3AxZFPw61bZ6/SLKNJF0At2cN0hwxwC5SRasPbW9deNARS+UiHsPopaOUT6JWQNmBxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW4PR11MB5869.namprd11.prod.outlook.com (2603:10b6:303:168::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Tue, 17 Jan 2023 12:48:33 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%3]) with mapi id 15.20.5986.023; Tue, 17 Jan 2023 12:48:33 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Liu, Zhiguang" , "Kumar, Rahul R" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging Thread-Index: AQHZH/9P2T/UYdbjFEWXX0eG9sRu/q6iZKyAgAA1sICAAAkngA== Date: Tue, 17 Jan 2023 12:48:33 +0000 Message-ID: References: <20230104054118.280-1-zhiguang.liu@intel.com> <20230117121359.52rxmec7dv6gfksa@sirius.home.kraxel.org> In-Reply-To: <20230117121359.52rxmec7dv6gfksa@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW4PR11MB5869:EE_ x-ms-office365-filtering-correlation-id: fb6e7fab-a9d6-4c30-2538-08daf8892498 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: etTEM3yuTCbz/eCnmEpvsXiBuzYwFYbgngcSZL5FymIt3Zabo3QAUN7q94S0f0MA+KR282Vqn5bm1Ord0ZU0rizF59U692pDguH5ell6E3fhhYnkkNFy5/3FP5YUfAmS/LteFv9cD3zFrBG2zWRaWy3lYwgdWHT5g5EA5nEelE3GIe0x33SDU89gDWe/m1pqO51et4Pt4rtHisEIPVPr93jPncZ8TsqHkBKT1dkQJX8e66LWZxC2BHjthCfbWejTjzk2Kw4VqbZJc3dmrB1KocSZGbEOAsffoHzQXfL2KOiq1NrTO9FD0xPkA+qmb8UW48Mx85PA9R8/47uS6MF6fCeOw8OVkMNoy2aRAW7Wdj5hOxoP/fSwvhbdyG8oblEHKm8IsqdvvvkQZzhEhDas+rpLXu9IAMaEzFzAV+tBBRPEOaw4QxtqpX2TF7CbyVzmZBAyp+QPaEenWKaYrkm3OftGpObSfw75yhyhdAyz/a11vyUcpW7EwEkQ3N1SD8yWATLtZdICdf8Hz7ms7uJSO3ipu/AD1JzjBL4MgAtcTRMEeY6YLsSLcMq/3FSF3ih1qFiQoDypr3DoJJpc6ktCu+xutH0ETmsz4ac1u0czot6zJezncTTkf5QMFHMfpSnkCqAH8b5DajP5KjNDWKTQB+XOoE51OWXVGtFgO2gl09JH31ng1hF61yyHEGUo3IjTPB24rsz7VuHzdoUcqilaqyj2FPG7cHwua1U36yuWMSN56esOyjwTKei6raX6lXCQ0AOkBREOEOoHfTB5vjdwOA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(5660300002)(110136005)(33656002)(2906002)(19627235002)(54906003)(478600001)(316002)(38100700002)(122000001)(966005)(83380400001)(71200400001)(7696005)(9686003)(26005)(6506007)(186003)(86362001)(55016003)(82960400001)(107886003)(8936002)(64756008)(52536014)(66556008)(66899015)(66476007)(66946007)(66446008)(4326008)(38070700005)(8676002)(41300700001)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jpbDLEF2MRn+njDtsoaqF3PYR/2d3Y8gFxXNV0krBnH7lmcujF8WGccbJuKw?= =?us-ascii?Q?uOO6zT4vfQZ6uiNjtuhPnp3x1LlmmdP5BrJ2hwwIWypqKHRNENf6LvQGkmlO?= =?us-ascii?Q?gZqudgndQmp9DTLXjrBDIZI8AF6lyUYtxZjCX+y5Pm/JPaO6V8sz1MXyErGo?= =?us-ascii?Q?CErlI1nF2CXgd+j5YqUuV+SlSypaPMjU2kwR8H2FK+2onJLkVYXAuX9FWApD?= =?us-ascii?Q?ochtbUB0+Yi6O+z40tHYWdtmIz2CQu4jmwsKePkNJDBnjcM+3hD5M4MM9vuv?= =?us-ascii?Q?bBBAFIjn3eh0K1LkU9kvq3rzwarFUpdIcJhP/5zDxZBYB5J1I6RIojwnZRaY?= =?us-ascii?Q?IYhatpa8QxDtpBXczsdH6HD+uR5i6ZKg1w0WA75FtSxnfDeSci2cCnO1aa5n?= =?us-ascii?Q?u+hLetVzSk5eFEsy5B5Bm05xh/cyrdQbjipxiwFJ8HssuGuWyyDabodSb/Ut?= =?us-ascii?Q?68H0VTSrxCdpz4y/ltGJwu2TqlCqXOh3DD0ilAryOhVRUXzW7LX4qc4+z4ZZ?= =?us-ascii?Q?G7LKnQzsib9kO0aczguv0+YvarcTJzWYn3V5tDR9W8Drry72x7pnzcM49RZU?= =?us-ascii?Q?9YE7uasKycfKQPOwIY/SuAd1TM95SRaVNAtNMSVAkwcc4Yj9mnb4C5ZeJHKm?= =?us-ascii?Q?XwFe71bFemQ0a/w5vOoNhc7BFnW1LmUn/cGZllu6pjqNAUCBjQPt35IaTB2E?= =?us-ascii?Q?ez50xBiVyG8XvA7zZ0NEyNf51zng67iNbAAplgLdi4wWBXOj30xQrVPHh6NF?= =?us-ascii?Q?q3LwKA+oRnxL7wSuCzCVCugcSh3BWAIW5D2hWIkADh/uTDjj0xfsmbd4BsMT?= =?us-ascii?Q?Lp/x6HruAYY/R7ETiU3epkuvbTnWfUWdfgekFI9psfRFvvKlWsjtPMpQmf2U?= =?us-ascii?Q?k90Prc8N1B7yMcTlg9pgiVGDjI/twl4MrUAfJj9hm2I9cVCR079BW4DCOogI?= =?us-ascii?Q?fiJm0JDJwdrnVsQrHILFu+jBlS6HnwMR/wTie4/3TmZ4uJKoqLwLRquiaAgj?= =?us-ascii?Q?4HmcT5kZy3M3MHDuJPzJHtM1DsaLvCXTqMhhW3MG3uS1LfYtgXsJNmMrBJXb?= =?us-ascii?Q?k7DEbMFx8lmu7oAj/vZox9wBrfvq2agnOiq0nTv2FDBl56PRABc7u/9DcbAF?= =?us-ascii?Q?lignJewPAyFt3FOgtIAawzoHJHqLI/aRoBqAkG5VocM+jhR5jqlW/KA+9kJf?= =?us-ascii?Q?yW3HD34rEOlYs6AGvIgvcPO/+eZA1P0fu3JhaDlz1M5NFA91WviPsiVciBUs?= =?us-ascii?Q?G/MDCaulKZiAcmhIHakKCYfrqVaztkqLljBGOmSbHoal19hUyHXfShVkQImL?= =?us-ascii?Q?zQy+y8ZJLHrejN5TMx2dNBIGIxwDWxayQnlZhv1wRK03iYbnAca/kGoWuHMK?= =?us-ascii?Q?A0cm2G7fC3JjeSwwZ82kEhlJQ41M9WMEApe4edf4lk+1CUlqYbzQiB2m4ts3?= =?us-ascii?Q?TmppGHPKhM3pA8Kxka4sLsiP2xps/h4dl+fK6T62ROxb8+fknmfR/0LNt/Pp?= =?us-ascii?Q?Hhwsyvgb5XjxBwsTWvnpz1n/EurJ7ypGJ3EScPkp4LiEwuFDxDVHwuAhwLwL?= =?us-ascii?Q?FX0nbo1khxRN4v1N17E=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb6e7fab-a9d6-4c30-2538-08daf8892498 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 12:48:33.3880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: niv9s+IeigskpbCdPm51EZC8sugm9+iT0TcdHIIMrcAy6kHs3XGhgJ6yNxM61BQJTsIMA6HhFe5JmfXhecBg7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5869 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > > > + ASSERT (SizeOfMemorySpace <=3D 52); > > > + > > > // > > > - // Calculate the table entries of PML4E and PDPTE. > > > + // Calculate the table entries of PML5E, PML4E and PDPTE. > > > // > > > NumberOfPml5Entries =3D 1; > > > - if (SizeOfMemorySpace > 48) { > > > + if (Enable5LevelPaging && (SizeOfMemorySpace > 48)) { > > > NumberOfPml5Entries =3D (UINTN)LShiftU64 (1, SizeOfMemorySpace= - 48); > > > - SizeOfMemorySpace =3D 48; > > > } > > > > > > + SizeOfMemorySpace =3D SizeOfMemorySpace > 48 ? 48 : SizeOfMemo= rySpace; >=20 > if (SizeOfMemorySpace > 48) { > if (Enable5LevelPaging) { > NumberOfPml5Entries =3D ... > } > SizeOfMemorySpace =3D 48 > } >=20 > That is a much more readable version. I had the same thought. New version is consistent with the logic below. >=20 > The only effect I can see is that this avoids creating page tables which > would not be used anyway. >=20 > Can you explain where the hangs mentioned in the subject line are coming > from and why the patch fixes them? >=20 > take care, > Gerd >=20 >=20 >=20 >=20 >=20