From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4577D740037 for ; Fri, 1 Dec 2023 08:40:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gUJahH75Q251SztxFX0OYYZECU6WgelGRG+aAhXe8AM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701420041; v=1; b=bZn5OZRCzkZYrLXVhi+MtT2dsv69llhVo7GAJwnoLBd55gpF3FLah8LEFF20HkG+Yxwhzwtd PM+FebH8+sXuTu6o2OPMYyhynXZbScAvwBluQNMSk2hd+r8kC24+h73Hm7qWhwUy9yHMfabMmng Aza+ZVsCyKLtLUb9zuzWo7NU= X-Received: by 127.0.0.2 with SMTP id pFxAYY7687511xX2uPmkCKhb; Fri, 01 Dec 2023 00:40:41 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.18635.1701420041225740924 for ; Fri, 01 Dec 2023 00:40:41 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="383859538" X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="383859538" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2023 00:40:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="11084202" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Dec 2023 00:40:40 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 1 Dec 2023 00:40:38 -0800 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 1 Dec 2023 00:40:38 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 1 Dec 2023 00:40:38 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 1 Dec 2023 00:40:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jpL4fT+Hmjl04fKfQgXa0i01TjjXcZAuwJUuYAILbidmJmxcFMYpDgmjB/Y4yoaCtXoilJ/pJgh6oBO7PUJ0XNH8j5duAFdU434jQBuE+LlKrO6hcYw6DnymxWbzI55OkVgF77aen1BFwUKBfq7m9HBFHTH/Jl/o2KMAf2WVoSv9FabppbES3E55SPyDlVNKMrkDIu4vPeemQmPou71X/jK3/YJIq9nNN35LJXhfdrQ9b1db5v2GedBmdtACxeXAlfyTc48uoR3dK+qHOcdJ1VAwh/Oy+lRCSuUkdVMtJ0RMl1jENyv3PMiCpj5nj/5lqophpwpYBmFCA645ymGj0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X2It3COEHWocEP/c2q9VaK+3ZO8IvNy3C38ExLz3Tak=; b=hqnefnzqFdN95ZkLN+FWlcJ/keCh2l9dmeKH6T5pT4+F93sViwFFNu+WhJEuor7biBwJhwEqmvm7ccIdb7INHEf9kz3kmmMxiZhXXNa/IpHuL2fJMtjdQU3D2SH19ki9XgQ8LtYcn5NBV6debD3ztYqBaUIWugzEEEmLkogfRVJeVqobH2QnFj7gez9Q32nYHx9nuTcwWjqOnfA+jJTTUqgbg9DWnUrP04BpoVOjAbm7iAmGdf+g4sXtNMaRiUd9BlY4lfd4xQUiy3rKcmWY9qx7s7cx06hM6Rw9+pDygp2M5UxLYJOrLoLiV8AnFeMMQW2i4oeeXoL+BLjXSaHYqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ0PR11MB5086.namprd11.prod.outlook.com (2603:10b6:a03:2d1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.24; Fri, 1 Dec 2023 08:40:36 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7046.027; Fri, 1 Dec 2023 08:40:35 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Kumar, Rahul R" , Gerd Hoffmann , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/CpuPageTableLib: Init local variable before using it. Thread-Topic: [PATCH v2 1/3] UefiCpuPkg/CpuPageTableLib: Init local variable before using it. Thread-Index: AQHaI1akKBoY1ci8X06007DZOfcp1rCUHVyg Date: Fri, 1 Dec 2023 08:40:35 +0000 Message-ID: References: <20231130062909.2003-1-zhiguang.liu@intel.com> In-Reply-To: <20231130062909.2003-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ0PR11MB5086:EE_ x-ms-office365-filtering-correlation-id: 0dd8c19b-e798-4ed8-be94-08dbf2493048 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: A8l53hyrXfsdjOFSGSBTKF+amS0gmHag7vJhtb9uP6t9ozyCP3Pq+OD2T3UW9HAzpYH8fLIy3wB06yz6+0GP7zC5tlXMshFvOzw3t9NfXd1iis2ReP2+TRQ2NGLb0jT00jMJA7qnyLbfZdgCwbpWxjVF0vFcjy0chIV3AFdJ/GIilJp5zU8KXnrr8nVaoFYFpSYPl2TF2VEpWXJdoQCeZNVkn23GKqcp3o0Eiz8Y9Ag1CO/iEENM38C2B/zuc0As6aYnlDG36Zs2Wicr4EaDSoLYgS1zzFWbwErTvg56azEw+G9jL7z1hdvyi71CcbanlSENa/gyUQ8xLE534bm52TzlD/KsLJyvVF9gW74Tcdk13DHkYridCrGafBq2UB/bt9dbeEianyyyO2pkRV7s5ymXBuGPclgvetDdvIyHiveGhFMfNb/AbeLfMVbu/mVTSD6Dwv7nmoqy8vacx5PHxJk7w0l12VvQyNihHIMSmFfuH05CbyDjBnyn+AYR7EMDY8/MDByU/fBGFC43DEIq/Iv3mE6EF6djsd9M/eam+V4Mk7eqmxnadqJHCsuO8Rpz/YBXkQqF0OOUYhf8j8yDPD40z5QPwfrFmqjDNQ7zGOSPQJDBXVxjviTnt0vwxMI6 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yQeXFneLkrtHsw18WEVAecOiYY/lr4o/rNsNLIE46hU8/k9szQmN58ykkECM?= =?us-ascii?Q?ewq9zMA89BLuLJPyfcbsKpXGb1VVQZyLGeEZADE0d64HptwUvwHg/IH8j5gu?= =?us-ascii?Q?9gaD3W98OTGpIDq3hjYCE7wSbRNW8tJKRgfvR8vxju1muKmn9wRwiEPypPqu?= =?us-ascii?Q?4yz+aPj8hc1A44oAn4JPS0P1U5njFNaWmEc5xEPoarlB1UXa9wTXn3g6lomL?= =?us-ascii?Q?7y/t2BpA0xSPVCaAmhMpze+EZSJ4hH1tC/fAlpw5BEPnePeLUYtcdNLFB6pz?= =?us-ascii?Q?G06f+ELRwjVkYFWmiCKfkQatzToP1XpUFw9mIVB8gBEWM2GBpW7bZTtpTgXP?= =?us-ascii?Q?m5k0aE2bQWyhPhM4MpaUnVS+AGRH8t3gYgc3gPR7nXdGWtKiU0DC6n94jPJH?= =?us-ascii?Q?KVcsiOftxR5BKs8CfOgxf2glcHCYYSqjohAshDlEPPmMGmUVeZpoY+O+XBmi?= =?us-ascii?Q?t7nMZ6hMwVZMOU/U1GetUy6T7Olv16UDITxqYPfSjUB13PxZnmqF5KQzhCUm?= =?us-ascii?Q?qdd8eG6lkLZR8pcRB1CXw/8zr2xU+D2FJXAW9u3mXI3lDPUgPxtnsKAdWQjm?= =?us-ascii?Q?qpH9uvHoVvSRdNBlq/nKeTieGOH23Fn8tEKIyJ1A2bTMqNCO41Cl4Oecz23V?= =?us-ascii?Q?u5Xogd9ynLPO4+flzt3ncjFn61iCbWoVCaLQ3nBorb03dsTuYqPAIvl0VDl1?= =?us-ascii?Q?nf1YPGH4c7LWiYpxpyncdGVzUuDgAYOV8PVa4wDS7Bos8hbnUX6HtyRbXQ6D?= =?us-ascii?Q?+bZorjsoEgG94AHEdrbM+OKR6cvz7C71Dv3gyNxIE+vpK+IT2X75FYO87FA6?= =?us-ascii?Q?AWIfzylNjdH7aSOF9vXGv/Cynk9GWeL1uezFmeYqOexRdbn7DRiM4sLm55Jp?= =?us-ascii?Q?kpU5esb0IwXbejizy0ZPP61grKanRDjO0XgvFH4I6LiHES9RFE4eVcEKqNRJ?= =?us-ascii?Q?/8IOl9S4EvxgI/qh+z2lcbkguaeZFZHviEoLQSb5qXtlRJ5M0bOpI+DLbTGv?= =?us-ascii?Q?5NyyuJNmrWPXCrwj/5ogfbvFXKLd73Fd1wxf5lBuyPxu/izc9zFt2RdBbY27?= =?us-ascii?Q?xxWM3h5yHA1LeuayVKYEycib0Fa9Bobph+AmaMdXYGMMkm1e3U9IgTloPgBS?= =?us-ascii?Q?D4egRzUHdyim2DjCGZmBoabEGNa8j9ZhhPXef4i4lTteK08OSRhhcB3YZP8g?= =?us-ascii?Q?vKKGSU4+5ehPuj9FlXSFYDGIgOGxCDV7zGIl6xJm+91eF4AisI36/0iu2NUa?= =?us-ascii?Q?jg3SQMsRJaq41XRWwh50rzVoNAM9WWEIS9khSKbGh6C/VaHMQJV7dgsjUTmg?= =?us-ascii?Q?KfZ5zCVz72eZsA0RTpsymNU2NOUFeAM0QAwsmvaxA+lHkG7surZuj8kl9Ezu?= =?us-ascii?Q?ojk+q29DsFZ7B+U7mZDB+oJV/iZZ2uNoodKynBZyKTxx+djcaHXnjTRH0RV2?= =?us-ascii?Q?/CXF1CP8MnUA2lQiSY09MQWZ7WiLcDWzFSJpKnCs/jnnN9qvcq+jXCyExqBF?= =?us-ascii?Q?isJcPf75PL5TTj+HYhLGVufrbH9dpDx+t4a+yeJkeMCBKEb6WPrUpGzhXYKi?= =?us-ascii?Q?7ka3EB3Fmoy947/23z0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dd8c19b-e798-4ed8-be94-08dbf2493048 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2023 08:40:35.9570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mgMq8wNmd0kN3oEWOTCx7MNxEnNaJhW64I+ILs3TNjWqDv1WGnuGcWwvVaHauRYshpSMjJLPgxAeVN65SwHUmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5086 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oAGuuItNYcuriqvUusfntOISx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=bZn5OZRC; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: Liu, Zhiguang > Sent: Thursday, November 30, 2023 2:29 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Ni, Ray ; > Kumar, Rahul R ; Gerd Hoffmann > ; Laszlo Ersek > Subject: [PATCH v2 1/3] UefiCpuPkg/CpuPageTableLib: Init local variable > before using it. >=20 > The local variable OneOfPagingEntry is used before initialized, this > may cause reserved bit in page table entry is set especially in PAE > paging mode. The bug is random because it depends on the value in > stack. >=20 > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Laszlo Ersek > Signed-off-by: Zhiguang Liu > --- > UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > index eff02619fa..36b2c4e6a3 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > @@ -338,7 +338,7 @@ PageTableLibMapInLevel ( > ParentAttribute =3D &LocalParentAttribute; >=20 > OriginalParentPagingEntry.Uint64 =3D ParentPagingEntry->Uint64; > - > + OneOfPagingEntry.Uint64 =3D 0; > // > // RegionLength: 256T (1 << 48) 512G (1 << 39), 1G (1 << 30), 2M (1 <<= 21) > or 4K (1 << 12). > // > @@ -367,8 +367,6 @@ PageTableLibMapInLevel ( > if (RETURN_ERROR (Status)) { > return Status; > } > - > - OneOfPagingEntry.Pnle.Uint64 =3D 0; > } else { > PageTableLibSetPle (Level, &OneOfPagingEntry, 0, &PleBAttribute, > &AllOneMask); > } > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111977): https://edk2.groups.io/g/devel/message/111977 Mute This Topic: https://groups.io/mt/102889278/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-