From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2187DAC0AAB for ; Thu, 3 Aug 2023 05:06:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hBvJ1l080Bg8C3GC2RvQ8QuEGoaSCry1RTs19oXRMac=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691039162; v=1; b=hB7n8yB45qyWyTGegHd3BESFLrvhDHFB0WbGB/Z/+IaeGTAzTwEFvqRmk8MrAbFx2ibZCP8r 2diQvI5pLJLXh9CzzWoqM7qeUrILGsxbX8RyQt23AUCC0WF+txVXJWdQSPScDeB2pog+StVrrp+ tdtDyrmzUSl7mIh+f5seSCa4= X-Received: by 127.0.0.2 with SMTP id dTJEYY7687511xoZat4ChIp8; Wed, 02 Aug 2023 22:06:02 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.7604.1691039161957246085 for ; Wed, 02 Aug 2023 22:06:02 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="436082939" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="436082939" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 22:06:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="794851462" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="794851462" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 02 Aug 2023 22:06:01 -0700 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 22:06:00 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 2 Aug 2023 22:06:00 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 2 Aug 2023 22:06:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XNHhSEchAIoZTSHTKoD137PBke7TUzpX6yjWySGjR81TZGrOrvrPRD2g2DhDOjTyr+VLyrOoxFrNRpk3gSs7kz/QvlLI3Y8zL1wGuvd6gxUwO8xI+uExXgnnsS3A8YgZwVzq5kHnLV/XqLIDq3ZSRIk3UhWCPUFK3H4y2cl9Q8K5AgvScRlZ+gsyQIBdeGGZx1LB8sxZZaRoSEAhjtwf1hcgfXJ6syXo81wC1nf5cV/pxU1fajvGTdAz21jYxTqrZ+e9gVEcNfYTq9nFV4YUmMfKbEHXK9KSROAHaWBZnnfis6nPCRShPvxVGSTE1usHKhZzYbOLb5qP7YDoIunDBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qGIbkgviMZcrHVWBA/7Q4LJM72oXs1kTUlQUbw4akEQ=; b=Zcxtvza6XJSnNiTC9mJqxtADCn2kMeHZUOWYaxDj+VN1DvIhpzYJdwCyjDhvxKQQoyUtusLaTaNpPJDvdrR/HzS98xlq+eUrGEru4UbT2SJWcMxPWL3aHh/ItLpcocLYuoesgDDSLldXFaayuiSVQ8cJxd49gLvZSSi4ludYFNHFQxwO1RAvgJDFZpZiN3tN9fEJkeJYyVdZJ5jz3xlWSGAodjngV+i+vGAkJIuwyG0mzcd/sdGFDJ0IPyPugCxbAzUQzT0fBOSTKaVso5gqMH6bKg5mCq1XdovtOBUCXDhAlvkM/jIBlfgdNINylj7AmzNUr3LnS7deO3EefahqsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MN2PR11MB4599.namprd11.prod.outlook.com (2603:10b6:208:26d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 05:05:59 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b%5]) with mapi id 15.20.6631.045; Thu, 3 Aug 2023 05:05:59 +0000 From: "Ni, Ray" To: "Ck, Chitralekha" , "devel@edk2.groups.io" CC: "Gao, Zhichao" , "S, Ashraf Ali" , "Duggapu, Chinni B" Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt Thread-Topic: [PATCH v2] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt Thread-Index: AQHZxcd1rLd2zQv8Mki5D+YAFwk0R6/YBJgA Date: Thu, 3 Aug 2023 05:05:58 +0000 Message-ID: References: <98d6a4e6edccdd8ecc9f221c4248b96fe004f80a.1691038792.git.chitralekha.ck@intel.com> In-Reply-To: <98d6a4e6edccdd8ecc9f221c4248b96fe004f80a.1691038792.git.chitralekha.ck@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MN2PR11MB4599:EE_ x-ms-office365-filtering-correlation-id: 00df9d64-815a-4513-d79f-08db93df5369 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 2gin4qj9cwuDa5xauFz8oQBQTTw9rgFS1BeYVc62hRB+jCtHsjrHVBOTSPu+FMIyd1U/mq5HdVd5utFHN32tGXeMEDvOY9FLEfuk5yN15bIO7Ynia6s8VguiyF+ddbJelARYkutgnHFswEnKBfC1U0vHgE0615LqdwQ6z2XydGTHsJi41YS1AZCXfqFrD5NIEoowoPLqpe8b3HodRqOFniB+D5I6rgEwb8o8Uqn7uboNigAsJgv+n37gnSsob/Req/H/gVzFDW3MHJGNAp0b6ZHjRZGpevwGIkRRm9KawUh23QAg3bzBVblCUGbr+eRS9r/GD49+x0KOicdz5vmBs+yPKJlp9idEO9lkcl3B52tRUApnnVehLdprnvf3aGsBstGFWKND/o6XCXMBoWz0+YAgv1PQX0wrUZxbR62qw+ihoharozeBW7gucHo8xcXwoleTZh7YR0BSSfwK4YNoPtg6YF3Cjhk9IZTMNKWv+iW7r2cONfml21qEcQfm1Th+hNqcMOSiijIScuB1teeZOMA6J9P6AexkWujo1x8VJglNPrh26+/TAeqQUEtCogZQRsnR14ajm+u2DawrO5Q+d7CkWO/W3uWls3Ft3xfZBDM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GFt6J5wg6A+2XsSkbXgnz/vbBNqNxXCqdfCvywVQxcsmf2d8YmcDEpARjeBJ?= =?us-ascii?Q?Z5pSBkiQB+Yy4pcjDqtrltWWTaMPHSqS3lD3Fzwk85Mc4f6JaQrzslfqDlbT?= =?us-ascii?Q?RkiNcPqhSfoMOpqcib2XOATRmbv4IwBGC9PNIcA1NXmBaO9oG0ph4pD7aGOM?= =?us-ascii?Q?eR8SQos+Jp/rgpVeZcF5d1ZEISzJ0XC0HcK/GST90fuVdzYEwDqJokMmMSeP?= =?us-ascii?Q?L1No0hPdK3q4GuvQXMgB+Qd96CkUiHszZGKqRfaXbFst5tC7kcJ+UZqeIIfr?= =?us-ascii?Q?98+UVTpsT7s/jeaJ5RfM5vWXnsoDzXsLcVIfAjlaCeBAgyJux+FKOmc2d1i5?= =?us-ascii?Q?IHWk7q5t8GUg062TTJweZ2onh8Ozwxuc+IjyznJlNCrcFHNoJ9ScUYlMhUle?= =?us-ascii?Q?AVCDe5jB+ZBRtUqK1AT8nI3rwQDjqSm7p5y9vBn4SgbE7JLsEktuRpuATn92?= =?us-ascii?Q?h0/jz5bahYX72b3FJ1CjBD3HUfxkDP6lI4HReuc7zOZscjCumuZuaS19A8Ug?= =?us-ascii?Q?IJbtPSOfZ+qeSSFulnoNEUzTJdO9diGJ9N8UQcKdI1I125lYck7rK2caf8/F?= =?us-ascii?Q?6oEFhckO0W3MgaVtjn/I9DeZDUbRdwyqJCkGTVe4DrRUUXVo/pv/u0bTED0M?= =?us-ascii?Q?7Yf5riRatgUWtXXFja8nfkN5JoYjGppHN0OWVVFp286nWOXViYXee5Wz2GBH?= =?us-ascii?Q?HS/KF5eV9VAZrpKJJyN3wNPK+26V6hXyTzWdzxtFybP/rY2NJ9hsuQEEsCnp?= =?us-ascii?Q?S7b0MdQJQlcUCSqRo46Y9SnuKyocaLJ/Lh08Hj6oP/WTdaO2f5gcbVbif64H?= =?us-ascii?Q?HgoxtSvcRB+WK2i4+fBbDraF83rmvJTcxwD2dm8lVseam/n/MMV92DzXp1Mv?= =?us-ascii?Q?BReBQk9oOvI2Oame3jU5xvEZ4k/cvuRB97DKylN49+/CH56hlOFxZBjVG2nq?= =?us-ascii?Q?P0a0ENKgtJxF5lS7xfiYvOLpDZ2MVUfzDiuOeUHRs57MBEkj4uHJ46+KQnA2?= =?us-ascii?Q?XOKwNcSkDzSIWKaPkGj1cn1DtqkE9k10HH/lPAHL21R8jifdEkQmRARiHY52?= =?us-ascii?Q?3kNMft+T2tfvFpNxjXlW1jo2FzlbelWSkwjjG+QCXha8zQCyqwq17u21FOuo?= =?us-ascii?Q?hGejZtz7COaSMTWfzi1JwP8vOFGNvuxXhuMpu2tUuisvBIFDs7LkU+/znXWg?= =?us-ascii?Q?lEFqK0FlJXOW+0CUC7qRM69nJbT10WbROKKyv+FPLrOR3c0AkFmKclnGToAN?= =?us-ascii?Q?kD1CfOT8IDEAJY9nk0r2L5volSNI2aA2R8AAz4AIE/EbbZYdRqgBuygowkIZ?= =?us-ascii?Q?cX1XcHEbAR5sl1/jOjIhOFRMBgke93b0QrotWYo4LGNmIssNUjFcwBX+2+wG?= =?us-ascii?Q?ch6l7AblgWjjFhL5DzNhf2PIgViSyfe6xlI89kr4BZXVtcAp4RpXBwjLfRaw?= =?us-ascii?Q?jVqqrNeikyFnloBofcMtX4MaOnQ/fV2528kfK6OWJrN3PkK1Jxc+J2TObKbS?= =?us-ascii?Q?YKKr1mqFkefi+tHrg0jFaCCFgJMxGDdvR2IKeJj28F/FZtSh2m6AzRb9MQ?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00df9d64-815a-4513-d79f-08db93df5369 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2023 05:05:58.9231 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jynYU9gxnGOILd5qtlPkunAQ4/0W+Du78CRyahrRKrh/MgnkYvi5OQ+B4nRrwjRxcD+MZPV198jXb0aSr4Uk/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4599 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: y33svBlYfVRkrEWwCI3KsLI6x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hB7n8yB4; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Please don't mix the two changes in one patch. The two changes are: 1. change to use __func__ 2. AllocatePages > -----Original Message----- > From: Ck, Chitralekha > Sent: Thursday, August 3, 2023 1:00 PM > To: devel@edk2.groups.io > Cc: Ck, Chitralekha ; Ni, Ray ; Gao, > Zhichao ; S, Ashraf Ali ; > Duggapu, Chinni B > Subject: [PATCH v2] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4507 > AllocatePool limits to allocate memory of 64 KB at most in PEI Phase. > AllocatePool() is being avoided due to its 64k allocation size limit > when the library is incorporated into a PEI component. >=20 > change the function debug string to __func__ >=20 > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Ashraf Ali S > Cc: Chinni B Duggapu > Signed-off-by: chitralekha ck > --- > .../Library/BaseBmpSupportLib/BmpSupportLib.c | 58 +++++++++++-------- > 1 file changed, 33 insertions(+), 25 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c > b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c > index c5e885d7a6..d0833a721f 100644 > --- a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c > +++ b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c > @@ -52,7 +52,7 @@ const BMP_IMAGE_HEADER mBmpImageHeaderTemplate > =3D { > /** > Translate a *.BMP graphics image to a GOP blt buffer. If a NULL Blt bu= ffer > is passed in a GopBlt buffer will be allocated by this routine using > - EFI_BOOT_SERVICES.AllocatePool(). If a GopBlt buffer is passed in it w= ill be > + EFI_BOOT_SERVICES.AllocatePages(). If a GopBlt buffer is passed in it = will be > used if it is big enough. >=20 > @param[in] BmpImage Pointer to BMP file. > @@ -113,14 +113,14 @@ TranslateBmpToGopBlt ( > } >=20 > if (BmpImageSize < sizeof (BMP_IMAGE_HEADER)) { > - DEBUG ((DEBUG_ERROR, "TranslateBmpToGopBlt: BmpImageSize too > small\n")); > + DEBUG ((DEBUG_ERROR, "%a: BmpImageSize too small\n", __func__)); > return RETURN_UNSUPPORTED; > } >=20 > BmpHeader =3D (BMP_IMAGE_HEADER *)BmpImage; >=20 > if ((BmpHeader->CharB !=3D 'B') || (BmpHeader->CharM !=3D 'M')) { > - DEBUG ((DEBUG_ERROR, "TranslateBmpToGopBlt: BmpHeader->Char fields > incorrect\n")); > + DEBUG ((DEBUG_ERROR, "%a: BmpHeader->Char fields incorrect\n", > __func__)); > return RETURN_UNSUPPORTED; > } >=20 > @@ -128,12 +128,12 @@ TranslateBmpToGopBlt ( > // Doesn't support compress. > // > if (BmpHeader->CompressionType !=3D 0) { > - DEBUG ((DEBUG_ERROR, "TranslateBmpToGopBlt: Compression Type > unsupported.\n")); > + DEBUG ((DEBUG_ERROR, "%a: Compression Type unsupported\n", > __func__)); > return RETURN_UNSUPPORTED; > } >=20 > if ((BmpHeader->PixelHeight =3D=3D 0) || (BmpHeader->PixelWidth =3D=3D= 0)) { > - DEBUG ((DEBUG_ERROR, "TranslateBmpToGopBlt: BmpHeader->PixelHeight > or BmpHeader->PixelWidth is 0.\n")); > + DEBUG ((DEBUG_ERROR, "%a: BmpHeader PixelHeight or PixelWidth is 0\n= ", > __func__)); > return RETURN_UNSUPPORTED; > } >=20 > @@ -144,7 +144,8 @@ TranslateBmpToGopBlt ( > if (BmpHeader->HeaderSize !=3D sizeof (BMP_IMAGE_HEADER) - OFFSET_OF > (BMP_IMAGE_HEADER, HeaderSize)) { > DEBUG (( > DEBUG_ERROR, > - "TranslateBmpToGopBlt: BmpHeader->Headership is not as expected. > Headersize is 0x%x\n", > + "%a: BmpHeader->Headership is not as expected. Headersize is 0x%x\= n", > + __func__, > BmpHeader->HeaderSize > )); > return RETURN_UNSUPPORTED; > @@ -161,7 +162,8 @@ TranslateBmpToGopBlt ( > if (EFI_ERROR (Status)) { > DEBUG (( > DEBUG_ERROR, > - "TranslateBmpToGopBlt: invalid BmpImage... PixelWidth:0x%x > BitPerPixel:0x%x\n", > + "%a: invalid BmpImage. PixelWidth:0x%x BitPerPixel:0x%x\n", > + __func__, > BmpHeader->PixelWidth, > BmpHeader->BitPerPixel > )); > @@ -172,7 +174,8 @@ TranslateBmpToGopBlt ( > if (EFI_ERROR (Status)) { > DEBUG (( > DEBUG_ERROR, > - "TranslateBmpToGopBlt: invalid BmpImage... DataSizePerLine:0x%x\n"= , > + "%a: invalid BmpImage. DataSizePerLine:0x%x\n", > + __func__, > DataSizePerLine > )); >=20 > @@ -189,7 +192,8 @@ TranslateBmpToGopBlt ( > if (EFI_ERROR (Status)) { > DEBUG (( > DEBUG_ERROR, > - "TranslateBmpToGopBlt: invalid BmpImage... DataSizePerLine:0x%x > PixelHeight:0x%x\n", > + "%a: invalid BmpImage. DataSizePerLine:0x%x PixelHeight:0x%x\n", > + __func__, > DataSizePerLine, > BmpHeader->PixelHeight > )); > @@ -206,7 +210,8 @@ TranslateBmpToGopBlt ( > if (EFI_ERROR (Status)) { > DEBUG (( > DEBUG_ERROR, > - "TranslateBmpToGopBlt: invalid BmpImage... PixelHeight:0x%x > DataSizePerLine:0x%x\n", > + "%a: invalid BmpImage. PixelHeight:0x%x DataSizePerLine:0x%x\n", > + __func__, > BmpHeader->PixelHeight, > DataSizePerLine > )); > @@ -218,11 +223,11 @@ TranslateBmpToGopBlt ( > (BmpHeader->Size < BmpHeader->ImageOffset) || > (BmpHeader->Size - BmpHeader->ImageOffset !=3D DataSize)) > { > - DEBUG ((DEBUG_ERROR, "TranslateBmpToGopBlt: invalid BmpImage... \n")= ); > - DEBUG ((DEBUG_ERROR, " BmpHeader->Size: 0x%x\n", BmpHeader->Size))= ; > - DEBUG ((DEBUG_ERROR, " BmpHeader->ImageOffset: 0x%x\n", > BmpHeader->ImageOffset)); > - DEBUG ((DEBUG_ERROR, " BmpImageSize: 0x%lx\n", > (UINTN)BmpImageSize)); > - DEBUG ((DEBUG_ERROR, " DataSize: 0x%lx\n", (UINTN)DataSize)); > + DEBUG ((DEBUG_ERROR, "%a: invalid BmpImage... \n", __func__)); > + DEBUG ((DEBUG_ERROR, " Size: 0x%x\n", BmpHeader->Size)); > + DEBUG ((DEBUG_ERROR, " ImageOffset: 0x%x\n", BmpHeader- > >ImageOffset)); > + DEBUG ((DEBUG_ERROR, " BmpImageSize: 0x%lx\n", > (UINTN)BmpImageSize)); > + DEBUG ((DEBUG_ERROR, " DataSize: 0x%lx\n", (UINTN)DataSize)); >=20 > return RETURN_UNSUPPORTED; > } > @@ -279,7 +284,8 @@ TranslateBmpToGopBlt ( > if (EFI_ERROR (Status)) { > DEBUG (( > DEBUG_ERROR, > - "TranslateBmpToGopBlt: invalid BltBuffer needed size... PixelWidth= :0x%x > PixelHeight:0x%x\n", > + "%a: invalid BltBuffer needed size. PixelWidth:0x%x PixelHeight:0x= %x\n", > + __func__, > BmpHeader->PixelWidth, > BmpHeader->PixelHeight > )); > @@ -297,7 +303,8 @@ TranslateBmpToGopBlt ( > if (EFI_ERROR (Status)) { > DEBUG (( > DEBUG_ERROR, > - "TranslateBmpToGopBlt: invalid BltBuffer needed size... PixelWidth= x > PixelHeight:0x%x struct size:0x%x\n", > + "%a: invalid BltBuffer needed size. PixelWidth x PixelHeight:0x%x = struct > size:0x%x\n", > + __func__, > Temp, > sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL) > )); > @@ -312,7 +319,7 @@ TranslateBmpToGopBlt ( > // > DEBUG ((DEBUG_INFO, "Bmp Support: Allocating 0x%X bytes of memory\n"= , > BltBufferSize)); > *GopBltSize =3D (UINTN)BltBufferSize; > - *GopBlt =3D AllocatePool (*GopBltSize); > + *GopBlt =3D AllocatePages (*GopBltSize); > IsAllocated =3D TRUE; > if (*GopBlt =3D=3D NULL) { > return RETURN_OUT_OF_RESOURCES; > @@ -329,13 +336,14 @@ TranslateBmpToGopBlt ( >=20 > *PixelWidth =3D BmpHeader->PixelWidth; > *PixelHeight =3D BmpHeader->PixelHeight; > - DEBUG ((DEBUG_INFO, "BmpHeader->ImageOffset 0x%X\n", BmpHeader- > >ImageOffset)); > - DEBUG ((DEBUG_INFO, "BmpHeader->PixelWidth 0x%X\n", BmpHeader- > >PixelWidth)); > - DEBUG ((DEBUG_INFO, "BmpHeader->PixelHeight 0x%X\n", BmpHeader- > >PixelHeight)); > - DEBUG ((DEBUG_INFO, "BmpHeader->BitPerPixel 0x%X\n", BmpHeader- > >BitPerPixel)); > - DEBUG ((DEBUG_INFO, "BmpHeader->ImageSize 0x%X\n", BmpHeader- > >ImageSize)); > - DEBUG ((DEBUG_INFO, "BmpHeader->HeaderSize 0x%X\n", BmpHeader- > >HeaderSize)); > - DEBUG ((DEBUG_INFO, "BmpHeader->Size 0x%X\n", BmpHeader->Size)); > + DEBUG ((DEBUG_INFO, "BmpHeader :\n")); > + DEBUG ((DEBUG_INFO, " ImageOffset 0x%X\n", BmpHeader->ImageOffset)); > + DEBUG ((DEBUG_INFO, " PixelWidth 0x%X\n", BmpHeader->PixelWidth)); > + DEBUG ((DEBUG_INFO, " PixelHeight 0x%X\n", BmpHeader->PixelHeight)); > + DEBUG ((DEBUG_INFO, " BitPerPixel 0x%X\n", BmpHeader->BitPerPixel)); > + DEBUG ((DEBUG_INFO, " ImageSize 0x%X\n", BmpHeader->ImageSize)); > + DEBUG ((DEBUG_INFO, " HeaderSize 0x%X\n", BmpHeader->HeaderSize)); > + DEBUG ((DEBUG_INFO, " Size 0x%X\n", BmpHeader->Size)); >=20 > // > // Translate image from BMP to Blt buffer format > -- > 2.38.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107514): https://edk2.groups.io/g/devel/message/107514 Mute This Topic: https://groups.io/mt/100520797/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-